sysadmin and Claude Opus 5
824c42f7e3
fix(drain): fail closed on missing or unproven acknowledgement evidence ( #661 )
...
The acks_or_timeout check treated an absent `acks` key as proof that no
session needed to acknowledge: `drain_state.get("acks") or {}` collapsed
absent, None, and empty into the same value, and the resulting empty mapping
satisfied `no_sessions_to_ack`. The impact report's counts.sessions_live_other
was never consulted, so absence of evidence was read as evidence of absence.
Reproduced at head 1cbbde0089 : with
sessions_live_other = 3 and the acknowledgement key absent, acks_or_timeout
passed with detail "no other live sessions required to acknowledge", the proof
minted clean, and gate_apply_restart returned verdict allow — a restart
authorized against three live sessions with zero acknowledgement evidence, and
the resulting artifact carried a valid signature.
Whether acknowledgement is required is now derived from the impact report,
never from the shape of the drain state:
- _live_session_count() reads counts.sessions_live_other and returns None for a
missing, malformed, negative, or bool value, so an unreadable report fails
closed instead of reading as "nobody was live".
- Absent, None, non-mapping, empty, partially-covering, and unparseable or
stale acknowledgement data all fail closed while live sessions require
acknowledgement.
- _is_acknowledged() no longer coerces with str(); only an explicit
"ack"/"acked"/"acknowledged" string counts, so None, timestamps, and
"pending"/"stale" markers are never read as an acknowledgement.
- Present-but-unacknowledged entries fail closed even when the report claims
zero live sessions: that contradiction is not safe to resolve in favour of
the restart.
- ack_timeout_policy_applied stays strict (`value is True`), so an absent, null,
or non-boolean value cannot open the gate on its own.
The genuine no-other-live-sessions case still passes, now justified by the
report proving sessions_live_other == 0 rather than by the absence of data.
Adds AcknowledgementFailClosedTests: 14 cases / 26 subtests covering missing,
null, empty, malformed, stale, partial-coverage, and unproven-count inputs,
the valid-acknowledgement and zero-live-session paths, timeout-policy
strictness, and that a failed check blocks proof.clean, verification, and the
restart gate.
Restart-surface suite: 132 passed, 38 subtests (branch baseline 118 passed,
12 subtests; +14 new tests, no regressions).
Co-Authored-By: Claude Opus 5 (1M context) <[email protected] >
Claude-Session: https://claude.ai/code/session_01VEaP3TohHLFWkp3Z2mmuZw
2026-07-24 22:36:25 -04:00
..
2026-07-02 15:31:56 -05:00
2026-06-21 17:26:18 -04:00
2026-07-22 05:40:15 -05:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-19 14:12:04 -04:00
2026-07-23 04:56:58 -04:00
2026-07-20 13:52:39 -05:00
2026-07-19 14:12:04 -04:00
2026-07-20 22:40:39 -04:00
2026-07-10 02:54:20 -04:00
2026-07-07 09:20:50 -04:00
2026-07-07 05:38:32 -04:00
2026-07-12 09:00:45 -04:00
2026-07-13 13:40:38 -04:00
2026-07-22 23:00:24 -05:00
2026-07-15 21:13:21 -04:00
2026-07-17 19:42:52 -04:00
2026-07-21 15:41:24 -04:00
2026-07-24 07:46:34 -04:00
2026-07-24 07:54:07 -04:00
2026-07-05 15:16:36 -04:00
2026-07-08 22:36:10 -04:00
2026-07-24 00:49:52 -04:00
2026-07-13 21:48:28 -04:00
2026-07-08 03:17:38 -04:00
2026-07-08 03:44:58 -04:00
2026-07-07 04:25:02 -04:00
2026-07-02 06:13:26 -04:00
2026-07-05 17:18:48 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-05 03:33:12 -04:00
2026-07-02 02:34:16 -04:00
2026-07-08 02:19:37 -04:00
2026-07-04 18:35:45 -04:00
2026-07-15 21:13:21 -04:00
2026-07-08 22:30:21 -04:00
2026-07-24 08:06:45 -04:00
2026-07-09 15:39:54 -04:00
2026-07-18 16:19:04 -04:00
2026-07-20 12:55:40 -05:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-06 01:26:33 -04:00
2026-07-18 03:44:28 -04:00
2026-07-23 00:05:35 -04:00
2026-07-17 19:42:52 -04:00
2026-07-23 22:34:35 -05:00
2026-07-24 01:13:50 -04:00
2026-07-24 22:36:25 -04:00
2026-07-05 03:23:40 -04:00
2026-07-07 04:27:02 -04:00
2026-07-09 12:56:12 -04:00
2026-07-07 04:26:58 -04:00
2026-07-13 02:29:46 -04:00
2026-07-07 04:35:34 -04:00
2026-07-07 02:57:45 -04:00
2026-07-10 03:18:54 -04:00
2026-07-12 13:15:58 -04:00
2026-07-20 12:55:40 -05:00
2026-07-24 07:35:26 -04:00
2026-07-21 20:45:17 -05:00
2026-07-24 08:42:20 -04:00
2026-07-24 18:18:10 -04:00
2026-07-12 13:15:58 -04:00
2026-07-17 14:04:45 -04:00
2026-07-13 14:35:15 -04:00
2026-07-13 02:29:46 -04:00
2026-07-13 21:48:28 -04:00
2026-07-13 17:37:13 -04:00
2026-07-13 16:40:58 -04:00
2026-07-13 14:35:15 -04:00
2026-07-17 23:31:39 -04:00
2026-07-18 01:27:26 -04:00
2026-07-15 13:55:06 -04:00
2026-07-15 21:13:21 -04:00
2026-07-17 14:25:08 -04:00
2026-07-16 15:47:52 -04:00
2026-07-19 23:21:54 -04:00
2026-07-17 22:45:18 -04:00
2026-07-18 12:02:31 -04:00
2026-07-18 12:59:51 -04:00
2026-07-18 13:55:46 -04:00
2026-07-18 17:38:54 -04:00
2026-07-18 19:31:55 -04:00
2026-07-20 02:52:29 -05:00
2026-07-19 12:59:08 -04:00
2026-07-22 00:39:51 -04:00
2026-07-22 01:10:48 -04:00
2026-07-19 18:27:34 -04:00
2026-07-20 02:52:29 -05:00
2026-07-22 00:39:51 -04:00
2026-07-21 16:52:23 -04:00
2026-07-21 18:07:21 -04:00
2026-07-22 04:19:48 -04:00
2026-07-22 04:19:48 -04:00
2026-07-24 07:38:57 -04:00
2026-07-22 16:18:00 -05:00
2026-07-22 17:27:49 -05:00
2026-07-23 03:41:28 -04:00
2026-07-24 00:49:52 -04:00
2026-07-23 21:19:32 -04:00
2026-07-24 02:56:57 -04:00
2026-07-24 08:40:19 -04:00
2026-07-08 03:27:37 -04:00
2026-07-07 05:41:33 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-07 23:40:12 -05:00
2026-07-07 16:18:42 -04:00
2026-07-23 20:38:47 -05:00
2026-07-08 02:22:54 -04:00
2026-07-15 21:13:21 -04:00
2026-07-10 16:17:31 -04:00
2026-07-15 21:13:21 -04:00
2026-07-10 11:30:53 -04:00
2026-07-07 05:22:08 -04:00
2026-07-07 04:25:02 -04:00
2026-07-15 21:13:21 -04:00
2026-07-08 04:08:07 -04:00
2026-07-15 21:13:21 -04:00
2026-07-10 13:05:27 -04:00
2026-07-22 05:40:15 -05:00
2026-07-13 21:48:28 -04:00
2026-07-06 12:37:04 -04:00
2026-07-19 14:43:10 -04:00
2026-07-09 18:44:04 -04:00
2026-07-08 13:43:39 -04:00
2026-07-23 19:16:28 -04:00
2026-07-24 00:57:33 -04:00
2026-07-17 19:42:52 -04:00
2026-07-08 22:22:34 -04:00
2026-07-16 21:21:39 -04:00
2026-07-13 21:48:28 -04:00
2026-07-05 15:16:55 -04:00
2026-07-23 16:41:27 -04:00
2026-07-17 13:30:52 -04:00
2026-07-15 21:13:21 -04:00
2026-07-18 10:12:49 -04:00
2026-07-12 22:35:14 -04:00
2026-06-21 18:08:53 -04:00
2026-07-20 18:58:40 -05:00
2026-07-17 20:42:25 -04:00
2026-07-07 04:08:27 -04:00
2026-07-20 12:55:40 -05:00
2026-07-09 10:43:42 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-09 09:25:08 -04:00
2026-07-07 17:19:37 -04:00
2026-07-18 12:59:51 -04:00
2026-07-09 15:49:14 -04:00
2026-07-15 21:13:21 -04:00
2026-07-24 01:09:39 -05:00
2026-07-08 23:33:51 -04:00
2026-07-08 02:17:58 -04:00
2026-07-17 10:42:53 -04:00
2026-07-23 04:46:30 -04:00
2026-07-12 13:15:58 -04:00
2026-07-17 23:45:44 -04:00
2026-07-08 23:04:44 -04:00
2026-07-07 04:46:48 -04:00
2026-07-05 15:16:55 -04:00
2026-07-10 13:05:27 -04:00
2026-07-07 04:57:50 -04:00
2026-07-07 09:20:50 -04:00
2026-07-09 00:09:47 -04:00
2026-07-07 09:15:13 -04:00
2026-07-19 02:26:58 -04:00
2026-07-12 21:31:00 -04:00
2026-07-09 12:36:50 -04:00
2026-07-07 05:45:51 -04:00
2026-07-07 09:25:55 -04:00
2026-07-07 09:25:55 -04:00
2026-07-02 05:37:41 -04:00
2026-07-15 21:13:21 -04:00
2026-07-07 02:53:25 -04:00
2026-07-19 23:21:54 -04:00
2026-07-24 02:14:27 -04:00
2026-07-13 13:40:38 -04:00
2026-07-09 19:08:28 -04:00
2026-07-08 00:37:54 -04:00
2026-07-09 09:25:08 -04:00
2026-07-07 09:14:29 -04:00
2026-07-05 20:16:04 -04:00
2026-07-13 17:37:13 -04:00
2026-07-08 11:13:43 -04:00
2026-07-08 22:22:34 -04:00
2026-07-07 09:19:33 -04:00
2026-07-07 09:23:50 -04:00
2026-07-07 05:42:08 -04:00
2026-07-07 05:12:01 -04:00
2026-07-07 05:27:24 -04:00
2026-07-08 03:33:31 -04:00
2026-07-07 05:33:12 -04:00
2026-07-07 05:39:43 -04:00
2026-07-07 05:13:30 -04:00
2026-07-07 05:08:53 -04:00
2026-07-07 17:20:01 -04:00
2026-07-07 05:31:24 -04:00
2026-07-18 13:55:46 -04:00
2026-07-07 10:24:54 -04:00
2026-07-07 09:08:38 -04:00
2026-07-07 05:44:18 -04:00
2026-07-07 13:09:58 -04:00
2026-07-07 11:22:00 -04:00
2026-07-07 05:19:22 -04:00
2026-07-07 05:28:19 -04:00
2026-07-07 05:26:37 -04:00
2026-07-06 11:42:14 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-11 19:49:16 -04:00
2026-07-07 17:44:22 -04:00
2026-07-15 21:13:21 -04:00
2026-07-21 02:33:51 -05:00
2026-07-20 04:08:52 -05:00
2026-07-12 02:35:47 -04:00
2026-07-09 17:19:29 -04:00
2026-07-10 13:05:27 -04:00
2026-07-06 14:52:12 -04:00
2026-07-11 20:07:40 -04:00
2026-07-11 20:07:40 -04:00
2026-07-16 14:58:43 -05:00
2026-07-20 12:28:07 -04:00
2026-07-08 02:22:54 -04:00
2026-07-17 14:25:08 -04:00
2026-07-08 03:14:32 -04:00
2026-07-13 13:40:38 -04:00
2026-07-07 00:28:32 -04:00
2026-07-07 00:17:26 -04:00
2026-07-23 17:28:23 -04:00
2026-07-21 15:41:24 -04:00
2026-07-13 02:29:46 -04:00
2026-07-08 03:46:25 -04:00
2026-07-07 00:22:28 -04:00
2026-07-07 12:53:55 -04:00
2026-07-24 18:18:10 -04:00
2026-07-22 04:52:21 -05:00
2026-07-24 18:18:10 -04:00
2026-07-09 11:59:23 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-23 23:19:21 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-24 18:18:10 -04:00
2026-07-22 06:10:34 -05:00
2026-07-24 18:18:10 -04:00
2026-07-06 01:36:10 -04:00
2026-07-06 14:44:41 -04:00
2026-07-19 14:43:10 -04:00
2026-07-15 21:13:21 -04:00
2026-07-24 07:46:34 -04:00
2026-07-07 05:09:44 -04:00
2026-07-23 21:19:32 -04:00
2026-07-07 17:30:35 -04:00
2026-07-24 17:29:16 -04:00