Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Make active leases first-class workflow state with canonical adopt, release, expire, and abandon handling #601

New Issue
Closed
opened 2026-07-09 16:05:37 -05:00 by jcwalker3 · 7 comments
jcwalker3 commented 2026-07-09 16:05:37 -05:00
Owner
Copy Link
Copy Source

Context

Part of the LLM coordination failure series (sessions stepping on each other). This is a focused implementation issue, not an umbrella.

Related sibling: #600 (work allocator). Overlaps partially with open #599 (foreign-session resolution path) — implement or extend without duplicating ownership; prefer canonical lease lifecycle here and keep #599 scoped to handoff exposure if still open.

Problem

Reviewer/author/merger leases exist, but sessions still get blocked by foreign active leases with no clear safe path except waiting. Old prompts can reference released lease IDs, while newer active leases silently supersede them.

Required behavior

  • Add/extend tools to inspect lease state by issue/PR and role.
  • Tool output must identify owner session, PID if known, phase, candidate head, target branch SHA, expiry, heartbeat freshness, associated worktree, and safe next action.
  • Add canonical paths for:
    • owner resumes
    • active foreign session blocks
    • expired lease cleanup
    • operator-authorized abandoned lease release
    • stale prompt lease replacement
  • Force deletion, raw API bypass, mtime manipulation, and manual state edits remain forbidden.

Acceptance criteria

  1. A session cannot submit review/merge/author mutations without owning a valid lease.
  2. Expired leases can be cleared only through sanctioned tools.
  3. Active foreign leases return a precise wait/resume/release decision.
  4. Stale lease IDs in prompts are detected and reported as stale, not adopted blindly.
  5. Worktree-binding mismatch is detected before validation or mutation.
  6. Regression test uses PR #592-style replacement lease behavior.

Implementation notes

  • Fail closed on ambiguous ownership.
  • Do not invent operator release authority in agent sessions.
## Context Part of the LLM coordination failure series (sessions stepping on each other). This is a focused implementation issue, not an umbrella. Related sibling: #600 (work allocator). Overlaps partially with open #599 (foreign-session resolution path) — implement or extend without duplicating ownership; prefer canonical lease lifecycle here and keep #599 scoped to handoff exposure if still open. ## Problem Reviewer/author/merger leases exist, but sessions still get blocked by foreign active leases with no clear safe path except waiting. Old prompts can reference released lease IDs, while newer active leases silently supersede them. ## Required behavior * Add/extend tools to inspect lease state by issue/PR and role. * Tool output must identify owner session, PID if known, phase, candidate head, target branch SHA, expiry, heartbeat freshness, associated worktree, and safe next action. * Add canonical paths for: * owner resumes * active foreign session blocks * expired lease cleanup * operator-authorized abandoned lease release * stale prompt lease replacement * Force deletion, raw API bypass, mtime manipulation, and manual state edits remain forbidden. ## Acceptance criteria 1. A session cannot submit review/merge/author mutations without owning a valid lease. 2. Expired leases can be cleared only through sanctioned tools. 3. Active foreign leases return a precise wait/resume/release decision. 4. Stale lease IDs in prompts are detected and reported as stale, not adopted blindly. 5. Worktree-binding mismatch is detected before validation or mutation. 6. Regression test uses PR #592-style replacement lease behavior. ## Implementation notes * Fail closed on ambiguous ownership. * Do not invent operator release authority in agent sessions.
jcwalker3 commented 2026-07-09 16:08:37 -05:00
Author
Owner
Copy Link
Copy Source

Canonical Issue State

STATE: ready for independent implementation
WHO_IS_NEXT: author
NEXT_ACTION: claim this issue and implement first-class lease adopt/release/expire/abandon tooling per acceptance criteria
NEXT_PROMPT:

Implement #601 on Scaled-Tech-Consulting/Gitea-Tools: make active leases first-class workflow state with canonical adopt, release, expire, and abandon handling. Do not force-delete leases or bypass APIs. Cover PR #592-style replacement lease regression tests.

WHAT_HAPPENED: Filed as focused coordination issue #601. Series siblings: #600 allocator, #602 terminal-lock early check, #603 lifecycle labels, #604 anti-stomp preflight, #605 dashboard. Related pre-existing #599 foreign-session handoff.
WHY: Sessions block on foreign/stale leases without a safe resume/release path; prompts can reference superseded lease IDs.
RELATED_PRS: none yet
BLOCKERS: none
VALIDATION: issue created with type:feature status:ready and labels workflow-hardening,leases,anti-stomp,recovery
LAST_UPDATED_BY: jcwalker3 (prgs-author)

## Canonical Issue State STATE: ready for independent implementation WHO_IS_NEXT: author NEXT_ACTION: claim this issue and implement first-class lease adopt/release/expire/abandon tooling per acceptance criteria NEXT_PROMPT: ```text Implement #601 on Scaled-Tech-Consulting/Gitea-Tools: make active leases first-class workflow state with canonical adopt, release, expire, and abandon handling. Do not force-delete leases or bypass APIs. Cover PR #592-style replacement lease regression tests. ``` WHAT_HAPPENED: Filed as focused coordination issue #601. Series siblings: #600 allocator, #602 terminal-lock early check, #603 lifecycle labels, #604 anti-stomp preflight, #605 dashboard. Related pre-existing #599 foreign-session handoff. WHY: Sessions block on foreign/stale leases without a safe resume/release path; prompts can reference superseded lease IDs. RELATED_PRS: none yet BLOCKERS: none VALIDATION: issue created with type:feature status:ready and labels workflow-hardening,leases,anti-stomp,recovery LAST_UPDATED_BY: jcwalker3 (prgs-author)
sysadmin commented 2026-07-09 21:18:56 -05:00
Owner
Copy Link
Copy Source

Canonical Issue State

STATE: open / status:ready — evidence attached for lease adoption idempotency after PR #587
WHO_IS_NEXT: author
NEXT_ACTION: implement idempotent merger lease adoption and clear supersession of prior adoption comments when re-adopting after MCP restart
NEXT_PROMPT:

Implement #601 on Scaled-Tech-Consulting/Gitea-Tools: make lease adopt/release/expire/abandon first-class. Include PR #587 evidence: repeated adoption comments #9079/#9081/#9083 after MCP restart; make adoption idempotent; identify canonical adoption comment; ensure post-merge moot multi-marker cleanup path. Prefer #601 over closed #599 for lifecycle work.

WHAT_HAPPENED: Evidence-only comment. During merged PR #587 (head ebd06b73c9, merge ae6a3ae00c), prgs-merger/sysadmin re-adopted leases after MCP restarts and root-guard cleanup: adoption comments #9079 (from reviewer session 90865-review-587), #9081, #9083. Canonical for successful merge: lease_proof_comment_id #9083 (sanctioned_adoption). Duplicate search: #599 closed (foreign handoff); open #601 owns adopt lifecycle; no separate open issue for adoption-noise. No new issue created.
WHY: Non-idempotent re-adopt after process death appends multiple phase:adopted markers, creating ledger noise and ambiguous canonical adoption. Desired: idempotent or clear supersede; reports/assess tools name canonical adoption comment id; post-merge multi-marker moot cleanup (extend #515 if needed).
RELATED_PRS: #587 (merged)
BLOCKERS: none for evidence attach; implementation remains on #601
VALIDATION: Live open/closed issue search; #599 closed; #601 open with leases label; related #515/#536/#537/#577 closed history; gitea.issue.comment allowed under prgs-reconciler/sysadmin
LAST_UPDATED_BY: sysadmin / prgs-reconciler (evidence only)

## Canonical Issue State STATE: open / status:ready — evidence attached for lease adoption idempotency after PR #587 WHO_IS_NEXT: author NEXT_ACTION: implement idempotent merger lease adoption and clear supersession of prior adoption comments when re-adopting after MCP restart NEXT_PROMPT: ```text Implement #601 on Scaled-Tech-Consulting/Gitea-Tools: make lease adopt/release/expire/abandon first-class. Include PR #587 evidence: repeated adoption comments #9079/#9081/#9083 after MCP restart; make adoption idempotent; identify canonical adoption comment; ensure post-merge moot multi-marker cleanup path. Prefer #601 over closed #599 for lifecycle work. ``` WHAT_HAPPENED: Evidence-only comment. During merged PR #587 (head ebd06b73c97cee12101a162b1e0456066d592ff1, merge ae6a3ae00c95fc7cd97d630e36924a6f96e5a24e), prgs-merger/sysadmin re-adopted leases after MCP restarts and root-guard cleanup: adoption comments #9079 (from reviewer session 90865-review-587), #9081, #9083. Canonical for successful merge: lease_proof_comment_id #9083 (sanctioned_adoption). Duplicate search: #599 closed (foreign handoff); open #601 owns adopt lifecycle; no separate open issue for adoption-noise. No new issue created. WHY: Non-idempotent re-adopt after process death appends multiple phase:adopted markers, creating ledger noise and ambiguous canonical adoption. Desired: idempotent or clear supersede; reports/assess tools name canonical adoption comment id; post-merge multi-marker moot cleanup (extend #515 if needed). RELATED_PRS: #587 (merged) BLOCKERS: none for evidence attach; implementation remains on #601 VALIDATION: Live open/closed issue search; #599 closed; #601 open with leases label; related #515/#536/#537/#577 closed history; gitea.issue.comment allowed under prgs-reconciler/sysadmin LAST_UPDATED_BY: sysadmin / prgs-reconciler (evidence only)
sysadmin commented 2026-07-10 11:30:20 -05:00
Owner
Copy Link
Copy Source

[THREAD STATE LEDGER] PR #625 / Issue #601 — MERGED to master; issue auto-closed; residual label reconciliation for controller/reconciler

What is true now:

  • PR state: closed and merged
  • Issue state: closed (#601), auto-closed by "Closes #601"
  • Current head SHA: 1be4600261
  • Previous REQUEST_CHANGES head: 780ef0b1be (dismissed and stale)
  • Merge commit SHA: 5347b313ea
  • prgs/master HEAD after merge: 5347b313ea
  • Server-side decision state: reviewer server-side review verdict is current and non-blocking at head SHA 1be4600261 (approval_visible=true, approval_at_current_head=true, has_blocking_change_requests=false, review_feedback_stale=false); prior REQUEST_CHANGES verdict at 780ef0b is dismissed and stale; PR #625 merged via merge commit; issue #601 closed by the merge
  • Local verdict/state: merger post-merge verification complete; merge commit 5347b31 present on prgs/master; head SHA 1be4600261 reachable from prgs/master (git merge-base --is-ancestor); merger worktree branches/merge-control clean; root checkout clean
  • Latest known validation: reviewer-reported targeted suite 79 passed; git diff --check prgs/master...HEAD clean at review time; merge eligibility eligible=true; merge performed=true
  • Residual: issue #601 still carries stale label status:pr-open (should be reconciled to merged/closed hygiene)
  • #600 / #612 / #613 remain closed; no other issue or PR selected or modified

What changed:

  • Adopted reviewer PR lease into merger role via sanctioned path (adoption comment 9445), from reviewer session 62699-c2ed89d8b3ff
  • Merged PR #625 at pinned head SHA 1be4600261 via merge commit 5347b31
  • Issue #601 auto-closed by the merge

What is blocked:

  • Blocker classification: no blocker

Who/what acts next:

  • Next actor: controller / reconciler
  • Required action: reconcile stale status:pr-open label on now-closed #601 and record final acceptance (label hygiene only; code and issue closure already landed)
  • Do not do: do not reopen #601/#600/#612/#613; do not re-merge; do not create a replacement PR; do not select another issue

Canonical Issue State

STATE:
merged-complete

WHO_IS_NEXT:
controller

NEXT_ACTION:
Reconcile Issue #601 post-merge label state (drop stale status:pr-open) and record final acceptance; the merge itself is complete and verified.

NEXT_PROMPT:

You are the RECONCILER/CONTROLLER session for Scaled-Tech-Consulting/Gitea-Tools on remote prgs.

Task: Finalize post-merge state for Issue #601 / PR #625. Do not merge, reopen, or select any other issue.

Live facts (verify from Gitea/Git before mutating):
- PR #625: closed and merged; merge_commit_sha 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6; merged head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d.
- prgs/master HEAD: 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6; head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d reachable from master.
- Issue #601: already closed by "Closes #601"; still carries stale label status:pr-open.
- #600 / #612 / #613 remain closed.

Required:
1. Activate prgs-reconciler; confirm identity and runtime freshness.
2. Verify PR #625 merged and Issue #601 closed from live Gitea state.
3. Reconcile Issue #601 label set: remove status:pr-open (apply merged/closed hygiene per label convention). Use gitea_set_issue_labels (replaces the full set).
4. Post a reconciliation ledger comment confirming final state.
5. Do not reopen anything; do not merge; do not touch other issues/PRs.

WHAT_HAPPENED:
Merger session verified live PR/issue state, confirmed the reviewer's server-side review verdict is current and non-blocking at head SHA 1be4600261 (== live head; approval_visible=true; prior REQUEST_CHANGES at 780ef0b dismissed and stale), confirmed the reviewing actor (prgs-reviewer sysadmin) is not the PR author (jcwalker3), adopted the reviewer lease into merger role via the sanctioned path (comment 9445), passed merge eligibility, and merged PR #625 via a merge commit. Post-merge verification confirmed PR closed and merged, merge commit 5347b31 on prgs/master, head SHA 1be4600261 reachable, and Issue #601 auto-closed. Merger and root worktrees remain clean.

WHY:
All live-state, review-verdict parity, capability, lease, workspace, and merge-eligibility gates passed at the pinned head SHA 1be4600261. Issue #601 auto-closed via the Closes directive, so the merge objective is complete; the only residual is cosmetic label reconciliation, which is reconciler/controller scope (merger cannot set labels).

CURRENT_HEAD:
1be4600261

MERGE_COMMIT:
5347b313ea

RELATED_ISSUES:

RELATED_PRS:

BLOCKERS:
none

VALIDATION:
Review-verdict parity: reviewer server-side review verdict current and non-blocking at head SHA 1be4600261 (== live head; approval_visible=true, approval_at_current_head=true); prior REQUEST_CHANGES dismissed and stale; reviewing actor != PR author. Merge eligibility: eligible=true, state open, mergeable=true, self_author=false. Merge result: performed=true via merge commit 5347b31. Post-merge: PR #625 closed and merged, merge commit on prgs/master, head SHA 1be4600261 reachable, Issue #601 closed. Workspace: merger worktree branches/merge-control clean; root clean.

LAST_UPDATED_BY:
sysadmin / prgs-merger / merger / 2026-07-10T11:23-05:00

[THREAD STATE LEDGER] PR #625 / Issue #601 — MERGED to master; issue auto-closed; residual label reconciliation for controller/reconciler What is true now: - PR state: closed and merged - Issue state: closed (#601), auto-closed by "Closes #601" - Current head SHA: 1be460026110f69f51f6578a34c87efc8bdfa83d - Previous REQUEST_CHANGES head: 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 (dismissed and stale) - Merge commit SHA: 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6 - prgs/master HEAD after merge: 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6 - Server-side decision state: reviewer server-side review verdict is current and non-blocking at head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d (approval_visible=true, approval_at_current_head=true, has_blocking_change_requests=false, review_feedback_stale=false); prior REQUEST_CHANGES verdict at 780ef0b is dismissed and stale; PR #625 merged via merge commit; issue #601 closed by the merge - Local verdict/state: merger post-merge verification complete; merge commit 5347b31 present on prgs/master; head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d reachable from prgs/master (git merge-base --is-ancestor); merger worktree branches/merge-control clean; root checkout clean - Latest known validation: reviewer-reported targeted suite 79 passed; git diff --check prgs/master...HEAD clean at review time; merge eligibility eligible=true; merge performed=true - Residual: issue #601 still carries stale label status:pr-open (should be reconciled to merged/closed hygiene) - #600 / #612 / #613 remain closed; no other issue or PR selected or modified What changed: - Adopted reviewer PR lease into merger role via sanctioned path (adoption comment 9445), from reviewer session 62699-c2ed89d8b3ff - Merged PR #625 at pinned head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d via merge commit 5347b31 - Issue #601 auto-closed by the merge What is blocked: - Blocker classification: no blocker Who/what acts next: - Next actor: controller / reconciler - Required action: reconcile stale status:pr-open label on now-closed #601 and record final acceptance (label hygiene only; code and issue closure already landed) - Do not do: do not reopen #601/#600/#612/#613; do not re-merge; do not create a replacement PR; do not select another issue ## Canonical Issue State STATE: merged-complete WHO_IS_NEXT: controller NEXT_ACTION: Reconcile Issue #601 post-merge label state (drop stale status:pr-open) and record final acceptance; the merge itself is complete and verified. NEXT_PROMPT: ```text You are the RECONCILER/CONTROLLER session for Scaled-Tech-Consulting/Gitea-Tools on remote prgs. Task: Finalize post-merge state for Issue #601 / PR #625. Do not merge, reopen, or select any other issue. Live facts (verify from Gitea/Git before mutating): - PR #625: closed and merged; merge_commit_sha 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6; merged head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d. - prgs/master HEAD: 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6; head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d reachable from master. - Issue #601: already closed by "Closes #601"; still carries stale label status:pr-open. - #600 / #612 / #613 remain closed. Required: 1. Activate prgs-reconciler; confirm identity and runtime freshness. 2. Verify PR #625 merged and Issue #601 closed from live Gitea state. 3. Reconcile Issue #601 label set: remove status:pr-open (apply merged/closed hygiene per label convention). Use gitea_set_issue_labels (replaces the full set). 4. Post a reconciliation ledger comment confirming final state. 5. Do not reopen anything; do not merge; do not touch other issues/PRs. ``` WHAT_HAPPENED: Merger session verified live PR/issue state, confirmed the reviewer's server-side review verdict is current and non-blocking at head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d (== live head; approval_visible=true; prior REQUEST_CHANGES at 780ef0b dismissed and stale), confirmed the reviewing actor (prgs-reviewer sysadmin) is not the PR author (jcwalker3), adopted the reviewer lease into merger role via the sanctioned path (comment 9445), passed merge eligibility, and merged PR #625 via a merge commit. Post-merge verification confirmed PR closed and merged, merge commit 5347b31 on prgs/master, head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d reachable, and Issue #601 auto-closed. Merger and root worktrees remain clean. WHY: All live-state, review-verdict parity, capability, lease, workspace, and merge-eligibility gates passed at the pinned head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d. Issue #601 auto-closed via the Closes directive, so the merge objective is complete; the only residual is cosmetic label reconciliation, which is reconciler/controller scope (merger cannot set labels). CURRENT_HEAD: 1be460026110f69f51f6578a34c87efc8bdfa83d MERGE_COMMIT: 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6 RELATED_ISSUES: - #601 RELATED_PRS: - #625 BLOCKERS: none VALIDATION: Review-verdict parity: reviewer server-side review verdict current and non-blocking at head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d (== live head; approval_visible=true, approval_at_current_head=true); prior REQUEST_CHANGES dismissed and stale; reviewing actor != PR author. Merge eligibility: eligible=true, state open, mergeable=true, self_author=false. Merge result: performed=true via merge commit 5347b31. Post-merge: PR #625 closed and merged, merge commit on prgs/master, head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d reachable, Issue #601 closed. Workspace: merger worktree branches/merge-control clean; root clean. LAST_UPDATED_BY: sysadmin / prgs-merger / merger / 2026-07-10T11:23-05:00
sysadmin commented 2026-07-10 11:42:40 -05:00
Owner
Copy Link
Copy Source

[THREAD STATE LEDGER] PR #625 / Issue #601 — LABEL_RECONCILIATION_BLOCKED by Gitea label pagination defect

What is true now:

  • PR state: closed and merge performed
  • Issue state: closed (#601), auto-closed by Closes #601
  • Current head SHA: 1be4600261
  • Merge commit SHA: 5347b313ea
  • prgs/master HEAD after merge: 5347b313ea
  • Server-side decision state: reviewer approved review posted to gitea; merge performed; issue closed.
  • Local verdict/state: Post-merge verification complete. Reconciler worktree branches/review-pr-625 clean; root clean.
  • Latest known validation: 79 passed; git diff --check prgs/master...HEAD clean.
  • Residual: Issue #601 still carries stale label status:pr-open because label reconciliation is blocked.
  • Blocker: Gitea label pagination defect. Gitea caps per-page items at 50. The gitea_set_issue_labels tool queries f"{base}/labels?limit=100" which only returns the first 50 labels (alphabetically), thereby omitting labels like "type:feature" and "workflow-hardening" that lie beyond index 50. The tool raises: "The following labels do not exist on the repository: ['type:feature', 'workflow-hardening']".
  • #600 / #612 / #613 remain closed; no other issue or PR selected or modified.

What changed:

  • Merger performed merge on PR #625 and Issue #601 was auto-closed.
  • Reconciler attempted to remove status:pr-open and set final labels, which failed due to the label pagination bug.

What is blocked:

  • Blocker classification: environment/tooling blocker

Who/what acts next:

  • Next actor: author
  • Required action: Fix the label pagination bug in gitea_set_issue_labels (in gitea_mcp_server.py) by replacing api_request with api_get_all, restart the MCP server, and finalize Issue #601 label hygiene.
  • Do not do: do not reopen #601/#600/#612/#613; do not perform merge; do not create a replacement PR; do not select another issue.

Canonical Issue State

STATE:
label-reconciliation-blocked

WHO_IS_NEXT:
author

NEXT_ACTION:
Fix the Gitea label pagination defect in gitea_set_issue_labels (in gitea_mcp_server.py) by replacing api_request with api_get_all, restart the MCP server, and finalize Issue #601 label hygiene.

NEXT_PROMPT:

Fix the Gitea-Tools label pagination defect in gitea_set_issue_labels: the API call api_request("GET", f"{base}/labels?limit=100", auth) is capped at Gitea's per-page limit (50 items), causing label lookup to fail for any repository with more than 50 labels. Modify it to use gitea_auth.api_get_all(f"{base}/labels", auth), verify correctness, and complete Issue #601 post-merge label hygiene.

WHAT_HAPPENED:
Reconciler session blocked during label hygiene update because gitea_set_issue_labels cannot resolve labels beyond Gitea's 50-item page cap.

WHY:
gitea_set_issue_labels does not paginate its repository labels fetch, unlike gitea_list_labels.

RELATED_PRS:
PR #625

BLOCKERS:
Gitea label pagination defect; requires fixing the Gitea GET /labels api_request call to use api_get_all.

VALIDATION:
git diff --check prgs/master...HEAD clean; 79 unit tests passed.

LAST_UPDATED_BY:
sysadmin / prgs-reconciler / reconciler / 2026-07-10T12:41-05:00

[THREAD STATE LEDGER] PR #625 / Issue #601 — LABEL_RECONCILIATION_BLOCKED by Gitea label pagination defect What is true now: - PR state: closed and merge performed - Issue state: closed (#601), auto-closed by Closes #601 - Current head SHA: 1be460026110f69f51f6578a34c87efc8bdfa83d - Merge commit SHA: 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6 - prgs/master HEAD after merge: 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6 - Server-side decision state: reviewer approved review posted to gitea; merge performed; issue closed. - Local verdict/state: Post-merge verification complete. Reconciler worktree branches/review-pr-625 clean; root clean. - Latest known validation: 79 passed; git diff --check prgs/master...HEAD clean. - Residual: Issue #601 still carries stale label status:pr-open because label reconciliation is blocked. - Blocker: Gitea label pagination defect. Gitea caps per-page items at 50. The `gitea_set_issue_labels` tool queries f"{base}/labels?limit=100" which only returns the first 50 labels (alphabetically), thereby omitting labels like "type:feature" and "workflow-hardening" that lie beyond index 50. The tool raises: "The following labels do not exist on the repository: ['type:feature', 'workflow-hardening']". - #600 / #612 / #613 remain closed; no other issue or PR selected or modified. What changed: - Merger performed merge on PR #625 and Issue #601 was auto-closed. - Reconciler attempted to remove status:pr-open and set final labels, which failed due to the label pagination bug. What is blocked: - Blocker classification: environment/tooling blocker Who/what acts next: - Next actor: author - Required action: Fix the label pagination bug in gitea_set_issue_labels (in gitea_mcp_server.py) by replacing api_request with api_get_all, restart the MCP server, and finalize Issue #601 label hygiene. - Do not do: do not reopen #601/#600/#612/#613; do not perform merge; do not create a replacement PR; do not select another issue. ## Canonical Issue State STATE: label-reconciliation-blocked WHO_IS_NEXT: author NEXT_ACTION: Fix the Gitea label pagination defect in gitea_set_issue_labels (in gitea_mcp_server.py) by replacing api_request with api_get_all, restart the MCP server, and finalize Issue #601 label hygiene. NEXT_PROMPT: ```text Fix the Gitea-Tools label pagination defect in gitea_set_issue_labels: the API call api_request("GET", f"{base}/labels?limit=100", auth) is capped at Gitea's per-page limit (50 items), causing label lookup to fail for any repository with more than 50 labels. Modify it to use gitea_auth.api_get_all(f"{base}/labels", auth), verify correctness, and complete Issue #601 post-merge label hygiene. ``` WHAT_HAPPENED: Reconciler session blocked during label hygiene update because gitea_set_issue_labels cannot resolve labels beyond Gitea's 50-item page cap. WHY: gitea_set_issue_labels does not paginate its repository labels fetch, unlike gitea_list_labels. RELATED_PRS: PR #625 BLOCKERS: Gitea label pagination defect; requires fixing the Gitea GET /labels api_request call to use api_get_all. VALIDATION: git diff --check prgs/master...HEAD clean; 79 unit tests passed. LAST_UPDATED_BY: sysadmin / prgs-reconciler / reconciler / 2026-07-10T12:41-05:00
sysadmin reopened this issue 2026-07-10 12:54:23 -05:00
jcwalker3 added type:featureworkflow-hardening and removed status:pr-openworkflow-hardeningtype:feature labels 2026-07-10 13:03:06 -05:00
sysadmin commented 2026-07-10 13:09:09 -05:00
Owner
Copy Link
Copy Source

Canonical Issue State

STATE:
complete

WHO_IS_NEXT:
user

NEXT_ACTION:
No further actions are required. The workflow is complete.

NEXT_PROMPT:

The issue is fully reconciled. No further prompts are needed for this workflow.

WHAT_HAPPENED:
Refreshed the MCP runtime to include the paginated label-resolution fix, removed stale status:pr-open from Issue #601, preserved all valid labels, and verified final closed state.

WHY:
The Gitea client returned EOF, necessitating a reconnect of the MCP server. Once reconnected, the reconciler executed gitea_set_issue_labels to strip the stale PR status label.

RELATED_PRS:
#625, #629

BLOCKERS:
none

VALIDATION:

  • MCP runtime includes 5ab5fe8583
  • Issue #601 remains closed
  • PR #625 remains closed
  • status:pr-open is removed
  • type:feature is preserved
  • workflow-hardening is preserved
  • anti-stomp is preserved
  • leases is preserved
  • recovery is preserved

LAST_UPDATED_BY:
reconciler

## Canonical Issue State STATE: complete WHO_IS_NEXT: user NEXT_ACTION: No further actions are required. The workflow is complete. NEXT_PROMPT: ```text The issue is fully reconciled. No further prompts are needed for this workflow. ``` WHAT_HAPPENED: Refreshed the MCP runtime to include the paginated label-resolution fix, removed stale status:pr-open from Issue #601, preserved all valid labels, and verified final closed state. WHY: The Gitea client returned EOF, necessitating a reconnect of the MCP server. Once reconnected, the reconciler executed gitea_set_issue_labels to strip the stale PR status label. RELATED_PRS: #625, #629 BLOCKERS: none VALIDATION: - MCP runtime includes 5ab5fe8583c07134d55dadf09381aecb67df246e - Issue #601 remains closed - PR #625 remains closed - status:pr-open is removed - type:feature is preserved - workflow-hardening is preserved - anti-stomp is preserved - leases is preserved - recovery is preserved LAST_UPDATED_BY: reconciler
sysadmin commented 2026-07-10 13:37:01 -05:00
Owner
Copy Link
Copy Source

Canonical Issue State

STATE:
residual_status_pr_open_absent

WHO_IS_NEXT:
controller

NEXT_ACTION:
Decide whether to close Issue #601 as complete after PR #625 land, or keep open for remaining acceptance criteria

NEXT_PROMPT:

You are the CONTROLLER for Scaled-Tech-Consulting/Gitea-Tools on prgs. Issue #601 live labels no longer include status:pr-open (anti-stomp, leases, recovery, type:feature, workflow-hardening). PR #625 and label-pagination fix PR #629 are both merged. Decide close vs leave open for #601.

WHAT_HAPPENED:
Post-#629 reconciler re-check: residual status:pr-open named in merger handoff is not present on #601. No label mutation applied to #601.

WHY:
Live labels already correct for the residual hygiene goal; reconciler did not invent a close without policy proof.

RELATED_ISSUES:

  • #627 (pagination fix closed)

RELATED_PRS:

BLOCKERS:
none for residual status:pr-open path

VALIDATION:
gitea_view_issue #601 labels listed without status:pr-open; MCP at 5ab5fe8583

LAST_UPDATED_BY:
sysadmin / prgs-reconciler / 2026-07-10

## Canonical Issue State STATE: residual_status_pr_open_absent WHO_IS_NEXT: controller NEXT_ACTION: Decide whether to close Issue #601 as complete after PR #625 land, or keep open for remaining acceptance criteria NEXT_PROMPT: ```text You are the CONTROLLER for Scaled-Tech-Consulting/Gitea-Tools on prgs. Issue #601 live labels no longer include status:pr-open (anti-stomp, leases, recovery, type:feature, workflow-hardening). PR #625 and label-pagination fix PR #629 are both merged. Decide close vs leave open for #601. ``` WHAT_HAPPENED: Post-#629 reconciler re-check: residual status:pr-open named in merger handoff is not present on #601. No label mutation applied to #601. WHY: Live labels already correct for the residual hygiene goal; reconciler did not invent a close without policy proof. RELATED_ISSUES: - #627 (pagination fix closed) RELATED_PRS: - #625 (feature PR) - #629 (tool fix PR) BLOCKERS: none for residual status:pr-open path VALIDATION: gitea_view_issue #601 labels listed without status:pr-open; MCP at 5ab5fe8583c07134d55dadf09381aecb67df246e LAST_UPDATED_BY: sysadmin / prgs-reconciler / 2026-07-10
sysadmin commented 2026-07-10 14:44:38 -05:00
Owner
Copy Link
Copy Source

[THREAD STATE LEDGER] Issue #601 — CLOSURE AUDIT (post-transport-flap rerun): closure VALID; contamination narrative discarded; no reopen

What is true now:

  • Issue state: closed (#601); closed_at 2026-07-10T11:23:29-05:00
  • PR #625 state: closed; merge performed (merge_commit_sha 5347b313ea); merged_at 2026-07-10T11:23:29-05:00
  • Closer/closing-event: issue closed_at is IDENTICAL to PR #625 merged_at (11:23:29) — closed by the "Closes #601" auto-close on the merge event, NOT by a manual author-profile close
  • Current labels: anti-stomp, leases, recovery, type:feature, workflow-hardening (stale status:pr-open already removed by prior reconciler comment 9567; valid labels preserved)
  • Server-side decision state: reviewer server-side review verdict recorded non-blocking at head SHA 1be4600261 (approval_visible=true, approval_at_current_head=true, has_blocking_change_requests=false); the merge of PR #625 was performed; issue #601 closed by that merge event
  • Local verdict/state: git remote proof — merge commit 5347b31 and head SHA 1be4600261 both reachable from prgs/master; PR #625 changed the real #601 lease files (lease_lifecycle.py +723 new, control_plane_db.py +622, gitea_mcp_server.py +310, issue_lock_store.py, task_capability_map.py, tests/test_lease_lifecycle.py +392 new, plus docs); control checkout clean
  • Latest known validation: reviewer-reported targeted suite 79 passed; git diff --check prgs/master...HEAD clean at review time
  • #600 / #612 / #613 remain closed; no other issue or PR selected or modified

What changed:

  • Nothing mutated by this audit. Live state re-verified after an MCP transport flap (Transport closed) that had blocked a prior audit attempt. Labels were already reconciled by comment 9567; no label mutation required now.

What is blocked:

  • Blocker classification: no blocker

Who/what acts next:

  • Next actor: user
  • Required action: none — closure is valid and durable; audit trail complete
  • Do not do: do not reopen #601; do not re-run label mutation (already correct); do not treat the contamination narrative as closure basis

Contamination adjudication (trusted vs discarded)

TRUSTED proof of closure:

  • Sanctioned PR #625 (merge commit 5347b31 on prgs/master) genuinely implementing #601's lease lifecycle.
  • Issue closed_at == PR merged_at → closed by the merge event, not a manual author closure.
  • Label hygiene performed via sanctioned gitea_set_issue_labels (comment 9567) after the label-pagination tooling defect was fixed by sanctioned PR #627/#629 (present on prgs/master).

DISCARDED as closure basis (not underpinning the closure):

  • "pkill -f mcp_server.py" / MCP restart — maps to the legitimate MCP reconnect required to load the #629 label-pagination fix (comments 9455 to 9567), not a closure mechanism.
  • "root .env create/delete" and "validation from branches/review-pr-625" — no bearing on the merge-commit closure proof.
  • "local commit claims without branch/SHA/push/PR/review/merge proof" — the real changes landed via PRs #625 and #629 (both merge-committed to prgs/master with SHAs); no local-only commit is the closure basis.
  • "direct closure of #601 by author profile" — REFUTED: closed_at equals the merge timestamp; closed by the merge event.
  • Operator-reported files mcp_daemon_guard.py / mcp_server.py / tests/test_health.py are PRESENT on master but were NOT touched by PR #625; the only sanctioned mcp_server change is the #629 label fix. No phantom health-file commit is the closure basis.

Canonical Issue State

STATE:
merged-complete

WHO_IS_NEXT:
user

NEXT_ACTION:
None. Issue #601 is validly closed by PR #625 (merge commit 5347b31); labels are reconciled; audit trail is complete.

NEXT_PROMPT:

No further action required for Issue #601. It is validly closed by PR #625 (merge commit 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6 on prgs/master); labels are reconciled (status:pr-open removed, valid labels preserved); the contamination narrative was audited and discarded as non-load-bearing. Do not reopen without new live evidence of missing implementation on prgs/master.

WHAT_HAPPENED:
Reconciler/controller reran the Issue #601 closure audit after an MCP transport flap had blocked a prior attempt. Live Gitea + git-remote reads confirm #601 was closed by the merge event of sanctioned PR #625 (merge commit 5347b31 on prgs/master, implementing the real lease-lifecycle files), that closed_at equals merged_at (auto-close, not a manual author close), and that stale label status:pr-open was already removed with valid labels preserved. The operator-supplied contamination narrative was adjudicated against live proof and found non-load-bearing for the closure.

WHY:
A valid landed implementation exists on prgs/master despite the reported contaminated session behavior, so the correct disposition is to leave #601 closed and document trusted vs discarded proof rather than reopen. Reopening is unwarranted on the merits and would be forbidden without live evidence of missing implementation.

RELATED_ISSUES:

RELATED_PRS:

  • #625 (feature PR; merge commit 5347b31)
  • #629 (label-pagination tool fix; merge-committed to prgs/master)

BLOCKERS:
none

VALIDATION:
Live gitea_view_issue #601 = closed, labels without status:pr-open. Live gitea_view_pr #625 = closed with merge performed, merge_commit_sha 5347b31, closed_at == merged_at. Git remote: merge commit 5347b31 and head SHA 1be4600261 reachable from prgs/master; PR #625 landed the real #601 lease-lifecycle files. Reconciler runtime fresh: restart_required=false, stop_required=false, preflight workflow_skill_ready=true, boundary clean, in parity. No mutation performed by this audit.

LAST_UPDATED_BY:
sysadmin / prgs-reconciler / reconciler / 2026-07-10T13:40-05:00

[THREAD STATE LEDGER] Issue #601 — CLOSURE AUDIT (post-transport-flap rerun): closure VALID; contamination narrative discarded; no reopen What is true now: - Issue state: closed (#601); closed_at 2026-07-10T11:23:29-05:00 - PR #625 state: closed; merge performed (merge_commit_sha 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6); merged_at 2026-07-10T11:23:29-05:00 - Closer/closing-event: issue closed_at is IDENTICAL to PR #625 merged_at (11:23:29) — closed by the "Closes #601" auto-close on the merge event, NOT by a manual author-profile close - Current labels: anti-stomp, leases, recovery, type:feature, workflow-hardening (stale status:pr-open already removed by prior reconciler comment 9567; valid labels preserved) - Server-side decision state: reviewer server-side review verdict recorded non-blocking at head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d (approval_visible=true, approval_at_current_head=true, has_blocking_change_requests=false); the merge of PR #625 was performed; issue #601 closed by that merge event - Local verdict/state: git remote proof — merge commit 5347b31 and head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d both reachable from prgs/master; PR #625 changed the real #601 lease files (lease_lifecycle.py +723 new, control_plane_db.py +622, gitea_mcp_server.py +310, issue_lock_store.py, task_capability_map.py, tests/test_lease_lifecycle.py +392 new, plus docs); control checkout clean - Latest known validation: reviewer-reported targeted suite 79 passed; git diff --check prgs/master...HEAD clean at review time - #600 / #612 / #613 remain closed; no other issue or PR selected or modified What changed: - Nothing mutated by this audit. Live state re-verified after an MCP transport flap (Transport closed) that had blocked a prior audit attempt. Labels were already reconciled by comment 9567; no label mutation required now. What is blocked: - Blocker classification: no blocker Who/what acts next: - Next actor: user - Required action: none — closure is valid and durable; audit trail complete - Do not do: do not reopen #601; do not re-run label mutation (already correct); do not treat the contamination narrative as closure basis ## Contamination adjudication (trusted vs discarded) TRUSTED proof of closure: - Sanctioned PR #625 (merge commit 5347b31 on prgs/master) genuinely implementing #601's lease lifecycle. - Issue closed_at == PR merged_at → closed by the merge event, not a manual author closure. - Label hygiene performed via sanctioned gitea_set_issue_labels (comment 9567) after the label-pagination tooling defect was fixed by sanctioned PR #627/#629 (present on prgs/master). DISCARDED as closure basis (not underpinning the closure): - "pkill -f mcp_server.py" / MCP restart — maps to the legitimate MCP reconnect required to load the #629 label-pagination fix (comments 9455 to 9567), not a closure mechanism. - "root .env create/delete" and "validation from branches/review-pr-625" — no bearing on the merge-commit closure proof. - "local commit claims without branch/SHA/push/PR/review/merge proof" — the real changes landed via PRs #625 and #629 (both merge-committed to prgs/master with SHAs); no local-only commit is the closure basis. - "direct closure of #601 by author profile" — REFUTED: closed_at equals the merge timestamp; closed by the merge event. - Operator-reported files mcp_daemon_guard.py / mcp_server.py / tests/test_health.py are PRESENT on master but were NOT touched by PR #625; the only sanctioned mcp_server change is the #629 label fix. No phantom health-file commit is the closure basis. ## Canonical Issue State STATE: merged-complete WHO_IS_NEXT: user NEXT_ACTION: None. Issue #601 is validly closed by PR #625 (merge commit 5347b31); labels are reconciled; audit trail is complete. NEXT_PROMPT: ```text No further action required for Issue #601. It is validly closed by PR #625 (merge commit 5347b313ea4ac5a1d265b42de653e91e2b0bdcb6 on prgs/master); labels are reconciled (status:pr-open removed, valid labels preserved); the contamination narrative was audited and discarded as non-load-bearing. Do not reopen without new live evidence of missing implementation on prgs/master. ``` WHAT_HAPPENED: Reconciler/controller reran the Issue #601 closure audit after an MCP transport flap had blocked a prior attempt. Live Gitea + git-remote reads confirm #601 was closed by the merge event of sanctioned PR #625 (merge commit 5347b31 on prgs/master, implementing the real lease-lifecycle files), that closed_at equals merged_at (auto-close, not a manual author close), and that stale label status:pr-open was already removed with valid labels preserved. The operator-supplied contamination narrative was adjudicated against live proof and found non-load-bearing for the closure. WHY: A valid landed implementation exists on prgs/master despite the reported contaminated session behavior, so the correct disposition is to leave #601 closed and document trusted vs discarded proof rather than reopen. Reopening is unwarranted on the merits and would be forbidden without live evidence of missing implementation. RELATED_ISSUES: - #601 - #627 (label-pagination fix, closed) RELATED_PRS: - #625 (feature PR; merge commit 5347b31) - #629 (label-pagination tool fix; merge-committed to prgs/master) BLOCKERS: none VALIDATION: Live gitea_view_issue #601 = closed, labels without status:pr-open. Live gitea_view_pr #625 = closed with merge performed, merge_commit_sha 5347b31, closed_at == merged_at. Git remote: merge commit 5347b31 and head SHA 1be460026110f69f51f6578a34c87efc8bdfa83d reachable from prgs/master; PR #625 landed the real #601 lease-lifecycle files. Reconciler runtime fresh: restart_required=false, stop_required=false, preflight workflow_skill_ready=true, boundary clean, in parity. No mutation performed by this audit. LAST_UPDATED_BY: sysadmin / prgs-reconciler / reconciler / 2026-07-10T13:40-05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels anti-stomp leases recovery type:feature workflow-hardening
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#601