feat: lifecycle role/hazard labels and canonical state mapping (#603) #654
Merged
sysadmin
merged 1 commits from 2026-07-10 15:43:47 -05:00
feat/issue-603-lifecycle-labels into master
Labels
Clear labels
allocator
anti-stomp
architecture
bug
chore
codex
concurrency
contamination
control-plane
dashboard
database
design
documentation
enhancement
gitea
glitchtip
important
incident
incident-bridge
integration
jenkins
labels
leases
mcp
mcp-health
mcp-menu
multi-project
mutating
nice-to-have
observability
portability
preflight
protected-branch
queue
read-only
reconnect
recovery
refactor
release
reliability
resumable-review
reviewer
roadmap
safety
security
self-hosted
sentry
stale-runtime
status:blocked
status:in-progress
status:pr-open
status:ready
terminal-lock
testing
tracker
type:bug
type:feature
type:feature
type:guardrail
visibility
workflow
workflow-hardening
workflow-hardening
Controller-owned work allocator
Prevent concurrent LLM session stomping
Architecture / structural design
OpenAI Codex client / workflow session surface
Concurrent session safety
Workflow or session contamination incident
MCP control-plane coordination and allocation authority
MCP operational dashboard/queue view
Internal coordination storage (SQLite/Postgres)
Design / investigation, no implementation
Docs / runbooks
New feature or improvement
Gitea MCP workflow
GlitchTip integration
Operational or process incident requiring durable audit trail
Sentry-to-Gitea incident bridging
Integration testing
Jenkins integration
Label taxonomy management
Lease adopt/release/expire lifecycle
MCP server / tooling
MCP namespace and runtime health
MCP menu surface
Work spanning multiple monitoring projects or Gitea repos
Mutating action; requires gating
Observability, metrics, traces, error reporting
Cross-platform / portability
Shared preflight gates before mutation
Protected branch / stable-branch policy concern
Work queue visibility and allocation
Read-only, no mutation
MCP client reconnect/reload recovery path
Recovery paths for stale/foreign leases
Code refactor / restructure
Release / versioning
Reliability / failure handling
Persist and resume prepared review verdicts across sessions
Reviewer workflow tooling
Roadmap / umbrella issue
Safety rails and fail-closed mutation guards
Security / trust boundary
Self-hosted infrastructure integration
Sentry error monitoring integration
Stale backend daemon / runtime-vs-master parity failures
Issue is blocked
Issue is being worked on
Issue has an open pull request
Issue is ready for work
Terminal review lock (#332) path
Tests / test coverage
Issue tracker hygiene / meta
Bug or defect
Feature or enhancement
Feature or enhancement
Safety gate or guardrail
Workflow state visibility for LLMs/operators
Cross-tool workflow
LLM workflow coordination hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Scaled-Tech-Consulting/Gitea-Tools#654
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Implements #603: lifecycle visibility labels so LLM workflows can see ownership and process state, folded into the existing canonical taxonomy instead of a parallel vocabulary.
Changes
issue_workflow_labels.pyrole:*labels (author/reviewer/merger) — single active owner, advisory only; control-plane leases (#601) remain the mutation source of truth.hazard:*labels (stale-lease, workflow-contaminated, conflicted, root-mutation, manual-state, terminal-blocker) — additive warning flags, multiple may be active at once.status:changes-requestedlifecycle status.state:*proposal into canonicalstatus:*via transition synonyms (authoring→in-progress, merge-ready→approved, abandoned→wontfix, etc.);state:terminal-blocker→hazard:terminal-blocker.transition_role_labels,add_hazard_label,clear_hazard_label,canonical_role_label,canonical_hazard_label,is_discussion,is_implementation_candidate,requires_blocking_reason.assess_issue_labelsnow surfaces role/hazard dimensions and flags multiple active role labels.docs/label-taxonomy.md: role, hazard,state:*→canonical migration, and allocator cross-check sections.manage_labels.py: seeds the new labels automatically viaCANONICAL_LABEL_SPECS(no code change required).state:*synonym + blocked/merged transitions.Acceptance criteria
is_implementation_candidate.requires_blocking_reason.Validation
venv/bin/python3 -m pytest tests/test_issue_workflow_labels.py tests/test_manage_labels.py tests/test_post_merge_validation.py -q→ 51 passedissue_workflow_labels,manage_labels,create_issue) → OK;CANONICAL_LABELScount 37, roles 3, hazards 6.TestTrackerHygieneCleanupfailures are environmental HTTP 401 (live API escaping test mocks); reproduced on clean master without this change (7 failing at baseline) — not introduced here.Reviewer handoff
feat/issue-603-lifecycle-labels, headf34319852e94, ownerprgs-author, freshness live.Closes #603
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #654
issue: #603
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 20908-934cf2e14b4e
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-654
phase: claimed
candidate_head:
f34319852etarget_branch: master
target_branch_sha:
5ab5fe8583last_activity: 2026-07-10T20:28:14Z
expires_at: 2026-07-10T22:28:14Z
blocker: none
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #654
issue: #603
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 20908-934cf2e14b4e
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-654
phase: claimed
candidate_head:
f34319852etarget_branch: master
target_branch_sha:
5ab5fe8583last_activity: 2026-07-10T20:30:00Z
expires_at: 2026-07-10T22:30:00Z
blocker: none
All acceptance criteria met. 51 passed tests verified.
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #654
issue: #603
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 20908-934cf2e14b4e
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-654
phase: released
candidate_head:
f34319852etarget_branch: master
target_branch_sha:
5ab5fe8583last_activity: 2026-07-10T20:40:09Z
expires_at: 2026-07-10T22:40:09Z
blocker: manual-release
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #654
issue: #603
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 20788-27e3725bd380
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-654-f343198
phase: claimed
candidate_head:
f34319852etarget_branch: master
target_branch_sha:
5ab5fe8583last_activity: 2026-07-10T20:40:19Z
expires_at: 2026-07-10T22:40:19Z
blocker: none
Canonical PR State
STATE: approved
WHO_IS_NEXT: merger
NEXT_ACTION: Merge PR #654 at head
f34319852ewith a clean merger session (do not treat review_id 417 as merge-authorizing).NEXT_PROMPT:
WHAT_HAPPENED: Fresh independent prgs-reviewer re-validated #603 lifecycle labels on head f343198; authorized correction of contaminated APPROVE 417; acquired lease via sanctioned release+acquire; formal APPROVE submitted.
WHY: Implementation meets #603 acceptance (role/hazard labels, state synonyms, discussion exclusion, blocking-reason helper); validation 67 passed; prior APPROVE 417 is workflow-contaminated and not merge-authorizing.
ISSUE: #603
BASE: master
HEAD: feat/issue-603-lifecycle-labels
HEAD_SHA:
f34319852eREVIEW_STATUS: approved
VALIDATION: git diff --check clean; pytest tests/test_issue_workflow_labels.py tests/test_manage_labels.py tests/test_set_issue_labels_pagination.py tests/test_post_merge_validation.py -q → 67 passed; AC smoke roles=3 hazards=6 CANONICAL=37
BLOCKERS: none for merge on this head; ignore contaminated review_id 417; use this clean APPROVE only
SUPERSEDES: contaminated review_id 417 (same head, not merge-authorizing)
SUPERSEDED_BY: none
MERGE_READY: yes — clean independent APPROVE at current head; open+mergeable; author jcwalker3 ≠ reviewer sysadmin
LAST_UPDATED_BY: sysadmin / prgs-reviewer / 2026-07-10
adopted_at: 2026-07-10T20:43:05Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 20788-27e3725bd380
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 10281
adoption_reason: merger-handoff-approved-head
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #654
issue: #603
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 20908-653f4ab30b6f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-654
phase: adopted
candidate_head:
f34319852etarget_branch: master
target_branch_sha:
5ab5fe8583last_activity: 2026-07-10T20:43:05Z
expires_at: 2026-07-10T22:43:05Z
blocker: none
Reconciler audit — PR #654 merge
Classification: WORKFLOW-CONTAMINATED, NO UNAUTHORIZED CODE LANDED.
Reconciler:
sysadmin/prgs-reconciler. PR #654 left merged (no revert — no unauthorized content landed).Code-layer proof (sanctioned)
prgs/masterHEADec903b0d= Gitea-API merge of PR #654. Parents:2fa97c26(pre-existing master) +f34319852e94(reviewed #603 branch head). Committersysadmin= server merge identity, Gitea "Merge pull request" message format — not a localgit push/git merge.2fa97c26..ec903b0d= exactly the 3 reviewed #603 files (issue_workflow_labels.py,docs/label-taxonomy.md,tests/test_issue_workflow_labels.py), +388/−1. No extra commits on master's first-parent chain.The "dotenv fix" (
2fa97c26,gitea_auth.py)20:43Zmerge; it was the in-parity base at the author session start).git push prgs masterduring the merge run was therefore a no-op with respect to remote master content. It did not introduce the dotenv commit or any other code toprgs/master.Process contamination recorded (no code impact)
git push prgs master --dry-run/git push prgs master/git merge prgs/master— a direct-to-master git pattern. Verified no-op (remote already held the content; the merge itself is the Gitea API commit).ec903b0d(ff-sync, porcelain clean — no divergent content).gitea-reviewerserver with an activatedprgs-mergerprofile (lease adoption comment 10285:adopted_by_profile: prgs-merger) rather than the dedicatedgitea-mergernamespace.Separate, pre-existing finding (NOT this merge run)
2fa97c26"fix(mcp): load dotenv relative to project root" is itself a bare direct-to-master commit (single parent from #629 merge5ab5fe8, no PR wrapper,gitea_auth.pyonly). It predates #654 by >1h. Recommend a controller review of how it landed; a durable incident issue should be opened by an author/controller session (reconciler cannot create issues).Reconciliation actions
status:pr-open.Closes #603) — left closed.Decision: no history rewrite, no force-push, no revert.
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #654
issue: #603
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 20908-653f4ab30b6f
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-654
phase: released
candidate_head:
f34319852etarget_branch: master
target_branch_sha:
5ab5fe8583last_activity: 2026-07-10T21:03:54Z
expires_at: 2026-07-10T23:03:54Z
blocker: post-merge-moot