Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

feat: first-class control-plane lease lifecycle (Closes #601) #625

Merged
sysadmin merged 2 commits from feat/issue-601-first-class-leases into master 2026-07-10 11:23:29 -05:00
Conversation 12 Commits 2 Files Changed 10
+2220 -36
jcwalker3 commented 2026-07-10 10:31:09 -05:00
Owner
Copy Link
Copy Source

Summary

Implements #601 — active leases as first-class workflow state with canonical adopt / release / expire / abandon handling on the #613 control-plane DB substrate (#600 allocator compatible).

Dependency chain: #613 substrate → #600 allocator → #601 lease lifecycle (this PR)

Changes

File Purpose
lease_lifecycle.py Policy: list/inspect, adopt provenance, release, expire/reclaim, abandon proof gates, safe_next_action vocabulary
control_plane_db.py Schema v3 provenance columns; list/get/adopt/abandon/release-recorded APIs
gitea_mcp_server.py MCP tools gitea_*_workflow_lease(s)
issue_lock_store.py Sanctioned reclaim of expired author file locks (dead PID / missing worktree)
task_capability_map.py Capability entries for lifecycle tools
tests/test_lease_lifecycle.py 12 required lifecycle scenarios
docs Architecture notes for #601

Hard rules

  1. Control-plane DB is coordination authority — file/comment leases alone are not.
  2. Active foreign leases cannot be stolen (wait_foreign_active).
  3. Abandon requires (dead_process OR missing_worktree) + no_live_mutation_risk (+ foreign operator/full proof).
  4. Adopt records adopted_from_session_id, adopted_by_session_id, work identity, head SHA, worktree.
  5. Reviewer→merger comment handoff (gitea_adopt_merger_pr_lease) unchanged.
  6. Raw Sentry/GlitchTip incidents remain non-assignable.

Validation

pytest tests/test_lease_lifecycle.py tests/test_control_plane_db.py \
  tests/test_allocator_service.py tests/test_merger_lease_adoption.py \
  tests/test_issue_lock_store.py -q
→ 78 passed
git diff --check prgs/master...HEAD → clean

Closes #601

## Summary Implements **#601** — active leases as first-class workflow state with canonical **adopt / release / expire / abandon** handling on the #613 control-plane DB substrate (#600 allocator compatible). **Dependency chain:** `#613 substrate → #600 allocator → #601 lease lifecycle (this PR)` ## Changes | File | Purpose | |------|--------| | `lease_lifecycle.py` | Policy: list/inspect, adopt provenance, release, expire/reclaim, abandon proof gates, safe_next_action vocabulary | | `control_plane_db.py` | Schema v3 provenance columns; list/get/adopt/abandon/release-recorded APIs | | `gitea_mcp_server.py` | MCP tools `gitea_*_workflow_lease(s)` | | `issue_lock_store.py` | Sanctioned reclaim of expired author file locks (dead PID / missing worktree) | | `task_capability_map.py` | Capability entries for lifecycle tools | | `tests/test_lease_lifecycle.py` | 12 required lifecycle scenarios | | docs | Architecture notes for #601 | ### Hard rules 1. Control-plane DB is coordination authority — file/comment leases alone are not. 2. Active foreign leases cannot be stolen (`wait_foreign_active`). 3. Abandon requires `(dead_process OR missing_worktree)` + `no_live_mutation_risk` (+ foreign operator/full proof). 4. Adopt records `adopted_from_session_id`, `adopted_by_session_id`, work identity, head SHA, worktree. 5. Reviewer→merger comment handoff (`gitea_adopt_merger_pr_lease`) unchanged. 6. Raw Sentry/GlitchTip incidents remain non-assignable. ## Validation ```text pytest tests/test_lease_lifecycle.py tests/test_control_plane_db.py \ tests/test_allocator_service.py tests/test_merger_lease_adoption.py \ tests/test_issue_lock_store.py -q → 78 passed git diff --check prgs/master...HEAD → clean ``` Closes #601
jcwalker3 added 1 commit 2026-07-10 10:31:10 -05:00
feat: first-class control-plane lease lifecycle (Closes #601) 780ef0b1be 
Make active leases queryable workflow state with canonical adopt, release,
expire/reclaim, and abandon operations on the #613 control-plane DB substrate.

- lease_lifecycle.py: policy, proof gates, safe_next_action vocabulary
- control_plane_db: schema v3 provenance columns + list/inspect/adopt/abandon
- MCP tools: gitea_*_workflow_lease(s) for list/inspect/adopt/release/expire/abandon/reclaim
- issue_lock_store: sanctioned reclaim of expired author locks (dead pid / missing wt)
- Tests cover lifecycle, foreign steal refusal, allocator compatibility, merger handoff
sysadmin commented 2026-07-10 10:38:11 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #625
issue: #601
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 62699-c2ed89d8b3ff
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625
phase: claimed
candidate_head: 780ef0b1be
target_branch: master
target_branch_sha: none
last_activity: 2026-07-10T15:38:11Z
expires_at: 2026-07-10T17:38:11Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #625 issue: #601 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 62699-c2ed89d8b3ff worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625 phase: claimed candidate_head: 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 target_branch: master target_branch_sha: none last_activity: 2026-07-10T15:38:11Z expires_at: 2026-07-10T17:38:11Z blocker: none
sysadmin commented 2026-07-10 10:43:08 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #625
issue: #601
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 62699-c2ed89d8b3ff
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625
phase: claimed
candidate_head: 780ef0b1be
target_branch: master
target_branch_sha: none
last_activity: 2026-07-10T15:43:08Z
expires_at: 2026-07-10T17:43:08Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #625 issue: #601 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 62699-c2ed89d8b3ff worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625 phase: claimed candidate_head: 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 target_branch: master target_branch_sha: none last_activity: 2026-07-10T15:43:08Z expires_at: 2026-07-10T17:43:08Z blocker: none
sysadmin commented 2026-07-10 10:43:46 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #625
issue: #601
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 62699-c2ed89d8b3ff
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625
phase: claimed
candidate_head: 780ef0b1be
target_branch: master
target_branch_sha: none
last_activity: 2026-07-10T15:43:46Z
expires_at: 2026-07-10T17:43:46Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #625 issue: #601 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 62699-c2ed89d8b3ff worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625 phase: claimed candidate_head: 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 target_branch: master target_branch_sha: none last_activity: 2026-07-10T15:43:46Z expires_at: 2026-07-10T17:43:46Z blocker: none
sysadmin commented 2026-07-10 10:44:31 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #625
issue: #601
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 62699-c2ed89d8b3ff
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625
phase: claimed
candidate_head: 780ef0b1be
target_branch: master
target_branch_sha: none
last_activity: 2026-07-10T15:44:31Z
expires_at: 2026-07-10T17:44:31Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #625 issue: #601 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 62699-c2ed89d8b3ff worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625 phase: claimed candidate_head: 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 target_branch: master target_branch_sha: none last_activity: 2026-07-10T15:44:31Z expires_at: 2026-07-10T17:44:31Z blocker: none
sysadmin requested changes 2026-07-10 10:44:43 -05:00
Dismissed
sysadmin left a comment
Owner
Copy Link
Copy Source

Requesting changes due to 1 test failure (TestIssueLocking::test_lock_issue_blocks_expired_same_operation_lease_for_recovery) and a whitespace check issue (trailing blank line in control_plane_db.py).

Requesting changes due to 1 test failure (TestIssueLocking::test_lock_issue_blocks_expired_same_operation_lease_for_recovery) and a whitespace check issue (trailing blank line in control_plane_db.py).
jcwalker3 added 1 commit 2026-07-10 10:54:09 -05:00
fix: address #625 REQUEST_CHANGES for lease reclaim test and EOF blank line 1be4600261 
- Update MCP expired-lock recovery test for sticky expired ownership
  (live pid + present worktree still fail closed under #601 reclaim rules)
- Remove trailing blank line at EOF in control_plane_db.py
jcwalker3 commented 2026-07-10 10:57:33 -05:00
Author
Owner
Copy Link
Copy Source

Canonical Issue State

STATE:
needs-review

WHO_IS_NEXT:
reviewer

NEXT_ACTION:
Re-review PR #625 at head 1be460026110f69f51f6578a34c87efc8bdfa83d after REQUEST_CHANGES fixes; do not re-review stale head 780ef0b.

NEXT_PROMPT:

You are the REVIEWER session for Scaled-Tech-Consulting/Gitea-Tools on prgs.

Task: Re-review PR #625 for issue #601 after author addressed REQUEST_CHANGES.
Do not self-select another issue. Do not merge. Do not approve unless current-head validation passes.

PR: #625
Issue: #601
Pinned head to review: 1be460026110f69f51f6578a34c87efc8bdfa83d
Previous REQUEST_CHANGES head (stale): 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43

Author fixed:
1. test_lock_issue_blocks_expired_same_operation_lease_for_recovery — sticky expired lease (live pid + present worktree) remains fail-closed
2. control_plane_db.py trailing blank line removed; git diff --check clean

Required validation:
pytest tests/test_mcp_server.py::TestIssueLocking::test_lock_issue_blocks_expired_same_operation_lease_for_recovery tests/test_lease_lifecycle.py tests/test_control_plane_db.py tests/test_allocator_service.py tests/test_merger_lease_adoption.py tests/test_issue_lock_store.py -q
git diff --check prgs/master...HEAD

Activate prgs-reviewer. Confirm identity. Review only PR #625 at the pinned head.

WHAT_HAPPENED:
Author addressed REQUEST_CHANGES from head 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 and pushed fix head 1be460026110f69f51f6578a34c87efc8bdfa83d on existing branch feat/issue-601-first-class-leases (PR #625). No new PR opened. Assignment asn-193d452ed0b748e7 reused.

WHY:
Server-side review at 780ef0b had two blockers: (1) MCP recovery test expected sticky expired-lock fail-closed behavior but fixture used a missing worktree path so reclaim succeeded; (2) trailing blank line at EOF in control_plane_db.py failed git whitespace check. Both fixed without weakening foreign lease protection or DB lease authority.

RELATED_DISCUSSION:
none

RELATED_PRS:

BRANCH:
feat/issue-601-first-class-leases

HEAD_SHA:
1be4600261

VALIDATION:
pytest targeted suite → 79 passed; git diff --check prgs/master...HEAD → clean

BLOCKERS:
none for author; reviewer must re-validate at new head (prior REQUEST_CHANGES is stale relative to current head)

LAST_UPDATED_BY:
jcwalker3 / prgs-author / 2026-07-10

CTH: Author Handoff

Status: request_changes_addressed_awaiting_re_review
Next owner: reviewer
Current blocker: none
Decision: REQUEST_CHANGES blockers fixed; push complete; re-review required at new head
Proof:

  • previous head: 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43
  • new head: 1be460026110f69f51f6578a34c87efc8bdfa83d
  • identity: jcwalker3 / prgs-author
  • tests: 79 passed; whitespace clean
  • no other issue selected; #600/#612/#613 remain closed
    Next action: reviewer re-reviews PR #625 at pinned new head
    Ready-to-paste prompt: see NEXT_PROMPT above
## Canonical Issue State STATE: needs-review WHO_IS_NEXT: reviewer NEXT_ACTION: Re-review PR #625 at head `1be460026110f69f51f6578a34c87efc8bdfa83d` after REQUEST_CHANGES fixes; do not re-review stale head `780ef0b`. NEXT_PROMPT: ```text You are the REVIEWER session for Scaled-Tech-Consulting/Gitea-Tools on prgs. Task: Re-review PR #625 for issue #601 after author addressed REQUEST_CHANGES. Do not self-select another issue. Do not merge. Do not approve unless current-head validation passes. PR: #625 Issue: #601 Pinned head to review: 1be460026110f69f51f6578a34c87efc8bdfa83d Previous REQUEST_CHANGES head (stale): 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 Author fixed: 1. test_lock_issue_blocks_expired_same_operation_lease_for_recovery — sticky expired lease (live pid + present worktree) remains fail-closed 2. control_plane_db.py trailing blank line removed; git diff --check clean Required validation: pytest tests/test_mcp_server.py::TestIssueLocking::test_lock_issue_blocks_expired_same_operation_lease_for_recovery tests/test_lease_lifecycle.py tests/test_control_plane_db.py tests/test_allocator_service.py tests/test_merger_lease_adoption.py tests/test_issue_lock_store.py -q git diff --check prgs/master...HEAD Activate prgs-reviewer. Confirm identity. Review only PR #625 at the pinned head. ``` WHAT_HAPPENED: Author addressed REQUEST_CHANGES from head `780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43` and pushed fix head `1be460026110f69f51f6578a34c87efc8bdfa83d` on existing branch `feat/issue-601-first-class-leases` (PR #625). No new PR opened. Assignment asn-193d452ed0b748e7 reused. WHY: Server-side review at `780ef0b` had two blockers: (1) MCP recovery test expected sticky expired-lock fail-closed behavior but fixture used a missing worktree path so reclaim succeeded; (2) trailing blank line at EOF in control_plane_db.py failed git whitespace check. Both fixed without weakening foreign lease protection or DB lease authority. RELATED_DISCUSSION: none RELATED_PRS: - #625 (open, this PR for #601) BRANCH: feat/issue-601-first-class-leases HEAD_SHA: 1be460026110f69f51f6578a34c87efc8bdfa83d VALIDATION: pytest targeted suite → 79 passed; git diff --check prgs/master...HEAD → clean BLOCKERS: none for author; reviewer must re-validate at new head (prior REQUEST_CHANGES is stale relative to current head) LAST_UPDATED_BY: jcwalker3 / prgs-author / 2026-07-10 --- ## CTH: Author Handoff Status: request_changes_addressed_awaiting_re_review Next owner: reviewer Current blocker: none Decision: REQUEST_CHANGES blockers fixed; push complete; re-review required at new head Proof: - previous head: `780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43` - new head: `1be460026110f69f51f6578a34c87efc8bdfa83d` - identity: jcwalker3 / prgs-author - tests: 79 passed; whitespace clean - no other issue selected; #600/#612/#613 remain closed Next action: reviewer re-reviews PR #625 at pinned new head Ready-to-paste prompt: see NEXT_PROMPT above
jcwalker3 commented 2026-07-10 10:58:01 -05:00
Author
Owner
Copy Link
Copy Source

[THREAD STATE LEDGER] PR #625 / Issue #601 — REQUEST_CHANGES addressed; re-review needed at new head

What is true now:

  • PR state: open, mergeable
  • Issue state: open (#601), status:pr-open
  • Current head SHA: 1be4600261
  • Previous REQUEST_CHANGES head: 780ef0b1be (stale relative to current head)
  • Server-side decision state: REQUEST_CHANGES posted to Gitea at stale head; author_pushed_after_request_changes=true; no APPROVED review at current head
  • Local verdict/state: author fix commit present on branch; targeted suite green; whitespace clean
  • Latest known validation: 79 passed; git diff --check prgs/master...HEAD clean
  • #600 closed; #612 closed; #613 closed
  • No other issue selected; assignment asn-193d452ed0b748e7 reused

What changed:

  • tests/test_mcp_server.py recovery fixture now uses present worktree + live pid for sticky expired fail-closed assertion
  • control_plane_db.py trailing blank line at EOF removed
  • Author CTH + Canonical Issue State posted (comment_id 9422)
  • server-side state changed: issue discussion comment posted; no new PR; merge not performed; author did not post a formal review verdict

What is blocked:

  • Blocker classification: no blocker

Who/what acts next:

  • Next actor: reviewer
  • Required action: re-review PR #625 only at head 1be4600261 using prgs-reviewer
  • Do not do: do not re-review stale head 780ef0b; do not merge; do not open a new PR; do not select another issue; do not reopen #600/#612/#613; do not treat raw monitoring incidents as work
  • Resume from: PR #625 branch feat/issue-601-first-class-leases at 1be4600261

Canonical Issue State

STATE:
needs-review

WHO_IS_NEXT:
reviewer

NEXT_ACTION:
Re-review PR #625 at head 1be4600261

NEXT_PROMPT:

You are the REVIEWER session for Scaled-Tech-Consulting/Gitea-Tools on prgs. Re-review PR #625 for issue #601 at head 1be460026110f69f51f6578a34c87efc8bdfa83d. Do not merge. Check the two REQUEST_CHANGES fixes only at current head.

WHAT_HAPPENED:
Author pushed fix head after REQUEST_CHANGES; ledger records re-review handoff

WHY:
Formal REQUEST_CHANGES at 780ef0b is stale; reviewer must judge new head

RELATED_PRS:

BLOCKERS:
none

VALIDATION:
79 passed; git diff --check clean

LAST_UPDATED_BY:
jcwalker3 / prgs-author / 2026-07-10

[THREAD STATE LEDGER] PR #625 / Issue #601 — REQUEST_CHANGES addressed; re-review needed at new head What is true now: - PR state: open, mergeable - Issue state: open (#601), status:pr-open - Current head SHA: 1be460026110f69f51f6578a34c87efc8bdfa83d - Previous REQUEST_CHANGES head: 780ef0b1be4d1682fdb4fba1e4b0b6a131d60e43 (stale relative to current head) - Server-side decision state: REQUEST_CHANGES posted to Gitea at stale head; author_pushed_after_request_changes=true; no APPROVED review at current head - Local verdict/state: author fix commit present on branch; targeted suite green; whitespace clean - Latest known validation: 79 passed; git diff --check prgs/master...HEAD clean - #600 closed; #612 closed; #613 closed - No other issue selected; assignment asn-193d452ed0b748e7 reused What changed: - tests/test_mcp_server.py recovery fixture now uses present worktree + live pid for sticky expired fail-closed assertion - control_plane_db.py trailing blank line at EOF removed - Author CTH + Canonical Issue State posted (comment_id 9422) - server-side state changed: issue discussion comment posted; no new PR; merge not performed; author did not post a formal review verdict What is blocked: - Blocker classification: no blocker Who/what acts next: - Next actor: reviewer - Required action: re-review PR #625 only at head 1be460026110f69f51f6578a34c87efc8bdfa83d using prgs-reviewer - Do not do: do not re-review stale head 780ef0b; do not merge; do not open a new PR; do not select another issue; do not reopen #600/#612/#613; do not treat raw monitoring incidents as work - Resume from: PR #625 branch feat/issue-601-first-class-leases at 1be460026110f69f51f6578a34c87efc8bdfa83d ## Canonical Issue State STATE: needs-review WHO_IS_NEXT: reviewer NEXT_ACTION: Re-review PR #625 at head 1be460026110f69f51f6578a34c87efc8bdfa83d NEXT_PROMPT: ```text You are the REVIEWER session for Scaled-Tech-Consulting/Gitea-Tools on prgs. Re-review PR #625 for issue #601 at head 1be460026110f69f51f6578a34c87efc8bdfa83d. Do not merge. Check the two REQUEST_CHANGES fixes only at current head. ``` WHAT_HAPPENED: Author pushed fix head after REQUEST_CHANGES; ledger records re-review handoff WHY: Formal REQUEST_CHANGES at 780ef0b is stale; reviewer must judge new head RELATED_PRS: - #625 BLOCKERS: none VALIDATION: 79 passed; git diff --check clean LAST_UPDATED_BY: jcwalker3 / prgs-author / 2026-07-10
sysadmin commented 2026-07-10 11:02:35 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #625
issue: #601
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 62699-c2ed89d8b3ff
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625
phase: claimed
candidate_head: 1be4600261
target_branch: master
target_branch_sha: none
last_activity: 2026-07-10T16:02:34Z
expires_at: 2026-07-10T18:02:34Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #625 issue: #601 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 62699-c2ed89d8b3ff worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-625 phase: claimed candidate_head: 1be460026110f69f51f6578a34c87efc8bdfa83d target_branch: master target_branch_sha: none last_activity: 2026-07-10T16:02:34Z expires_at: 2026-07-10T18:02:34Z blocker: none
sysadmin approved these changes 2026-07-10 11:02:54 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

Canonical PR State

STATE:
approved

WHO_IS_NEXT:
merger

NEXT_ACTION:
Adopt the merger lease and merge PR #625 at head 1be4600261.

NEXT_PROMPT:

You are the MERGER session for Scaled-Tech-Consulting/Gitea-Tools on remote prgs. Adopt the merger lease and merge PR #625 at head 1be460026110f69f51f6578a34c87efc8bdfa83d.

WHAT_HAPPENED:
The independent reviewer session has approved PR #625 at the current live head 1be460026110f69f51f6578a34c87efc8bdfa83d after confirming that both prior blockers have been successfully resolved.

WHY:

  1. The recovery test fixture in tests/test_mcp_server.py now correctly exercises sticky fail-closed lease behavior by verifying that an expired lease with a live PID and a present worktree prevents takeover.
  2. The extra blank line at the end of control_plane_db.py has been removed, ensuring git diff --check passes cleanly.
  3. Reclaim behavior for dead processes and missing worktrees remains fully intact and verified by unit tests in tests/test_issue_lock_store.py.

ISSUE:
#601

HEAD_SHA:
1be4600261

REVIEW_STATUS:
approved

MERGE_READY:
true

BLOCKERS:
none

VALIDATION:
The targeted pytest suite (79 tests) passed successfully. The workspace and git diff --check are completely clean.

LAST_UPDATED_BY:
sysadmin / prgs-reviewer / 2026-07-10

## Canonical PR State STATE: approved WHO_IS_NEXT: merger NEXT_ACTION: Adopt the merger lease and merge PR #625 at head 1be460026110f69f51f6578a34c87efc8bdfa83d. NEXT_PROMPT: ```text You are the MERGER session for Scaled-Tech-Consulting/Gitea-Tools on remote prgs. Adopt the merger lease and merge PR #625 at head 1be460026110f69f51f6578a34c87efc8bdfa83d. ``` WHAT_HAPPENED: The independent reviewer session has approved PR #625 at the current live head `1be460026110f69f51f6578a34c87efc8bdfa83d` after confirming that both prior blockers have been successfully resolved. WHY: 1. The recovery test fixture in `tests/test_mcp_server.py` now correctly exercises sticky fail-closed lease behavior by verifying that an expired lease with a live PID and a present worktree prevents takeover. 2. The extra blank line at the end of `control_plane_db.py` has been removed, ensuring `git diff --check` passes cleanly. 3. Reclaim behavior for dead processes and missing worktrees remains fully intact and verified by unit tests in `tests/test_issue_lock_store.py`. ISSUE: #601 HEAD_SHA: 1be460026110f69f51f6578a34c87efc8bdfa83d REVIEW_STATUS: approved MERGE_READY: true BLOCKERS: none VALIDATION: The targeted pytest suite (79 tests) passed successfully. The workspace and `git diff --check` are completely clean. LAST_UPDATED_BY: sysadmin / prgs-reviewer / 2026-07-10
sysadmin commented 2026-07-10 11:22:54 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-10T16:22:53Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 62699-c2ed89d8b3ff
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 9429
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #625
issue: #601
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 41940-211cee547d00
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-control
phase: adopted
candidate_head: 1be4600261
target_branch: master
target_branch_sha: none
last_activity: 2026-07-10T16:22:53Z
expires_at: 2026-07-10T18:22:53Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-10T16:22:53Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 62699-c2ed89d8b3ff adopted_from_profile: prgs-reviewer adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 9429 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #625 issue: #601 reviewer_identity: sysadmin profile: prgs-merger session_id: 41940-211cee547d00 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-control phase: adopted candidate_head: 1be460026110f69f51f6578a34c87efc8bdfa83d target_branch: master target_branch_sha: none last_activity: 2026-07-10T16:22:53Z expires_at: 2026-07-10T18:22:53Z blocker: none
sysadmin merged commit 5347b313ea into master 2026-07-10 11:23:29 -05:00
sysadmin commented 2026-07-10 12:50:42 -05:00
Owner
Copy Link
Copy Source

Stale #332 review-decision lock cleanup (#594)

Status: APPLIED

Manual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.

## Stale #332 review-decision lock cleanup (#594) Status: **APPLIED** - actor: `sysadmin` - profile: `prgs-reviewer` - timestamp: `2026-07-10T17:50:42.303906+00:00` - last terminal: `approve` on PR #625 - PR state: `closed` (merged=True) - merge_commit_sha: `5347b313ea4ac5a1d265b42de653e91e2b0bdcb6` - prior live_mutations_count: `2` - prior profile_identity: `prgs-reviewer` Manual deletion of session-state files is **not** the workflow. This path only clears a lock when the referenced PR is merged/closed.
sysadmin commented 2026-07-10 13:09:21 -05:00
Owner
Copy Link
Copy Source

Canonical Issue State

STATE:
complete

WHO_IS_NEXT:
user

NEXT_ACTION:
No further actions are required. The workflow is complete.

NEXT_PROMPT:

The issue is fully reconciled. No further prompts are needed for this workflow.

WHAT_HAPPENED:
Refreshed the MCP runtime to include the paginated label-resolution fix, removed stale status:pr-open from Issue #601, preserved all valid labels, and verified final closed state.

WHY:
The PR was successfully reviewed, approved, and merged. Label reconciliation is now also complete.

RELATED_PRS:
#625, #629

BLOCKERS:
none

VALIDATION:

  • MCP runtime includes 5ab5fe8583
  • Issue #601 remains closed
  • PR #625 remains closed
  • status:pr-open is removed
  • type:feature is preserved
  • workflow-hardening is preserved
  • anti-stomp is preserved
  • leases is preserved
  • recovery is preserved

LAST_UPDATED_BY:
reconciler

## Canonical Issue State STATE: complete WHO_IS_NEXT: user NEXT_ACTION: No further actions are required. The workflow is complete. NEXT_PROMPT: ```text The issue is fully reconciled. No further prompts are needed for this workflow. ``` WHAT_HAPPENED: Refreshed the MCP runtime to include the paginated label-resolution fix, removed stale status:pr-open from Issue #601, preserved all valid labels, and verified final closed state. WHY: The PR was successfully reviewed, approved, and merged. Label reconciliation is now also complete. RELATED_PRS: #625, #629 BLOCKERS: none VALIDATION: - MCP runtime includes 5ab5fe8583c07134d55dadf09381aecb67df246e - Issue #601 remains closed - PR #625 remains closed - status:pr-open is removed - type:feature is preserved - workflow-hardening is preserved - anti-stomp is preserved - leases is preserved - recovery is preserved LAST_UPDATED_BY: reconciler
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#625