Add anti-stomp preflight gate before every mutation tool #604
Open
opened 2026-07-09 16:06:52 -05:00 by jcwalker3
·
6 comments
No Branch/Tag Specified
master
fix/issue-709-decision-lock-cross-profile
fix/issue-695-native-transport-quarantine
fix/issue-698-report-validator-schema
fix/issue-702-stale-binding-lease-recovery
fix/issue-699-structured-auth-mcp-errors
fix/issue-695-native-quarantine-v2
fix/issue-693-review-decision-lock-recovery
fix/issue-691-obsolete-reviewer-lease-cleanup
feat/issue-687-reconciler-branch-delete
fix/issue-683-workflow-guard-hardening
chore/issue-681-preserve-review-session-wip
feat/issue-604-anti-stomp-preflight
feat/issue-606-sentry-observability
fix/issue-671-block-stable-branch-push
fix/issue-675-residual-preflight-remediation
fix/issue-673-remediate-regressions-part2
fix/issue-673-remediate-regressions
feat/issue-603-lifecycle-labels
fix/issue-627-set-issue-labels-pagination
feat/issue-601-first-class-leases
feat/issue-612-incident-bridge
feat/issue-600-controller-allocator-api
fix/issue-620-head-scoped-review-locks
feat/issue-613-allocator-db-substrate
docs/mcp-stable-control-runtime-policy
feat/issue-609-prepared-review-verdict-resume
feat/issue-610-live-remote-parity
feat/issue-503-reviewer-active-worktree
feat/issue-470-preflight-contract
feat/issue-440-lock-recovery
feat/issue-440-branch-recovery
feat/issue-458-queue-fail-closed-copy
feat/issue-400-early-duplicate-work-gate
feat/issue-308-reconcile-inventory-pagination
feat/issue-308-reconcile-pagination-proof
docs/issue-261-agent-temp-artifact-cleanup
feat/issue-262-map-commit-files
fix/infra-stop-conflict-marker-false-positive
feat/issue-139-role-aware-task-routing
feat/issue-188-continuation-selection-wall
feat/issue-189-continuation-mode-proofs
feat/issue-232-refresh-wiki-proof-heads
feat/issue-210-block-workspace-edits
feat/issue-204-exact-issue-lock
docs/issue-80-label-taxonomy
docs/issue-79-safety-boundary-updates
v1.1.0
Labels
Clear labels
allocator
anti-stomp
architecture
bug
chore
codex
concurrency
contamination
control-plane
dashboard
database
design
documentation
enhancement
gitea
glitchtip
important
incident
incident-bridge
integration
jenkins
labels
leases
mcp
mcp-health
mcp-menu
multi-project
mutating
nice-to-have
observability
portability
preflight
protected-branch
queue
read-only
reconnect
recovery
refactor
release
reliability
resumable-review
reviewer
roadmap
safety
security
self-hosted
sentry
stale-runtime
status:blocked
status:in-progress
status:pr-open
status:ready
terminal-lock
testing
tracker
type:bug
type:feature
type:feature
type:guardrail
visibility
workflow
workflow-hardening
workflow-hardening
Controller-owned work allocator
Prevent concurrent LLM session stomping
Architecture / structural design
OpenAI Codex client / workflow session surface
Concurrent session safety
Workflow or session contamination incident
MCP control-plane coordination and allocation authority
MCP operational dashboard/queue view
Internal coordination storage (SQLite/Postgres)
Design / investigation, no implementation
Docs / runbooks
New feature or improvement
Gitea MCP workflow
GlitchTip integration
Operational or process incident requiring durable audit trail
Sentry-to-Gitea incident bridging
Integration testing
Jenkins integration
Label taxonomy management
Lease adopt/release/expire lifecycle
MCP server / tooling
MCP namespace and runtime health
MCP menu surface
Work spanning multiple monitoring projects or Gitea repos
Mutating action; requires gating
Observability, metrics, traces, error reporting
Cross-platform / portability
Shared preflight gates before mutation
Protected branch / stable-branch policy concern
Work queue visibility and allocation
Read-only, no mutation
MCP client reconnect/reload recovery path
Recovery paths for stale/foreign leases
Code refactor / restructure
Release / versioning
Reliability / failure handling
Persist and resume prepared review verdicts across sessions
Reviewer workflow tooling
Roadmap / umbrella issue
Safety rails and fail-closed mutation guards
Security / trust boundary
Self-hosted infrastructure integration
Sentry error monitoring integration
Stale backend daemon / runtime-vs-master parity failures
Issue is blocked
Issue is being worked on
Issue has an open pull request
Issue is ready for work
Terminal review lock (#332) path
Tests / test coverage
Issue tracker hygiene / meta
Bug or defect
Feature or enhancement
Feature or enhancement
Safety gate or guardrail
Workflow state visibility for LLMs/operators
Cross-tool workflow
LLM workflow coordination hardening
LLM workflow coordination hardening
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Scaled-Tech-Consulting/Gitea-Tools#604
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Context
Part of the LLM coordination failure series (sessions stepping on each other). This is a focused implementation issue, not an umbrella.
Related siblings: #600 (allocator), #601 (leases), #602 (terminal lock early check), #603 (lifecycle labels).
Problem
Even with leases, mutation tools need a shared preflight that prevents stale sessions, wrong worktrees, wrong repos, old prompts, terminal locks, foreign leases, contaminated approvals, and root-checkout mutations from slipping through.
Required behavior
Before create issue/comment, acquire lease, submit review, approve, request changes, merge, cleanup, or label mutation, run a common anti-stomp preflight:
Acceptance criteria
Implementation notes
Canonical Issue State
STATE: ready for independent implementation
WHO_IS_NEXT: author
NEXT_ACTION: claim this issue and add a shared anti-stomp preflight before every mutation tool
NEXT_PROMPT:
WHAT_HAPPENED: Filed as focused coordination issue #604. Series siblings: #600 allocator, #601 leases, #602 terminal-lock early check, #603 lifecycle labels, #605 dashboard.
WHY: Mutation tools still allow stale/wrong-worktree/foreign-lease/terminal-lock failures to slip through without a shared gate.
RELATED_PRS: none yet
BLOCKERS: none
VALIDATION: issue created with type:guardrail status:ready and labels workflow-hardening,anti-stomp,preflight,safety
LAST_UPDATED_BY: jcwalker3 (prgs-author)
Issue claim heartbeat
Canonical Issue State
STATE: implementation complete — PR open for review
WHO_IS_NEXT: reviewer
NEXT_ACTION: independent review of PR #680 against issue #604 acceptance criteria; do not self-merge
NEXT_PROMPT:
WHAT_HAPPENED: Claimed #604 as prgs-author (jcwalker3). Implemented pure
anti_stomp_preflight.py+ wired_run_anti_stomp_preflightintoverify_preflight_purityand live review/merge paths. Pushedfeat/issue-604-anti-stomp-preflight@ea8e186. Opened PR #680 with Closes #604.WHY: Mutation tools still allowed stale/wrong-worktree/foreign-lease/terminal-lock/contamination failures without a shared typed gate.
RELATED_PRS: #680
BLOCKERS: none
VALIDATION: pytest tests/test_anti_stomp_preflight.py → 31 passed; full suite → 2627 passed, 6 skipped
LAST_UPDATED_BY: jcwalker3 (prgs-author)
Implementation state
ea8e186549d4a21e7e3e8f41261ff527b6a60e97feat/issue-604-anti-stomp-preflightmasterbranches/issue-604-anti-stomp-preflightRemaining risks
GITEA_TEST_FORCE_ANTI_STOMP); production paths always enforce for named mutation tasksNext role
reviewer (not author; no self-review/self-merge)
Canonical Issue State
STATE: changes requested
WHO_IS_NEXT: author
NEXT_ACTION: Fix the critical anti-stomp role regression (reviewer/merger WRONG_ROLE-blocked on issue-comment-class tasks), then address the two coverage/test findings, repin head, and hand back to a distinct reviewer.
NEXT_PROMPT:
WHAT_HAPPENED: Independent review of PR #680 at head
ea8e186posted a REQUEST_CHANGES verdict to Gitea. Diff scope matches #604 (anti_stomp_preflight.py, gitea_mcp_server.py, tests/test_anti_stomp_preflight.py). Focused 31 passed and full suite 2627 passed / 6 skipped, reproduced independently.WHY: The shared anti-stomp assessor is pure and fail-closed, but a role-check design flaw breaks reviewer/merger issue comments (AC5), the declared mutation set overstates wiring (AC1), and the enforcement path lacks behavioral proof (AC4) because the gate is inert under pytest.
RELATED_PRS: #680 (Closes #604)
BLOCKERS: (1) anti-stomp role check WRONG_ROLE-blocks reviewer/merger on issue-comment-class tasks; (2) MUTATION_TASKS over-declares vs wiring; (3) inadequate wiring/ordering regression proof
VALIDATION: pytest tests/test_anti_stomp_preflight.py -> 31 passed; assessor gate suites -> 93 passed; capability/lease/merge/reconciler/review suites -> 133 passed; full suite -> 2627 passed, 6 skipped; py_compile OK; direct assessor repro of the role regression against PR code
LAST_UPDATED_BY: sysadmin (prgs-reviewer)
[THREAD STATE LEDGER]
What is true now: PR #680 (Closes #604) received an independent REQUEST_CHANGES review at head
ea8e186549. The shared anti-stomp assessor is pure and fail-closed; the full suite is 2627 passing with 6 skipped.What changed: A formal request_changes review verdict was posted to Gitea on PR #680, head-pinned. A supplementary critical-regression note was posted to the PR thread. No merge performed.
What is blocked: Merging PR #680 is held pending author fix.
Who/what acts next: author addresses the three findings; then a distinct reviewer re-reviews at the new head (no self-review, no self-merge).
Canonical Issue State
STATE: author rework complete — PR #680 ready for independent re-review
WHO_IS_NEXT: reviewer
NEXT_ACTION: independent re-review of PR #680 at head
3fd02a3c633fb539850ce202c68b2043cbf7e4caNEXT_PROMPT:
WHAT_HAPPENED: Author fixed REQUEST_CHANGES from review comments 10479/10481. New commit
3fd02a3onfeat/issue-604-anti-stomp-preflight. Worktree:branches/issue-604-anti-stomp-preflight(clean). Control-checkout dirt documented as #681 — not absorbed into #604.WHY: Shared anti-stomp role check blocked legitimate reviewer/merger issue handoffs; inventory overstated wiring; suite lacked behavioral proof that the gate aborts before side effects.
RELATED_PRS: #680
BLOCKERS: none for #604 rework; unrelated root dirt tracked in #681
VALIDATION: focused anti-stomp 43 passed; related suites 216 passed; full suite 2639 passed / 6 skipped; py_compile OK
LAST_UPDATED_BY: jcwalker3 (prgs-author)
Classification of disputed mutation tasks
edit_pr(non-closinggitea_edit_pr),acquire_reviewer_pr_lease, plus existing wired mutation set.mark_final_review_decision,save_review_draft,resume_review_draft,cleanup_stale_review_decision_lock, lease heartbeat/release helpers.Next role
reviewer — distinct from author; pin head SHA; no self-merge.
Canonical Issue State
STATE: approved on PR #680 — awaiting distinct merger
WHO_IS_NEXT: merger
NEXT_ACTION: merge PR #680 at head
3fd02a3c63with operator confirmation MERGE PR 680NEXT_PROMPT:
WHAT_HAPPENED: After transport-EOF recovery, independent re-review APPROVED PR #680 at
3fd02a3. Prior REQUEST_CHANGES findings A/B/C confirmed fixed. Canonical Gitea feedback: APPROVED at current head.WHY: Shared anti-stomp preflight ready for merge after review rework.
RELATED_PRS: #680
BLOCKERS: none on implementation; control-plane #584/#672; root #681 unrelated
VALIDATION: 43 focused anti-stomp passed at head; approval_visible + approval_at_current_head on Gitea
LAST_UPDATED_BY: sysadmin (prgs-reviewer)