Replace deprecated Starlette TestClient HTTPX integration #682
Closed
opened 2026-07-12 09:32:36 -05:00 by jcwalker3
·
2 comments
No Branch/Tag Specified
master
fix/issue-987-native-mcp-bootstrap
feat/issue-985-project-scoped-launcher-identity
fix/issue-983-cross-repo-base-ref
feat/issue-980-stale-worker-retirement
fix/issue-975-client-identity-heartbeat
fix/issue-973-cross-repo-canonical-roots
fix/issue-970-safely-resolve-missing-worktrees
fix/issue-969-native-mcp-bootstrap
feat/issue-664-break-glass-restart
feat/issue-708-mcp-namespace-attachment
feat/issue-665-restart-audit
fix/issue-700-durable-walls
fix/issue-704-prevent-env-workspace-bindings
feat/issue-707-cross-project-boundaries
fix/issue-690-review-profile-switch-guard
fix/issue-953-bootstrap-lock-provenance
feat/issue-949-native-fleet-inventory
fix/issue-943-runtime-context-helpers
fix/issue-945-owning-pr-renewal-evidence
fix/issue-941-scope-guard-bootstrap-wiring
docs/issue-930-remote-mcp-coupling-inventory
fix/issue-892-author-bootstrap-deadlock
fix/issue-686-detect-reject-manual-mcp
fix/issue-672-mcp-config-drift
fix/issue-689-deterministic-mcp-namespace
feat/issue-666-concurrent-mcp-restart-tests
feat/issue-659-maintenance-drain-mode
feat/issue-648-notifications-console
fix/issue-670-direct-master-incident
feat/issue-644-console-recovery
feat/issue-650-providers-insights
feat/issue-669-scoped-component-recovery
docs/issue-668-mcp-ha-rolling-restart
feat/issue-667-console-restart-controls
feat/issue-645-linkage-console
feat/issue-643-request-preview-initiate
fix/issue-897-permission-stale-runtime-classification
feat/issue-641-runtime-session-view
feat/issue-663-restart-classes
feat/issue-661-drain-proof-hard-gate
fix/issue-854-semantic-container-exclusion
issue-640
fix/issue-682-starlette-httpx2
v1.1.0
Labels
Clear labels
allocator
anti-stomp
architecture
bug
chore
codex
concurrency
contamination
control-plane
dashboard
database
design
documentation
enhancement
gitea
glitchtip
important
incident
incident-bridge
integration
jenkins
labels
leases
mcp
mcp-health
mcp-menu
multi-project
mutating
nice-to-have
observability
portability
preflight
protected-branch
queue
read-only
reconnect
recovery
refactor
release
reliability
resumable-review
reviewer
roadmap
safety
security
self-hosted
sentry
stale-runtime
status:blocked
status:in-progress
status:pr-open
status:ready
terminal-lock
testing
tracker
type:bug
type:feature
type:feature
type:guardrail
visibility
workflow
workflow-hardening
workflow-hardening
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Controller-owned work allocator
Prevent concurrent LLM session stomping
Architecture / structural design
OpenAI Codex client / workflow session surface
Concurrent session safety
Workflow or session contamination incident
MCP control-plane coordination and allocation authority
MCP operational dashboard/queue view
Internal coordination storage (SQLite/Postgres)
Design / investigation, no implementation
Docs / runbooks
New feature or improvement
Gitea MCP workflow
GlitchTip integration
Operational or process incident requiring durable audit trail
Sentry-to-Gitea incident bridging
Integration testing
Jenkins integration
Label taxonomy management
Lease adopt/release/expire lifecycle
MCP server / tooling
MCP namespace and runtime health
MCP menu surface
Work spanning multiple monitoring projects or Gitea repos
Mutating action; requires gating
Observability, metrics, traces, error reporting
Cross-platform / portability
Shared preflight gates before mutation
Protected branch / stable-branch policy concern
Work queue visibility and allocation
Read-only, no mutation
MCP client reconnect/reload recovery path
Recovery paths for stale/foreign leases
Code refactor / restructure
Release / versioning
Reliability / failure handling
Persist and resume prepared review verdicts across sessions
Reviewer workflow tooling
Roadmap / umbrella issue
Safety rails and fail-closed mutation guards
Security / trust boundary
Self-hosted infrastructure integration
Sentry error monitoring integration
Stale backend daemon / runtime-vs-master parity failures
Issue is blocked
Issue is being worked on
Issue has an open pull request
Issue is ready for work
Terminal review lock (#332) path
Tests / test coverage
Issue tracker hygiene / meta
Bug or defect
Feature or enhancement
Feature or enhancement
Safety gate or guardrail
Workflow state visibility for LLMs/operators
Cross-tool workflow
LLM workflow coordination hardening
LLM workflow coordination hardening
Something is not working
This issue or pull request already exists
New feature
Need some help
Something is wrong
More information is needed
This won't be fixed
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Scaled-Tech-Consulting/Gitea-Tools#682
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
The Web UI test suite imports
starlette.testclient.TestClient, which currently uses the deprecatedhttpxcompatibility path.Starlette emits:
The warning currently appears from (first reported site):
Observed during full suite (2026-07-12)
During PR #680 validation the full suite produced this warning summary:
Preliminary inventory (repo scan at master
22698c1)Direct
starlette.testclient.TestClientimports (not exhaustive forever — re-scan at implementation time):tests/test_webui_audit.pytests/test_webui_runtime_health.pytests/test_webui_gated_actions.pytests/test_webui_worktree_hygiene.pytests/test_webui_deployment_boundary.pytests/test_webui_mvp_suite.pytests/test_webui_project_registry.pytests/test_webui_lease_visibility.pytests/test_webui_skeleton.pytests/test_webui_prompt_library.pytests/test_webui_queue_dashboard.pyDependencies (pinned in
requirements.txtas of filing):starlette==1.3.1httpx==0.28.1httpx-sse==0.4.3sse-starlette==3.4.5httpx2not declared / not installed in the local venv used for inventoryThe full scope must still be determined by searching the repository for all uses of:
starlette.testclientTestClienthttpxhttpx2Impact
Leaving this unresolved creates several risks:
Required investigation
Determine:
httpx2is the intended dependency for the repository’s current Starlette version (confirm against official Starlette/HTTPX release notes).httpx, inherits it transitively, or relies on an optional Starlette test dependency (currently direct pinhttpx==0.28.1inrequirements.txt).httpx2can coexist with current runtime or test dependencies (including MCP/FastMCP stacks that also usehttpx).TestClient(create_app())independently).Use official Starlette and HTTPX documentation or release information when confirming the supported migration path.
Scope
The implementation issue should cover:
httpx2path.Non-goals
Acceptance criteria
StarletteDeprecationWarning.starlette.testclient.TestClientare reviewed.tests/test_webui_audit.pypasses.tests/test_webui_*.py).Required tests
At minimum run:
Also run:
scripts// CI)git diff --checkObservability and maintenance
Document in the implementing PR / completion comment:
httpx2versionConsider adding a focused CI check that fails on newly introduced Starlette deprecation warnings, provided it does not fail on unrelated third-party warning noise outside the repository’s control.
Linkage
httpx2/TestClientAny dependency conflict, installation failure, CI mismatch, or undocumented environment dependency discovered during this work must be captured as durable issue-backed work (do not bury in chat).
Canonical issue state
Ready-to-run author prompt
Required completion comment (author handoff)
At completion, leave a canonical issue comment containing:
Canonical Issue State
STATE: ready for independent implementation
WHO_IS_NEXT: author
NEXT_ACTION: claim this issue and migrate Web UI tests off deprecated Starlette TestClient+httpx path onto supported httpx2 without warning filters
NEXT_PROMPT:
WHAT_HAPPENED: Filed #682 after inventory found no open Gitea issue matching Starlette TestClient/httpx2 deprecation. Warning observed during PR #680 full-suite validation. Preliminary scan: ≥11 test_webui_* modules use starlette.testclient.TestClient; requirements pin starlette==1.3.1 and httpx==0.28.1; httpx2 not declared. Implementation deferred.
WHY: Deprecation risk on Web UI suite / CI noise / future hard-fail on upgrade.
RELATED_PRS: none yet; context PR #680 (warning surface); vision links #631 #652 #653
BLOCKERS: none
VALIDATION: issue create with type:bug status:ready labels dashboard,workflow-hardening; local inventory only (no code change)
LAST_UPDATED_BY: jcwalker3 (prgs-author)
Author claim — issue #682 (comment-based; label tools degraded)
Claiming this issue for implementation. Note:
gitea_mark_issueandgitea_set_issue_labelscurrently returninternal_error(daemon subprocess spawn failure pergitea_diagnose_terminal: "Subprocess spawn failed despite valid CWD and executable"), so thestatus:in-progresslabel cannot be applied through the sanctioned label path right now. This comment serves as the durable claim signal until the label path recovers; the label will be reconciled when tooling permits.Branch:
fix/issue-682-testclient-httpx2Worktree:
branches/fix-issue-682-testclient-httpx2(fresh from master67e4a2b5e96b680a1dcb90a20c2ebf87357a3b1f, clean)Planned change: declare and install
httpx2sostarlette.testclient(Starlette 1.3.1) uses its preferredhttpx2import path; no warning filters; test imports unchanged unless required.Canonical Issue State
STATE: claimed for implementation by prgs-author at master
67e4a2b5e9WHO_IS_NEXT: author
NEXT_ACTION: implement httpx2 migration in branches/fix-issue-682-testclient-httpx2, run focused webui suites plus full suite, then open the implementing PR
NEXT_PROMPT:
WHAT_HAPPENED: author verified scope (11 tests/test_webui_.py modules import starlette.testclient.TestClient; no httpx2 anywhere in the repo; no warning filters hide the deprecation) and confirmed installed starlette 1.3.1 prefers
import httpx2 as httpxwith fallback deprecationWHY: Starlette 1.3.1 testclient emits StarletteDeprecationWarning on the httpx fallback; declaring httpx2 removes the warning on the supported path without suppressing anything
RELATED_PRS: implementing PR to follow from branch fix/issue-682-testclient-httpx2
BLOCKERS: label-claim tooling degraded (internal_error); does not affect the code change itself
VALIDATION: pending — focused tests/test_webui_.py plus full suite will be recorded in the PR
LAST_UPDATED_BY: prgs-author (jcwalker3), 2026-07-17
[THREAD STATE LEDGER]
what is true now: issue #682 remains open and is claimed by prgs-author via this comment; worktree branches/fix-issue-682-testclient-httpx2 exists clean at master 67e4a2b5; the status:in-progress label is not yet applied because label tools return internal_error.
what changed: author claim recorded; scope re-scan completed (11 webui test modules, no filters, no existing httpx2 declaration).
what is blocked: only the label-based claim signal; classification below. Implementation itself can proceed.
who/what acts next: author continues implementation in the named worktree.
Server-side decision state: no review or merge decision exists for this issue; implementation not yet delivered
Local verdict/state: fresh clean worktree at master head; no local edits yet
Next actor: author
Required action: implement httpx2 dependency migration, validate, open PR
Blocker classification: environment/tooling blocker
Do not do: do not apply warning filters; do not upgrade unrelated dependencies; do not self-review or merge the eventual PR