Support gitea.branch.delete capability in reconciler profile and migration helper #687
Open
opened 2026-07-12 20:30:40 -05:00 by jcwalker3
·
4 comments
No Branch/Tag Specified
master
fix/issue-709-decision-lock-cross-profile
fix/issue-695-native-transport-quarantine
fix/issue-698-report-validator-schema
fix/issue-702-stale-binding-lease-recovery
fix/issue-699-structured-auth-mcp-errors
fix/issue-695-native-quarantine-v2
fix/issue-693-review-decision-lock-recovery
fix/issue-691-obsolete-reviewer-lease-cleanup
feat/issue-687-reconciler-branch-delete
fix/issue-683-workflow-guard-hardening
chore/issue-681-preserve-review-session-wip
feat/issue-604-anti-stomp-preflight
feat/issue-606-sentry-observability
fix/issue-671-block-stable-branch-push
fix/issue-675-residual-preflight-remediation
fix/issue-673-remediate-regressions-part2
fix/issue-673-remediate-regressions
feat/issue-603-lifecycle-labels
fix/issue-627-set-issue-labels-pagination
feat/issue-601-first-class-leases
feat/issue-612-incident-bridge
feat/issue-600-controller-allocator-api
fix/issue-620-head-scoped-review-locks
feat/issue-613-allocator-db-substrate
docs/mcp-stable-control-runtime-policy
feat/issue-609-prepared-review-verdict-resume
feat/issue-610-live-remote-parity
feat/issue-503-reviewer-active-worktree
feat/issue-470-preflight-contract
feat/issue-440-lock-recovery
feat/issue-440-branch-recovery
feat/issue-458-queue-fail-closed-copy
feat/issue-400-early-duplicate-work-gate
feat/issue-308-reconcile-inventory-pagination
feat/issue-308-reconcile-pagination-proof
docs/issue-261-agent-temp-artifact-cleanup
feat/issue-262-map-commit-files
fix/infra-stop-conflict-marker-false-positive
feat/issue-139-role-aware-task-routing
feat/issue-188-continuation-selection-wall
feat/issue-189-continuation-mode-proofs
feat/issue-232-refresh-wiki-proof-heads
feat/issue-210-block-workspace-edits
feat/issue-204-exact-issue-lock
docs/issue-80-label-taxonomy
docs/issue-79-safety-boundary-updates
v1.1.0
Labels
Clear labels
allocator
anti-stomp
architecture
bug
chore
codex
concurrency
contamination
control-plane
dashboard
database
design
documentation
enhancement
gitea
glitchtip
important
incident
incident-bridge
integration
jenkins
labels
leases
mcp
mcp-health
mcp-menu
multi-project
mutating
nice-to-have
observability
portability
preflight
protected-branch
queue
read-only
reconnect
recovery
refactor
release
reliability
resumable-review
reviewer
roadmap
safety
security
self-hosted
sentry
stale-runtime
status:blocked
status:in-progress
status:pr-open
status:ready
terminal-lock
testing
tracker
type:bug
type:feature
type:feature
type:guardrail
visibility
workflow
workflow-hardening
workflow-hardening
Controller-owned work allocator
Prevent concurrent LLM session stomping
Architecture / structural design
OpenAI Codex client / workflow session surface
Concurrent session safety
Workflow or session contamination incident
MCP control-plane coordination and allocation authority
MCP operational dashboard/queue view
Internal coordination storage (SQLite/Postgres)
Design / investigation, no implementation
Docs / runbooks
New feature or improvement
Gitea MCP workflow
GlitchTip integration
Operational or process incident requiring durable audit trail
Sentry-to-Gitea incident bridging
Integration testing
Jenkins integration
Label taxonomy management
Lease adopt/release/expire lifecycle
MCP server / tooling
MCP namespace and runtime health
MCP menu surface
Work spanning multiple monitoring projects or Gitea repos
Mutating action; requires gating
Observability, metrics, traces, error reporting
Cross-platform / portability
Shared preflight gates before mutation
Protected branch / stable-branch policy concern
Work queue visibility and allocation
Read-only, no mutation
MCP client reconnect/reload recovery path
Recovery paths for stale/foreign leases
Code refactor / restructure
Release / versioning
Reliability / failure handling
Persist and resume prepared review verdicts across sessions
Reviewer workflow tooling
Roadmap / umbrella issue
Safety rails and fail-closed mutation guards
Security / trust boundary
Self-hosted infrastructure integration
Sentry error monitoring integration
Stale backend daemon / runtime-vs-master parity failures
Issue is blocked
Issue is being worked on
Issue has an open pull request
Issue is ready for work
Terminal review lock (#332) path
Tests / test coverage
Issue tracker hygiene / meta
Bug or defect
Feature or enhancement
Feature or enhancement
Safety gate or guardrail
Workflow state visibility for LLMs/operators
Cross-tool workflow
LLM workflow coordination hardening
LLM workflow coordination hardening
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Scaled-Tech-Consulting/Gitea-Tools#687
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Provisional local work already exists at commit
a6665d2, created before issue ownership, and is classified as unreviewed WIP.Acceptance Criteria:
cleanup_merged_pr_branchremains reconciler-owned;gitea.branch.deleteis recommended or required according to the intended policy;Canonical Issue State
STATE: in-progress
WHO_IS_NEXT: author
NEXT_ACTION: Author needs to write tests and run validation suite on branch feat/issue-687-reconciler-branch-delete.
NEXT_PROMPT:
WHAT_HAPPENED: A provisional pre-issue commit was created under commit a6665d2 on branch branches/issue-tbd-reconciler-branch-delete. This happened because the implementation was begun before an owning Gitea issue had been created to track the change. To repair ownership, issue #687 has been created to cover the work. The task branch has been recreated under the canonical name feat/issue-687-reconciler-branch-delete, and the provisional changes have been cherry-picked onto it as commit
8cac50b2e7.WHY: Provisional work was committed before issue ownership was established.
RELATED_PRS: none
BLOCKERS: none
VALIDATION: local tests are being run on the canonical worktree.
LAST_UPDATED_BY: author
Canonical Issue State
STATE: request-changes
WHO_IS_NEXT: author
NEXT_ACTION: Author must correct the migrated reconciler defaults shorthand operations and limit delete scope.
NEXT_PROMPT:
WHY: PR #688 failed review due to three findings in reconciler profile setup and migrate_profiles.
BLOCKERS: unresolved findings in validation report
VALIDATION: 57 tests passed in review worktree on head
c7a444e.RELATED_PRS: #688
LAST_UPDATED_BY: reviewer
Canonical Issue State
STATE:
author-complete — REQUEST_CHANGES fixes pushed on PR #688; waiting independent re-review
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent REVIEWER re-validates PR #688 at head
4a6357800364718a27a36ebc73578d4b929ff4aaagainst all three blockers; do not self-review or mergeNEXT_PROMPT:
WHAT_HAPPENED:
Author continued on existing PR #688 branch (no replacement PR). Addressed formal REQUEST_CHANGES from head
c7a444e.New head:
4a6357800364718a27a36ebc73578d4b929ff4aagitea.pr.closeetc.; canonicalize + fail if reconciler loses required opsgitea_delete_branch; only guardedgitea_cleanup_merged_pr_branch; preserve branch blockeddocs/gitea-execution-profiles.mdfull migrate/apply/reconnect/cleanup runbookCanonical reconciler allowed ops after migration:
gitea.read,gitea.pr.close,gitea.pr.comment,gitea.issue.comment,gitea.issue.close,gitea.branch.deleteNot done (by design): live profile not updated; PR #684 source branch not deleted; #689 not modified except cross-link.
Separate work: #690 filed for mid-review profile-switch isolation (not absorbed into #687).
WHY:
Reviewer findings were correct: shorthand ops drop under the normalizer; branch.delete without role gates exposes raw delete.
RELATED_PRS:
PR #688 @ 4a63578; related #690; preserve evidence #681 branch untouched
BLOCKERS:
none for re-review
VALIDATION:
4a6357800364718a27a36ebc73578d4b929ff4aaLAST_UPDATED_BY:
jcwalker3 / prgs-author / AUTHOR / 2026-07-12
[THREAD STATE LEDGER]
what is true now
4a6357800364718a27a36ebc73578d4b929ff4aa; the latest formal review verdict is REQUEST_CHANGES recorded via the review API at superseded headc7a444eb4b41cf916fdbd20a4999ffd78af496d0; reviewer lease comment 10749 (session25883-7d4c6e6ebd53, profileprgs-reviewer) isphase: claimed, pinned toc7a444e…, freshnessactive,expires_at: 2026-07-13T04:23:00Z.branches/review-pr688-feat-issue-687-reconciler-branch-deleteis clean atc7a444eand was never advanced; control root clean onmaster@56f1230.what changed
gitea_diagnose_reviewer_pr_lease_handoff(02:52Z): classificationforeign_active,next_action: wait(earlier controller run classifiedinstructed_lease_missing_with_replacement, also prescribingwait).gitea_release_reviewer_pr_leaseis owner-session only;gitea_cleanup_post_merge_moot_leaserequires a landed/closed PR; control-planeexpire/reclaim/abandontools have nolease_idfor comment lease 10749 and foreign-abandon proof is unsatisfiable (owner PID alive, worktree present, PR open, no operator authorization). PID equality with a livemcp_server.pyprocess was NOT treated as ownership.what is blocked
4a63578…waits on lease 10749 owner release or expiry at2026-07-13T04:23:00Z. No bypass performed.who/what acts next
expires_at(2026-07-13T04:23:00Z) or its owner session releases it, start a freshprgs-reviewerrun: full preflight (whoami, load_review_workflow, resolve review_pr), confirm live head is still exactly4a6357800364718a27a36ebc73578d4b929ff4aa, acquire a new reviewer lease bound to a NEW detached worktree, perform the complete independent re-review per PR #688 comment 10767, and record the formal head-scoped verdict.c7a444elease for the new head; do not merge.Canonical Issue State
STATE:
waiting-lease-expiry — REQUEST_CHANGES fixes at new head await independent re-review; foreign reviewer lease pinned to superseded head must expire or be released by its owner first
CANONICAL_ITEM:
PR #688 at live head
4a6357800364718a27a36ebc73578d4b929ff4aa— the sole review target; defect tracking for the lease-cleanup gap is issue #691SUPERSEDED_ITEM:
PR #688 head
c7a444eb4b41cf916fdbd20a4999ffd78af496d0— carries the recorded REQUEST_CHANGES verdict and remains the pin of reviewer lease comment 10749 (session25883-7d4c6e6ebd53); its validation must not be reused for the new headWHO_IS_NEXT:
reviewer
NEXT_ACTION:
After 2026-07-13T04:23:00Z (or owner release of PR #688 lease comment 10749), fresh
prgs-reviewersession re-validates PR #688 at pinned head4a6357800364718a27a36ebc73578d4b929ff4aaper the checklist in PR #688 comment 10767NEXT_PROMPT:
WHAT_HAPPENED:
CONTROLLER ran review-lease recovery for PR #688. Confirmed: formal REQUEST_CHANGES complete at
c7a444e; author push superseded it with4a63578; lease comment 10749 (foreign session25883-7d4c6e6ebd53) remains active and pinned to the superseded head with its worktree untouched. Searched all canonical release/expire/moot/abandon paths — none applies to a comment lease on an open PR without owner participation. Filed defect issue #691 with acceptance criteria for guarded superseded-head lease cleanup. Performed no lease mutation and no takeover; prescribed action iswait.WHY:
Diagnostic prescribes
waitand forbids foreign-lease steal; no supported non-owner cleanup exists for a provably obsolete comment lease on an open PR (defect tracked in #691).RELATED_PRS:
#688 (awaiting re-review at
4a63578); defect issue #691; prior verdict thread PR #688 comments 10731–10767BLOCKERS:
queue/lease blocker — foreign reviewer lease (PR #688 comment 10749) active until 2026-07-13T04:23:00Z
VALIDATION:
Read-only evidence this session: gitea_get_pr_review_feedback (verdict + stale flags), gitea_assess_reviewer_pr_lease + gitea_diagnose_reviewer_pr_lease_handoff (foreign_active / wait), gitea_list_workflow_leases (no DB lease for PR #688), lease worktree clean at
c7a444e, control root clean at master56f1230, master parity in-parity. Gitea mutations this session: issue #691 creation and this comment only.LAST_UPDATED_BY:
jcwalker3 / prgs-author / CONTROLLER / 2026-07-12