Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Add dedicated reconciler capability to close already-landed open PRs #309

New Issue
Closed
opened 2026-07-07 00:54:12 -05:00 by jcwalker3 · 1 comment
jcwalker3 commented 2026-07-07 00:54:12 -05:00
Owner
Copy Link
Copy Source

Already-landed open PRs are blocking the PR review queue because the normal reviewer workflow correctly stops before approval/merge, but no available profile can close the redundant PR.

Observed behavior:

  • PR #278 is open in Gitea.
  • PR #278 head SHA 2a544b78d1371925761d16f1c451bb3b2984470e is already an ancestor of prgs/master.
  • Issue #263 is already closed.
  • Reviewer workflow correctly classifies PR #278 as ALREADY_LANDED_RECONCILE_REQUIRED.
  • Reviewer workflow correctly does not approve, request changes, or merge.
  • Queue remains blocked because no profile has exact gitea.pr.close capability.
  • Every normal review run encounters PR #278 again and stops.

Problem:

The already-landed gate is safe, but without a close/reconciliation capability the queue cannot progress.

Required behavior:

  1. Add a dedicated reconciler profile or tool path, such as prgs-reconciler.

  2. The reconciler path must prove exact gitea.pr.close capability.

  3. The reconciler path must not imply normal review, approval, request-changes, or merge capability.

  4. The reconciler path may close a PR only if all gates pass:

    • PR fetched live
    • PR state is open
    • PR head SHA pinned
    • target branch freshly fetched
    • target branch SHA recorded
    • PR head SHA is an ancestor of target branch
    • linked issue fetched live, if present
    • no normal review/merge is required

  5. If linked issue is already closed, do not attempt issue close.

  6. If linked issue is open and resolved by the landed commits, close it only if exact gitea.issue.close capability is proven.

  7. Final report must include:

    • identity/profile
    • exact close capability proof
    • PR live state
    • candidate head SHA
    • target branch SHA
    • ancestor proof
    • linked issue status
    • PR close result
    • issue close result
    • no review/merge confirmation

Acceptance criteria:

  • Already-landed PR #278 can be closed through the reconciler path after proof.
  • Non-landed PRs cannot be closed through the reconciler path.
  • Missing gitea.pr.close produces a recovery handoff.
  • Normal reviewer profile does not need broad PR-close authority.
  • Tests cover already-landed PR, not-landed PR, stale target branch, missing close capability, linked issue already closed, linked issue open, and successful PR close.
Already-landed open PRs are blocking the PR review queue because the normal reviewer workflow correctly stops before approval/merge, but no available profile can close the redundant PR. Observed behavior: * PR #278 is open in Gitea. * PR #278 head SHA `2a544b78d1371925761d16f1c451bb3b2984470e` is already an ancestor of `prgs/master`. * Issue #263 is already closed. * Reviewer workflow correctly classifies PR #278 as `ALREADY_LANDED_RECONCILE_REQUIRED`. * Reviewer workflow correctly does not approve, request changes, or merge. * Queue remains blocked because no profile has exact `gitea.pr.close` capability. * Every normal review run encounters PR #278 again and stops. Problem: The already-landed gate is safe, but without a close/reconciliation capability the queue cannot progress. Required behavior: 1. Add a dedicated reconciler profile or tool path, such as `prgs-reconciler`. 2. The reconciler path must prove exact `gitea.pr.close` capability. 3. The reconciler path must not imply normal review, approval, request-changes, or merge capability. 4. The reconciler path may close a PR only if all gates pass: * PR fetched live * PR state is open * PR head SHA pinned * target branch freshly fetched * target branch SHA recorded * PR head SHA is an ancestor of target branch * linked issue fetched live, if present * no normal review/merge is required 5. If linked issue is already closed, do not attempt issue close. 6. If linked issue is open and resolved by the landed commits, close it only if exact `gitea.issue.close` capability is proven. 7. Final report must include: * identity/profile * exact close capability proof * PR live state * candidate head SHA * target branch SHA * ancestor proof * linked issue status * PR close result * issue close result * no review/merge confirmation Acceptance criteria: * Already-landed PR #278 can be closed through the reconciler path after proof. * Non-landed PRs cannot be closed through the reconciler path. * Missing `gitea.pr.close` produces a recovery handoff. * Normal reviewer profile does not need broad PR-close authority. * Tests cover already-landed PR, not-landed PR, stale target branch, missing close capability, linked issue already closed, linked issue open, and successful PR close.
jcwalker3 added the status:in-progress label 2026-07-07 08:09:03 -05:00
jcwalker3 commented 2026-07-07 08:16:22 -05:00
Author
Owner
Copy Link
Copy Source

Implementation PR opened: #379 (branch feat/issue-309-reconciler-close-capability, head 958d470).

Adds reconcile_close_landed_pr / reconcile_close_landed_issue tasks (exact gitea.pr.close / gitea.issue.close) under a dedicated reconciler role, wrong-role routing (wrong_role_stop in author/reviewer sessions), and assess_reconciler_close_gate with outcomes CLOSE_ALLOWED / NOT_LANDED_CLOSE_BLOCKED / RECOVERY_HANDOFF_REQUIRED / GATE_NOT_PROVEN — review/approve/request-changes/merge never granted. 17 new tests.

Scope: profile provisioning for a concrete prgs-reconciler profile stays with #310/#304; #306 duplicates this issue. Awaiting reviewer.

Implementation PR opened: #379 (branch `feat/issue-309-reconciler-close-capability`, head 958d470). Adds `reconcile_close_landed_pr` / `reconcile_close_landed_issue` tasks (exact `gitea.pr.close` / `gitea.issue.close`) under a dedicated `reconciler` role, wrong-role routing (`wrong_role_stop` in author/reviewer sessions), and `assess_reconciler_close_gate` with outcomes CLOSE_ALLOWED / NOT_LANDED_CLOSE_BLOCKED / RECOVERY_HANDOFF_REQUIRED / GATE_NOT_PROVEN — review/approve/request-changes/merge never granted. 17 new tests. Scope: profile provisioning for a concrete `prgs-reconciler` profile stays with #310/#304; #306 duplicates this issue. Awaiting reviewer.
sysadmin removed the status:in-progress label 2026-07-07 08:57:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#309