Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Add dedicated reconciler capability for closing already-landed open PRs #306

New Issue
Closed
opened 2026-07-07 00:45:55 -05:00 by jcwalker3 · 1 comment
jcwalker3 commented 2026-07-07 00:45:55 -05:00
Owner
Copy Link
Copy Source

Already-landed PR reconciliation is blocked because no available MCP execution profile has gitea.pr.close.

Observed behavior:

  • PR #278 is open in Gitea.

  • PR #278 head SHA 2a544b78d1371925761d16f1c451bb3b2984470e is already an ancestor of prgs/master.

  • Issue #263 is already closed.

  • The reconciliation workflow proved:

    • PR inspect allowed
    • issue inspect allowed
    • comment_pr allowed
    • comment_issue allowed
    • close_issue allowed
    • close_pr blocked

  • The workflow correctly did not close PR #278.

Problem:

The queue remains blocked by already-landed PRs unless an authorized human closes them manually. Adding broad PR-close permission to normal author/reviewer profiles may be too permissive.

Required behavior:

  1. Add a dedicated reconciler capability/profile, such as prgs-reconciler.

  2. The reconciler path must only close already-landed PRs after all reconciliation gates pass.

  3. Required gates:

    • PR fetched live
    • PR state is open
    • PR head SHA pinned
    • target branch freshly fetched
    • PR head SHA is ancestor of target branch
    • linked issue fetched live
    • no normal review/merge action is required
    • exact close_pr capability proven

  4. Reconciler capability must not imply normal approve, request-changes, or merge capability.

  5. Final report must include exact capability proof, ancestor proof, close result, and linked issue result.

Acceptance criteria:

  • Already-landed PRs can be closed through a dedicated reconciler path.
  • Non-landed PRs cannot be closed by the reconciler path.
  • Missing close capability produces a recovery handoff.
  • Tests cover already-landed PR, not-landed PR, stale target branch, missing issue proof, missing close capability, and successful close.
Already-landed PR reconciliation is blocked because no available MCP execution profile has `gitea.pr.close`. Observed behavior: * PR #278 is open in Gitea. * PR #278 head SHA `2a544b78d1371925761d16f1c451bb3b2984470e` is already an ancestor of `prgs/master`. * Issue #263 is already closed. * The reconciliation workflow proved: * PR inspect allowed * issue inspect allowed * `comment_pr` allowed * `comment_issue` allowed * `close_issue` allowed * `close_pr` blocked * The workflow correctly did not close PR #278. Problem: The queue remains blocked by already-landed PRs unless an authorized human closes them manually. Adding broad PR-close permission to normal author/reviewer profiles may be too permissive. Required behavior: 1. Add a dedicated reconciler capability/profile, such as `prgs-reconciler`. 2. The reconciler path must only close already-landed PRs after all reconciliation gates pass. 3. Required gates: * PR fetched live * PR state is open * PR head SHA pinned * target branch freshly fetched * PR head SHA is ancestor of target branch * linked issue fetched live * no normal review/merge action is required * exact `close_pr` capability proven 4. Reconciler capability must not imply normal approve, request-changes, or merge capability. 5. Final report must include exact capability proof, ancestor proof, close result, and linked issue result. Acceptance criteria: * Already-landed PRs can be closed through a dedicated reconciler path. * Non-landed PRs cannot be closed by the reconciler path. * Missing close capability produces a recovery handoff. * Tests cover already-landed PR, not-landed PR, stale target branch, missing issue proof, missing close capability, and successful close.
jcwalker3 added the status:in-progress label 2026-07-07 11:58:14 -05:00
jcwalker3 commented 2026-07-07 11:58:14 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: claim - issue: #306 - branch: feat/issue-306-reconciler-close-proof - phase: claimed - profile: prgs-author - pr: none - blocker: none - next_action: create worktree and begin implementation
sysadmin removed the status:in-progress label 2026-07-08 21:32:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#306