Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Fix test suite stdout capture issue that forces junitxml workaround #178

New Issue
Closed
opened 2026-07-05 13:58:51 -05:00 by jcwalker3 · 3 comments
jcwalker3 commented 2026-07-05 13:58:51 -05:00
Owner
Copy Link
Copy Source

Problem:
During validation for PR #176, the full pytest run produced swallowed or missing stdout because a test appears to close stdout mid-run. The agent used junitxml to recover reliable counts, reporting 681 tests, 0 fail, 0 error, 6 skip.

This workaround is acceptable for the run, but the test suite should not close or corrupt stdout because it weakens validation reporting and makes automated review harder.

Required behavior:

  1. Identify which test closes or corrupts stdout.
  2. Fix the test to use proper monkeypatch/capsys isolation.
  3. Ensure normal pytest output works without needing junitxml.
  4. Add regression coverage if appropriate.

Acceptance criteria:

  • venv/bin/pytest tests/ --ignore=branches prints normal summary output.
  • No test closes global stdout/stderr in a way that affects later tests.
  • Review agents can capture exact pass/fail counts without a workaround.

Priority: lower — validation workaround exists (junitxml counts); fix improves review-agent reporting quality per #173 exact-count requirements.

Problem: During validation for PR #176, the full pytest run produced swallowed or missing stdout because a test appears to close stdout mid-run. The agent used junitxml to recover reliable counts, reporting `681 tests, 0 fail, 0 error, 6 skip`. This workaround is acceptable for the run, but the test suite should not close or corrupt stdout because it weakens validation reporting and makes automated review harder. Required behavior: 1. Identify which test closes or corrupts stdout. 2. Fix the test to use proper monkeypatch/capsys isolation. 3. Ensure normal pytest output works without needing junitxml. 4. Add regression coverage if appropriate. Acceptance criteria: * `venv/bin/pytest tests/ --ignore=branches` prints normal summary output. * No test closes global stdout/stderr in a way that affects later tests. * Review agents can capture exact pass/fail counts without a workaround. Priority: lower — validation workaround exists (junitxml counts); fix improves review-agent reporting quality per #173 exact-count requirements.
jcwalker3 added the status:in-progress label 2026-07-05 14:09:27 -05:00
jcwalker3 commented 2026-07-05 14:17:08 -05:00
Author
Owner
Copy Link
Copy Source

PR #180 opened with output isolation fixes and regression tests for stdout usability. Full checks passed. Fresh branch from master. Scoped to test fixes per #178.

PR #180 opened with output isolation fixes and regression tests for stdout usability. Full checks passed. Fresh branch from master. Scoped to test fixes per #178.
jcwalker3 commented 2026-07-05 14:22:47 -05:00
Author
Owner
Copy Link
Copy Source

Acceptance-evidence requirement (operator triage of the authoring run; see #183 and the review note on PR #180, comment 3061):

This issue may only be closed when the closing PR (currently #180) demonstrates, at its pinned head, that ./venv/bin/python -m pytest tests/ --ignore=branches prints a normal pytest summary to the terminal without the junitxml workaround, and the exact visible summary is quoted in the review or PR. The authoring run's report did not include that canonical run; targeted tests and subprocess pipe capture are not sufficient proof for this issue's acceptance.

Also note PR #180's body uses Refs #178 (non-closing) — closure will need a body fix or an explicit post-merge close with status:in-progress removal.

Acceptance-evidence requirement (operator triage of the authoring run; see #183 and the review note on PR #180, comment 3061): This issue may only be closed when the closing PR (currently #180) demonstrates, at its pinned head, that `./venv/bin/python -m pytest tests/ --ignore=branches` prints a normal pytest summary to the terminal **without** the junitxml workaround, and the exact visible summary is quoted in the review or PR. The authoring run's report did not include that canonical run; targeted tests and subprocess pipe capture are not sufficient proof for this issue's acceptance. Also note PR #180's body uses `Refs #178` (non-closing) — closure will need a body fix or an explicit post-merge close with `status:in-progress` removal.
sysadmin removed the status:in-progress label 2026-07-05 14:26:34 -05:00
jcwalker3 commented 2026-07-05 14:29:28 -05:00
Author
Owner
Copy Link
Copy Source

Post-merge acceptance verification (closing the evidence gap from comment 3064 — the issue was closed without the required quoted summary):

Verified on merged master at 340b585bfdfdc267c4fc1aad26a38b9727091b6e (merge commit of PR #180), in a detached verification worktree with local HEAD proven equal to that SHA:

Command (canonical, no junitxml):

venv/bin/python -m pytest tests/ --ignore=branches

Exact visible tail of the output:

tests/test_review_pr.py ....                                             [ 91%]
tests/test_review_proofs.py .....................................        [ 96%]
tests/test_runtime_clarity.py .........                                  [ 98%]
tests/test_worktrees.py ............                                     [100%]

======================== 677 passed, 6 skipped in 7.55s ========================

Normal pytest progress output and the standard summary line now print to the terminal; stdout is no longer closed mid-run and no junitxml workaround was needed. Count reconciliation: pre-fix master reported 681 collected (675 passed + 6 skipped, recoverable only via junitxml); post-merge = 683 collected (677 passed + 6 skipped), consistent with the 2 regression tests PR #180 added.

Acceptance criteria of this issue are met on the merged head; closure stands. Evidence gathered under jcwalker3 / prgs-author (read-only local validation + this comment; no other mutations).

Post-merge acceptance verification (closing the evidence gap from comment 3064 — the issue was closed without the required quoted summary): Verified on merged `master` at `340b585bfdfdc267c4fc1aad26a38b9727091b6e` (merge commit of PR #180), in a detached verification worktree with local `HEAD` proven equal to that SHA: Command (canonical, no junitxml): ``` venv/bin/python -m pytest tests/ --ignore=branches ``` Exact visible tail of the output: ``` tests/test_review_pr.py .... [ 91%] tests/test_review_proofs.py ..................................... [ 96%] tests/test_runtime_clarity.py ......... [ 98%] tests/test_worktrees.py ............ [100%] ======================== 677 passed, 6 skipped in 7.55s ======================== ``` Normal pytest progress output and the standard summary line now print to the terminal; stdout is no longer closed mid-run and no junitxml workaround was needed. Count reconciliation: pre-fix master reported 681 collected (675 passed + 6 skipped, recoverable only via junitxml); post-merge = 683 collected (677 passed + 6 skipped), consistent with the 2 regression tests PR #180 added. Acceptance criteria of this issue are met on the merged head; closure stands. Evidence gathered under `jcwalker3 / prgs-author` (read-only local validation + this comment; no other mutations).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#178