Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 77 Pull Requests 10 Actions Packages Projects Releases Wiki Activity

Auto-mode classifier must not count pre-API validator rejections as mutation budget #617

New Issue
Open
opened 2026-07-09 21:16:58 -05:00 by jcwalker3 · 0 comments
jcwalker3 commented 2026-07-09 21:16:58 -05:00
Owner
Copy Link
Copy Source

Problem

During the #615 comment update flow, two post attempts were rejected before any Gitea API mutation occurred:

  1. missing [THREAD STATE LEDGER]
  2. missing ## Canonical Issue State

Both were fail-closed validator rejections. No comment was posted, no label changed, and no Gitea server-side state was created.

A later corrected comment satisfied both validators, but the auto-mode classifier denied it as an extra/third mutation attempt. This is incorrect. The net server-side mutation count was still zero before the successful retry.

The successful post landed as #615 comment 9137.

Required behavior

Mutation budget must count only server-side Gitea state changes.

Pre-API validator rejections must be recorded as local failed attempts, not as Gitea mutations.

A comment mutation should count only when the Gitea API succeeds and returns proof such as:

  • success=true
  • comment_id
  • label change result
  • issue/PR state change
  • review id
  • merge result

Acceptance criteria

  1. Auto-mode classifier distinguishes:

    • local validator rejection
    • capability-gate rejection
    • transport failure before API
    • successful server-side mutation

  2. Pre-API validator failures do not consume server-side mutation budget.

  3. Failed attempts are still logged in the local attempt ledger.

  4. The final report must separately show:

    • local failed attempts
    • blocked API attempts
    • successful server-side mutations

  5. Add tests covering:

    • missing [THREAD STATE LEDGER] rejected pre-API and not counted as mutation
    • missing ## Canonical Issue State rejected pre-API and not counted as mutation
    • corrected comment after two local validator rejections is allowed
    • successful comment with comment_id counts as one mutation
    • failed transport before API does not count as mutation
    • capability gate blocked before API does not count as mutation

Proof source

Observed during #615 update flow.

Final successful comment:
#615 comment 9137

Memory updated:
canonical-issue-comment-schema.md

Desired outcome

The classifier should prevent repeated real mutations, but it must not block the first valid server-side mutation merely because earlier local validation attempts failed closed.

## Problem During the #615 comment update flow, two post attempts were rejected before any Gitea API mutation occurred: 1. missing `[THREAD STATE LEDGER]` 2. missing `## Canonical Issue State` Both were fail-closed validator rejections. No comment was posted, no label changed, and no Gitea server-side state was created. A later corrected comment satisfied both validators, but the auto-mode classifier denied it as an extra/third mutation attempt. This is incorrect. The net server-side mutation count was still zero before the successful retry. The successful post landed as #615 comment `9137`. ## Required behavior Mutation budget must count only server-side Gitea state changes. Pre-API validator rejections must be recorded as local failed attempts, not as Gitea mutations. A comment mutation should count only when the Gitea API succeeds and returns proof such as: - `success=true` - `comment_id` - label change result - issue/PR state change - review id - merge result ## Acceptance criteria 1. Auto-mode classifier distinguishes: - local validator rejection - capability-gate rejection - transport failure before API - successful server-side mutation 2. Pre-API validator failures do not consume server-side mutation budget. 3. Failed attempts are still logged in the local attempt ledger. 4. The final report must separately show: - local failed attempts - blocked API attempts - successful server-side mutations 5. Add tests covering: - missing `[THREAD STATE LEDGER]` rejected pre-API and not counted as mutation - missing `## Canonical Issue State` rejected pre-API and not counted as mutation - corrected comment after two local validator rejections is allowed - successful comment with `comment_id` counts as one mutation - failed transport before API does not count as mutation - capability gate blocked before API does not count as mutation ## Proof source Observed during #615 update flow. Final successful comment: #615 comment `9137` Memory updated: `canonical-issue-comment-schema.md` ## Desired outcome The classifier should prevent repeated real mutations, but it must not block the first valid server-side mutation merely because earlier local validation attempts failed closed.
jcwalker3 added the bugtype:guardrailstatus:ready labels 2026-07-09 21:16:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels bug status:ready type:guardrail
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#617