Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 74 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Author worktree binding can disappear mid-session and mutation guards enforce it inconsistently #618

New Issue
Open
opened 2026-07-09 21:21:12 -05:00 by jcwalker3 · 0 comments
jcwalker3 commented 2026-07-09 21:21:12 -05:00
Owner
Copy Link
Copy Source

Problem

The author MCP runtime can remain bound to a role worktree path that no longer exists on disk.

Observed case:

  • GITEA_AUTHOR_WORKTREE pointed to branches/mcp-author-clean-ns
  • that path did not exist on disk
  • it was not present in git worktree list
  • runtime context showed preflight_workspace.inspected_git_root: null

create_issue correctly failed closed under the branches-only / worktree-existence guard.

However, an earlier create_issue_comment mutation succeeded from the same broader author environment. This suggests mutation guard behavior is inconsistent between issue creation and issue comment paths.

Impact

This creates confusing and unsafe behavior:

  • one mutation path blocks because the bound worktree is missing
  • another mutation path may still mutate
  • the runtime may appear partially healthy
  • author sessions cannot reliably know whether the namespace is safe for mutation
  • missing worktree binding becomes an environment/tooling blocker instead of a clear early runtime failure

Required behavior

If a role-bound worktree path is configured but missing, the MCP runtime must fail early and consistently before any mutation.

All author mutation tools should agree on workspace safety.

At minimum, these paths must not disagree:

  • create_issue
  • create_issue_comment
  • label mutations
  • issue status mutations
  • PR/review/merge/reconcile mutations where applicable

Acceptance criteria

  1. Runtime context fails or clearly reports an unhealthy state when a configured role-bound worktree path does not exist.

  2. The error must identify:

    • role/profile
    • configured worktree path
    • whether the path exists
    • whether it appears in git worktree list
    • whether inspected_git_root is null
    • operator recovery instructions

  3. create_issue and create_issue_comment must enforce the same worktree-existence rule.

  4. If GITEA_AUTHOR_WORKTREE points to a missing path, all author mutation tools must fail closed before API mutation.

  5. The runtime should return a clear blocker message:
    bound worktree missing; operator must recreate or repoint the worktree and reconnect

  6. Add tests for:

    • missing GITEA_AUTHOR_WORKTREE
    • deleted role-bound author worktree
    • create_issue blocked
    • create_issue_comment blocked consistently
    • runtime context reports inspected_git_root=null
    • operator recovery by recreating/repointing the worktree

  7. Add or update canonical [THREAD STATE LEDGER] example for this blocker class.

Related issues

Related but not duplicates:

  • #450 — create_issue worktree_path fail-closed
  • #560 — create_issue_comment worktree binding
  • #460 — branches-only guard vs runtime_context agreement
  • #510 — workspace binding isolation
  • #610 — resolver vs parity disagreement on stale runtime
  • #617 — auto-mode classifier mutation-budget issue

Desired outcome

A missing role-bound worktree should be a clear environment/tooling blocker.

The MCP runtime must not allow one author mutation path to proceed while another blocks on the same missing worktree binding.

## Problem The author MCP runtime can remain bound to a role worktree path that no longer exists on disk. Observed case: - `GITEA_AUTHOR_WORKTREE` pointed to `branches/mcp-author-clean-ns` - that path did not exist on disk - it was not present in `git worktree list` - runtime context showed `preflight_workspace.inspected_git_root: null` `create_issue` correctly failed closed under the branches-only / worktree-existence guard. However, an earlier `create_issue_comment` mutation succeeded from the same broader author environment. This suggests mutation guard behavior is inconsistent between issue creation and issue comment paths. ## Impact This creates confusing and unsafe behavior: - one mutation path blocks because the bound worktree is missing - another mutation path may still mutate - the runtime may appear partially healthy - author sessions cannot reliably know whether the namespace is safe for mutation - missing worktree binding becomes an environment/tooling blocker instead of a clear early runtime failure ## Required behavior If a role-bound worktree path is configured but missing, the MCP runtime must fail early and consistently before any mutation. All author mutation tools should agree on workspace safety. At minimum, these paths must not disagree: - `create_issue` - `create_issue_comment` - label mutations - issue status mutations - PR/review/merge/reconcile mutations where applicable ## Acceptance criteria 1. Runtime context fails or clearly reports an unhealthy state when a configured role-bound worktree path does not exist. 2. The error must identify: - role/profile - configured worktree path - whether the path exists - whether it appears in `git worktree list` - whether `inspected_git_root` is null - operator recovery instructions 3. `create_issue` and `create_issue_comment` must enforce the same worktree-existence rule. 4. If `GITEA_AUTHOR_WORKTREE` points to a missing path, all author mutation tools must fail closed before API mutation. 5. The runtime should return a clear blocker message: `bound worktree missing; operator must recreate or repoint the worktree and reconnect` 6. Add tests for: - missing `GITEA_AUTHOR_WORKTREE` - deleted role-bound author worktree - `create_issue` blocked - `create_issue_comment` blocked consistently - runtime context reports `inspected_git_root=null` - operator recovery by recreating/repointing the worktree 7. Add or update canonical `[THREAD STATE LEDGER]` example for this blocker class. ## Related issues Related but not duplicates: - #450 — create_issue worktree_path fail-closed - #560 — create_issue_comment worktree binding - #460 — branches-only guard vs runtime_context agreement - #510 — workspace binding isolation - #610 — resolver vs parity disagreement on stale runtime - #617 — auto-mode classifier mutation-budget issue ## Desired outcome A missing role-bound worktree should be a clear environment/tooling blocker. The MCP runtime must not allow one author mutation path to proceed while another blocks on the same missing worktree binding.
jcwalker3 added the bugtype:guardrailstatus:readymcp-health labels 2026-07-09 21:21:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels bug mcp-health status:ready type:guardrail
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#618