Add pagination metadata or explicit final-page proof to gitea_list_prs #340

New Issue

2026-07-07T03:16:53-05:00

jcwalker3 commented

2026-07-07 03:16:53 -05:00

Problem

The reviewer workflow now correctly requires strict PR inventory pagination proof before selecting the next eligible PR. However, gitea_list_prs does not appear to expose paging parameters or return pagination metadata such as has_more, next_page, total_count, or is_final_page. As a result, reviewer runs must stop with INVENTORY_PAGINATION_UNPROVEN even when the visible PR queue is small.

Required behavior

gitea_list_prs must either support explicit pagination traversal or return metadata proving that the returned PR inventory is complete.

Acceptance criteria

gitea_list_prs supports explicit pagination parameters such as page and limit / per_page, or returns complete-inventory metadata.
The response includes enough metadata to prove final-page status, such as has_more=false, next_page=null, total_count, page, per_page, or is_final_page=true.
Reviewer workflow can prove complete PR inventory without relying on assumed default Gitea page size.
Tests cover a PR inventory that spans multiple pages.
Tests cover a final-page response.
Tests reject inventory-complete claims when pagination metadata is absent.
Final-report verifier recognizes valid gitea_list_prs pagination proof.
Reviewer workflow no longer blocks with INVENTORY_PAGINATION_UNPROVEN when inventory completeness can be proven.

Observed failure

A reviewer loaded skills/llm-project-workflow/workflows/review-merge-pr.md, called gitea_list_prs, inspected the tool schema, and correctly stopped because the tool did not support paging parameters and did not return pagination metadata.

Non-goal

Do not weaken the reviewer workflow by allowing default page-size assumptions as proof.

## Problem The reviewer workflow now correctly requires strict PR inventory pagination proof before selecting the next eligible PR. However, `gitea_list_prs` does not appear to expose paging parameters or return pagination metadata such as `has_more`, `next_page`, `total_count`, or `is_final_page`. As a result, reviewer runs must stop with `INVENTORY_PAGINATION_UNPROVEN` even when the visible PR queue is small. ## Required behavior `gitea_list_prs` must either support explicit pagination traversal or return metadata proving that the returned PR inventory is complete. ## Acceptance criteria * `gitea_list_prs` supports explicit pagination parameters such as `page` and `limit` / `per_page`, or returns complete-inventory metadata. * The response includes enough metadata to prove final-page status, such as `has_more=false`, `next_page=null`, `total_count`, `page`, `per_page`, or `is_final_page=true`. * Reviewer workflow can prove complete PR inventory without relying on assumed default Gitea page size. * Tests cover a PR inventory that spans multiple pages. * Tests cover a final-page response. * Tests reject inventory-complete claims when pagination metadata is absent. * Final-report verifier recognizes valid `gitea_list_prs` pagination proof. * Reviewer workflow no longer blocks with `INVENTORY_PAGINATION_UNPROVEN` when inventory completeness can be proven. ## Observed failure A reviewer loaded `skills/llm-project-workflow/workflows/review-merge-pr.md`, called `gitea_list_prs`, inspected the tool schema, and correctly stopped because the tool did not support paging parameters and did not return pagination metadata. ## Non-goal Do not weaken the reviewer workflow by allowing default page-size assumptions as proof.

jcwalker3 added the status:in-progress label 2026-07-07 03:21:32 -05:00

jcwalker3 referenced this issue from a commit

2026-07-07 03:25:10 -05:00

feat: add pagination metadata to gitea_list_prs (#340)

jcwalker3 referenced a pull request that will close this issue

2026-07-07 03:25:56 -05:00

Add pagination metadata to gitea_list_prs #342

sysadmin closed this issue

2026-07-07 04:03:31 -05:00

sysadmin removed the status:in-progress label 2026-07-07 04:03:32 -05:00

jcwalker3 referenced this issue

2026-07-07 08:51:11 -05:00