Final report validator must reject eligible/reviewed wording for already-landed PRs #298

New Issue

2026-07-07T00:33:09-05:00

jcwalker3 commented

2026-07-07 00:33:09 -05:00

Reviewer workflows now correctly stop when an already-landed PR is detected, but final reports and controller handoffs still allow contradictory old wording.

Observed behavior

PR #278 was classified as ALREADY_LANDED_RECONCILE_REQUIRED.
The workflow correctly did not validate, approve, or merge.
However, the report still included:
- oldest eligible PR: PR #278
- next eligible PR: PR #278
- Pinned reviewed head: 2a544...
- Scratch worktree used: False

Problem

An already-landed PR is not review/merge eligible. It is reconciliation-only. Also, a head SHA cannot be called reviewed unless validation and diff review passed.

Required behavior

If already-landed gate fires, final reports must use:
- Oldest open PR requiring action
- Eligibility class: ALREADY_LANDED_RECONCILE_REQUIRED
- Candidate head SHA
- Reviewed head SHA: none
- Review worktree used: false
Final reports must not use:
- oldest eligible PR
- next eligible PR
- Pinned reviewed head
- Scratch worktree used
Controller handoff validation must fail if:
- already-landed PR is called eligible
- reviewed head is populated before validation/diff review
- old scratch worktree field is present
- Pinned reviewed head appears in a blocked/reconciliation handoff

Acceptance criteria

Already-landed reports cannot call the PR eligible.
Already-landed reports cannot claim reviewed head SHA.
Old handoff field names fail validation.
Tests cover already-landed, normal reviewed, blocked infra, and validation-failed reports.

Reviewer workflows now correctly stop when an already-landed PR is detected, but final reports and controller handoffs still allow contradictory old wording. ## Observed behavior * PR #278 was classified as `ALREADY_LANDED_RECONCILE_REQUIRED`. * The workflow correctly did not validate, approve, or merge. * However, the report still included: * `oldest eligible PR: PR #278` * `next eligible PR: PR #278` * `Pinned reviewed head: 2a544...` * `Scratch worktree used: False` ## Problem An already-landed PR is not review/merge eligible. It is reconciliation-only. Also, a head SHA cannot be called reviewed unless validation and diff review passed. ## Required behavior 1. If already-landed gate fires, final reports must use: * `Oldest open PR requiring action` * `Eligibility class: ALREADY_LANDED_RECONCILE_REQUIRED` * `Candidate head SHA` * `Reviewed head SHA: none` * `Review worktree used: false` 2. Final reports must not use: * `oldest eligible PR` * `next eligible PR` * `Pinned reviewed head` * `Scratch worktree used` 3. Controller handoff validation must fail if: * already-landed PR is called eligible * reviewed head is populated before validation/diff review * old `scratch worktree` field is present * `Pinned reviewed head` appears in a blocked/reconciliation handoff ## Acceptance criteria * Already-landed reports cannot call the PR eligible. * Already-landed reports cannot claim reviewed head SHA. * Old handoff field names fail validation. * Tests cover already-landed, normal reviewed, blocked infra, and validation-failed reports.

jcwalker3 referenced this issue

2026-07-07 01:51:24 -05:00

Add final-report validator rules for reviewer and reconciliation handoffs #327

jcwalker3 referenced this issue

2026-07-07 03:16:44 -05:00

Reject reviewer queue-status reports that violate loaded workflow proof gates #339

jcwalker3 added the status:in-progress label 2026-07-07 04:33:23 -05:00

jcwalker3 referenced this issue from a commit

2026-07-07 04:38:35 -05:00

feat: reject eligible/reviewed wording for already-landed PRs (Closes #298)

jcwalker3 referenced a pull request that will close this issue

2026-07-07 04:39:02 -05:00