Controller handoff schema must support already-landed PR reconciliation #303

New Issue

2026-07-07T00:43:16-05:00

jcwalker3 commented

2026-07-07 00:43:16 -05:00

Already-landed PR reconciliation reports still use stale review/author handoff fields that do not fit reconciliation workflows.

Observed stale fields

Mutations: None even though git fetch occurred
Workspace mutations: None
PR number opened: 278 even though no PR was opened in the session
Generic author fields such as Issue lock proof and Claim/comment status for a reconciliation task

Problem

The controller handoff schema is still shaped around author issue work or reviewer merge work, not reconciliation.

Required behavior

Add a dedicated reconciliation handoff schema with fields:

Task: Reconcile already-landed open PRs
Repo:
Role/profile:
Identity:
Selected PR:
PR live state:
Candidate head SHA:
Target branch:
Target branch SHA:
Ancestor proof:
Linked issue:
Linked issue live status:
Eligibility class: ALREADY_LANDED_RECONCILE_REQUIRED
Capabilities proven:
Missing capabilities:
PR comments posted:
Issue comments posted:
PRs closed:
Issues closed:
Git ref mutations:
Worktree mutations:
MCP/Gitea mutations:
External-state mutations:
Read-only diagnostics:
Blocker:
Safe next action:
No review/merge confirmation:

Reject stale fields

PR number opened
Pinned reviewed head
Scratch worktree used
Workspace mutations: None
Mutations: None when any git ref or external mutation occurred

Acceptance criteria

Reconciliation handoffs use the dedicated schema.
Stale author/reviewer fields fail validation.
git fetch must be reported under Git ref mutations.
Tests cover blocked reconciliation, successful PR close, comment-only reconciliation, missing issue proof, and no-op already-closed states.

Already-landed PR reconciliation reports still use stale review/author handoff fields that do not fit reconciliation workflows. ## Observed stale fields - `Mutations: None` even though `git fetch` occurred - `Workspace mutations: None` - `PR number opened: 278` even though no PR was opened in the session - Generic author fields such as `Issue lock proof` and `Claim/comment status` for a reconciliation task ## Problem The controller handoff schema is still shaped around author issue work or reviewer merge work, not reconciliation. ## Required behavior Add a dedicated reconciliation handoff schema with fields: - Task: Reconcile already-landed open PRs - Repo: - Role/profile: - Identity: - Selected PR: - PR live state: - Candidate head SHA: - Target branch: - Target branch SHA: - Ancestor proof: - Linked issue: - Linked issue live status: - Eligibility class: `ALREADY_LANDED_RECONCILE_REQUIRED` - Capabilities proven: - Missing capabilities: - PR comments posted: - Issue comments posted: - PRs closed: - Issues closed: - Git ref mutations: - Worktree mutations: - MCP/Gitea mutations: - External-state mutations: - Read-only diagnostics: - Blocker: - Safe next action: - No review/merge confirmation: ## Reject stale fields - `PR number opened` - `Pinned reviewed head` - `Scratch worktree used` - `Workspace mutations: None` - `Mutations: None` when any git ref or external mutation occurred ## Acceptance criteria - [ ] Reconciliation handoffs use the dedicated schema. - [ ] Stale author/reviewer fields fail validation. - [ ] `git fetch` must be reported under Git ref mutations. - [ ] Tests cover blocked reconciliation, successful PR close, comment-only reconciliation, missing issue proof, and no-op already-closed states.

jcwalker3 referenced this issue

2026-07-07 01:51:24 -05:00

Add final-report validator rules for reviewer and reconciliation handoffs #327

jcwalker3 added the status:in-progress label 2026-07-07 04:41:45 -05:00

jcwalker3 referenced this issue from a commit

2026-07-07 04:45:58 -05:00

feat: add dedicated reconciliation controller-handoff schema (Closes #303)

jcwalker3 referenced a pull request that will close this issue

2026-07-07 04:46:29 -05:00

feat: add dedicated reconciliation controller-handoff schema (Closes #303) #373

sysadmin closed this issue

2026-07-07 08:42:41 -05:00