Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Normal reviewer workflows must not use local Gitea fallback scripts or profile secrets #324

New Issue
Closed
opened 2026-07-07 01:49:29 -05:00 by jcwalker3 · 1 comment
jcwalker3 commented 2026-07-07 01:49:29 -05:00
Owner
Copy Link
Copy Source

A reviewer workflow used working MCP reviewer tools, but also inspected Gitea auth/config code, requested access to ~/.config/gitea-tools/profiles.json, and ran local list_prs.py with GITEA_MCP_CONFIG and GITEA_MCP_PROFILE.

Problem:

When MCP tools are available and capability checks pass, local Gitea scripts and profile files are unnecessary and increase risk. They may expose credentials, bypass MCP gates, or create inconsistent identity/capability proof.

Required behavior:

  1. Normal PR review/merge workflows must use MCP tools for Gitea operations.

  2. Do not inspect or read profile secret files during normal review.

  3. Do not run local Gitea fallback scripts during normal review.

  4. Local fallback is allowed only in explicit recovery mode and only if it independently proves:

    • identity
    • profile
    • repo
    • exact capability
    • no MCP path is available

  5. If local fallback is used, final report must classify it as fallback and explain why MCP was unavailable.

Acceptance criteria:

  • Reviewer workflow fails if it reads profiles.json during normal review.
  • Reviewer workflow fails if it runs local Gitea scripts while MCP tools are available.
  • Recovery-mode fallback requires exact capability proof.
  • Tests cover MCP available, MCP unavailable, local fallback attempted, and profile-file access.
A reviewer workflow used working MCP reviewer tools, but also inspected Gitea auth/config code, requested access to `~/.config/gitea-tools/profiles.json`, and ran local `list_prs.py` with `GITEA_MCP_CONFIG` and `GITEA_MCP_PROFILE`. Problem: When MCP tools are available and capability checks pass, local Gitea scripts and profile files are unnecessary and increase risk. They may expose credentials, bypass MCP gates, or create inconsistent identity/capability proof. Required behavior: 1. Normal PR review/merge workflows must use MCP tools for Gitea operations. 2. Do not inspect or read profile secret files during normal review. 3. Do not run local Gitea fallback scripts during normal review. 4. Local fallback is allowed only in explicit recovery mode and only if it independently proves: * identity * profile * repo * exact capability * no MCP path is available 5. If local fallback is used, final report must classify it as fallback and explain why MCP was unavailable. Acceptance criteria: * Reviewer workflow fails if it reads `profiles.json` during normal review. * Reviewer workflow fails if it runs local Gitea scripts while MCP tools are available. * Recovery-mode fallback requires exact capability proof. * Tests cover MCP available, MCP unavailable, local fallback attempted, and profile-file access.
jcwalker3 added the status:in-progress label 2026-07-07 04:05:52 -05:00
jcwalker3 commented 2026-07-07 04:06:47 -05:00
Author
Owner
Copy Link
Copy Source

PR opened with reviewer local-fallback verifier.

  • Entry point: assess_reviewer_fallback_report(report_text, action_log=..., recovery_mode=..., mcp_available=...)
  • Blocks profiles.json access and local list_prs.py/view_pr.py runs during normal review when MCP is available
  • Recovery mode requires explicit proof fields

Verification: pytest tests/test_reviewer_fallback.py tests/test_review_proofs.py -q — 158 passed

PR opened with reviewer local-fallback verifier. - Entry point: `assess_reviewer_fallback_report(report_text, action_log=..., recovery_mode=..., mcp_available=...)` - Blocks `profiles.json` access and local `list_prs.py`/`view_pr.py` runs during normal review when MCP is available - Recovery mode requires explicit proof fields Verification: `pytest tests/test_reviewer_fallback.py tests/test_review_proofs.py -q` — 158 passed
sysadmin removed the status:in-progress label 2026-07-07 04:37:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#324