Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Reviewer queue selection must prove prior PR blockers live before skipping #318

New Issue
Closed
opened 2026-07-07 01:23:51 -05:00 by jcwalker3 · 1 comment
jcwalker3 commented 2026-07-07 01:23:51 -05:00
Owner
Copy Link
Copy Source

A reviewer workflow selected PR #281 while PR #280 was still open, explaining that PR #280 was blocked by a prior REQUEST_CHANGES review and unchanged head SHA.

Problem

Skipping an earlier open PR may be correct, but the workflow must prove the blocker live in the current session. Prior-session memory is not enough.

Required behavior

  1. Before skipping an earlier open PR, fetch live PR state.

  2. If the reason is prior REQUEST_CHANGES, fetch live review feedback or review state.

  3. Verify the PR head SHA has not changed since the blocking review.

  4. Report:

    • skipped PR number
    • current head SHA
    • blocking review decision
    • blocking review head SHA
    • whether head changed after blocker
    • reason it remains blocked

  5. If blocker proof cannot be fetched, do not skip silently. Stop or classify as BLOCKER_STATUS_UNVERIFIED.

Acceptance criteria

  • Reviewer workflows cannot skip earlier open PRs based on stale memory.
  • Reports include live blocker proof for every skipped earlier PR.
  • Tests cover blocked unchanged PR, blocked updated PR, missing review feedback, draft PR, non-mergeable PR, and already-landed PR.
A reviewer workflow selected PR #281 while PR #280 was still open, explaining that PR #280 was blocked by a prior `REQUEST_CHANGES` review and unchanged head SHA. ## Problem Skipping an earlier open PR may be correct, but the workflow must prove the blocker live in the current session. Prior-session memory is not enough. ## Required behavior 1. Before skipping an earlier open PR, fetch live PR state. 2. If the reason is prior `REQUEST_CHANGES`, fetch live review feedback or review state. 3. Verify the PR head SHA has not changed since the blocking review. 4. Report: * skipped PR number * current head SHA * blocking review decision * blocking review head SHA * whether head changed after blocker * reason it remains blocked 5. If blocker proof cannot be fetched, do not skip silently. Stop or classify as `BLOCKER_STATUS_UNVERIFIED`. ## Acceptance criteria * Reviewer workflows cannot skip earlier open PRs based on stale memory. * Reports include live blocker proof for every skipped earlier PR. * Tests cover blocked unchanged PR, blocked updated PR, missing review feedback, draft PR, non-mergeable PR, and already-landed PR.
jcwalker3 added the status:in-progress label 2026-07-07 04:11:18 -05:00
jcwalker3 commented 2026-07-07 04:12:07 -05:00
Author
Owner
Copy Link
Copy Source

PR opened with prior-blocker skip proof verifier.

  • Entry point: assess_prior_blocker_skip_proof(report_text, skipped_prs=[...])
  • Requires live REQUEST_CHANGES blocker proof or BLOCKER_STATUS_UNVERIFIED

Verification: pytest tests/test_reviewer_blocker_skip.py tests/test_review_proofs.py -q — 158 passed

PR opened with prior-blocker skip proof verifier. - Entry point: `assess_prior_blocker_skip_proof(report_text, skipped_prs=[...])` - Requires live REQUEST_CHANGES blocker proof or `BLOCKER_STATUS_UNVERIFIED` Verification: `pytest tests/test_reviewer_blocker_skip.py tests/test_review_proofs.py -q` — 158 passed
sysadmin removed the status:in-progress label 2026-07-07 04:41:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#318