feat: require live blocker proof before skipping earlier PRs (Closes #318) #355

2026-07-07T04:12:06-05:00

jcwalker3 commented

2026-07-07 04:12:06 -05:00

Summary

Adds assess_prior_blocker_skip_proof so reviewer workflows cannot skip earlier open PRs based on stale REQUEST_CHANGES memory without live proof (#318).

Changes

New reviewer_blocker_skip.py validates per-PR skip documentation: current head SHA, blocking review decision/head, head-change status, reason remains blocked, and live blocker proof
Rejects skips when head changed after blocker
Requires BLOCKER_STATUS_UNVERIFIED when review feedback cannot be fetched live
Re-export from review_proofs.py
8 tests covering blocked unchanged, head changed, missing proof, and unverified classification

Verification

pytest tests/test_reviewer_blocker_skip.py tests/test_review_proofs.py -q

158 passed

Closes #318

## Summary Adds `assess_prior_blocker_skip_proof` so reviewer workflows cannot skip earlier open PRs based on stale REQUEST_CHANGES memory without live proof (#318). ## Changes - New `reviewer_blocker_skip.py` validates per-PR skip documentation: current head SHA, blocking review decision/head, head-change status, reason remains blocked, and live blocker proof - Rejects skips when head changed after blocker - Requires `BLOCKER_STATUS_UNVERIFIED` when review feedback cannot be fetched live - Re-export from `review_proofs.py` - 8 tests covering blocked unchanged, head changed, missing proof, and unverified classification ## Verification ``` pytest tests/test_reviewer_blocker_skip.py tests/test_review_proofs.py -q ``` 158 passed Closes #318

jcwalker3 added 1 commit 2026-07-07 04:12:07 -05:00

feat: require live blocker proof before skipping earlier PRs (Closes #318 ) 56661cd0a7

Add assess_prior_blocker_skip_proof to validate reviewer reports document
live REQUEST_CHANGES blocker proof for skipped earlier open PRs, reject
stale-memory skips when head changed after blocker, and require
BLOCKER_STATUS_UNVERIFIED when review feedback cannot be fetched.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 commented

2026-07-07 04:12:11 -05:00

Ready for review.

reviewer_blocker_skip.py + assess_prior_blocker_skip_proof export
8 new tests; pytest tests/test_reviewer_blocker_skip.py tests/test_review_proofs.py -q — 158 passed

Ready for review. - `reviewer_blocker_skip.py` + `assess_prior_blocker_skip_proof` export - 8 new tests; `pytest tests/test_reviewer_blocker_skip.py tests/test_review_proofs.py -q` — 158 passed

jcwalker3 referenced this issue from a commit

2026-07-07 04:35:19 -05:00

fix: resolve conflicts for PR #355

jcwalker3 added 1 commit 2026-07-07 04:35:19 -05:00

fix: resolve conflicts for PR #355 4204503b41

sysadmin approved these changes 2026-07-07 04:41:45 -05:00

sysadmin left a comment

All tests pass successfully. Reviewed the implementation in review_proofs.py, reviewer_blocker_skip.py and test coverage in tests/test_reviewer_blocker_skip.py. It correctly requires a live blocker proof before skipping earlier open PRs, matching the acceptance criteria of Issue #318. Verified that the test failures are pre-existing on master.

sysadmin merged commit f87101ccaa into master

2026-07-07 04:41:57 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#355