Reviewer reports must classify git fetch as a git ref mutation, not read-only diagnostics #297

New Issue

2026-07-07T00:33:07-05:00

jcwalker3 commented

2026-07-07 00:33:07 -05:00

Reviewer reports currently treat git fetch prgs master as read-only diagnostics, while also claiming Git/worktree mutations: None.

Problem:

git fetch may not edit files, but it updates remote-tracking refs such as prgs/master. It should not be hidden under read-only diagnostics.

Required behavior:

Final reports must distinguish:
- file edits
- worktree mutations
- git ref mutations
- MCP/Gitea mutations
- review mutations
- merge mutations
- cleanup mutations
- read-only diagnostics
git fetch, git remote update, or any command that updates refs must be reported under Git ref mutations.
Git/worktree mutations: None must be rejected if any git ref update occurred.
Read-only diagnostics should be limited to commands that do not mutate files, worktrees, refs, MCP state, Gitea state, or external state.

Acceptance criteria:

Reports using git fetch include Git ref mutations: fetched <remote>/<branch>.
Reports cannot classify fetch as purely read-only.
Final-report validator rejects Git/worktree mutations: None when fetch occurred.
Tests cover fetch-only review, worktree creation, merge, cleanup, and no-mutation blocked handoff.

Reviewer reports currently treat `git fetch prgs master` as read-only diagnostics, while also claiming `Git/worktree mutations: None`. Problem: `git fetch` may not edit files, but it updates remote-tracking refs such as `prgs/master`. It should not be hidden under read-only diagnostics. Required behavior: 1. Final reports must distinguish: * file edits * worktree mutations * git ref mutations * MCP/Gitea mutations * review mutations * merge mutations * cleanup mutations * read-only diagnostics 2. `git fetch`, `git remote update`, or any command that updates refs must be reported under `Git ref mutations`. 3. `Git/worktree mutations: None` must be rejected if any git ref update occurred. 4. Read-only diagnostics should be limited to commands that do not mutate files, worktrees, refs, MCP state, Gitea state, or external state. Acceptance criteria: * Reports using `git fetch` include `Git ref mutations: fetched <remote>/<branch>`. * Reports cannot classify fetch as purely read-only. * Final-report validator rejects `Git/worktree mutations: None` when fetch occurred. * Tests cover fetch-only review, worktree creation, merge, cleanup, and no-mutation blocked handoff.

jcwalker3 referenced this issue

2026-07-07 01:51:24 -05:00

Add final-report validator rules for reviewer and reconciliation handoffs #327

jcwalker3 added the status:in-progress label 2026-07-07 03:23:18 -05:00

jcwalker3 referenced this issue from a commit

2026-07-07 03:27:01 -05:00

feat(reports): classify git fetch as a git ref mutation (closes #297)

jcwalker3 referenced a pull request that will close this issue

2026-07-07 03:29:58 -05:00

feat(reports): classify git fetch as a git ref mutation (closes #297) #344

sysadmin referenced this issue

2026-07-07 04:06:59 -05:00