Final reports must not say workspace mutations none when worktree mutations occurred #313

New Issue

2026-07-07T01:08:56-05:00

jcwalker3 commented

2026-07-07 01:08:56 -05:00

A reviewer workflow correctly reported a worktree mutation but the controller handoff still included ambiguous wording:

Worktree mutation: git reset --hard FETCH_HEAD
Controller handoff: Workspace mutations: none (no local file edits)

Problem

This wording is contradictory. Resetting a worktree is a workspace/worktree mutation even if the reviewer did not edit files manually.

Required behavior

Reports must distinguish:
- file edits by reviewer
- worktree mutations
- Git ref mutations
- MCP/Gitea mutations
- review mutations
- merge mutations
- cleanup mutations
If git reset --hard, checkout, clean, worktree add/remove, or similar commands occurred, the report must not say Workspace mutations: none.
Use precise wording:
- File edits by reviewer: none
- Worktree mutations: git reset --hard FETCH_HEAD
- Git ref mutations: fetch/pull
- MCP/Gitea mutations: approved/merged

Acceptance criteria

Reports fail validation if they say workspace mutations none after worktree reset.
Reports pass when they say file edits none but worktree mutations occurred.
Tests cover reset, checkout, worktree add, worktree clean, fetch-only, and no-op cases.

A reviewer workflow correctly reported a worktree mutation but the controller handoff still included ambiguous wording: * Worktree mutation: `git reset --hard FETCH_HEAD` * Controller handoff: `Workspace mutations: none (no local file edits)` ## Problem This wording is contradictory. Resetting a worktree is a workspace/worktree mutation even if the reviewer did not edit files manually. ## Required behavior 1. Reports must distinguish: * file edits by reviewer * worktree mutations * Git ref mutations * MCP/Gitea mutations * review mutations * merge mutations * cleanup mutations 2. If `git reset --hard`, checkout, clean, worktree add/remove, or similar commands occurred, the report must not say `Workspace mutations: none`. 3. Use precise wording: * `File edits by reviewer: none` * `Worktree mutations: git reset --hard FETCH_HEAD` * `Git ref mutations: fetch/pull` * `MCP/Gitea mutations: approved/merged` ## Acceptance criteria * Reports fail validation if they say workspace mutations none after worktree reset. * Reports pass when they say file edits none but worktree mutations occurred. * Tests cover reset, checkout, worktree add, worktree clean, fetch-only, and no-op cases.

jcwalker3 referenced this issue

2026-07-07 01:51:24 -05:00

Add final-report validator rules for reviewer and reconciliation handoffs #327

jcwalker3 added the status:in-progress label 2026-07-07 04:03:47 -05:00

jcwalker3 referenced this issue from a commit

2026-07-07 04:09:55 -05:00

feat: reject workspace-none claims after worktree mutations (Closes #313)

jcwalker3 referenced a pull request that will close this issue

2026-07-07 04:11:54 -05:00

feat: reject workspace-none claims after worktree mutations (Closes #313) #354

sysadmin referenced this issue

2026-07-07 04:23:38 -05:00