jcwalker3
bc968dd2e0
fix: post AC4 recurrence comments on linked incident issues ( #607 )
...
Remediates review 479/481 findings F1 and F2 on PR #767 .
F1: issue #607 AC4 requires that an existing linked Gitea issue receives a
recurrence comment when Sentry events continue. That path did not exist.
This adds:
- incident_bridge.incident_recurred() — true only when event_count or
last_seen genuinely advanced, compared against the pre-upsert link row, so
an unchanged rescan stays silent and the exactly-once property holds.
- incident_bridge.build_recurrence_comment_body() — reuses the same
redact_text path as build_gitea_issue_body, so redaction is not
re-implemented.
- A comment_issue_fn hook on reconcile_incident, invoked only on
OUTCOME_UPDATED with genuinely new events. The durable incident_links row
is written first, so a comment failure degrades to "link updated, comment
withheld" without corrupting the mapping or creating a duplicate issue.
- _incident_recurrence_comment_fn() in gitea_mcp_server.py, routing through
the sanctioned gitea_create_issue_comment path named in issue #607 . It
returns None on dry runs and when the profile lacks gitea.issue.comment, so
the AC8 dry-run default and disabled-mode safety hold.
- comment_issue_fn threading through sentry_incident_bridge.watchdog(), with
the per-issue recurrence_comment outcome recorded in the scan result.
F2: observation_from_issue never populates a fingerprint, so the "deduped by
Sentry issue id and fingerprint" claim was unsupported. The
gitea_sentry_reconcile_issue and gitea_sentry_watchdog docstrings now state
the real dedupe basis: provider identity (provider, base URL, org, project,
Sentry issue id).
Tests: five new AC4 cases in tests/test_sentry_incident_bridge.py covering a
comment on the second scan, dry-run silence, no-new-events silence, link
durability when the comment fails, and comment redaction. Focused suite
43 passed (was 38).
Refs #607
2026-07-20 04:08:52 -05:00
..
2026-07-02 15:31:56 -05:00
2026-06-21 17:26:18 -04:00
2026-07-17 14:25:08 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-19 14:12:04 -04:00
2026-07-19 14:12:04 -04:00
2026-07-10 02:54:20 -04:00
2026-07-07 09:20:50 -04:00
2026-07-07 05:38:32 -04:00
2026-07-12 09:00:45 -04:00
2026-07-13 13:40:38 -04:00
2026-07-15 21:13:21 -04:00
2026-07-17 19:42:52 -04:00
2026-07-15 21:13:21 -04:00
2026-07-10 18:09:19 -04:00
2026-07-05 15:16:36 -04:00
2026-07-08 22:36:10 -04:00
2026-07-17 19:42:52 -04:00
2026-07-13 21:48:28 -04:00
2026-07-08 03:17:38 -04:00
2026-07-08 03:44:58 -04:00
2026-07-07 04:25:02 -04:00
2026-07-02 06:13:26 -04:00
2026-07-05 17:18:48 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-05 03:33:12 -04:00
2026-07-02 02:34:16 -04:00
2026-07-08 02:19:37 -04:00
2026-07-04 18:35:45 -04:00
2026-07-15 21:13:21 -04:00
2026-07-08 22:30:21 -04:00
2026-07-10 11:30:53 -04:00
2026-07-09 15:39:54 -04:00
2026-07-18 16:19:04 -04:00
2026-07-18 16:19:04 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-06 01:26:33 -04:00
2026-07-18 03:44:28 -04:00
2026-07-17 19:42:52 -04:00
2026-07-05 03:23:40 -04:00
2026-07-07 04:27:02 -04:00
2026-07-09 12:56:12 -04:00
2026-07-07 04:26:58 -04:00
2026-07-13 02:29:46 -04:00
2026-07-07 04:35:34 -04:00
2026-07-07 02:57:45 -04:00
2026-07-10 03:18:54 -04:00
2026-07-12 13:15:58 -04:00
2026-07-12 13:15:58 -04:00
2026-07-17 14:04:45 -04:00
2026-07-13 14:35:15 -04:00
2026-07-13 02:29:46 -04:00
2026-07-13 21:48:28 -04:00
2026-07-13 17:37:13 -04:00
2026-07-13 16:40:58 -04:00
2026-07-13 14:35:15 -04:00
2026-07-17 23:31:39 -04:00
2026-07-18 01:27:26 -04:00
2026-07-15 13:55:06 -04:00
2026-07-15 21:13:21 -04:00
2026-07-17 14:25:08 -04:00
2026-07-16 15:47:52 -04:00
2026-07-19 23:21:54 -04:00
2026-07-17 22:45:18 -04:00
2026-07-18 12:02:31 -04:00
2026-07-18 12:59:51 -04:00
2026-07-18 13:55:46 -04:00
2026-07-18 17:38:54 -04:00
2026-07-18 19:31:55 -04:00
2026-07-20 02:52:29 -05:00
2026-07-19 12:59:08 -04:00
2026-07-19 18:27:34 -04:00
2026-07-20 02:52:29 -05:00
2026-07-08 03:27:37 -04:00
2026-07-07 05:41:33 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-07 23:40:12 -05:00
2026-07-07 16:18:42 -04:00
2026-07-10 11:30:53 -04:00
2026-07-08 02:22:54 -04:00
2026-07-15 21:13:21 -04:00
2026-07-10 16:17:31 -04:00
2026-07-15 21:13:21 -04:00
2026-07-10 11:30:53 -04:00
2026-07-07 05:22:08 -04:00
2026-07-07 04:25:02 -04:00
2026-07-15 21:13:21 -04:00
2026-07-08 04:08:07 -04:00
2026-07-15 21:13:21 -04:00
2026-07-10 13:05:27 -04:00
2026-07-07 13:11:36 -04:00
2026-07-13 21:48:28 -04:00
2026-07-06 12:37:04 -04:00
2026-07-19 14:43:10 -04:00
2026-07-09 18:44:04 -04:00
2026-07-08 13:43:39 -04:00
2026-07-17 19:42:52 -04:00
2026-07-08 22:22:34 -04:00
2026-07-16 21:21:39 -04:00
2026-07-13 21:48:28 -04:00
2026-07-05 15:16:55 -04:00
2026-07-09 08:20:21 -04:00
2026-07-17 13:30:52 -04:00
2026-07-15 21:13:21 -04:00
2026-07-18 10:12:49 -04:00
2026-07-12 22:35:14 -04:00
2026-06-21 18:08:53 -04:00
2026-07-17 20:42:25 -04:00
2026-07-07 04:08:27 -04:00
2026-07-09 09:25:08 -04:00
2026-07-09 10:43:42 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-09 09:25:08 -04:00
2026-07-07 17:19:37 -04:00
2026-07-18 12:59:51 -04:00
2026-07-09 15:49:14 -04:00
2026-07-15 21:13:21 -04:00
2026-07-17 13:57:22 -04:00
2026-07-08 23:33:51 -04:00
2026-07-08 02:17:58 -04:00
2026-07-17 10:42:53 -04:00
2026-07-07 13:06:07 -04:00
2026-07-12 13:15:58 -04:00
2026-07-17 23:45:44 -04:00
2026-07-08 23:04:44 -04:00
2026-07-07 04:46:48 -04:00
2026-07-05 15:16:55 -04:00
2026-07-10 13:05:27 -04:00
2026-07-07 04:57:50 -04:00
2026-07-07 09:20:50 -04:00
2026-07-09 00:09:47 -04:00
2026-07-07 09:15:13 -04:00
2026-07-19 02:26:58 -04:00
2026-07-12 21:31:00 -04:00
2026-07-09 12:36:50 -04:00
2026-07-07 05:45:51 -04:00
2026-07-07 09:25:55 -04:00
2026-07-07 09:25:55 -04:00
2026-07-02 05:37:41 -04:00
2026-07-15 21:13:21 -04:00
2026-07-07 02:53:25 -04:00
2026-07-19 23:21:54 -04:00
2026-07-13 13:40:38 -04:00
2026-07-09 19:08:28 -04:00
2026-07-08 00:37:54 -04:00
2026-07-09 09:25:08 -04:00
2026-07-07 09:14:29 -04:00
2026-07-05 20:16:04 -04:00
2026-07-13 17:37:13 -04:00
2026-07-08 11:13:43 -04:00
2026-07-08 22:22:34 -04:00
2026-07-07 09:19:33 -04:00
2026-07-07 09:23:50 -04:00
2026-07-07 05:42:08 -04:00
2026-07-07 05:12:01 -04:00
2026-07-07 05:27:24 -04:00
2026-07-08 03:33:31 -04:00
2026-07-07 05:33:12 -04:00
2026-07-07 05:39:43 -04:00
2026-07-07 05:13:30 -04:00
2026-07-07 05:08:53 -04:00
2026-07-07 17:20:01 -04:00
2026-07-07 05:31:24 -04:00
2026-07-18 13:55:46 -04:00
2026-07-07 10:24:54 -04:00
2026-07-07 09:08:38 -04:00
2026-07-07 05:44:18 -04:00
2026-07-07 13:09:58 -04:00
2026-07-07 11:22:00 -04:00
2026-07-07 05:19:22 -04:00
2026-07-07 05:28:19 -04:00
2026-07-07 05:26:37 -04:00
2026-07-06 11:42:14 -04:00
2026-07-15 21:13:21 -04:00
2026-07-15 21:13:21 -04:00
2026-07-11 19:49:16 -04:00
2026-07-07 17:44:22 -04:00
2026-07-15 21:13:21 -04:00
2026-07-20 04:08:52 -05:00
2026-07-12 02:35:47 -04:00
2026-07-09 17:19:29 -04:00
2026-07-10 13:05:27 -04:00
2026-07-06 14:52:12 -04:00
2026-07-11 20:07:40 -04:00
2026-07-11 20:07:40 -04:00
2026-07-16 14:58:43 -05:00
2026-07-08 02:22:54 -04:00
2026-07-17 14:25:08 -04:00
2026-07-08 03:14:32 -04:00
2026-07-13 13:40:38 -04:00
2026-07-07 00:28:32 -04:00
2026-07-07 00:17:26 -04:00
2026-07-19 23:21:54 -04:00
2026-07-13 02:29:46 -04:00
2026-07-08 03:46:25 -04:00
2026-07-07 00:22:28 -04:00
2026-07-07 12:53:55 -04:00
2026-07-07 15:20:47 -04:00
2026-07-09 11:59:23 -04:00
2026-07-09 11:50:40 -04:00
2026-07-07 15:34:39 -04:00
2026-07-07 15:29:56 -04:00
2026-07-09 11:59:23 -04:00
2026-07-07 14:44:27 -04:00
2026-07-07 14:53:16 -04:00
2026-07-09 11:59:23 -04:00
2026-07-09 00:04:11 -04:00
2026-07-09 11:50:40 -04:00
2026-07-07 15:26:22 -04:00
2026-07-06 01:36:10 -04:00
2026-07-06 14:44:41 -04:00
2026-07-19 14:43:10 -04:00
2026-07-15 21:13:21 -04:00
2026-07-11 19:49:16 -04:00
2026-07-07 05:09:44 -04:00
2026-07-08 11:15:55 -04:00
2026-07-07 17:30:35 -04:00