Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 68 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: mutation budget counts server-side changes only (Closes #617) #775

Merged
sysadmin merged 1 commits from fix/issue-617-mutation-budget-classifier into master 2026-07-20 20:28:32 -05:00
Conversation 8 Commits 1 Files Changed 3
+746
jcwalker3 commented 2026-07-20 19:00:27 -05:00
Owner
Copy Link
Copy Source

Closes #617

Head

Published branch head: 296601647d3f0c067a656aa55dff2793d7b0143f (base master @ 702ceb2480704a08c3f48f7fa0f64c6f08548465, 0 commits behind).

Provenance

Resumed from a dead author session's preserved unpublished commit b46f0f9f138d569edbc73e0d36df4b34239f9934, recovered entirely through native MCP:

  • gitea_lock_issue unpublished-claim recovery (#772): recovery_mode=unpublished_claim, recorded_base=0568f44c, accepted_head=b46f0f9f proven descends_from_recorded_base, CAS on prior generation (dead pid 68614 to replacement 65541).
  • author-worktree lock binding (#618): mutation workspace resolved from the active author issue-lock worktree.
  • Reconciled onto current master (merge, b46f0f9 preserved as ancestor); published content is base-master plus this delta.

Changes

Auto-mode classifier now distinguishes four attempt outcomes and counts only durable server-side Gitea state as mutation budget:

  • mutation_budget_classifier.py (new): classify_mutation_attempt returns one of local validator rejection, capability_gate_rejection, transport_failure_before_api, successful server-side mutation (proven by comment_id / label / review id / merge result); plus attempt-ledger recording and final-report accounting.
  • final_report_validator.py (+72): wires a shared rule requiring the final report to separately account for local failed attempts, blocked API attempts, and successful server-side mutations, cross-checked against the attempt ledger.
  • tests/test_mutation_budget_classifier.py (new): 32 tests.

Acceptance criteria

  • AC1 classifier distinguishes the four outcomes — covered.
  • AC2 pre-API validator failures do not consume server-side budget — covered.
  • AC3 failed attempts still logged in the local ledger — covered.
  • AC4 final report separately shows local failed / blocked API / successful server-side — covered.
  • AC5 test matrix (missing [THREAD STATE LEDGER] pre-API; missing ## Canonical Issue State pre-API; corrected comment after two local rejections allowed; successful comment with comment_id counts one; transport-before-API not counted; capability gate before API not counted) — covered.

Validation

Runner: /opt/homebrew/bin/python3 -m pytest (pytest 9.0.3).

  • Focused tests/test_mutation_budget_classifier.py: 32 passed.
  • Affected validator suites (-k "final_report or validator"): 170 passed.
  • Full suite on the reconciled state: 3933 passed, 6 skipped, 11 failed.

Baseline proof for the 11 failures

All 11 reproduce identically on the pristine current master 702ceb2 control checkout, so they are pre-existing and not introduced by this branch (signature: stale mocks expecting verify_preflight_purity('prgs', task=...) without the org=/repo= arguments added by #735). Failing set: tests/test_commit_payloads.py (6), tests/test_issue_702_review_findings_f1_f6.py (2), tests/test_mcp_server.py::TestPreflightVerification::test_declared_clean_task_worktree_ignores_control_checkout_violation, tests/test_post_merge_moot_lease.py::...test_acquire_tool_fails_closed_on_merged_pr_without_posting, tests/test_reconciler_supersession_close.py::...test_tool_posts_comment_and_closes_superseded_pr_issue.

git diff --check clean; no secrets; scope limited to the three files above.

Closes #617 ## Head Published branch head: `296601647d3f0c067a656aa55dff2793d7b0143f` (base `master` @ `702ceb2480704a08c3f48f7fa0f64c6f08548465`, 0 commits behind). ## Provenance Resumed from a dead author session's preserved unpublished commit `b46f0f9f138d569edbc73e0d36df4b34239f9934`, recovered entirely through native MCP: - `gitea_lock_issue` unpublished-claim recovery (#772): `recovery_mode=unpublished_claim`, `recorded_base=0568f44c`, `accepted_head=b46f0f9f` proven `descends_from_recorded_base`, CAS on prior generation (dead pid 68614 to replacement 65541). - author-worktree lock binding (#618): mutation workspace resolved from the active author issue-lock worktree. - Reconciled onto current `master` (merge, `b46f0f9` preserved as ancestor); published content is base-`master` plus this delta. ## Changes Auto-mode classifier now distinguishes four attempt outcomes and counts only durable server-side Gitea state as mutation budget: - `mutation_budget_classifier.py` (new): `classify_mutation_attempt` returns one of local validator rejection, `capability_gate_rejection`, `transport_failure_before_api`, successful server-side mutation (proven by `comment_id` / label / review id / merge result); plus attempt-ledger recording and final-report accounting. - `final_report_validator.py` (+72): wires a shared rule requiring the final report to separately account for local failed attempts, blocked API attempts, and successful server-side mutations, cross-checked against the attempt ledger. - `tests/test_mutation_budget_classifier.py` (new): 32 tests. ## Acceptance criteria - AC1 classifier distinguishes the four outcomes — covered. - AC2 pre-API validator failures do not consume server-side budget — covered. - AC3 failed attempts still logged in the local ledger — covered. - AC4 final report separately shows local failed / blocked API / successful server-side — covered. - AC5 test matrix (missing `[THREAD STATE LEDGER]` pre-API; missing `## Canonical Issue State` pre-API; corrected comment after two local rejections allowed; successful comment with `comment_id` counts one; transport-before-API not counted; capability gate before API not counted) — covered. ## Validation Runner: `/opt/homebrew/bin/python3 -m pytest` (pytest 9.0.3). - Focused `tests/test_mutation_budget_classifier.py`: 32 passed. - Affected validator suites (`-k "final_report or validator"`): 170 passed. - Full suite on the reconciled state: 3933 passed, 6 skipped, 11 failed. ## Baseline proof for the 11 failures All 11 reproduce identically on the pristine current `master` `702ceb2` control checkout, so they are pre-existing and not introduced by this branch (signature: stale mocks expecting `verify_preflight_purity('prgs', task=...)` without the `org=`/`repo=` arguments added by #735). Failing set: `tests/test_commit_payloads.py` (6), `tests/test_issue_702_review_findings_f1_f6.py` (2), `tests/test_mcp_server.py::TestPreflightVerification::test_declared_clean_task_worktree_ignores_control_checkout_violation`, `tests/test_post_merge_moot_lease.py::...test_acquire_tool_fails_closed_on_merged_pr_without_posting`, `tests/test_reconciler_supersession_close.py::...test_tool_posts_comment_and_closes_superseded_pr_issue`. `git diff --check` clean; no secrets; scope limited to the three files above.
jcwalker3 added 1 commit 2026-07-20 19:00:27 -05:00
fix: mutation budget counts server-side changes only (Closes #617) 296601647d 
Auto-mode classifier now distinguishes local validator rejection,
capability-gate rejection, transport failure before API, and successful
server-side mutation. Pre-API validator failures no longer consume
server-side mutation budget; the final report separately accounts for
local failed attempts, blocked API attempts, and successful server-side
mutations.

Recovered from preserved unpublished commit b46f0f9 via native MCP
unpublished-claim recovery (#772) and author-worktree lock binding (#618),
reconciled onto current master.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
jcwalker3 commented 2026-07-20 19:04:17 -05:00
Author
Owner
Copy Link
Copy Source

CTH: Author Handoff

Canonical Issue State

STATE: author-complete-awaiting-independent-review
WHO_IS_NEXT: reviewer
NEXT_ACTION: run an independent prgs-reviewer review of PR #775 at head 296601647d and submit a formal verdict
NEXT_PROMPT: perform one independent reviewer phase for Gitea-Tools PR #775 (issue #617) at head 296601647d3f0c067a656aa55dff2793d7b0143f; verify the mutation-budget classifier scope is limited to the three files, confirm the 11 full-suite failures reproduce on pristine master 702ceb2 and are pre-existing, then submit APPROVE or REQUEST_CHANGES
WHAT_HAPPENED: recovered the dead author session preserved commit b46f0f9f138d569edbc73e0d36df4b34239f9934 through native MCP unpublished-claim recovery (#772) and author-worktree lock binding (#618), reconciled onto current master, and published the branch head via native commit
WHY: the author role cannot review or merge its own PR, so an independent reviewer verdict is required before merge
RELATED_PRS: PR #775 (head 296601647d), closes issue #617
BLOCKERS: none
VALIDATION: focused classifier tests 32 passed; validator suites 170 passed; full suite 3933 passed, 6 skipped, 11 failed with all 11 reproduced identically on pristine master 702ceb2 (pre-existing, not branch-caused)
LAST_UPDATED_BY: jcwalker3 (prgs-author)

Author lock for issue #617 remains live by design; do not release or edit it manually.

## CTH: Author Handoff ## Canonical Issue State STATE: author-complete-awaiting-independent-review WHO_IS_NEXT: reviewer NEXT_ACTION: run an independent prgs-reviewer review of PR #775 at head 296601647d3f0c067a656aa55dff2793d7b0143f and submit a formal verdict NEXT_PROMPT: perform one independent reviewer phase for Gitea-Tools PR #775 (issue #617) at head 296601647d3f0c067a656aa55dff2793d7b0143f; verify the mutation-budget classifier scope is limited to the three files, confirm the 11 full-suite failures reproduce on pristine master 702ceb2 and are pre-existing, then submit APPROVE or REQUEST_CHANGES WHAT_HAPPENED: recovered the dead author session preserved commit b46f0f9f138d569edbc73e0d36df4b34239f9934 through native MCP unpublished-claim recovery (#772) and author-worktree lock binding (#618), reconciled onto current master, and published the branch head via native commit WHY: the author role cannot review or merge its own PR, so an independent reviewer verdict is required before merge RELATED_PRS: PR #775 (head 296601647d3f0c067a656aa55dff2793d7b0143f), closes issue #617 BLOCKERS: none VALIDATION: focused classifier tests 32 passed; validator suites 170 passed; full suite 3933 passed, 6 skipped, 11 failed with all 11 reproduced identically on pristine master 702ceb2 (pre-existing, not branch-caused) LAST_UPDATED_BY: jcwalker3 (prgs-author) Author lock for issue #617 remains live by design; do not release or edit it manually.
sysadmin commented 2026-07-20 19:19:14 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #775
issue: #617
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 65607-bb4a5c9175ec
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-775
phase: claimed
candidate_head: 296601647d
target_branch: master
target_branch_sha: 702ceb2480
last_activity: 2026-07-21T00:19:13Z
expires_at: 2026-07-21T00:29:13Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #775 issue: #617 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 65607-bb4a5c9175ec worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-775 phase: claimed candidate_head: 296601647d3f0c067a656aa55dff2793d7b0143f target_branch: master target_branch_sha: 702ceb2480704a08c3f48f7fa0f64c6f08548465 last_activity: 2026-07-21T00:19:13Z expires_at: 2026-07-21T00:29:13Z blocker: none
sysadmin commented 2026-07-20 19:30:05 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #775
issue: #617
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: llm-lock-canary-gt-controller-702ceb2-20260720
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-775
phase: claimed
candidate_head: 296601647d
target_branch: master
target_branch_sha: 702ceb2480
last_activity: 2026-07-21T00:30:05Z
expires_at: 2026-07-21T00:40:05Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #775 issue: #617 reviewer_identity: sysadmin profile: prgs-reviewer session_id: llm-lock-canary-gt-controller-702ceb2-20260720 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-775 phase: claimed candidate_head: 296601647d3f0c067a656aa55dff2793d7b0143f target_branch: master target_branch_sha: 702ceb2480704a08c3f48f7fa0f64c6f08548465 last_activity: 2026-07-21T00:30:05Z expires_at: 2026-07-21T00:40:05Z blocker: none
sysadmin approved these changes 2026-07-20 19:30:55 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

Canonical PR State

STATE: approved
WHO_IS_NEXT: user
NEXT_ACTION: Operator must explicitly authorize merge of PR #775; only then may merger merge at pinned head
NEXT_PROMPT:

After operator authorizes merge: use prgs-merger as sysadmin; gitea_check_pr_eligibility merge on PR 775; pin expected_head_sha=296601647d3f0c067a656aa55dff2793d7b0143f; confirmation MERGE PR 775. Do not force-merge. Closes #617 on merge.

WHAT_HAPPENED: Canary fire 3 formal review completed; APPROVE submitted at current head; merge not performed
WHY: Classifier correctly counts only durable server-side mutations; pre-API failures do not consume budget; ambiguous outcomes fail closed; final-report ledger accounting correct
ISSUE: #617
HEAD_SHA: 296601647d
REVIEW_STATUS: approved / approval_at_current_head
MERGE_READY: false
BLOCKERS: operator merge authorization not granted this canary fire
VALIDATION: pytest tests/test_mutation_budget_classifier.py 32 passed; final_report or mutation_budget 118 passed; eligibility sysadmin!=jcwalker3; control clean @ 702ceb2480
NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; token_fingerprint=beafd9c22e5b95be
LAST_UPDATED_BY: sysadmin

## Canonical PR State STATE: approved WHO_IS_NEXT: user NEXT_ACTION: Operator must explicitly authorize merge of PR #775; only then may merger merge at pinned head NEXT_PROMPT: ```text After operator authorizes merge: use prgs-merger as sysadmin; gitea_check_pr_eligibility merge on PR 775; pin expected_head_sha=296601647d3f0c067a656aa55dff2793d7b0143f; confirmation MERGE PR 775. Do not force-merge. Closes #617 on merge. ``` WHAT_HAPPENED: Canary fire 3 formal review completed; APPROVE submitted at current head; merge not performed WHY: Classifier correctly counts only durable server-side mutations; pre-API failures do not consume budget; ambiguous outcomes fail closed; final-report ledger accounting correct ISSUE: #617 HEAD_SHA: 296601647d3f0c067a656aa55dff2793d7b0143f REVIEW_STATUS: approved / approval_at_current_head MERGE_READY: false BLOCKERS: operator merge authorization not granted this canary fire VALIDATION: pytest tests/test_mutation_budget_classifier.py 32 passed; final_report or mutation_budget 118 passed; eligibility sysadmin!=jcwalker3; control clean @ 702ceb2480704a08c3f48f7fa0f64c6f08548465 NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; token_fingerprint=beafd9c22e5b95be LAST_UPDATED_BY: sysadmin
sysadmin commented 2026-07-20 19:31:10 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #775
issue: #617
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: llm-lock-canary-gt-controller-702ceb2-20260720
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-775
phase: released
candidate_head: 296601647d
target_branch: master
target_branch_sha: 702ceb2480
last_activity: 2026-07-21T00:31:10Z
expires_at: 2026-07-21T00:41:10Z
blocker: manual-release

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #775 issue: #617 reviewer_identity: sysadmin profile: prgs-reviewer session_id: llm-lock-canary-gt-controller-702ceb2-20260720 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-775 phase: released candidate_head: 296601647d3f0c067a656aa55dff2793d7b0143f target_branch: master target_branch_sha: 702ceb2480704a08c3f48f7fa0f64c6f08548465 last_activity: 2026-07-21T00:31:10Z expires_at: 2026-07-21T00:41:10Z blocker: manual-release
sysadmin commented 2026-07-20 20:28:15 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #775
issue: #617
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 80637-b0e55d7c910a
worktree: branches/review-pr-775
phase: claimed
candidate_head: 296601647d
target_branch: master
target_branch_sha: 702ceb2480
last_activity: 2026-07-21T01:28:15Z
expires_at: 2026-07-21T01:38:15Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #775 issue: #617 reviewer_identity: sysadmin profile: prgs-merger session_id: 80637-b0e55d7c910a worktree: branches/review-pr-775 phase: claimed candidate_head: 296601647d3f0c067a656aa55dff2793d7b0143f target_branch: master target_branch_sha: 702ceb2480704a08c3f48f7fa0f64c6f08548465 last_activity: 2026-07-21T01:28:15Z expires_at: 2026-07-21T01:38:15Z blocker: none
sysadmin merged commit 52ded0ea71 into master 2026-07-20 20:28:32 -05:00
sysadmin commented 2026-07-20 20:28:33 -05:00
Owner
Copy Link
Copy Source

Stale #332 review-decision lock cleanup (#594)

Status: APPLIED

Manual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.

## Stale #332 review-decision lock cleanup (#594) Status: **APPLIED** - actor: `sysadmin` - profile: `prgs-merger` - timestamp: `2026-07-21T01:28:33.325537+00:00` - last terminal: `approve` on PR #775 - PR state: `closed` (merged=True) - merge_commit_sha: `52ded0ea714b31468ba991bac61084e103b08dcb` - prior live_mutations_count: `1` - prior profile_identity: `prgs-reviewer` Manual deletion of session-state files is **not** the workflow. This path only clears a lock when the referenced PR is merged/closed.
sysadmin commented 2026-07-20 20:41:59 -05:00
Owner
Copy Link
Copy Source

Canonical Issue State

STATE: terminal_cleanup_complete_with_preserved_local_branch_and_file_lock
WHO_IS_NEXT: user
NEXT_ACTION: No further reconciler action required for PR #775 / Issue #617. Optional operator-only follow-up if durable author issue-lock file or local non-ancestor branch ref must be force-removed outside this reconciler path.
NEXT_PROMPT:

No agent prompt required. Terminal cleanup for PR #775 / Issue #617 is complete. Preserved: local branch fix/issue-617-mutation-budget-classifier @ 174310d4 (git branch -d refused; tree-identical to landed head); author issue-lock file for #617 (no sanctioned unlock; owner pids dead). Do not force-delete. Do not touch #681 or unrelated worktrees.

WHAT_HAPPENED: prgs-reconciler terminal cleanup for merged PR #775 / closed Issue #617. Gate Zero PASS at 52ded0ea. Removed residual status:pr-open. Moot merger lease 80637-b0e55d7c910a/comment 13485 assessed then found naturally expired. Removed clean worktrees review-pr-775, issue-617-mutation-budget-classifier, baseline-master-617 via scripts/worktree-clean. Deleted remote fix/issue-617-mutation-budget-classifier via gitea_cleanup_merged_pr_branch (verified_absent). Local branch -d refused (not fully merged). Author file lock preserved.
WHY: Post-merge residual cleanup only; prove equivalence before removal; never force-delete; fail closed on unmerged local branch ancestry.
RELATED_PRS: #775 (this PR; merge 52ded0ea); closes #617; review_id 489 APPROVED at 296601647d
BLOCKERS: none for terminal cleanup of landable remote/worktree residue. Non-blocking preserves: (1) local branch fix/issue-617-mutation-budget-classifier @ 174310d4 — safe git branch -d fails despite identical tree c3fa30c1 to master/merged head; (2) file lock ~/.cache/gitea-tools/issue-locks/prgs-Scaled-Tech-Consulting-Gitea-Tools-617.json — dead author pids, no sanctioned reconciler unlock tool.
VALIDATION: Gate Zero parity in_parity at 52ded0ea; whoami sysadmin/prgs-reconciler; PR closed merge_commit_sha=52ded0ea; Issue 617 closed labels=[bug,type:guardrail]; review 489 APPROVED at 29660164; trees author=merged=master=c3fa30c1; remote branch verified_absent; worktrees absent; control clean porcelain=0 @ 52ded0ea
LAST_UPDATED_BY: sysadmin (prgs-reconciler)

Terminal cleanup ledger — PR #775 / Issue #617

Gate Zero

  • Control already at 52ded0ea71 (fetch prune; FF not needed; local master == prgs/master).
  • Reconciler namespace connected: profile prgs-reconciler, identity sysadmin, identity_match=true.
  • Parity PASS: startup_head=current_head=local=live master=52ded0ea; restart_required=false; clean control checkout.

Terminal verification

  • PR #775 closed/merged at merge_commit_sha 52ded0ea71.
  • Issue #617 closed.
  • 296601647d is on live master (ancestor).
  • Review 489 remains historical APPROVED at merged head 29660164 (not re-reviewed).

Moot lease

  • Dry-run: lease_moot=true cleanup_allowed=true session=80637-b0e55d7c910a comment=13485 head=29660164 phase=claimed.
  • Apply: no active lease remained (TTL elapsed). Final dry-run: nothing to clean.

Leases

  • lease-841f194afd864463 reviewer PR775: released
  • lease-23f18846bb3048c7 author #617: released
  • lease-3ea53153ef714e58 author #617: expired
  • merger comment lease 80637-b0e55d7c910a: no longer active after expiry

Mutations + readback

Artifact Mutation Readback
Issue #617 labels set to bug,type:guardrail (removed status:pr-open) bug, type:guardrail
branches/review-pr-775 worktree-clean ABSENT
branches/issue-617-mutation-budget-classifier worktree-clean ABSENT
branches/baseline-master-617 worktree-clean ABSENT
local fix/issue-617-mutation-budget-classifier git branch -d (safe) PRESERVED (not fully merged)
remote fix/issue-617-mutation-budget-classifier gitea_cleanup_merged_pr_branch verified_absent
branches/cleanup-pr-775-temp temp purity gate worktree ABSENT

Comparison 174310d4 vs 29660164

Identical tree c3fa30c183 (also equals master). No unique unpublished content. Author not merge-ancestor of master; merged head is. Clean worktrees (0 dirty).

Untouched

#681, preserve refs, unrelated dirty worktrees, branches/mcp-author-clean-ns.

Control final

Clean master @ 52ded0ea71.

## Canonical Issue State STATE: terminal_cleanup_complete_with_preserved_local_branch_and_file_lock WHO_IS_NEXT: user NEXT_ACTION: No further reconciler action required for PR #775 / Issue #617. Optional operator-only follow-up if durable author issue-lock file or local non-ancestor branch ref must be force-removed outside this reconciler path. NEXT_PROMPT: ```text No agent prompt required. Terminal cleanup for PR #775 / Issue #617 is complete. Preserved: local branch fix/issue-617-mutation-budget-classifier @ 174310d4 (git branch -d refused; tree-identical to landed head); author issue-lock file for #617 (no sanctioned unlock; owner pids dead). Do not force-delete. Do not touch #681 or unrelated worktrees. ``` WHAT_HAPPENED: prgs-reconciler terminal cleanup for merged PR #775 / closed Issue #617. Gate Zero PASS at 52ded0ea. Removed residual status:pr-open. Moot merger lease 80637-b0e55d7c910a/comment 13485 assessed then found naturally expired. Removed clean worktrees review-pr-775, issue-617-mutation-budget-classifier, baseline-master-617 via scripts/worktree-clean. Deleted remote fix/issue-617-mutation-budget-classifier via gitea_cleanup_merged_pr_branch (verified_absent). Local branch -d refused (not fully merged). Author file lock preserved. WHY: Post-merge residual cleanup only; prove equivalence before removal; never force-delete; fail closed on unmerged local branch ancestry. RELATED_PRS: #775 (this PR; merge 52ded0ea); closes #617; review_id 489 APPROVED at 296601647d3f0c067a656aa55dff2793d7b0143f BLOCKERS: none for terminal cleanup of landable remote/worktree residue. Non-blocking preserves: (1) local branch fix/issue-617-mutation-budget-classifier @ 174310d4 — safe git branch -d fails despite identical tree c3fa30c1 to master/merged head; (2) file lock ~/.cache/gitea-tools/issue-locks/prgs-Scaled-Tech-Consulting-Gitea-Tools-617.json — dead author pids, no sanctioned reconciler unlock tool. VALIDATION: Gate Zero parity in_parity at 52ded0ea; whoami sysadmin/prgs-reconciler; PR closed merge_commit_sha=52ded0ea; Issue 617 closed labels=[bug,type:guardrail]; review 489 APPROVED at 29660164; trees author=merged=master=c3fa30c1; remote branch verified_absent; worktrees absent; control clean porcelain=0 @ 52ded0ea LAST_UPDATED_BY: sysadmin (prgs-reconciler) ## Terminal cleanup ledger — PR #775 / Issue #617 ### Gate Zero - Control already at 52ded0ea714b31468ba991bac61084e103b08dcb (fetch prune; FF not needed; local master == prgs/master). - Reconciler namespace connected: profile prgs-reconciler, identity sysadmin, identity_match=true. - Parity PASS: startup_head=current_head=local=live master=52ded0ea; restart_required=false; clean control checkout. ### Terminal verification - PR #775 closed/merged at merge_commit_sha 52ded0ea714b31468ba991bac61084e103b08dcb. - Issue #617 closed. - 296601647d3f0c067a656aa55dff2793d7b0143f is on live master (ancestor). - Review 489 remains historical APPROVED at merged head 29660164 (not re-reviewed). ### Moot lease - Dry-run: lease_moot=true cleanup_allowed=true session=80637-b0e55d7c910a comment=13485 head=29660164 phase=claimed. - Apply: no active lease remained (TTL elapsed). Final dry-run: nothing to clean. ### Leases - lease-841f194afd864463 reviewer PR775: released - lease-23f18846bb3048c7 author #617: released - lease-3ea53153ef714e58 author #617: expired - merger comment lease 80637-b0e55d7c910a: no longer active after expiry ### Mutations + readback | Artifact | Mutation | Readback | |---|---|---| | Issue #617 labels | set to bug,type:guardrail (removed status:pr-open) | bug, type:guardrail | | branches/review-pr-775 | worktree-clean | ABSENT | | branches/issue-617-mutation-budget-classifier | worktree-clean | ABSENT | | branches/baseline-master-617 | worktree-clean | ABSENT | | local fix/issue-617-mutation-budget-classifier | git branch -d (safe) | PRESERVED (not fully merged) | | remote fix/issue-617-mutation-budget-classifier | gitea_cleanup_merged_pr_branch | verified_absent | | branches/cleanup-pr-775-temp | temp purity gate worktree | ABSENT | ### Comparison 174310d4 vs 29660164 Identical tree c3fa30c1837b1b479da941786d01e2ee636fdeca (also equals master). No unique unpublished content. Author not merge-ancestor of master; merged head is. Clean worktrees (0 dirty). ### Untouched #681, preserve refs, unrelated dirty worktrees, branches/mcp-author-clean-ns. ### Control final Clean master @ 52ded0ea714b31468ba991bac61084e103b08dcb.
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#775