defect: gitea_adopt_merger_pr_lease duplicate verify_preflight_purity call clears capability state #548

New Issue

2026-07-08T13:34:58-05:00

jcwalker3 commented

2026-07-08 13:34:58 -05:00

Defect Report

Tool: gitea_adopt_merger_pr_lease

Observed: Duplicate call to verify_preflight_purity (or equivalent purity/capability preflight) between lease adoption checks.

This cleared the capability state accumulated by the first check, so the second check saw a "clean" slate and could not carry forward proofs.

Context (post #542 merge for #517):

Merger (sysadmin / prgs-merger, session 71085-694544fbb790, worktree branches/merge-pr542)
Lease adoption proof at comment 7152 (adopted reviewer lease from session 32547-09f40fe5cf6d, lease comment 7110)
A temporary one-line local change was applied to allow the merge run, then reverted afterward.

Requirement:

File this as a separate defect issue (not accepted workaround).
The temporary local edit must not be treated as an accepted or documented workflow path.
Fix must preserve capability state across any internal preflight calls inside adopt/adoption flows.

Related:

PR feat: require MCP-native post-merge cleanup proof (Closes #517) (#542)
Issue Require MCP-native cleanup for post-merge lease/comment/worktree cleanup (#517)
Adoption comment: #7152
Merger session: 71085-694544fbb790

Impact: Capability proofs can be lost mid-operation in lease adoption paths, requiring unsafe local patches for otherwise valid merges.

Acceptance:

Root cause identified in the adopt implementation.
No temp patches required for future adoptions.
Test coverage for capability state preservation across preflights in adoption.

## Defect Report **Tool:** `gitea_adopt_merger_pr_lease` **Observed:** Duplicate call to `verify_preflight_purity` (or equivalent purity/capability preflight) between lease adoption checks. This cleared the capability state accumulated by the first check, so the second check saw a "clean" slate and could not carry forward proofs. **Context (post #542 merge for #517):** - Merger (sysadmin / prgs-merger, session `71085-694544fbb790`, worktree `branches/merge-pr542`) - Lease adoption proof at comment `7152` (adopted reviewer lease from session `32547-09f40fe5cf6d`, lease comment `7110`) - A temporary one-line local change was applied to allow the merge run, then reverted afterward. **Requirement:** - File this as a *separate* defect issue (not accepted workaround). - The temporary local edit must not be treated as an accepted or documented workflow path. - Fix must preserve capability state across any internal preflight calls inside adopt/adoption flows. **Related:** - PR #542 - Issue #517 - Adoption comment: #7152 - Merger session: 71085-694544fbb790 **Impact:** Capability proofs can be lost mid-operation in lease adoption paths, requiring unsafe local patches for otherwise valid merges. **Acceptance:** - Root cause identified in the adopt implementation. - No temp patches required for future adoptions. - Test coverage for capability state preservation across preflights in adoption.

sysadmin referenced this issue

2026-07-08 13:45:24 -05:00

Detect stale MCP runtime before mutation tools execute #545

jcwalker3 referenced this issue

2026-07-08 13:46:54 -05:00

controller-acceptance: PR #542 / Issue #517 cleanup closed (MCP-native per #517) #549

jcwalker3 added the status:in-progress label 2026-07-08 13:56:34 -05:00

jcwalker3 commented

2026-07-08 13:56:35 -05:00

Issue claim heartbeat

kind: claim
issue: defect: gitea_adopt_merger_pr_lease duplicate verify_preflight_purity call clears capability state (#548)
branch: issue-548-fix-duplicate-preflight
phase: claimed
profile: author
pr: none
blocker: none
next_action: create worktree and begin implementation

**Issue claim heartbeat** - kind: claim - issue: #548 - branch: issue-548-fix-duplicate-preflight - phase: claimed - profile: author - pr: none - blocker: none - next_action: create worktree and begin implementation

jcwalker3 referenced this issue from a commit

2026-07-08 14:01:55 -05:00

fix: remove duplicate verify_preflight_purity in gitea_adopt_merger_pr_lease (#548)

jcwalker3 referenced a pull request that will close this issue

2026-07-08 14:05:06 -05:00

fix: remove duplicate verify_preflight_purity in gitea_adopt_merger_pr_lease (closes #548) #550

sysadmin referenced this issue

2026-07-08 14:38:19 -05:00

fix: remove duplicate verify_preflight_purity in gitea_adopt_merger_pr_lease (closes #548) #550

sysadmin referenced this issue

2026-07-08 14:57:09 -05:00

fix: remove duplicate verify_preflight_purity in gitea_adopt_merger_pr_lease (closes #548) #550