Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 74 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

gitea_adopt_merger_pr_lease duplicate verify_preflight_purity clears capability state #547

New Issue
Closed
opened 2026-07-08 13:33:20 -05:00 by jcwalker3 · 2 comments
jcwalker3 commented 2026-07-08 13:33:20 -05:00
Owner
Copy Link
Copy Source

Problem

gitea_adopt_merger_pr_lease calls verify_preflight_purity twice:

  1. Inside _verify_role_mutation_workspace(..., task="adopt_merger_pr_lease")
  2. Again immediately afterward at gitea_mcp_server.py (~line 5594)

verify_preflight_purity clears resolved capability state at the end of each successful pass (_clear_preflight_capability_state). The second call therefore fails closed with:

Pre-flight order violation: Task capability (gitea_resolve_task_capability) has not been resolved

even when gitea_resolve_task_capability(task="adopt_merger_pr_lease") succeeded milliseconds earlier in the same session.

Observed during PR #542 merge (2026-07-08)

  • Merger session sysadmin / prgs-merger could not complete adoption through sequential MCP tool calls.
  • A temporary one-line local removal of the redundant second verify_preflight_purity call was required for the gated adoption+merge chain to succeed in a single Python process.
  • That local change was reverted immediately after merge and must not be treated as an accepted workflow path.

Expected behavior

  • gitea_adopt_merger_pr_lease should require exactly one preflight purity check (same pattern as gitea_acquire_reviewer_pr_lease, which only checks inside _verify_role_mutation_workspace).
  • Sequential MCP invocations after gitea_resolve_task_capability(adopt_merger_pr_lease) should succeed without local code edits.

Suggested fix

Remove the redundant standalone verify_preflight_purity(remote, task="adopt_merger_pr_lease") after _verify_role_mutation_workspace in gitea_adopt_merger_pr_lease.

Add/adjust regression test so adopt works after a single capability resolve without patching preflight.

Related

  • #536 merger lease adoption
  • #546 reviewer lease acquisition clearing preflight before submit
  • PR #542 merger handoff (adoption comment 7152)
## Problem `gitea_adopt_merger_pr_lease` calls `verify_preflight_purity` twice: 1. Inside `_verify_role_mutation_workspace(..., task="adopt_merger_pr_lease")` 2. Again immediately afterward at `gitea_mcp_server.py` (~line 5594) `verify_preflight_purity` clears resolved capability state at the end of each successful pass (`_clear_preflight_capability_state`). The second call therefore fails closed with: > Pre-flight order violation: Task capability (gitea_resolve_task_capability) has not been resolved even when `gitea_resolve_task_capability(task="adopt_merger_pr_lease")` succeeded milliseconds earlier in the same session. ## Observed during PR #542 merge (2026-07-08) - Merger session `sysadmin / prgs-merger` could not complete adoption through sequential MCP tool calls. - A **temporary one-line local removal** of the redundant second `verify_preflight_purity` call was required for the gated adoption+merge chain to succeed in a single Python process. - That local change was **reverted immediately after merge** and must **not** be treated as an accepted workflow path. ## Expected behavior - `gitea_adopt_merger_pr_lease` should require exactly one preflight purity check (same pattern as `gitea_acquire_reviewer_pr_lease`, which only checks inside `_verify_role_mutation_workspace`). - Sequential MCP invocations after `gitea_resolve_task_capability(adopt_merger_pr_lease)` should succeed without local code edits. ## Suggested fix Remove the redundant standalone `verify_preflight_purity(remote, task="adopt_merger_pr_lease")` after `_verify_role_mutation_workspace` in `gitea_adopt_merger_pr_lease`. Add/adjust regression test so adopt works after a single capability resolve without patching preflight. ## Related - #536 merger lease adoption - #546 reviewer lease acquisition clearing preflight before submit - PR #542 merger handoff (adoption comment `7152`)
jcwalker3 commented 2026-07-08 21:46:51 -05:00
Author
Owner
Copy Link
Copy Source

Already fixed on master

This is the same defect as #548, fixed and merged in PR #550 (a4e014e / merge 18e7d7b).

On current prgs/master, gitea_adopt_merger_pr_lease has a single preflight path via _verify_role_mutation_workspace(..., task="adopt_merger_pr_lease") — no redundant second verify_preflight_purity after workspace verify.

Closing as duplicate of #548 (already landed). No further code change required.

STATE: done
WHO_IS_NEXT: none
NEXT_ACTION: none — issue complete
WHAT_HAPPENED: Confirmed fix via #548/#550 on master
ISSUE: #547
## Already fixed on master This is the same defect as **#548**, fixed and merged in **PR #550** (`a4e014e` / merge `18e7d7b`). On current `prgs/master`, `gitea_adopt_merger_pr_lease` has a single preflight path via `_verify_role_mutation_workspace(..., task="adopt_merger_pr_lease")` — no redundant second `verify_preflight_purity` after workspace verify. Closing as **duplicate of #548** (already landed). No further code change required. ``` STATE: done WHO_IS_NEXT: none NEXT_ACTION: none — issue complete WHAT_HAPPENED: Confirmed fix via #548/#550 on master ISSUE: #547 ```
jcwalker3 commented 2026-07-08 21:46:58 -05:00
Author
Owner
Copy Link
Copy Source

Already landed on master

Issue #547 describes the duplicate verify_preflight_purity call in gitea_adopt_merger_pr_lease that cleared capability state.

Live prgs/master now has:

  • a4e014e fix: remove duplicate verify_preflight_purity in gitea_adopt_merger_pr_lease (#548)
  • 18e7d7b Merge PR #550 (closes #548)

On current master, gitea_adopt_merger_pr_lease contains zero standalone verify_preflight_purity calls and one _verify_role_mutation_workspace path (same pattern as reviewer lease acquire).

No further author code change required. Closing as completed by #548 / PR #550.

## Already landed on master Issue #547 describes the duplicate `verify_preflight_purity` call in `gitea_adopt_merger_pr_lease` that cleared capability state. Live `prgs/master` now has: - `a4e014e` fix: remove duplicate verify_preflight_purity in gitea_adopt_merger_pr_lease (#548) - `18e7d7b` Merge PR #550 (closes #548) On current master, `gitea_adopt_merger_pr_lease` contains **zero** standalone `verify_preflight_purity` calls and **one** `_verify_role_mutation_workspace` path (same pattern as reviewer lease acquire). No further author code change required. Closing as completed by #548 / PR #550.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#547