Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Reviewer lease acquisition clears preflight capability token needed by gitea_submit_pr_review #546

New Issue
Closed
opened 2026-07-08 13:05:58 -05:00 by jcwalker3 · 1 comment
jcwalker3 commented 2026-07-08 13:05:58 -05:00
Owner
Copy Link
Copy Source

Defect Summary

The Gitea MCP server review workflow contains a pre-flight capability token deadlock:

  1. Calling gitea_resolve_task_capability(task="review_pr") sets the capability proof but clears the in-session lease (via reviewer_pr_lease.clear_session_lease() in init_review_decision_lock).
  2. Calling gitea_acquire_reviewer_pr_lease sets the in-session lease but triggers preflight verification which clears the task capability proof (_preflight_capability_called).
  3. As a result, both requirements of gitea_submit_pr_review (resolved capability proof AND active in-session lease) cannot be satisfied concurrently.

This deadlock forces operators to either bypass the validation or get stuck in a preflight failure loop when trying to submit reviews.

Steps to Reproduce

  1. Call gitea_resolve_task_capability(task="review_pr").
  2. Call gitea_acquire_reviewer_pr_lease to adopt the active lease.
  3. Call gitea_submit_pr_review. The tool fails closed because the capability proof was cleared when the lease was acquired.
  4. Call gitea_resolve_task_capability(task="review_pr") again. This clears the lease in memory, causing gitea_submit_pr_review to fail closed due to missing lease.
### Defect Summary The Gitea MCP server review workflow contains a pre-flight capability token deadlock: 1. Calling `gitea_resolve_task_capability(task="review_pr")` sets the capability proof but clears the in-session lease (via `reviewer_pr_lease.clear_session_lease()` in `init_review_decision_lock`). 2. Calling `gitea_acquire_reviewer_pr_lease` sets the in-session lease but triggers preflight verification which clears the task capability proof (`_preflight_capability_called`). 3. As a result, both requirements of `gitea_submit_pr_review` (resolved capability proof AND active in-session lease) cannot be satisfied concurrently. This deadlock forces operators to either bypass the validation or get stuck in a preflight failure loop when trying to submit reviews. ### Steps to Reproduce 1. Call `gitea_resolve_task_capability(task="review_pr")`. 2. Call `gitea_acquire_reviewer_pr_lease` to adopt the active lease. 3. Call `gitea_submit_pr_review`. The tool fails closed because the capability proof was cleared when the lease was acquired. 4. Call `gitea_resolve_task_capability(task="review_pr")` again. This clears the lease in memory, causing `gitea_submit_pr_review` to fail closed due to missing lease.
jcwalker3 added the status:in-progress label 2026-07-08 14:32:08 -05:00
jcwalker3 commented 2026-07-08 14:32:08 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: claim - issue: #546 - branch: fix/issue-546-reviewer-lease-preflight - phase: claimed - profile: prgs-author - pr: none - blocker: none - next_action: create worktree and begin implementation
jcwalker3 removed the status:in-progress label 2026-07-08 14:33:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#546