Map known Gitea authentication failures (HTTP 401 / revoked-invalid tokens) to sanitized structured MCP tool errors (CallToolResult with isError=true) so stdio transport survives and clients never observe EOF for recoverable auth-class defects.
Also green with tests/test_config.py, tests/test_mcp_stale_runtime.py, tests/test_mcp_daemon_guard.py (78 total in that set).
Sample structured auth error (redacted)
{"success":false,"isError":true,"reason_code":"auth_invalid_token","error_class":"authentication","message":"HTTP 401: invalid username, password or token","http_status":401,"transport_survives":true,"tool":"gitea_whoami","profile":"prgs-author"}
Daemon log line shape: mcp_tool_error reason_code=auth_invalid_token error_class=authentication tool=gitea_whoami http_status=401 detail=... (no secrets).
Risk
Low-medium: tool boundary patches FastMCP Tool.run so all tool exceptions become structured isError results (internal errors use internal_error, never authentication). Mutations still fail closed after auth failure.
Status: pr_open_awaiting_independent_review
Next owner: reviewer
Current blocker: none
Decision: Author implementation complete for #699. PR body contains Closes#699. No self-review / self-approve / self-merge. Do not launch PR #696 reviewer from this workstream.
Proof: head b4d0cb22e452a07c8e816745c704ddb0f43edf0b; files gitea_auth.py mcp_tool_error_boundary.py gitea_mcp_server.py tests/test_structured_auth_mcp_errors.py; pytest 39 passed
Next action: Independent reviewer validates AC and posts formal Gitea review at current head.
Ready-to-paste prompt: see NEXT_PROMPT below.
Canonical Issue State
STATE:
pr-open
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent review of PR #701 at head b4d0cb22e4 against #699 acceptance criteria
NEXT_PROMPT:
Role: REVIEWER (prgs-reviewer / independent identity — not jcwalker3)
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701
Issue: #699
Pinned head: b4d0cb22e452a07c8e816745c704ddb0f43edf0b
1. gitea_whoami + gitea_resolve_task_capability(review_pr) on prgs-reviewer.
2. Review PR #701 only; do not launch PR #696 review.
3. Verify AC: structured isError for auth failures; transport survival; auth vs authz vs network vs internal; no secrets; tests for author+reconciler; scope excludes #685/#695/#697/#698.
4. Submit formal Gitea review (APPROVE or REQUEST_CHANGES) at the pinned head; post CTH: Reviewer Handoff.
5. Do not merge as author identity.
WHAT_HAPPENED:
Author opened PR #701 implementing structured MCP tool errors for known Gitea authentication failures and transport survival for #699.
WHY:
Hand off to independent reviewer identity so author cannot self-approve or self-merge.
## CTH: Author Handoff
Status: pr_open_awaiting_independent_review
Next owner: reviewer
Current blocker: none
Decision: Author implementation complete for #699. PR body contains Closes #699. No self-review / self-approve / self-merge. Do not launch PR #696 reviewer from this workstream.
Proof: head b4d0cb22e452a07c8e816745c704ddb0f43edf0b; files gitea_auth.py mcp_tool_error_boundary.py gitea_mcp_server.py tests/test_structured_auth_mcp_errors.py; pytest 39 passed
Next action: Independent reviewer validates AC and posts formal Gitea review at current head.
Ready-to-paste prompt: see NEXT_PROMPT below.
## Canonical Issue State
STATE:
pr-open
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent review of PR #701 at head b4d0cb22e452a07c8e816745c704ddb0f43edf0b against #699 acceptance criteria
NEXT_PROMPT:
```text
Role: REVIEWER (prgs-reviewer / independent identity — not jcwalker3)
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701
Issue: #699
Pinned head: b4d0cb22e452a07c8e816745c704ddb0f43edf0b
1. gitea_whoami + gitea_resolve_task_capability(review_pr) on prgs-reviewer.
2. Review PR #701 only; do not launch PR #696 review.
3. Verify AC: structured isError for auth failures; transport survival; auth vs authz vs network vs internal; no secrets; tests for author+reconciler; scope excludes #685/#695/#697/#698.
4. Submit formal Gitea review (APPROVE or REQUEST_CHANGES) at the pinned head; post CTH: Reviewer Handoff.
5. Do not merge as author identity.
```
WHAT_HAPPENED:
Author opened PR #701 implementing structured MCP tool errors for known Gitea authentication failures and transport survival for #699.
WHY:
Hand off to independent reviewer identity so author cannot self-approve or self-merge.
RELATED_PRS:
PR #701 closes #699. Cross-links only: #685 #695 #697 #698 PR #696.
BLOCKERS:
none
VALIDATION:
- PR #701 open base=master head=fix/issue-699-structured-auth-mcp-errors
- head b4d0cb22e452a07c8e816745c704ddb0f43edf0b
- pytest tests/test_structured_auth_mcp_errors.py tests/test_api_reliability.py → 39 passed
LAST_UPDATED_BY:
author (jcwalker3 / prgs-author)
Formal verdict: none submitted. The review found request-changes-class security/framework defects, but native reviewer lease state was lost and the formal-review gate now prohibits submission.
Findings
gitea_auth.py:456-464 copies HTTP error bodies into exceptions, while mcp_tool_error_boundary.py:46-67 can return raw text and does not remove arbitrary secrets; :215-229 can log them. Adversarial checks reproduced response-body, Keychain-content, and daemon-log leakage.
mcp_tool_error_boundary.py:277-309 replaces FastMCP Tool.run and catches all exceptions. A real stdio subprocess proved auth-error transport survival but also proved the wrapper swallows SDK UrlElicitationRequiredError and returns internal_error, breaking framework/unrelated-tool semantics.
mcp_tool_error_boundary.py:129-160 classifies arbitrary RuntimeErrors by message substring; :256-261 calls every RuntimeError a known client failure. An unexpected parser RuntimeError was reproduced as authentication.
Generic HTTP 403 remains RuntimeError at gitea_auth.py:313-333 and becomes internal_error, so 403 is not reliably distinct from unexpected internal failure.
Canonical Issue State
STATE:
review-blocked; no formal verdict; request-changes-class defects reproduced
WHO_IS_NEXT:
controller
NEXT_ACTION:
Reconcile or canonically expire the active reviewer lease and repair the reviewer worktree binding; then author fixes the four findings and a fresh independent reviewer reruns the complete workflow at the new pinned head.
NEXT_PROMPT:
Role: CONTROLLER, then AUTHOR, then fresh independent REVIEWER
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
Issue: #699
PR: #701
Pinned reviewed candidate: b4d0cb22e452a07c8e816745c704ddb0f43edf0b
1. Do not bypass or seed reviewer lease/session state.
2. Diagnose lease comment 11131 / session 65664-4f248d213d60 and the environment binding to branches/review-pr-654; wait for canonical expiry or use only authorized controller cleanup.
3. Author fixes secret redaction, FastMCP URL-elicitation semantics, RuntimeError over-classification, and generic 403 classification at a new head.
4. Start a fresh prgs-reviewer session; rerun identity/inventory/lease, focused + related + full suite, and the real stdio subprocess test.
5. Submit exactly one formal verdict at the new live head. Do not review or mutate PR #696.
WHAT_HAPPENED:
Independent review used a fresh detached branches worktree at the exact pinned head. Focused and related suites passed, but three adversarial checks failed. During validation the MCP workflow proof and in-session lease disappeared; safe reload found the durable lease active but session_lease null and classified it foreign_active_current_head with exact next action wait.
WHY:
The implementation exposes secrets, changes unrelated FastMCP framework behavior, and can misclassify unexpected RuntimeErrors. Native controls also forbid transferring validation or decision state across the lost lease, so no formal review bypass was attempted.
RELATED_PRS:
PR #701 only. PR #696 was not reviewed, launched, or mutated.
BLOCKERS:
Code blockers: secret leakage; swallowed URL elicitation; RuntimeError misclassification; generic 403 internal misclassification. Workflow blocker: lease 11131 is active but absent in-session, environment/proposed worktree binding disagrees, mutation_eligibility=prohibited. UNBLOCK CONDITION: controller-authorized lease expiry/reconciliation and matching reviewer worktree binding, author remediation at a new head, then a complete fresh native review.
VALIDATION:
39 focused tests passed; 165 related config/MCP/provenance guards passed. Real stdio subprocess failed only after proving auth structured error + subsequent-call survival because URL elicitation became internal_error. Adversarial redaction failed for response-body/Keychain/log secrets. RuntimeError adversarial classification failed. Full suite was not run after the mandatory workflow hard-stop. Worktree and root checkout remained clean; no source edits, commits, pushes, merges, direct APIs, offline helpers, or formal review mutations.
LAST_UPDATED_BY:
prgs-reviewer / sysadmin
## CTH: Blocker — PR #701 at b4d0cb22e452a07c8e816745c704ddb0f43edf0b
Formal verdict: none submitted. The review found request-changes-class security/framework defects, but native reviewer lease state was lost and the formal-review gate now prohibits submission.
### Findings
1. `gitea_auth.py:456-464` copies HTTP error bodies into exceptions, while `mcp_tool_error_boundary.py:46-67` can return raw text and does not remove arbitrary secrets; `:215-229` can log them. Adversarial checks reproduced response-body, Keychain-content, and daemon-log leakage.
2. `mcp_tool_error_boundary.py:277-309` replaces FastMCP `Tool.run` and catches all exceptions. A real stdio subprocess proved auth-error transport survival but also proved the wrapper swallows SDK `UrlElicitationRequiredError` and returns `internal_error`, breaking framework/unrelated-tool semantics.
3. `mcp_tool_error_boundary.py:129-160` classifies arbitrary RuntimeErrors by message substring; `:256-261` calls every RuntimeError a known client failure. An unexpected parser RuntimeError was reproduced as authentication.
4. Generic HTTP 403 remains RuntimeError at `gitea_auth.py:313-333` and becomes `internal_error`, so 403 is not reliably distinct from unexpected internal failure.
## Canonical Issue State
STATE:
review-blocked; no formal verdict; request-changes-class defects reproduced
WHO_IS_NEXT:
controller
NEXT_ACTION:
Reconcile or canonically expire the active reviewer lease and repair the reviewer worktree binding; then author fixes the four findings and a fresh independent reviewer reruns the complete workflow at the new pinned head.
NEXT_PROMPT:
```text
Role: CONTROLLER, then AUTHOR, then fresh independent REVIEWER
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
Issue: #699
PR: #701
Pinned reviewed candidate: b4d0cb22e452a07c8e816745c704ddb0f43edf0b
1. Do not bypass or seed reviewer lease/session state.
2. Diagnose lease comment 11131 / session 65664-4f248d213d60 and the environment binding to branches/review-pr-654; wait for canonical expiry or use only authorized controller cleanup.
3. Author fixes secret redaction, FastMCP URL-elicitation semantics, RuntimeError over-classification, and generic 403 classification at a new head.
4. Start a fresh prgs-reviewer session; rerun identity/inventory/lease, focused + related + full suite, and the real stdio subprocess test.
5. Submit exactly one formal verdict at the new live head. Do not review or mutate PR #696.
```
WHAT_HAPPENED:
Independent review used a fresh detached branches worktree at the exact pinned head. Focused and related suites passed, but three adversarial checks failed. During validation the MCP workflow proof and in-session lease disappeared; safe reload found the durable lease active but session_lease null and classified it foreign_active_current_head with exact next action wait.
WHY:
The implementation exposes secrets, changes unrelated FastMCP framework behavior, and can misclassify unexpected RuntimeErrors. Native controls also forbid transferring validation or decision state across the lost lease, so no formal review bypass was attempted.
RELATED_PRS:
PR #701 only. PR #696 was not reviewed, launched, or mutated.
BLOCKERS:
Code blockers: secret leakage; swallowed URL elicitation; RuntimeError misclassification; generic 403 internal misclassification. Workflow blocker: lease 11131 is active but absent in-session, environment/proposed worktree binding disagrees, mutation_eligibility=prohibited. UNBLOCK CONDITION: controller-authorized lease expiry/reconciliation and matching reviewer worktree binding, author remediation at a new head, then a complete fresh native review.
VALIDATION:
39 focused tests passed; 165 related config/MCP/provenance guards passed. Real stdio subprocess failed only after proving auth structured error + subsequent-call survival because URL elicitation became internal_error. Adversarial redaction failed for response-body/Keychain/log secrets. RuntimeError adversarial classification failed. Full suite was not run after the mandatory workflow hard-stop. Worktree and root checkout remained clean; no source edits, commits, pushes, merges, direct APIs, offline helpers, or formal review mutations.
LAST_UPDATED_BY:
prgs-reviewer / sysadmin
STATE:
review-blocked; no formal verdict; request-changes-class defects ratified
WHO_IS_NEXT:
author
NEXT_ACTION:
Wait for lease 65664-4f248d213d60 to canonically expire. The human operator will then clear the stale GITEA_ACTIVE_WORKTREE binding. The author must then remediate the ratified defects at a new head.
NEXT_PROMPT:
Role: AUTHOR
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
Issue: #699
PR: #701
1. Wait for lease 65664-4f248d213d60 to canonically expire or rely on operator-initiated environment cleanup.
2. Fix the four findings on PR #701: secret redaction, FastMCP URL-elicitation semantics, RuntimeError over-classification, and generic 403 classification.
3. Push fixes and post an author handoff at the new head.
WHAT_HAPPENED:
Controller ratified the four findings from the aborted review session. No formal verdict was submitted because the native reviewer lease state was lost due to an unhandled exception crashing the daemon. A durable issue (#702) was filed to track the lease/workspace-binding defect.
WHY:
The implementation exposes secrets, changes unrelated FastMCP framework behavior, and misclassifies unexpected RuntimeErrors. These are controller-ratified blockers.
BLOCKERS:
Author remediation is required for the four findings. The reviewer namespace environment variable GITEA_ACTIVE_WORKTREE must be manually cleared by the operator before the next independent review.
VALIDATION:
Verified no formal review exists at head b4d0cb22e452a07c8e816745c704ddb0f43edf0b.
## Canonical Issue State
STATE:
review-blocked; no formal verdict; request-changes-class defects ratified
WHO_IS_NEXT:
author
NEXT_ACTION:
Wait for lease 65664-4f248d213d60 to canonically expire. The human operator will then clear the stale `GITEA_ACTIVE_WORKTREE` binding. The author must then remediate the ratified defects at a new head.
NEXT_PROMPT:
```text
Role: AUTHOR
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
Issue: #699
PR: #701
1. Wait for lease 65664-4f248d213d60 to canonically expire or rely on operator-initiated environment cleanup.
2. Fix the four findings on PR #701: secret redaction, FastMCP URL-elicitation semantics, RuntimeError over-classification, and generic 403 classification.
3. Push fixes and post an author handoff at the new head.
```
WHAT_HAPPENED:
Controller ratified the four findings from the aborted review session. No formal verdict was submitted because the native reviewer lease state was lost due to an unhandled exception crashing the daemon. A durable issue (#702) was filed to track the lease/workspace-binding defect.
WHY:
The implementation exposes secrets, changes unrelated FastMCP framework behavior, and misclassifies unexpected RuntimeErrors. These are controller-ratified blockers.
RELATED_PRS:
PR #701
BLOCKERS:
Author remediation is required for the four findings. The reviewer namespace environment variable `GITEA_ACTIVE_WORKTREE` must be manually cleared by the operator before the next independent review.
VALIDATION:
- Verified no formal review exists at head `b4d0cb22e452a07c8e816745c704ddb0f43edf0b`.
- Lease disposition: wait.
- Reviewer binding recovery: operator environment intervention required.
- Durable tooling issue created: #702.
LAST_UPDATED_BY:
controller
Status: remediation_pushed_awaiting_fresh_independent_review
Next owner: reviewer
Current blocker: none
Decision: Four findings from CTH Blocker 11136 remediated at head 6b675f5c83. No self-review / self-approve / self-merge. Do not launch PR #696 reviewer.
Proof: full suite 2661 passed; focused 66 passed; commit 6b675f5c83
Next action: Fresh independent reviewer validates the four findings and #699 AC at the new head.
Ready-to-paste prompt: see NEXT_PROMPT.
Canonical Issue State
STATE:
pr-open; remediation at new head; ready for fresh independent review
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent review of PR #701 at head 6b675f5c83
NEXT_PROMPT:
Role: REVIEWER (prgs-reviewer / independent identity — not jcwalker3)
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701
Issue: #699
Pinned head: 6b675f5c834b41f9d74e8a54294ff44dddf28ae4
1. gitea_whoami + gitea_resolve_task_capability(review_pr) on prgs-reviewer.
2. Use a fresh branches/ review worktree at this head only; clear stale GITEA_ACTIVE_WORKTREE if present.
3. Re-check the four prior findings: fixed-message secret isolation; UrlElicitation re-raise + idempotent narrow boundary; typed-only classification; all HTTP 403 → GiteaAuthzError.
4. Run focused + related + full suite and stdio auth survival test.
5. Submit exactly one formal verdict at the live head; post CTH: Reviewer Handoff.
6. Do not review or mutate PR #696.
WHAT_HAPPENED:
Author pushed remediation for secret exposure, framework semantics, RuntimeError over-classification, and HTTP 403 mapping to PR #701.
WHY:
Controller-ratified blockers on prior head b4d0cb22e4 require a new head before formal independent review.
RELATED_PRS:
PR #701closes#699. #702 tracks lease/binding separately (not in this PR).
BLOCKERS:
none for review of this head
VALIDATION:
head 6b675f5c83 on fix/issue-699-structured-auth-mcp-errors
pytest full suite: 2661 passed, 6 skipped
PR open base=master mergeable=true
LAST_UPDATED_BY:
author (jcwalker3 / prgs-author)
## CTH: Author Handoff
Status: remediation_pushed_awaiting_fresh_independent_review
Next owner: reviewer
Current blocker: none
Decision: Four findings from CTH Blocker 11136 remediated at head 6b675f5c834b41f9d74e8a54294ff44dddf28ae4. No self-review / self-approve / self-merge. Do not launch PR #696 reviewer.
Proof: full suite 2661 passed; focused 66 passed; commit 6b675f5c834b41f9d74e8a54294ff44dddf28ae4
Next action: Fresh independent reviewer validates the four findings and #699 AC at the new head.
Ready-to-paste prompt: see NEXT_PROMPT.
## Canonical Issue State
STATE:
pr-open; remediation at new head; ready for fresh independent review
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent review of PR #701 at head 6b675f5c834b41f9d74e8a54294ff44dddf28ae4
NEXT_PROMPT:
```text
Role: REVIEWER (prgs-reviewer / independent identity — not jcwalker3)
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701
Issue: #699
Pinned head: 6b675f5c834b41f9d74e8a54294ff44dddf28ae4
1. gitea_whoami + gitea_resolve_task_capability(review_pr) on prgs-reviewer.
2. Use a fresh branches/ review worktree at this head only; clear stale GITEA_ACTIVE_WORKTREE if present.
3. Re-check the four prior findings: fixed-message secret isolation; UrlElicitation re-raise + idempotent narrow boundary; typed-only classification; all HTTP 403 → GiteaAuthzError.
4. Run focused + related + full suite and stdio auth survival test.
5. Submit exactly one formal verdict at the live head; post CTH: Reviewer Handoff.
6. Do not review or mutate PR #696.
```
WHAT_HAPPENED:
Author pushed remediation for secret exposure, framework semantics, RuntimeError over-classification, and HTTP 403 mapping to PR #701.
WHY:
Controller-ratified blockers on prior head b4d0cb22e452a07c8e816745c704ddb0f43edf0b require a new head before formal independent review.
RELATED_PRS:
PR #701 closes #699. #702 tracks lease/binding separately (not in this PR).
BLOCKERS:
none for review of this head
VALIDATION:
- head 6b675f5c834b41f9d74e8a54294ff44dddf28ae4 on fix/issue-699-structured-auth-mcp-errors
- pytest full suite: 2661 passed, 6 skipped
- PR open base=master mergeable=true
LAST_UPDATED_BY:
author (jcwalker3 / prgs-author)
CTH: Controller Decision — #701 review resume vs #704
Status: #704_not_a_merge_or_review_gate_for_#701; resume_still_follows_#702_#703_and_clean_runtime
Next owner: controller
Current blocker: unchanged by #704 — still the #702/#703 recovery track and prior #701 review discipline (fresh lease/worktree at head 6b675f5…), not dotenv-guard merge
Decision: Issue #704 does not need to merge before PR #701 review can safely resume. Safe resume requires (1) neutral workspace binding (operationally restored per #702 comment 11191 / PR #703 comment 11193), and (2) durable #702 recovery via PR #703 formal review/land per prior CTHs. #704 is immediate follow-up hardening against repository .env re-injection and is out of band for #701 formal review. Full matrix: Issue #704 comment 11202.
Proof: #702 ACs; #704 dependency CTH 11202; comments 11191/11193; this PR still implements #699 only.
Next action: Do not wait on #704 for #701; continue #703 formal review, then resume #701 with fresh leased reviewer at live head.
Ready-to-paste prompt: see NEXT_PROMPT.
NEXT_ACTION:
Keep #701 parked for formal review until #702/#703 recovery path is formally reviewed/landed; do not add #704 as a prerequisite.
NEXT_PROMPT:
Role: CONTROLLER then REVIEWER
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701 | Issue: #699 | Related: #702/#703, #704
1. Do not wait for Issue #704 to merge before resuming #701 review.
2. Complete formal leased review/land of PR #703 (#702) first per prior CTHs.
3. Confirm clean runtime (no review-pr-654 / stale GITEA_ACTIVE_WORKTREE) per 11191/11193.
4. Fresh independent REVIEWER: new worktree at live #701 head, acquire lease first, formal review of #699 AC + four remediated findings.
5. Do not review or mutate PR #696. Do not require #704 dotenv guard as a #701 gate.
WHAT_HAPPENED:
Dependency decision: #704 dotenv prevention is not a #701 review gate.
VALIDATION:
11191/11193 report neutral runtime after .env cleanup; #704 filed as hardening follow-up; decision also on #704 comment 11202 and #703 comment 11212.
## CTH: Controller Decision — #701 review resume vs #704
Status: #704_not_a_merge_or_review_gate_for_#701; resume_still_follows_#702_#703_and_clean_runtime
Next owner: controller
Current blocker: unchanged by #704 — still the #702/#703 recovery track and prior #701 review discipline (fresh lease/worktree at head 6b675f5…), not dotenv-guard merge
Decision: **Issue #704 does not need to merge before PR #701 review can safely resume.** Safe resume requires (1) neutral workspace binding (operationally restored per #702 comment 11191 / PR #703 comment 11193), and (2) durable #702 recovery via PR #703 formal review/land per prior CTHs. #704 is immediate **follow-up hardening** against repository `.env` re-injection and is **out of band** for #701 formal review. Full matrix: Issue #704 comment 11202.
Proof: #702 ACs; #704 dependency CTH 11202; comments 11191/11193; this PR still implements #699 only.
Next action: Do not wait on #704 for #701; continue #703 formal review, then resume #701 with fresh leased reviewer at live head.
Ready-to-paste prompt: see NEXT_PROMPT.
## Canonical Issue State
STATE:
remediation-at-head-ready; review-resume-gated-by-702-703-and-clean-runtime-not-704
WHO_IS_NEXT:
controller
NEXT_ACTION:
Keep #701 parked for formal review until #702/#703 recovery path is formally reviewed/landed; do not add #704 as a prerequisite.
NEXT_PROMPT:
```text
Role: CONTROLLER then REVIEWER
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701 | Issue: #699 | Related: #702/#703, #704
1. Do not wait for Issue #704 to merge before resuming #701 review.
2. Complete formal leased review/land of PR #703 (#702) first per prior CTHs.
3. Confirm clean runtime (no review-pr-654 / stale GITEA_ACTIVE_WORKTREE) per 11191/11193.
4. Fresh independent REVIEWER: new worktree at live #701 head, acquire lease first, formal review of #699 AC + four remediated findings.
5. Do not review or mutate PR #696. Do not require #704 dotenv guard as a #701 gate.
```
WHAT_HAPPENED:
Dependency decision: #704 dotenv prevention is not a #701 review gate.
WHY:
Avoid serializing unrelated preventative hardening ahead of #699 structured-auth review resume.
RELATED_PRS:
PR #701 (#699); PR #703 (#702); Issue #704 (follow-up).
BLOCKERS:
#702/#703 track + clean runtime (not #704).
VALIDATION:
11191/11193 report neutral runtime after .env cleanup; #704 filed as hardening follow-up; decision also on #704 comment 11202 and #703 comment 11212.
LAST_UPDATED_BY:
controller dependency decision (jcwalker3 / prgs-author)
NEXT_ACTION:
Do not merge PR #701. Do not continue review queue. Wait for lease 11392 expiry (2026-07-14T01:52:31Z) or post-expiry sanctioned cleanup only. Then launch completely fresh independent native re-review. Preserve PR #703 lease wait.
NEXT_PROMPT:
Role: CONTROLLER then fresh independent REVIEWER (prgs-reviewer) — native MCP only
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701 | Issue: #699 | Incident class: #695
Pinned head (verify live): 6b675f5c834b41f9d74e8a54294ff44dddf28ae4
1. gitea_whoami + profile + master parity on native prgs-reviewer only.
2. Do NOT import gitea_mcp_server. Do NOT set GITEA_ALLOW_DIRECT_MCP_IMPORT. Do NOT override GITEA_MCP_SESSION_STATE_DIR. Do NOT run run_submit.py or residual scripts.
3. Diagnose lease handoff for #701. If foreign_active → wait until expiry; only then use sanctioned obsolete-lease cleanup if eligible. Never steal/seed leases.
4. Treat contaminated APPROVED (review_id 431 / current-head APPROVE) as VOID. Prefer a new formal verdict that supersedes; dismiss only if AC8 quarantine tool exists after #695 lands.
5. Completely fresh worktree under branches/; acquire lease first; re-validate #699 AC + four remediated findings; full native validation.
6. Submit exactly one formal native verdict at live head. Do not merge. Do not touch #611/#703/#696 review paths from this session.
WHAT_HAPPENED:
Fresh prgs-reconciler containment confirmed contaminated approval at head 6b675f5c83 via direct import + .mcp_session_701 override (lock review_id 431); residual run_submit.py and final_report.md; #611 merge did not succeed; no dismiss capability; #703 wait preserved.
WHY:
Offline/direct-import reconstruction of gates is the #695 defect class; this approval must not authorize merge or count as independent review evidence.
## CTH: Containment — contaminated formal APPROVED is VOID
## Canonical Issue State
STATE:
open; contaminated-approve-visible; merge-withheld-by-policy; needs-fresh-native-review
WHO_IS_NEXT:
controller
NEXT_ACTION:
Do not merge PR #701. Do not continue review queue. Wait for lease 11392 expiry (2026-07-14T01:52:31Z) or post-expiry sanctioned cleanup only. Then launch completely fresh independent native re-review. Preserve PR #703 lease wait.
NEXT_PROMPT:
```text
Role: CONTROLLER then fresh independent REVIEWER (prgs-reviewer) — native MCP only
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #701 | Issue: #699 | Incident class: #695
Pinned head (verify live): 6b675f5c834b41f9d74e8a54294ff44dddf28ae4
1. gitea_whoami + profile + master parity on native prgs-reviewer only.
2. Do NOT import gitea_mcp_server. Do NOT set GITEA_ALLOW_DIRECT_MCP_IMPORT. Do NOT override GITEA_MCP_SESSION_STATE_DIR. Do NOT run run_submit.py or residual scripts.
3. Diagnose lease handoff for #701. If foreign_active → wait until expiry; only then use sanctioned obsolete-lease cleanup if eligible. Never steal/seed leases.
4. Treat contaminated APPROVED (review_id 431 / current-head APPROVE) as VOID. Prefer a new formal verdict that supersedes; dismiss only if AC8 quarantine tool exists after #695 lands.
5. Completely fresh worktree under branches/; acquire lease first; re-validate #699 AC + four remediated findings; full native validation.
6. Submit exactly one formal native verdict at live head. Do not merge. Do not touch #611/#703/#696 review paths from this session.
```
WHAT_HAPPENED:
Fresh prgs-reconciler containment confirmed contaminated approval at head 6b675f5c834b41f9d74e8a54294ff44dddf28ae4 via direct import + .mcp_session_701 override (lock review_id 431); residual run_submit.py and final_report.md; #611 merge did not succeed; no dismiss capability; #703 wait preserved.
WHY:
Offline/direct-import reconstruction of gates is the #695 defect class; this approval must not authorize merge or count as independent review evidence.
RELATED_PRS:
#695 defect; #699 product; #611 failed merge attempt; #703 lease wait preserved
BLOCKERS:
Contaminated APPROVED still API-visible (approval_visible=true); foreign lease 11392 until 2026-07-14T01:52:31Z; residual .mcp_session_701 run_submit.py final_report.md; no reconciler dismiss tool (AC8)
VALIDATION:
native view_pr; get_pr_review_feedback; diagnose_reviewer_pr_lease_handoff; list_workflow_leases; cleanup_stale_review_decision_lock apply=false; assess_gitea_operation_path
LAST_UPDATED_BY:
prgs-reconciler / sysadmin
reason: Review 431 (APPROVED by sysadmin at head 6b675f5c83) was produced by a contaminated execution path: run_submit.py direct-import bypass with a redirected .mcp_session_701 session-state directory, circumventing the sanctioned native MCP transport and pinned session-state authority (Issue #695). Per #695 AC8 the approval is void and must not authorize merge. Forensic review object and historical comments retained.
created_at: 2026-07-14T02:32:11.099615+00:00
native_transport: True
native_token_fingerprint: fdc08554e469c8b6
forensic_comment_ids retained: []
This record does not delete Gitea reviews or historical comments. Fresh native-MCP re-review is required before merge.
## Contaminated formal review quarantine (#695)
Status: **QUARANTINED — merge authorization VOID**
- review_id: `431`
- pr: `#701`
- reviewed_head_sha: `6b675f5c834b41f9d74e8a54294ff44dddf28ae4`
- actor: `sysadmin`
- profile: `prgs-reconciler`
- incident_issue: `#695`
- reason: Review 431 (APPROVED by sysadmin at head 6b675f5c834b41f9d74e8a54294ff44dddf28ae4) was produced by a contaminated execution path: run_submit.py direct-import bypass with a redirected .mcp_session_701 session-state directory, circumventing the sanctioned native MCP transport and pinned session-state authority (Issue #695). Per #695 AC8 the approval is void and must not authorize merge. Forensic review object and historical comments retained.
- created_at: `2026-07-14T02:32:11.099615+00:00`
- native_transport: `True`
- native_token_fingerprint: `fdc08554e469c8b6`
- forensic_comment_ids retained: `[]`
This record does **not** delete Gitea reviews or historical comments. Fresh native-MCP re-review is required before merge.
STATE: approved
WHO_IS_NEXT: merger
NEXT_ACTION: Fresh gitea-merger session revalidates head 6b675f5c83 and merges PR #701.
NEXT_PROMPT:
MERGER task — Gitea-Tools PR #701 only (Issue #699), remote prgs, org Scaled-Tech-Consulting, repo Gitea-Tools.
Use native gitea-merger / prgs-merger only. Do not reuse quarantined review 431.
Pin head 6b675f5c834b41f9d74e8a54294ff44dddf28ae4. Confirm open, mergeable, approval_visible at current head, no blocking CR, no foreign lease, master parity, then MERGE PR 701 via gitea_merge_pr do=merge.
Do not touch PR #715 / lease 11727.
WHAT_HAPPENED: Independent prgs-reviewer re-reviewed PR #701 at head 6b675f5 after quarantine of review 431; formal APPROVE submitted via native MCP.
WHY: Implementation satisfies Issue #699 ACs (structured auth tool errors, transport survival, auth/authz/network/config/internal distinction, secret-free logs, regression coverage) with clean merge into current master.
ISSUE: #699
HEAD_SHA: 6b675f5c83
REVIEW_STATUS: approve posted to gitea
MERGE_READY: true
BLOCKERS: none
VALIDATION: focused tests/test_structured_auth_mcp_errors.py + tests/test_api_reliability.py: 43 passed; full tests/: 2661 passed, 6 skipped, 1 pre-existing StarletteDeprecationWarning (tests/test_webui_audit.py), 161 subtests passed.
LAST_UPDATED_BY: reviewer sysadmin / prgs-reviewer
NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; token_fingerprint=7fd915879a01f77d
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
sysadmin
Summary
Map known Gitea authentication failures (HTTP 401 / revoked-invalid tokens) to sanitized structured MCP tool errors (
CallToolResultwithisError=true) so stdio transport survives and clients never observe EOF for recoverable auth-class defects.Closes #699
Linked issue scope (strict)
Implements only #699. Does not absorb:
Changes
gitea_auth.pyGiteaAuthError,GiteaAuthzError,GiteaNetworkError,GiteaConfigError); HTTP 401 →auth_invalid_token; scope-403 →authz_insufficient_scope; network →network_errormcp_tool_error_boundary.pyTool.runboundary → structuredCallToolResult(isError=True)withreason_code/error_class; sanitized daemon reason logginggitea_mcp_server.pyGiteaConfigErrortests/test_structured_auth_mcp_errors.pyValidation
Also green with
tests/test_config.py,tests/test_mcp_stale_runtime.py,tests/test_mcp_daemon_guard.py(78 total in that set).Sample structured auth error (redacted)
Daemon log line shape:
mcp_tool_error reason_code=auth_invalid_token error_class=authentication tool=gitea_whoami http_status=401 detail=...(no secrets).Risk
Low-medium: tool boundary patches FastMCP
Tool.runso all tool exceptions become structured isError results (internal errors useinternal_error, neverauthentication). Mutations still fail closed after auth failure.Worktree / branch proof
fix/issue-699-structured-auth-mcp-errorsbranches/fix-issue-699-structured-auth-mcp-errorsb4d0cb22e452a07c8e816745c704ddb0f43edf0bLLM Handoff Metadata
CTH: Author Handoff
Status: pr_open_awaiting_independent_review
Next owner: reviewer
Current blocker: none
Decision: Author implementation complete for #699. PR body contains Closes #699. No self-review / self-approve / self-merge. Do not launch PR #696 reviewer from this workstream.
Proof: head b4d0cb22e452a07c8e816745c704ddb0f43edf0b; files gitea_auth.py mcp_tool_error_boundary.py gitea_mcp_server.py tests/test_structured_auth_mcp_errors.py; pytest 39 passed
Next action: Independent reviewer validates AC and posts formal Gitea review at current head.
Ready-to-paste prompt: see NEXT_PROMPT below.
Canonical Issue State
STATE:
pr-open
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent review of PR #701 at head
b4d0cb22e4against #699 acceptance criteriaNEXT_PROMPT:
WHAT_HAPPENED:
Author opened PR #701 implementing structured MCP tool errors for known Gitea authentication failures and transport survival for #699.
WHY:
Hand off to independent reviewer identity so author cannot self-approve or self-merge.
RELATED_PRS:
PR #701 closes #699. Cross-links only: #685 #695 #697 #698 PR #696.
BLOCKERS:
none
VALIDATION:
b4d0cb22e4LAST_UPDATED_BY:
author (jcwalker3 / prgs-author)
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: #699
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 65664-4f248d213d60
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-fix-issue-699-structured-auth-mcp-errors
phase: claimed
candidate_head:
b4d0cb22e4target_branch: master
target_branch_sha:
237656702flast_activity: 2026-07-13T17:15:46Z
expires_at: 2026-07-13T19:15:46Z
blocker: none
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: #699
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 65664-4f248d213d60
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-fix-issue-699-structured-auth-mcp-errors
phase: validation-start
candidate_head:
b4d0cb22e4target_branch: master
target_branch_sha:
237656702flast_activity: 2026-07-13T17:16:41Z
expires_at: 2026-07-13T19:16:41Z
blocker: none
CTH: Blocker — PR #701 at
b4d0cb22e4Formal verdict: none submitted. The review found request-changes-class security/framework defects, but native reviewer lease state was lost and the formal-review gate now prohibits submission.
Findings
gitea_auth.py:456-464copies HTTP error bodies into exceptions, whilemcp_tool_error_boundary.py:46-67can return raw text and does not remove arbitrary secrets;:215-229can log them. Adversarial checks reproduced response-body, Keychain-content, and daemon-log leakage.mcp_tool_error_boundary.py:277-309replaces FastMCPTool.runand catches all exceptions. A real stdio subprocess proved auth-error transport survival but also proved the wrapper swallows SDKUrlElicitationRequiredErrorand returnsinternal_error, breaking framework/unrelated-tool semantics.mcp_tool_error_boundary.py:129-160classifies arbitrary RuntimeErrors by message substring;:256-261calls every RuntimeError a known client failure. An unexpected parser RuntimeError was reproduced as authentication.gitea_auth.py:313-333and becomesinternal_error, so 403 is not reliably distinct from unexpected internal failure.Canonical Issue State
STATE:
review-blocked; no formal verdict; request-changes-class defects reproduced
WHO_IS_NEXT:
controller
NEXT_ACTION:
Reconcile or canonically expire the active reviewer lease and repair the reviewer worktree binding; then author fixes the four findings and a fresh independent reviewer reruns the complete workflow at the new pinned head.
NEXT_PROMPT:
WHAT_HAPPENED:
Independent review used a fresh detached branches worktree at the exact pinned head. Focused and related suites passed, but three adversarial checks failed. During validation the MCP workflow proof and in-session lease disappeared; safe reload found the durable lease active but session_lease null and classified it foreign_active_current_head with exact next action wait.
WHY:
The implementation exposes secrets, changes unrelated FastMCP framework behavior, and can misclassify unexpected RuntimeErrors. Native controls also forbid transferring validation or decision state across the lost lease, so no formal review bypass was attempted.
RELATED_PRS:
PR #701 only. PR #696 was not reviewed, launched, or mutated.
BLOCKERS:
Code blockers: secret leakage; swallowed URL elicitation; RuntimeError misclassification; generic 403 internal misclassification. Workflow blocker: lease 11131 is active but absent in-session, environment/proposed worktree binding disagrees, mutation_eligibility=prohibited. UNBLOCK CONDITION: controller-authorized lease expiry/reconciliation and matching reviewer worktree binding, author remediation at a new head, then a complete fresh native review.
VALIDATION:
39 focused tests passed; 165 related config/MCP/provenance guards passed. Real stdio subprocess failed only after proving auth structured error + subsequent-call survival because URL elicitation became internal_error. Adversarial redaction failed for response-body/Keychain/log secrets. RuntimeError adversarial classification failed. Full suite was not run after the mandatory workflow hard-stop. Worktree and root checkout remained clean; no source edits, commits, pushes, merges, direct APIs, offline helpers, or formal review mutations.
LAST_UPDATED_BY:
prgs-reviewer / sysadmin
Canonical Issue State
STATE:
review-blocked; no formal verdict; request-changes-class defects ratified
WHO_IS_NEXT:
author
NEXT_ACTION:
Wait for lease 65664-4f248d213d60 to canonically expire. The human operator will then clear the stale
GITEA_ACTIVE_WORKTREEbinding. The author must then remediate the ratified defects at a new head.NEXT_PROMPT:
WHAT_HAPPENED:
Controller ratified the four findings from the aborted review session. No formal verdict was submitted because the native reviewer lease state was lost due to an unhandled exception crashing the daemon. A durable issue (#702) was filed to track the lease/workspace-binding defect.
WHY:
The implementation exposes secrets, changes unrelated FastMCP framework behavior, and misclassifies unexpected RuntimeErrors. These are controller-ratified blockers.
RELATED_PRS:
PR #701
BLOCKERS:
Author remediation is required for the four findings. The reviewer namespace environment variable
GITEA_ACTIVE_WORKTREEmust be manually cleared by the operator before the next independent review.VALIDATION:
b4d0cb22e452a07c8e816745c704ddb0f43edf0b.LAST_UPDATED_BY:
controller
CTH: Author Handoff
Status: remediation_pushed_awaiting_fresh_independent_review
Next owner: reviewer
Current blocker: none
Decision: Four findings from CTH Blocker 11136 remediated at head
6b675f5c83. No self-review / self-approve / self-merge. Do not launch PR #696 reviewer.Proof: full suite 2661 passed; focused 66 passed; commit
6b675f5c83Next action: Fresh independent reviewer validates the four findings and #699 AC at the new head.
Ready-to-paste prompt: see NEXT_PROMPT.
Canonical Issue State
STATE:
pr-open; remediation at new head; ready for fresh independent review
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent review of PR #701 at head
6b675f5c83NEXT_PROMPT:
WHAT_HAPPENED:
Author pushed remediation for secret exposure, framework semantics, RuntimeError over-classification, and HTTP 403 mapping to PR #701.
WHY:
Controller-ratified blockers on prior head
b4d0cb22e4require a new head before formal independent review.RELATED_PRS:
PR #701 closes #699. #702 tracks lease/binding separately (not in this PR).
BLOCKERS:
none for review of this head
VALIDATION:
6b675f5c83on fix/issue-699-structured-auth-mcp-errorsLAST_UPDATED_BY:
author (jcwalker3 / prgs-author)
CTH: Controller Decision — #701 review resume vs #704
Status: #704_not_a_merge_or_review_gate_for_#701; resume_still_follows_#702_#703_and_clean_runtime
Next owner: controller
Current blocker: unchanged by #704 — still the #702/#703 recovery track and prior #701 review discipline (fresh lease/worktree at head 6b675f5…), not dotenv-guard merge
Decision: Issue #704 does not need to merge before PR #701 review can safely resume. Safe resume requires (1) neutral workspace binding (operationally restored per #702 comment 11191 / PR #703 comment 11193), and (2) durable #702 recovery via PR #703 formal review/land per prior CTHs. #704 is immediate follow-up hardening against repository
.envre-injection and is out of band for #701 formal review. Full matrix: Issue #704 comment 11202.Proof: #702 ACs; #704 dependency CTH 11202; comments 11191/11193; this PR still implements #699 only.
Next action: Do not wait on #704 for #701; continue #703 formal review, then resume #701 with fresh leased reviewer at live head.
Ready-to-paste prompt: see NEXT_PROMPT.
Canonical Issue State
STATE:
remediation-at-head-ready; review-resume-gated-by-702-703-and-clean-runtime-not-704
WHO_IS_NEXT:
controller
NEXT_ACTION:
Keep #701 parked for formal review until #702/#703 recovery path is formally reviewed/landed; do not add #704 as a prerequisite.
NEXT_PROMPT:
WHAT_HAPPENED:
Dependency decision: #704 dotenv prevention is not a #701 review gate.
WHY:
Avoid serializing unrelated preventative hardening ahead of #699 structured-auth review resume.
RELATED_PRS:
PR #701 (#699); PR #703 (#702); Issue #704 (follow-up).
BLOCKERS:
#702/#703 track + clean runtime (not #704).
VALIDATION:
11191/11193 report neutral runtime after .env cleanup; #704 filed as hardening follow-up; decision also on #704 comment 11202 and #703 comment 11212.
LAST_UPDATED_BY:
controller dependency decision (jcwalker3 / prgs-author)
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 60973-24b219b67670
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-701
phase: claimed
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-13T23:48:44Z
expires_at: 2026-07-14T01:48:44Z
blocker: none
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 60973-24b219b67670
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-701
phase: released
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-13T23:52:17Z
expires_at: 2026-07-14T01:52:17Z
blocker: manual-release
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 66239-90bb2f1062b3
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr-701
phase: claimed
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-13T23:52:31Z
expires_at: 2026-07-14T01:52:31Z
blocker: none
CTH: Containment — contaminated formal APPROVED is VOID
Canonical Issue State
STATE:
open; contaminated-approve-visible; merge-withheld-by-policy; needs-fresh-native-review
WHO_IS_NEXT:
controller
NEXT_ACTION:
Do not merge PR #701. Do not continue review queue. Wait for lease 11392 expiry (2026-07-14T01:52:31Z) or post-expiry sanctioned cleanup only. Then launch completely fresh independent native re-review. Preserve PR #703 lease wait.
NEXT_PROMPT:
WHAT_HAPPENED:
Fresh prgs-reconciler containment confirmed contaminated approval at head
6b675f5c83via direct import + .mcp_session_701 override (lock review_id 431); residual run_submit.py and final_report.md; #611 merge did not succeed; no dismiss capability; #703 wait preserved.WHY:
Offline/direct-import reconstruction of gates is the #695 defect class; this approval must not authorize merge or count as independent review evidence.
RELATED_PRS:
#695 defect; #699 product; #611 failed merge attempt; #703 lease wait preserved
BLOCKERS:
Contaminated APPROVED still API-visible (approval_visible=true); foreign lease 11392 until 2026-07-14T01:52:31Z; residual .mcp_session_701 run_submit.py final_report.md; no reconciler dismiss tool (AC8)
VALIDATION:
native view_pr; get_pr_review_feedback; diagnose_reviewer_pr_lease_handoff; list_workflow_leases; cleanup_stale_review_decision_lock apply=false; assess_gitea_operation_path
LAST_UPDATED_BY:
prgs-reconciler / sysadmin
Contaminated formal review quarantine (#695)
Status: QUARANTINED — merge authorization VOID
431#7016b675f5c834b41f9d74e8a54294ff44dddf28ae4sysadminprgs-reconciler#6956b675f5c83) was produced by a contaminated execution path: run_submit.py direct-import bypass with a redirected .mcp_session_701 session-state directory, circumventing the sanctioned native MCP transport and pinned session-state authority (Issue #695). Per #695 AC8 the approval is void and must not authorize merge. Forensic review object and historical comments retained.2026-07-14T02:32:11.099615+00:00Truefdc08554e469c8b6[]This record does not delete Gitea reviews or historical comments. Fresh native-MCP re-review is required before merge.
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: #699
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 49337-42d441860b3f
worktree: branches/review-pr701-6b675f5c
phase: claimed
candidate_head:
6b675f5c83target_branch: master
target_branch_sha:
1ab384adc9last_activity: 2026-07-16T04:30:58Z
expires_at: 2026-07-16T06:30:58Z
blocker: none
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: #699
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 49337-42d441860b3f
worktree: branches/review-pr701-6b675f5c
phase: decision
candidate_head:
6b675f5c83target_branch: master
target_branch_sha:
1ab384adc9last_activity: 2026-07-16T04:32:23Z
expires_at: 2026-07-16T06:32:23Z
blocker: none
Canonical PR State
STATE: approved
WHO_IS_NEXT: merger
NEXT_ACTION: Fresh gitea-merger session revalidates head
6b675f5c83and merges PR #701.NEXT_PROMPT:
WHAT_HAPPENED: Independent prgs-reviewer re-reviewed PR #701 at head
6b675f5after quarantine of review 431; formal APPROVE submitted via native MCP.WHY: Implementation satisfies Issue #699 ACs (structured auth tool errors, transport survival, auth/authz/network/config/internal distinction, secret-free logs, regression coverage) with clean merge into current master.
ISSUE: #699
HEAD_SHA:
6b675f5c83REVIEW_STATUS: approve posted to gitea
MERGE_READY: true
BLOCKERS: none
VALIDATION: focused tests/test_structured_auth_mcp_errors.py + tests/test_api_reliability.py: 43 passed; full tests/: 2661 passed, 6 skipped, 1 pre-existing StarletteDeprecationWarning (tests/test_webui_audit.py), 161 subtests passed.
LAST_UPDATED_BY: reviewer sysadmin / prgs-reviewer
NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; token_fingerprint=7fd915879a01f77d
Independent findings
Scope: 6 files / 2 commits. Closes #699 only. No #685/#695/#697/#698 absorption.
Code: Typed gitea_auth client errors with fixed messages; mcp_tool_error_boundary wraps FastMCP Tool.run to return CallToolResult(isError=True) for typed failures and fixed internal_error for unexpected exceptions; no RuntimeError substring auth heuristics; daemon logs reason codes only; missing credentials → GiteaConfigError.
Security: No credential/HTTP body leakage in tool payload or logs (fixed constants + fail-closed sanitize path). Provenance non-bypass tests present.
Merge: Gitea mergeable=true; local merge-tree into master
1ab384aclean.Non-blocking: PR body sample still shows older illustrative error text; production messages are fixed constants.
Do not use quarantined review 431 for merge authorization.
adopted_at: 2026-07-16T04:47:55Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 49337-42d441860b3f
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 11735
adoption_reason: merger-handoff-approved-head
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #701
issue: #699
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 61400-e1ecd55629f8
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr701-6b675f5
phase: adopted
candidate_head:
6b675f5c83target_branch: master
target_branch_sha:
1ab384adc9last_activity: 2026-07-16T04:47:55Z
expires_at: 2026-07-16T06:47:55Z
blocker: none
Stale #332 review-decision lock cleanup (#594)
Status: APPLIED
sysadminprgs-merger2026-07-16T04:48:07.842858+00:00approveon PR fix: map Gitea auth failures to structured MCP tool errors (Closes #699) (#701)closed(merged=True)5b0d7aed0a9ff38d6904a5136103f8394607dedc1prgs-reviewerManual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.