feat: common anti-stomp preflight before every mutation tool (Closes #604)

Conversation 9 Commits 2 Files Changed 4

+2142 -3

2 Commits

Author	SHA1	Message	Date
sysadmin	3fd02a3c63	fix: anti-stomp capability auth, inventory wiring, side-effect proof (#604 ) Address REQUEST_CHANGES on PR #680: Blocker A — role vs capability agreement - authorization_compatible allows reviewer/merger when they hold the task's required permission (e.g. gitea.issue.comment on comment_issue/mark_issue/ set_issue_labels/lock_issue) without broad role-bypass. - Unauthorized escalation without the permission remains fail closed. - Regression coverage for allowed and denied reviewer/merger cases. Blocker B — MUTATION_TASKS matches runtime wiring - Remove unenforced entries; document dedicated-gate exclusions (mark_final_review_decision, save/resume_review_draft, etc.). - Wire non-closing gitea_edit_pr as edit_pr; acquire lease uses acquire_reviewer_pr_lease task through verify_preflight_purity. - Inventory↔wiring consistency tests replace set-membership-only coverage. Blocker C — entrypoint side-effect ordering - Behavioral tests for merge_pr, submit_pr_review, and comment_issue prove the assessor block aborts before Gitea API mutation and local durable writes. Validation: 43 focused anti-stomp + related suites green; full suite 2639 passed / 6 skipped. Closes #604	2026-07-12 09:00:45 -04:00
sysadmin	ea8e186549	feat: common anti-stomp preflight before mutation tools (Closes #604 ) Add a shared fail-closed anti-stomp preflight that mutation tools invoke before create/comment/lease/review/approve/request-changes/merge/cleanup/ label mutations. Composes repo/role/root/worktree/lease/terminal-lock/ head-SHA/stale-runtime/workflow-hash/contamination checks into a typed blocker with an exact next action. No agent bypass flags.	2026-07-12 05:10:30 -04:00

Author

SHA1

Message

Date

sysadmin

3fd02a3c63

fix: anti-stomp capability auth, inventory wiring, side-effect proof (#604 )

Address REQUEST_CHANGES on PR #680:

Blocker A — role vs capability agreement
- authorization_compatible allows reviewer/merger when they hold the task's
  required permission (e.g. gitea.issue.comment on comment_issue/mark_issue/
  set_issue_labels/lock_issue) without broad role-bypass.
- Unauthorized escalation without the permission remains fail closed.
- Regression coverage for allowed and denied reviewer/merger cases.

Blocker B — MUTATION_TASKS matches runtime wiring
- Remove unenforced entries; document dedicated-gate exclusions
  (mark_final_review_decision, save/resume_review_draft, etc.).
- Wire non-closing gitea_edit_pr as edit_pr; acquire lease uses
  acquire_reviewer_pr_lease task through verify_preflight_purity.
- Inventory↔wiring consistency tests replace set-membership-only coverage.

Blocker C — entrypoint side-effect ordering
- Behavioral tests for merge_pr, submit_pr_review, and comment_issue prove
  the assessor block aborts before Gitea API mutation and local durable writes.

Validation: 43 focused anti-stomp + related suites green; full suite
2639 passed / 6 skipped.

Closes #604

2026-07-12 09:00:45 -04:00

sysadmin

ea8e186549

feat: common anti-stomp preflight before mutation tools (Closes #604 )

Add a shared fail-closed anti-stomp preflight that mutation tools invoke
before create/comment/lease/review/approve/request-changes/merge/cleanup/
label mutations. Composes repo/role/root/worktree/lease/terminal-lock/
head-SHA/stale-runtime/workflow-hash/contamination checks into a typed
blocker with an exact next action. No agent bypass flags.

2026-07-12 05:10:30 -04:00

feat: common anti-stomp preflight before every mutation tool (Closes #604) #680