feat: canonical cleanup for stale #332 review decision locks (Closes #594) #595

Merged

sysadmin merged 3 commits from feat/issue-594-stale-decision-lock-cleanup into master

2026-07-09 15:01:28 -05:00

Author	SHA1	Message	Date
sysadmin	b98e8dfa1a	test: harden session-state isolation for #594 decision-lock suite Pin per-test durable session-state so patch.dict(clear=True) cannot adopt host ~/.cache review-decision locks, and clear the merge-test ledger in setUp. Keeps active #332 hard-stop coverage while making TestMergePR deterministic without manual host cache cleanup. Aligned with #590 / PR #592 isolation approach.	2026-07-09 15:24:41 -04:00
sysadmin	86651a3d05	docs: expand #594 stale decision-lock cleanup guidance Add allowed/forbidden workflow steps to the review-merge skill and document the #594 cleanup gate on the Safety-and-Gates wiki page.	2026-07-09 15:21:21 -04:00
sysadmin	3f3f880147	feat: canonical cleanup for stale #332 review decision locks (#594 ) Durable review-decision locks (#559) can outlive the PR they protect. When the last terminal mutation references a PR that is already merged/closed, expose gitea_cleanup_stale_review_decision_lock so a reviewer can clear the lock with identity/profile gates and a durable audit trail — without weakening #332 for open PRs or deleting session-state files by hand. Also auto-clear same-profile locks after a successful merge of the approved PR, and document allowed vs forbidden cleanup. Closes #594	2026-07-09 15:18:48 -04:00

Author

SHA1

Message

Date

sysadmin

b98e8dfa1a

test: harden session-state isolation for #594 decision-lock suite

Pin per-test durable session-state so patch.dict(clear=True) cannot adopt
host ~/.cache review-decision locks, and clear the merge-test ledger in
setUp. Keeps active #332 hard-stop coverage while making TestMergePR
deterministic without manual host cache cleanup.

Aligned with #590 / PR #592 isolation approach.

2026-07-09 15:24:41 -04:00

sysadmin

86651a3d05

docs: expand #594 stale decision-lock cleanup guidance

Add allowed/forbidden workflow steps to the review-merge skill and
document the #594 cleanup gate on the Safety-and-Gates wiki page.

2026-07-09 15:21:21 -04:00

sysadmin

3f3f880147

feat: canonical cleanup for stale #332 review decision locks (#594 )

Durable review-decision locks (#559) can outlive the PR they protect.
When the last terminal mutation references a PR that is already
merged/closed, expose gitea_cleanup_stale_review_decision_lock so a
reviewer can clear the lock with identity/profile gates and a durable
audit trail — without weakening #332 for open PRs or deleting
session-state files by hand.

Also auto-clear same-profile locks after a successful merge of the
approved PR, and document allowed vs forbidden cleanup.

Closes #594

2026-07-09 15:18:48 -04:00