Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

feat: add skip-stale-REQUEST_CHANGES reviewer menu prompt (Closes #482) #491

Merged
sysadmin merged 1 commits from feat/issue-482-skip-stale-request-changes-pr into master 2026-07-08 23:06:57 -05:00
Conversation 5 Commits 1 Files Changed 3
+52 -2
jcwalker3 commented 2026-07-08 01:37:44 -05:00
Owner
Copy Link
Copy Source

Summary

Closes #482. Adds a reviewer menu prompt to skip already-reviewed stale REQUEST_CHANGES PRs and hand off to the author — menu/docs/tests only; no server behavior change.

Stacked on PR #479 / issue #478. Base branch: feat/issue-478-mcp-menu-shell. Do not merge before PR #479 lands; retarget to master after #479 merges.

Changes

  • mcp-menu.sh — new Reviewer workflows entry with full prompt + Return fields
  • docs/mcp-menu.md — documents the new prompt
  • tests/test_mcp_menu_script.py — guardrail label in REQUIRED_SUBMENU_LABELS + prompt content assertions

Verification

venv/bin/python -m pytest tests/test_mcp_menu_script.py -q
# 13 passed, 26 subtests passed

Worktree

branches/issue-482-skip-stale-rc @ 8f866ae

## Summary Closes #482. Adds a reviewer menu prompt to skip already-reviewed stale REQUEST_CHANGES PRs and hand off to the author — menu/docs/tests only; no server behavior change. **Stacked on PR #479 / issue #478.** Base branch: `feat/issue-478-mcp-menu-shell`. Do not merge before PR #479 lands; retarget to `master` after #479 merges. ## Changes - `mcp-menu.sh` — new Reviewer workflows entry with full prompt + Return fields - `docs/mcp-menu.md` — documents the new prompt - `tests/test_mcp_menu_script.py` — guardrail label in `REQUIRED_SUBMENU_LABELS` + prompt content assertions ## Verification ```bash venv/bin/python -m pytest tests/test_mcp_menu_script.py -q # 13 passed, 26 subtests passed ``` ## Worktree `branches/issue-482-skip-stale-rc` @ `8f866ae`
sysadmin commented 2026-07-08 22:08:07 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #491
issue: #482
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 12056-c5916410bff2
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr491-now
phase: claimed
candidate_head: 8f866ae753
target_branch: master
target_branch_sha: f6b2adac4d
last_activity: 2026-07-09T03:08:07Z
expires_at: 2026-07-09T05:08:07Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #491 issue: #482 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 12056-c5916410bff2 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr491-now phase: claimed candidate_head: 8f866ae75336d830ec804d2d227263059f2c0c85 target_branch: master target_branch_sha: f6b2adac4de1e521623770b807f4c8b2cf283121 last_activity: 2026-07-09T03:08:07Z expires_at: 2026-07-09T05:08:07Z blocker: none
sysadmin commented 2026-07-08 22:08:45 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #491
issue: #482
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 12056-c5916410bff2
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr491-now
phase: released
candidate_head: 8f866ae753
target_branch: master
target_branch_sha: f6b2adac4d
last_activity: 2026-07-09T03:08:45Z
expires_at: 2026-07-09T05:08:45Z
blocker: manual-release

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #491 issue: #482 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 12056-c5916410bff2 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr491-now phase: released candidate_head: 8f866ae75336d830ec804d2d227263059f2c0c85 target_branch: master target_branch_sha: f6b2adac4de1e521623770b807f4c8b2cf283121 last_activity: 2026-07-09T03:08:45Z expires_at: 2026-07-09T05:08:45Z blocker: manual-release
sysadmin commented 2026-07-08 22:42:30 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #491
issue: #482
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 12056-c5916410bff2
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr491-now
phase: claimed
candidate_head: 8f866ae753
target_branch: master
target_branch_sha: 066eec8477
last_activity: 2026-07-09T03:42:30Z
expires_at: 2026-07-09T05:42:30Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #491 issue: #482 reviewer_identity: sysadmin profile: prgs-reviewer session_id: 12056-c5916410bff2 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-pr491-now phase: claimed candidate_head: 8f866ae75336d830ec804d2d227263059f2c0c85 target_branch: master target_branch_sha: 066eec84771a3811fa6e890e1a3241c3441921ae last_activity: 2026-07-09T03:42:30Z expires_at: 2026-07-09T05:42:30Z blocker: none
sysadmin approved these changes 2026-07-08 22:42:46 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

APPROVED at head 8f866ae

Scope

Menu/docs/tests only for #482 (skip already-reviewed stale REQUEST_CHANGES handoff prompt). Diff vs master is 3 files, +52/-2.

Validation

  • Worktree: branches/review-pr491-now @ 8f866ae
  • pytest tests/test_mcp_menu_script.py -q → 13 passed, 26 subtests passed
  • Prompt text correctly forbids duplicate terminal mutations and requires author-ready fix prompt

Notes (non-blocking)

  • Stacked base feat/issue-478-mcp-menu-shell is fully merged via #479; consider retargeting this PR base to master before merge for a cleaner history.

Merge not performed in this reviewer session (no merge authorization for this PR).

## APPROVED at head `8f866ae` ### Scope Menu/docs/tests only for #482 (skip already-reviewed stale REQUEST_CHANGES handoff prompt). Diff vs master is 3 files, +52/-2. ### Validation - Worktree: `branches/review-pr491-now` @ `8f866ae` - `pytest tests/test_mcp_menu_script.py -q` → **13 passed, 26 subtests passed** - Prompt text correctly forbids duplicate terminal mutations and requires author-ready fix prompt ### Notes (non-blocking) - Stacked base `feat/issue-478-mcp-menu-shell` is fully merged via #479; consider retargeting this PR base to `master` before merge for a cleaner history. Merge not performed in this reviewer session (no merge authorization for this PR).
jcwalker3 changed target branch from feat/issue-478-mcp-menu-shell to master 2026-07-08 23:06:35 -05:00
jcwalker3 added 1 commit 2026-07-08 23:06:35 -05:00
feat: add skip-stale-REQUEST_CHANGES reviewer menu prompt (#482) 8f866ae753 
Add a second reviewer workflow prompt to the root MCP operator menu:
"Skip already-reviewed stale REQUEST_CHANGES PR and hand off to author".

show_reviewer_prompts becomes a small 2-option submenu (mirroring the
existing show_author_prompts idiom): option 1 keeps the standard PR
review prompt; option 2 is the new prompt. It instructs the reviewer to
determine whether the current head already carries a non-stale
REQUEST_CHANGES verdict and, if so, to submit no new terminal review
mutation, run only handoff diagnostics, and return an author-ready fix
prompt with the full 8-field handoff.

Stacked on PR #479 (feat/issue-478-mcp-menu-shell); the menu is not yet
on master. Diff limited to the new prompt: mcp-menu.sh, docs/mcp-menu.md,
and a discoverability test in tests/test_mcp_menu_script.py.

Closes #482.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
sysadmin commented 2026-07-08 23:06:49 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-09T04:06:48Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 12056-c5916410bff2
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 7741
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #491
issue: #482
reviewer_identity: sysadmin
profile: prgs-merger
session_id: grok-merge-pr491-20260709
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr491-issue-482
phase: adopted
candidate_head: 8f866ae753
target_branch: master
target_branch_sha: 066eec8477
last_activity: 2026-07-09T04:06:48Z
expires_at: 2026-07-09T06:06:48Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-09T04:06:48Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 12056-c5916410bff2 adopted_from_profile: prgs-reviewer adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 7741 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #491 issue: #482 reviewer_identity: sysadmin profile: prgs-merger session_id: grok-merge-pr491-20260709 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr491-issue-482 phase: adopted candidate_head: 8f866ae75336d830ec804d2d227263059f2c0c85 target_branch: master target_branch_sha: 066eec84771a3811fa6e890e1a3241c3441921ae last_activity: 2026-07-09T04:06:48Z expires_at: 2026-07-09T06:06:48Z blocker: none
sysadmin merged commit b68805e88a into master 2026-07-08 23:06:57 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#491