Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Add reviewer menu prompt: skip already-reviewed stale REQUEST_CHANGES PR and hand off to author #482

New Issue
Closed
opened 2026-07-08 00:35:36 -05:00 by jcwalker3 · 2 comments
jcwalker3 commented 2026-07-08 00:35:36 -05:00
Owner
Copy Link
Copy Source

Type

Menu / docs / tests addition to the root MCP operator shell menu (./mcp-menu.sh). No runtime/server behavior change.

Dependency (stacked)

This is a stacked addition on top of the base menu introduced by #478 / PR #479 (feat/issue-478-mcp-menu-shell). mcp-menu.sh does not yet exist on master; it lands with #479. The PR for this issue must base on feat/issue-478-mcp-menu-shell and must not merge before #479 lands. Final target after #479 lands is master.

User instruction (verbatim)

Add this menu prompt under: Reviewer workflows OR Queue / controller workflows — Label: Skip already-reviewed stale REQUEST_CHANGES PR and hand off to author — Prompt: Review the selected PR only far enough to determine whether the current head already has a non-stale REQUEST_CHANGES verdict. If the same current head already has active REQUEST_CHANGES, do not submit another terminal review mutation. Confirm the prior verdict is still bound to the current head, summarize the blockers, run only the diagnostics needed to produce a useful author handoff, and stop. Return: - selected PR and issue - current head SHA - prior REQUEST_CHANGES proof - duplicate/supersession analysis - validation summary - why no new review mutation was submitted - corrected mutation ledger, including local worktree create/remove if used - author-ready fix prompt

Acceptance criteria

  • Add the menu entry under Reviewer workflows with label Skip already-reviewed stale REQUEST_CHANGES PR and hand off to author.
  • The prompt block instructs: determine whether current head already has a non-stale REQUEST_CHANGES; if so, submit no new terminal review mutation; confirm binding to current head; summarize blockers; run only handoff diagnostics; stop.
  • The prompt Return section includes all 8 fields: selected PR and issue; current head SHA; prior REQUEST_CHANGES proof; duplicate/supersession analysis; validation summary; why no new review mutation was submitted; corrected mutation ledger (incl. local worktree create/remove if used); author-ready fix prompt.
  • Update mcp-menu.sh.
  • Update docs/mcp-menu.md.
  • Update tests/test_mcp_menu_script.py.
  • Add the exact label string to the REQUIRED_SUBMENU_LABELS guardrail so test_contains_required_submenu_labels proves the menu label is covered.
  • PR diff limited to this new prompt addition relative to feat/issue-478-mcp-menu-shell — no full #478 menu diff.
  • PR body states it is stacked on #479 and must merge only after #479 lands.

Out of scope

  • The base menu itself (#478 / #479).
  • Any server/runtime behavior change; this is menu copy + docs + guardrail test only.
## Type **Menu / docs / tests addition** to the root MCP operator shell menu (`./mcp-menu.sh`). No runtime/server behavior change. ## Dependency (stacked) This is a **stacked** addition on top of the base menu introduced by **#478 / PR #479** (`feat/issue-478-mcp-menu-shell`). `mcp-menu.sh` does not yet exist on `master`; it lands with #479. The PR for this issue must base on `feat/issue-478-mcp-menu-shell` and must **not** merge before #479 lands. Final target after #479 lands is `master`. ## User instruction (verbatim) > Add this menu prompt under: Reviewer workflows OR Queue / controller workflows — Label: Skip already-reviewed stale REQUEST_CHANGES PR and hand off to author — Prompt: Review the selected PR only far enough to determine whether the current head already has a non-stale REQUEST_CHANGES verdict. If the same current head already has active REQUEST_CHANGES, do not submit another terminal review mutation. Confirm the prior verdict is still bound to the current head, summarize the blockers, run only the diagnostics needed to produce a useful author handoff, and stop. Return: - selected PR and issue - current head SHA - prior REQUEST_CHANGES proof - duplicate/supersession analysis - validation summary - why no new review mutation was submitted - corrected mutation ledger, including local worktree create/remove if used - author-ready fix prompt ## Acceptance criteria - [ ] Add the menu entry under **Reviewer workflows** with label `Skip already-reviewed stale REQUEST_CHANGES PR and hand off to author`. - [ ] The prompt block instructs: determine whether current head already has a non-stale REQUEST_CHANGES; if so, submit **no** new terminal review mutation; confirm binding to current head; summarize blockers; run only handoff diagnostics; stop. - [ ] The prompt Return section includes all 8 fields: selected PR and issue; current head SHA; prior REQUEST_CHANGES proof; duplicate/supersession analysis; validation summary; why no new review mutation was submitted; corrected mutation ledger (incl. local worktree create/remove if used); author-ready fix prompt. - [ ] Update `mcp-menu.sh`. - [ ] Update `docs/mcp-menu.md`. - [ ] Update `tests/test_mcp_menu_script.py`. - [ ] Add the exact label string to the `REQUIRED_SUBMENU_LABELS` guardrail so `test_contains_required_submenu_labels` proves the menu label is covered. - [ ] PR diff limited to this new prompt addition **relative to `feat/issue-478-mcp-menu-shell`** — no full #478 menu diff. - [ ] PR body states it is stacked on #479 and must merge only after #479 lands. ## Out of scope - The base menu itself (#478 / #479). - Any server/runtime behavior change; this is menu copy + docs + guardrail test only.
jcwalker3 added the status:in-progress label 2026-07-08 01:35:56 -05:00
jcwalker3 commented 2026-07-08 01:35:57 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: claim - issue: #482 - branch: feat/issue-482-skip-stale-request-changes-pr - phase: claimed - profile: prgs-author - pr: none - blocker: none - next_action: create worktree and begin implementation
jcwalker3 commented 2026-07-08 01:37:50 -05:00
Author
Owner
Copy Link
Copy Source

Issue claim heartbeat

<!-- gitea-issue-claim-heartbeat:v1 --> **Issue claim heartbeat** - kind: progress - issue: #482 - branch: feat/issue-482-skip-stale-request-changes-pr - phase: pr_opened - profile: prgs-author - pr: 491 - blocker: none - next_action: await review; merge only after PR #479 lands
sysadmin removed the status:in-progress label 2026-07-08 23:06:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#482