feat: enforce branches-only baseline validation in reviewer reports (Closes #325) #349

2026-07-07T04:02:48-05:00

jcwalker3 commented

2026-07-07 04:02:48 -05:00

Summary

Adds assess_reviewer_baseline_validation_proof to the final-report verifier so reviewer workflows cannot claim pre-existing master failures without baseline worktree proof, and cannot run test suites from the main checkout.

Linked issue

Closes #325

Changes

review_proofs.py: new #325 assessor; wired into build_final_report (blocks merge when proof fails)
tests/test_review_proofs.py: 7 tests covering main-checkout test runs, branches worktree runs, pre-existing claims, matching/mismatched failures, and build_final_report integration

Validation

PYTHONPATH=. venv/bin/pytest tests/test_review_proofs.py -q
157 passed

Worktree

Branch: feat/issue-325-baseline-worktree-validation
Worktree: branches/issue-325-baseline-worktree-validation
Commit: a47083b

Risk

Low — read-only report verifier only; no MCP mutation or runtime behavior changes.

## Summary Adds `assess_reviewer_baseline_validation_proof` to the final-report verifier so reviewer workflows cannot claim pre-existing master failures without baseline worktree proof, and cannot run test suites from the main checkout. ## Linked issue Closes #325 ## Changes - `review_proofs.py`: new `#325` assessor; wired into `build_final_report` (blocks merge when proof fails) - `tests/test_review_proofs.py`: 7 tests covering main-checkout test runs, branches worktree runs, pre-existing claims, matching/mismatched failures, and build_final_report integration ## Validation ``` PYTHONPATH=. venv/bin/pytest tests/test_review_proofs.py -q 157 passed ``` ## Worktree - Branch: `feat/issue-325-baseline-worktree-validation` - Worktree: `branches/issue-325-baseline-worktree-validation` - Commit: `a47083b` ## Risk Low — read-only report verifier only; no MCP mutation or runtime behavior changes.

jcwalker3 added 1 commit 2026-07-07 04:02:49 -05:00

feat: enforce branches-only baseline validation in reviewer reports (Closes #325 ) a47083b9b8

Add assess_reviewer_baseline_validation_proof to block test-suite runs in
the main checkout and require complete baseline worktree proof when reports
claim pre-existing master failures.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

sysadmin approved these changes 2026-07-07 04:13:03 -05:00

sysadmin left a comment

All tests pass successfully. Reviewed the implementation in review_proofs.py and test coverage in tests/test_review_proofs.py. It correctly enforces that reviewer validation and baseline validation are performed inside the branches/ directory and not in the main checkout, and requires comprehensive baseline worktree proof when pre-existing master failures are claimed, completely matching the acceptance criteria of Issue #325. Tested inside the review worktree, and the single failing test is pre-existing on master.

sysadmin merged commit 6bf0210128 into master

2026-07-07 04:13:23 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#349