Reviewer baseline validation must use branches worktrees, not the main checkout #325

New Issue

2026-07-07T01:49:32-05:00

jcwalker3 commented

2026-07-07 01:49:32 -05:00

A reviewer workflow for PR #280 ran the full test suite in the main master checkout to compare failures against the PR worktree.

Problem

The main checkout is the stable control checkout and MCP entrypoint. It must not be used for PR validation or baseline testing. Running test suites in the main checkout can generate files, mutate caches, create artifacts, or confuse control-checkout state.

Required behavior

The main checkout may be used only for read-only status/fetch/stable update operations.
Reviewer validation and baseline comparison must happen under branches/.
If a PR full-suite failure is claimed to be pre-existing on master, the workflow must create a clean baseline worktree under branches/, such as:
branches/baseline-master-pr<PR_NUMBER>
The baseline worktree must be clean before and after validation.
Baseline comparison must report:
- baseline target SHA
- PR head SHA
- exact validation command
- baseline failures
- PR failures
- proof the failure signatures match
The main checkout must not run test suites.

Acceptance criteria

Running tests in the main checkout fails reviewer workflow validation.
Baseline comparison uses a separate branches/ worktree.
Reports cannot claim “pre-existing master failure” without baseline worktree proof.
Tests cover main-checkout test attempt, clean baseline worktree, failing baseline, matching failures, and mismatched failures.

A reviewer workflow for PR #280 ran the full test suite in the main master checkout to compare failures against the PR worktree. ## Problem The main checkout is the stable control checkout and MCP entrypoint. It must not be used for PR validation or baseline testing. Running test suites in the main checkout can generate files, mutate caches, create artifacts, or confuse control-checkout state. ## Required behavior 1. The main checkout may be used only for read-only status/fetch/stable update operations. 2. Reviewer validation and baseline comparison must happen under `branches/`. 3. If a PR full-suite failure is claimed to be pre-existing on master, the workflow must create a clean baseline worktree under `branches/`, such as: `branches/baseline-master-pr<PR_NUMBER>` 4. The baseline worktree must be clean before and after validation. 5. Baseline comparison must report: * baseline target SHA * PR head SHA * exact validation command * baseline failures * PR failures * proof the failure signatures match 6. The main checkout must not run test suites. ## Acceptance criteria * Running tests in the main checkout fails reviewer workflow validation. * Baseline comparison uses a separate `branches/` worktree. * Reports cannot claim “pre-existing master failure” without baseline worktree proof. * Tests cover main-checkout test attempt, clean baseline worktree, failing baseline, matching failures, and mismatched failures.

jcwalker3 referenced this issue

2026-07-07 01:51:24 -05:00

Add final-report validator rules for reviewer and reconciliation handoffs #327

jcwalker3 added the status:in-progress label 2026-07-07 04:00:46 -05:00

jcwalker3 referenced this issue from a commit

2026-07-07 04:02:12 -05:00

feat: enforce branches-only baseline validation in reviewer reports (Closes #325)

jcwalker3 referenced a pull request that will close this issue

2026-07-07 04:02:48 -05:00

feat: enforce branches-only baseline validation in reviewer reports (Closes #325) #349

sysadmin referenced this issue

2026-07-07 04:13:03 -05:00