feat(author): add continuation-mode selection wall for open-PR issues (closes #188) #246

Merged
sysadmin merged 3 commits from feat/issue-188-continuation-selection-wall into master 2026-07-06 11:26:11 -05:00
Owner

Summary

Adds proof helpers so author issue-selection runs cannot pick issues with open PRs for fresh work unless continuation mode is explicitly declared with full evidence.

Changes

  • classify_issue_for_selection — classifies issues as unclaimed, represented-by-PR, in-progress, continuation, or excluded
  • assess_fresh_issue_selection — blocks fresh selection of issues with open PRs
  • assess_continuation_mode_report — requires PR number, author, branch, old/new head SHAs, session authorship, and why continuation is allowed
  • assess_contradictory_no_pr_claim — downgrades "no open PR" claims when a PR is later edited
  • assess_edited_pr_inventory_coverage — requires edited PRs appear in inventory
  • assess_issue_selection_final_report — composite A-bar grade
  • Continuation handoff role fields in workflow skill

Tests

6 new unit tests — all pass.

Closes #188

## Summary Adds proof helpers so author issue-selection runs cannot pick issues with open PRs for fresh work unless continuation mode is explicitly declared with full evidence. ## Changes - `classify_issue_for_selection` — classifies issues as unclaimed, represented-by-PR, in-progress, continuation, or excluded - `assess_fresh_issue_selection` — blocks fresh selection of issues with open PRs - `assess_continuation_mode_report` — requires PR number, author, branch, old/new head SHAs, session authorship, and why continuation is allowed - `assess_contradictory_no_pr_claim` — downgrades "no open PR" claims when a PR is later edited - `assess_edited_pr_inventory_coverage` — requires edited PRs appear in inventory - `assess_issue_selection_final_report` — composite A-bar grade - Continuation handoff role fields in workflow skill ## Tests 6 new unit tests — all pass. Closes #188
jcwalker3 added 1 commit 2026-07-06 10:40:44 -05:00
jcwalker3 added 2 commits 2026-07-06 10:47:13 -05:00
Issues already represented by open PRs must not be selected for fresh work
unless the operator explicitly requests continuation. Adds classification,
continuation report proofs (old/new head SHA, PR author, branch), contradictory
no-PR claim detection, and edited-PR inventory coverage checks.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
sysadmin reviewed 2026-07-06 11:25:59 -05:00
sysadmin left a comment
Owner

Review summary

Reviewed PR #246 at head e441b81d3b2076dfa54ff32a9876ce12cca2107e.

Scope: Closes #188 — continuation-mode selection wall for author issue picking. Adds proof helpers in review_proofs.py to block fresh selection of issues with open PRs unless continuation mode is explicitly declared with evidence.

Findings:

  • classify_issue_for_selection, assess_fresh_issue_selection, assess_continuation_mode_report are well-structured.
  • 6 new unit tests in TestIssueSelectionContinuation all pass.
  • Scope clean: 3 files, no unrelated changes.

Validation:

  • pytest tests/test_review_proofs.py -v → 133 passed
  • pytest tests/ -q → full suite exit 0
  • git diff --check → clean

Verdict: Approve. Ready to merge into master.

## Review summary Reviewed PR #246 at head `e441b81d3b2076dfa54ff32a9876ce12cca2107e`. **Scope:** Closes #188 — continuation-mode selection wall for author issue picking. Adds proof helpers in `review_proofs.py` to block fresh selection of issues with open PRs unless continuation mode is explicitly declared with evidence. **Findings:** - `classify_issue_for_selection`, `assess_fresh_issue_selection`, `assess_continuation_mode_report` are well-structured. - 6 new unit tests in `TestIssueSelectionContinuation` all pass. - Scope clean: 3 files, no unrelated changes. **Validation:** - `pytest tests/test_review_proofs.py -v` → 133 passed - `pytest tests/ -q` → full suite exit 0 - `git diff --check` → clean **Verdict:** Approve. Ready to merge into `master`.
sysadmin merged commit 08ed5a82d2 into master 2026-07-06 11:26:11 -05:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#246