feat(continuation): formalize continuation proofs for claim and push (closes #189) #253

Merged
Owner

Summary

Formalizes continuation mode proofs on top of #188 (#246). When an author continues work on an issue already represented by an open PR, the workflow must prove claim status, head SHA transitions, and safe force-with-lease pushes.

Changes

  • assess_continuation_mode_report: issue number + claim status evidence (#189)
  • assess_force_with_lease_push_report: old remote head, lease head, pushed head, feature-branch-only confirmation
  • canonical_secret_sweep_report + CANONICAL_SECRET_SWEEP_COMMAND for comparable sweeps
  • Wire push + sweep checks into assess_issue_selection_final_report
  • Controller Handoff continuation fields: Issue claim status:
  • Runbook update in skills/llm-project-workflow/SKILL.md

Tests

11 continuation tests (6 #188 + 5 #189); full test_review_proofs.py: 138 passed.

Stack: bases on #246 (feat/issue-188-continuation-selection-wall). Merge #246 first.

Closes #189

## Summary Formalizes continuation mode proofs on top of #188 (#246). When an author continues work on an issue already represented by an open PR, the workflow must prove claim status, head SHA transitions, and safe force-with-lease pushes. ## Changes - `assess_continuation_mode_report`: issue number + claim status evidence (#189) - `assess_force_with_lease_push_report`: old remote head, lease head, pushed head, feature-branch-only confirmation - `canonical_secret_sweep_report` + `CANONICAL_SECRET_SWEEP_COMMAND` for comparable sweeps - Wire push + sweep checks into `assess_issue_selection_final_report` - Controller Handoff continuation fields: `Issue claim status:` - Runbook update in `skills/llm-project-workflow/SKILL.md` ## Tests 11 continuation tests (6 #188 + 5 #189); full `test_review_proofs.py`: 138 passed. **Stack:** bases on #246 (`feat/issue-188-continuation-selection-wall`). Merge #246 first. Closes #189
jcwalker3 added 1 commit 2026-07-06 10:54:51 -05:00
Extend #188 continuation mode with issue claim status evidence,
force-with-lease push reporting, canonical secret sweep helper, and
composite final-report checks wired into assess_issue_selection_final_report.
sysadmin reviewed 2026-07-06 11:27:20 -05:00
sysadmin left a comment
Owner

Review summary

Reviewed PR #253 at head 1158594a200bc7c118b9e3265375cb769f65b83a.

Scope: Closes #189 — continuation proofs for claim status, force-with-lease push evidence, and canonical secret sweep on top of #188.

Changes:

  • assess_continuation_mode_report gains issue claim status evidence
  • assess_force_with_lease_push_report for lease/push proofs
  • canonical_secret_sweep_report + wired into final report grading
  • 5 new #189 tests (+ 6 #188 continuation tests)

Validation:

  • pytest tests/test_review_proofs.py -k continuation → 11 passed
  • pytest tests/test_review_proofs.py → 138 passed
  • pytest tests/ -q → full suite exit 0
  • Diff vs master: 3 files, scope clean

Note: Stack PR — merges into feat/issue-188-continuation-selection-wall (#246 already on master). Follow-up PR to master may be needed for #189 to land on master.

Verdict: Approve.

## Review summary Reviewed PR #253 at head `1158594a200bc7c118b9e3265375cb769f65b83a`. **Scope:** Closes #189 — continuation proofs for claim status, force-with-lease push evidence, and canonical secret sweep on top of #188. **Changes:** - `assess_continuation_mode_report` gains issue claim status evidence - `assess_force_with_lease_push_report` for lease/push proofs - `canonical_secret_sweep_report` + wired into final report grading - 5 new #189 tests (+ 6 #188 continuation tests) **Validation:** - `pytest tests/test_review_proofs.py -k continuation` → 11 passed - `pytest tests/test_review_proofs.py` → 138 passed - `pytest tests/ -q` → full suite exit 0 - Diff vs master: 3 files, scope clean **Note:** Stack PR — merges into `feat/issue-188-continuation-selection-wall` (#246 already on master). Follow-up PR to master may be needed for #189 to land on master. **Verdict:** Approve.
sysadmin merged commit 054628c50d into feat/issue-188-continuation-selection-wall 2026-07-06 11:27:26 -05:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#253