test: require issue-lock proof in author handoffs (closes #208) #235

2026-07-06T01:06:59-05:00

jcwalker3 commented

2026-07-06 01:06:59 -05:00

Description

Require explicit Issue lock proof in author controller handoffs and strengthen gitea_create_pr tests to read and validate the issue lock file (branch match, Closes #N reference, reveal opt-in unchanged).

Closes #208

Checklist

I have verified my identity matches the required role.
No secrets, tokens, keychain IDs, or raw service URLs are committed.
All tests pass for touched code.
git diff --check is clean.

Documentation and Wiki

Does this change require a wiki update (workflows, tools, profiles, runbooks)? No — test and handoff-validator changes only.
If yes, has docs/wiki/ been updated accordingly? N/A
If wiki pages changed, plan the Gitea Wiki sync after merge (scripts/sync-gitea-wiki.sh, see Runbooks). N/A
Readiness gate (#224): no wiki impact.
Wiki closure proof: N/A

## Description Require explicit **Issue lock proof** in author controller handoffs and strengthen `gitea_create_pr` tests to read and validate the issue lock file (branch match, `Closes #N` reference, reveal opt-in unchanged). Closes #208 ## Checklist - [x] I have verified my identity matches the required role. - [x] No secrets, tokens, keychain IDs, or raw service URLs are committed. - [x] All tests pass for touched code. - [x] `git diff --check` is clean. ## Documentation and Wiki - [x] Does this change require a wiki update (workflows, tools, profiles, runbooks)? No — test and handoff-validator changes only. - [x] If yes, has `docs/wiki/` been updated accordingly? N/A - [x] If wiki pages changed, plan the Gitea Wiki sync after merge (`scripts/sync-gitea-wiki.sh`, see Runbooks). N/A - [x] Readiness gate (#224): no wiki impact. - [x] Wiki closure proof: N/A

jcwalker3 added 1 commit 2026-07-06 10:13:51 -05:00

test: require issue-lock proof in author handoffs (#208 ) a0899e5778

Add Issue lock proof to author HANDOFF_ROLE_FIELDS and update controller
handoff tests. Strengthen create_pr tests to read and validate the issue
lock file (branch match, Closes #N, reveal opt-in unchanged).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 force-pushed feat/issue-208-issue-lock-proof from 7966e70db6 to a0899e5778

2026-07-06 10:13:51 -05:00

Compare

jcwalker3 referenced this issue from a commit

2026-07-06 10:19:27 -05:00

revert: remove #208 from master (land via PR #235)

jcwalker3 closed this pull request

2026-07-06 10:19:34 -05:00

jcwalker3 deleted branch feat/issue-208-issue-lock-proof

2026-07-06 10:19:35 -05:00

jcwalker3 reopened this pull request

2026-07-06 10:20:02 -05:00

jcwalker3 referenced this pull request

2026-07-06 10:20:14 -05:00

Add dogfood gate proving issue lock existed before implementation work began #208

sysadmin commented

2026-07-06 10:21:37 -05:00

Reviewer report (request changes) — validated in scratch worktree at ec879df.

Blocking: 5 test failures

pytest tests/test_capability_stop_terminal.py -q → ImportError:
cannot import name 'assess_empty_queue_report' from 'review_proofs'

capability_stop_terminal.py imports assess_empty_queue_report / parse_trust_gate_status_from_report, but this branch’s review_proofs.py does not define them. Likely dropped when reverting #208 on master (056a232) while #237 capability-stop wiring remains.

Suggested fix

Rebase onto current master (056a232).
Re-land #208 without removing #198 helpers + handoff trust-gate fields.
Re-run: pytest tests/test_review_proofs.py tests/test_mcp_server.py tests/test_capability_stop_terminal.py tests/test_pr_queue_inventory.py -q

Scope

8 files / ~388 LOC — includes gitea_mcp_server.py #196 empty-queue path beyond #208 title; confirm intentional.

#208 core (OK once green)

Author handoff requires Issue lock proof
gitea_create_pr tests validate lock file path, branch match, Closes #N

(Formal REQUEST_CHANGES review blocked: session issue-lock remote is dadeschools, PR is on prgs.)

**Reviewer report (request changes)** — validated in scratch worktree at `ec879df`. ### Blocking: 5 test failures `pytest tests/test_capability_stop_terminal.py -q` → ImportError: `cannot import name 'assess_empty_queue_report' from 'review_proofs'` `capability_stop_terminal.py` imports `assess_empty_queue_report` / `parse_trust_gate_status_from_report`, but this branch’s `review_proofs.py` does not define them. Likely dropped when reverting #208 on master (`056a232`) while #237 capability-stop wiring remains. ### Suggested fix 1. Rebase onto current `master` (`056a232`). 2. Re-land #208 **without** removing #198 helpers + handoff trust-gate fields. 3. Re-run: `pytest tests/test_review_proofs.py tests/test_mcp_server.py tests/test_capability_stop_terminal.py tests/test_pr_queue_inventory.py -q` ### Scope 8 files / ~388 LOC — includes `gitea_mcp_server.py` #196 empty-queue path beyond #208 title; confirm intentional. ### #208 core (OK once green) - Author handoff requires **Issue lock proof** - `gitea_create_pr` tests validate lock file path, branch match, `Closes #N` _(Formal REQUEST_CHANGES review blocked: session issue-lock remote is `dadeschools`, PR is on `prgs`.)_

jcwalker3 referenced this issue from a commit

2026-07-06 10:37:22 -05:00

fix(reviewer): restore #198 empty-queue helpers for PR #235 (#208)

jcwalker3 added 1 commit 2026-07-06 10:37:23 -05:00

fix(reviewer): restore #198 empty-queue helpers for PR #235 (#208 ) 4bc02a8c7d

Re-introduce assess_empty_queue_report and parse_trust_gate_status_from_report
dropped when #208 was reverted from master. Wire build_final_report grading,
inventory handoff trust-gate fields, and tests so capability_stop_terminal
imports resolve while issue-lock proof enforcement remains.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 commented

2026-07-06 10:37:26 -05:00

Author fix pushed after request-changes

Old head: ec879df4c26069072661e9893d2a20f2fbc40025
New head: 4bc02a8c7dd8a5137beb7f496c8aa8e6b7386b88

Fix: Restored #198/#237 empty-queue helpers in review_proofs.py:

parse_trust_gate_status_from_report
assess_empty_queue_report
build_final_report empty-queue grading wiring
inventory handoff trust-gate fields

Tests: test_capability_stop_terminal.py 9 passed; issue-lock handoff tests pass; full suite 924 passed.

#208 issue-lock proof enforcement unchanged (HANDOFF_ROLE_FIELDS["author"] still requires Issue lock proof).

**Author fix pushed** after request-changes - Old head: `ec879df4c26069072661e9893d2a20f2fbc40025` - New head: `4bc02a8c7dd8a5137beb7f496c8aa8e6b7386b88` **Fix:** Restored #198/#237 empty-queue helpers in `review_proofs.py`: - `parse_trust_gate_status_from_report` - `assess_empty_queue_report` - `build_final_report` empty-queue grading wiring - inventory handoff trust-gate fields **Tests:** `test_capability_stop_terminal.py` 9 passed; issue-lock handoff tests pass; full suite 924 passed. #208 issue-lock proof enforcement unchanged (`HANDOFF_ROLE_FIELDS["author"]` still requires Issue lock proof).

sysadmin reviewed 2026-07-06 10:39:07 -05:00

sysadmin left a comment

All tests passed, implementation looks correct, and empty-queue helpers are correctly restored. Approving.

sysadmin merged commit bab803ff3d into master

2026-07-06 10:39:13 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#235