Require explicit PR inventory trust-gate status in empty-queue reports #198

New Issue

2026-07-05T15:11:28-05:00

jcwalker3 commented

2026-07-05 15:11:28 -05:00

Problem

Agents can still claim an empty PR queue using raw pagination or weak corroboration instead of the formal PR inventory trust gate.

Observed failure

The agent claimed:

Open PR count: 0
Pagination complete: yes
"Queue cleared"
"Workflow correctly stops with nothing to review"

But the report did not show pr_inventory_trust_gate.status == trusted_empty. It also used weak corroboration: "master latest commit is merge of PR #79." A recent merge does not prove there are no other open PRs.

Required wall

Any report that says "no open PRs," "empty queue," or "nothing to review" must include the explicit PR inventory trust-gate result.

Required report fields

pr_inventory_trust_gate.status
reasons
corroborated
independent corroboration source, if any
exact remote / owner / repo / state filter
active MCP profile used for the inventory

Acceptance criteria

Empty queue reports without pr_inventory_trust_gate.status == trusted_empty are blocked.
"Latest commit was a PR merge" must not count as queue-empty corroboration.
Raw api_get_all exhaustion alone is insufficient unless the trust gate accepts it.
If the active MCP session is author-bound, reviewer queue inventory must not be presented as a reviewer decision.

#194 (false-empty PR queue investigation) — origin incident.
PR #195 — pr_inventory_trust_gate helper + unit tests.
#196 — wiring the gate into the live reviewer queue path (code enforcement); this issue is the reporting-wall counterpart: the gate result must be surfaced verbatim in every empty-queue report.
#191 / #183 — final-report hardening lineage.

### Problem Agents can still claim an empty PR queue using raw pagination or weak corroboration instead of the formal PR inventory trust gate. ### Observed failure The agent claimed: * `Open PR count: 0` * `Pagination complete: yes` * "Queue cleared" * "Workflow correctly stops with nothing to review" But the report did not show `pr_inventory_trust_gate.status == trusted_empty`. It also used weak corroboration: "master latest commit is merge of PR #79." A recent merge does not prove there are no other open PRs. ### Required wall Any report that says "no open PRs," "empty queue," or "nothing to review" must include the explicit PR inventory trust-gate result. ### Required report fields * `pr_inventory_trust_gate.status` * `reasons` * `corroborated` * independent corroboration source, if any * exact remote / owner / repo / state filter * active MCP profile used for the inventory ### Acceptance criteria * Empty queue reports without `pr_inventory_trust_gate.status == trusted_empty` are blocked. * "Latest commit was a PR merge" must not count as queue-empty corroboration. * Raw `api_get_all` exhaustion alone is insufficient unless the trust gate accepts it. * If the active MCP session is author-bound, reviewer queue inventory must not be presented as a reviewer decision. ### Related * #194 (false-empty PR queue investigation) — origin incident. * PR #195 — `pr_inventory_trust_gate` helper + unit tests. * #196 — wiring the gate into the live reviewer queue path (code enforcement); this issue is the reporting-wall counterpart: the gate result must be surfaced verbatim in every empty-queue report. * #191 / #183 — final-report hardening lineage.

jcwalker3 referenced this issue

2026-07-05 15:13:27 -05:00

Add hard queue-target resolution wall before PR inventory or empty-queue claims #200

jcwalker3 referenced this issue

2026-07-05 15:13:38 -05:00

Add hard queue-target resolution wall before PR inventory or empty-queue claims #201

sysadmin commented

2026-07-05 16:10:09 -05:00

Additional observed failure:

A run executed the full test suite and got a failure:

TestAuthorProofs.test_run expected no_local_work but got order_violation.

The run then continued to produce a final PR-inventory report instead of treating the failing validation as a blocker.

Required behavior:

Any failed validation command must be reported as a blocker.
A final report must not summarize the run as clean if tests failed.
If a test failure occurs during a reviewer/inventory task, the report must explicitly separate:
- PR inventory result;
- local workspace validation result;
- whether the failing test affects the current branch/PR.
If the active branch is unrelated to the target repo or review task, that must be disclosed.

Additional observed failure: A run executed the full test suite and got a failure: `TestAuthorProofs.test_run` expected `no_local_work` but got `order_violation`. The run then continued to produce a final PR-inventory report instead of treating the failing validation as a blocker. Required behavior: * Any failed validation command must be reported as a blocker. * A final report must not summarize the run as clean if tests failed. * If a test failure occurs during a reviewer/inventory task, the report must explicitly separate: * PR inventory result; * local workspace validation result; * whether the failing test affects the current branch/PR. * If the active branch is unrelated to the target repo or review task, that must be disclosed.

jcwalker3 added the status:in-progress label 2026-07-06 10:15:27 -05:00

jcwalker3 commented

2026-07-06 10:16:36 -05:00

Claimed and implementation started.

Branch: feat/issue-198-empty-queue-trust-gate-report
Adds assess_empty_queue_report + handoff/report integration
Blocks weak merge-commit corroboration and author-bound reviewer-queue claims
154 tests passed in targeted regression run

Opening PR next.

Claimed and implementation started. - Branch: `feat/issue-198-empty-queue-trust-gate-report` - Adds `assess_empty_queue_report` + handoff/report integration - Blocks weak merge-commit corroboration and author-bound reviewer-queue claims - 154 tests passed in targeted regression run Opening PR next.

jcwalker3 referenced this issue from a commit

2026-07-06 10:16:37 -05:00

feat(reviewer): require trust-gate proof in empty-queue reports (#198)

jcwalker3 referenced a pull request that will close this issue

2026-07-06 10:16:45 -05:00

feat(reviewer): require trust-gate proof in empty-queue reports (closes #198) #237

sysadmin referenced this issue

2026-07-06 10:18:50 -05:00

feat(reviewer): require trust-gate proof in empty-queue reports (closes #198) #237

sysadmin closed this issue

2026-07-06 10:18:55 -05:00

sysadmin referenced this issue from a commit