Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Add fail-closed PR inventory wall when list_prs returns an unexpected empty queue (Issue #194) #195

Merged
sysadmin merged 1 commits from feat/issue-194-fail-closed-pr-inventory-wall into master 2026-07-05 15:27:08 -05:00
Conversation 1 Commits 1 Files Changed 2
+177
jcwalker3 commented 2026-07-05 15:06:25 -05:00
Owner
Copy Link
Copy Source

Implements Issue #194. Adds the pr_inventory_trust_gate helper in review_proofs.py to verify empty PR queues before terminating work, preventing incorrect empty queue assertions. Includes comprehensive unit tests in test_review_proofs.py.

Closes #194

Implements Issue #194. Adds the pr_inventory_trust_gate helper in review_proofs.py to verify empty PR queues before terminating work, preventing incorrect empty queue assertions. Includes comprehensive unit tests in test_review_proofs.py. Closes #194
jcwalker3 added 1 commit 2026-07-05 15:06:26 -05:00
Implement fail-closed PR inventory trust gate for Issue #194 b354c93710
sysadmin reviewed 2026-07-05 15:27:02 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

Blind review (sysadmin / prgs-reviewer)

Pinned head: b354c937109667b4191c3f61f04eac859029e4f4
Live head recheck: matches pinned; PR open and mergeable.

Scope (#194)

Adds pr_inventory_trust_gate() to fail closed on untrusted empty PR inventory results (wrong repo scope, missing read permission proof, unproven pagination finality, local remote mismatch, user-context contradiction). Two files only; comprehensive unit tests. Additive harness helper — does not weaken review/merge gates.

Validation (reviewer rerun)

  • py_compile review_proofs.py tests/test_review_proofs.py — passed
  • pytest tests/test_review_proofs.py — 58 passed
  • pytest tests/test_review_proofs.py tests/test_pr_queue_inventory.py — 74 passed
  • pytest tests/ --ignore=branches — 704 passed, 6 skipped
  • git diff --check prgs/master...HEAD — clean
  • Secret sweep — only benign test fixture URLs

Note

Workflow/skill wiring for multi-repo inventory recommendations is follow-up beyond this helper; acceptable incremental step for #194.

Approved.

## Blind review (sysadmin / prgs-reviewer) **Pinned head:** `b354c937109667b4191c3f61f04eac859029e4f4` **Live head recheck:** matches pinned; PR open and mergeable. ### Scope (#194) Adds `pr_inventory_trust_gate()` to fail closed on untrusted empty PR inventory results (wrong repo scope, missing read permission proof, unproven pagination finality, local remote mismatch, user-context contradiction). Two files only; comprehensive unit tests. Additive harness helper — does not weaken review/merge gates. ### Validation (reviewer rerun) - `py_compile review_proofs.py tests/test_review_proofs.py` — passed - `pytest tests/test_review_proofs.py` — **58 passed** - `pytest tests/test_review_proofs.py tests/test_pr_queue_inventory.py` — **74 passed** - `pytest tests/ --ignore=branches` — **704 passed, 6 skipped** - `git diff --check prgs/master...HEAD` — clean - Secret sweep — only benign test fixture URLs ### Note Workflow/skill wiring for multi-repo inventory recommendations is follow-up beyond this helper; acceptable incremental step for #194. Approved.
sysadmin merged commit c6fd0fd963 into master 2026-07-05 15:27:08 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#195