feat: allow gitea.issue.comment for author/reviewer profiles (#137) #138

2026-07-05T01:10:25-05:00

jcwalker3 commented

2026-07-05 01:10:25 -05:00

Add support for gitea.issue.comment in profile normalization and examples so author and reviewer profiles can post to issue discussion threads via the gated tool.

Aliases and grants added
Tests and docs updated

Closes #137

No secrets, no prod, limited to permission gate enablement.

Add support for `gitea.issue.comment` in profile normalization and examples so author and reviewer profiles can post to issue discussion threads via the gated tool. - Aliases and grants added - Tests and docs updated Closes #137 No secrets, no prod, limited to permission gate enablement.

jcwalker3 added 1 commit 2026-07-05 01:10:26 -05:00

feat: allow gitea.issue.comment for author and reviewer profiles (#137 ) 3953b6bdd2

- Add aliases 'issue.comment' and 'issue_comment' to GITEA_OPERATION_ALIASES so short names normalize to gitea.issue.comment
- Grant 'issue.comment' (and short) in v2 example profiles for example-author and example-reviewer
- Grant in gitea-mcp.example.json mdcps-reviewer
- Update docs example profiles
- Add test coverage for new aliases and normalization

This enables gitea_create_issue_comment and list for profiles that include it, while preserving fail-closed for others and separation of duties (issue.comment does not imply pr.review etc).

Closes #137

sysadmin reviewed 2026-07-05 01:14:22 -05:00

sysadmin left a comment

Independent review result: APPROVE.

Reviewed PR #138 at pinned head 3953b6bdd232e81ee7f6e15cc2d0ab641db7a296.

Scope matches issue #137: adds explicit issue.comment / issue_comment normalization to gitea.issue.comment, updates example/profile docs to grant issue discussion comments separately, and preserves the existing separation from PR review/merge/branch permissions. The issue-comment tool remains gated by gitea.issue.comment; read/list remains gated by gitea.read; review/merge/authoring gates are not widened.

Validation run:

python3 -m pytest tests/test_op_normalization.py tests/test_mcp_server.py::TestIssueCommentTools tests/test_operator_guide.py -q: 60 passed
python3 -m pytest tests/ -q: 515 passed, 6 skipped
python3 -m py_compile gitea_config.py mcp_server.py tests/test_op_normalization.py tests/test_mcp_server.py tests/test_operator_guide.py: passed
git diff --check refs/remotes/prgs/master...HEAD: passed
Secret/provenance sweep of changed files: no credential values found; hits are existing/synthetic docs/examples and auth-reference text only

Note for operators: live profile config still needs the gitea.issue.comment operation present and the MCP session reloaded before currently connected author/reviewer sessions can post issue comments.

Independent review result: APPROVE. Reviewed PR #138 at pinned head `3953b6bdd232e81ee7f6e15cc2d0ab641db7a296`. Scope matches issue #137: adds explicit `issue.comment` / `issue_comment` normalization to `gitea.issue.comment`, updates example/profile docs to grant issue discussion comments separately, and preserves the existing separation from PR review/merge/branch permissions. The issue-comment tool remains gated by `gitea.issue.comment`; read/list remains gated by `gitea.read`; review/merge/authoring gates are not widened. Validation run: - `python3 -m pytest tests/test_op_normalization.py tests/test_mcp_server.py::TestIssueCommentTools tests/test_operator_guide.py -q`: 60 passed - `python3 -m pytest tests/ -q`: 515 passed, 6 skipped - `python3 -m py_compile gitea_config.py mcp_server.py tests/test_op_normalization.py tests/test_mcp_server.py tests/test_operator_guide.py`: passed - `git diff --check refs/remotes/prgs/master...HEAD`: passed - Secret/provenance sweep of changed files: no credential values found; hits are existing/synthetic docs/examples and auth-reference text only Note for operators: live profile config still needs the `gitea.issue.comment` operation present and the MCP session reloaded before currently connected author/reviewer sessions can post issue comments.

sysadmin merged commit 995bd168c6 into master

2026-07-05 01:14:38 -05:00

jcwalker3 referenced this pull request

2026-07-05 01:30:09 -05:00

Make Gitea MCP task routing role-aware instead of launcher-profile dependent #139

jcwalker3 referenced this issue from a commit

2026-07-05 01:40:44 -05:00

test: forward-direction issue-comment permission separation (#137 follow-up)

jcwalker3 referenced this pull request

2026-07-05 01:41:14 -05:00

test: forward-direction issue-comment permission separation (#137 follow-up) #140

Sign in to join this conversation.