fix: residual preflight/worktree/test-isolation remediations after #673 #675

New Issue

2026-07-11T18:49:12-05:00

jcwalker3 commented

2026-07-11 18:49:12 -05:00

Context

Issue #673 (repository-wide master test-suite regression) was remediated and merged via PR #674 (fix/issue-673-remediate-regressions → master at bee24e2).

After that merge, residual local follow-up work remained in an isolated worktree (fix/issue-673-remediate-regressions-part2) that was never published because the MCP session hit EOF mid-workflow. This issue tracks that residual remediation only.

Residual defects (part2)

Review worktree regex inconsistency — multiple modules use divergent patterns for review worktree path recognition (reviewer_worktree.py, reviewer_worktree_ownership.py, worktree_cleanup_audit.py, MCP preflight paths).
Web UI NameError on /worktrees — webui/worktree_scanner.py still references an unbound/mismatched REVIEW_WORKTREE_RE symbol in some code paths.
Test isolation gaps — workspace-guard alignment tests and root-checkout guard tests still leak host workspace state / real subprocess calls without proper mocks; tests/conftest.py needs stronger isolation defaults for preflight paths.
Test-mode workspace bypass — preflight must bypass host workspace checks under pytest so suite results stay deterministic.

Scope (files)

gitea_mcp_server.py
reviewer_worktree.py
reviewer_worktree_ownership.py
worktree_cleanup_audit.py
webui/worktree_scanner.py
tests/conftest.py
tests/test_root_checkout_guard.py
tests/test_workspace_guard_alignment.py

Acceptance

Residual part2 fixes land on a dedicated branch/PR linked to this issue.
Targeted preflight/worktree/guard tests pass from the author worktree.
PR body includes Closes #<this-issue>.
No reuse of closed #673 / merged #674 branch for new work.

## Context Issue #673 (repository-wide master test-suite regression) was remediated and merged via PR #674 (`fix/issue-673-remediate-regressions` → `master` at `bee24e2`). After that merge, residual local follow-up work remained in an isolated worktree (`fix/issue-673-remediate-regressions-part2`) that was never published because the MCP session hit EOF mid-workflow. This issue tracks that residual remediation only. ## Residual defects (part2) 1. **Review worktree regex inconsistency** — multiple modules use divergent patterns for review worktree path recognition (`reviewer_worktree.py`, `reviewer_worktree_ownership.py`, `worktree_cleanup_audit.py`, MCP preflight paths). 2. **Web UI NameError on `/worktrees`** — `webui/worktree_scanner.py` still references an unbound/mismatched `REVIEW_WORKTREE_RE` symbol in some code paths. 3. **Test isolation gaps** — workspace-guard alignment tests and root-checkout guard tests still leak host workspace state / real subprocess calls without proper mocks; `tests/conftest.py` needs stronger isolation defaults for preflight paths. 4. **Test-mode workspace bypass** — preflight must bypass host workspace checks under pytest so suite results stay deterministic. ## Scope (files) - `gitea_mcp_server.py` - `reviewer_worktree.py` - `reviewer_worktree_ownership.py` - `worktree_cleanup_audit.py` - `webui/worktree_scanner.py` - `tests/conftest.py` - `tests/test_root_checkout_guard.py` - `tests/test_workspace_guard_alignment.py` ## Acceptance - Residual part2 fixes land on a dedicated branch/PR linked to this issue. - Targeted preflight/worktree/guard tests pass from the author worktree. - PR body includes `Closes #<this-issue>`. - No reuse of closed #673 / merged #674 branch for new work. ## Related - Parent incident: #673 - Already merged remediation: PR #674

jcwalker3 added the type:bug status:in-progress labels 2026-07-11 18:49:55 -05:00

jcwalker3 commented

2026-07-11 18:49:56 -05:00

Issue claim heartbeat

kind: claim
issue: fix: residual preflight/worktree/test-isolation remediations after #673 (#675)
branch: fix/issue-675-residual-preflight-remediation
phase: claimed
profile: prgs-author
pr: none
blocker: none
next_action: create worktree and begin implementation

**Issue claim heartbeat** - kind: claim - issue: #675 - branch: fix/issue-675-residual-preflight-remediation - phase: claimed - profile: prgs-author - pr: none - blocker: none - next_action: create worktree and begin implementation

jcwalker3 referenced a pull request that will close this issue

2026-07-11 18:50:15 -05:00

fix: residual preflight/worktree/test-isolation remediations after #673 #676

jcwalker3 added status:pr-open and removed status:in-progress labels 2026-07-11 18:50:16 -05:00

sysadmin referenced this issue

2026-07-11 18:55:59 -05:00

fix: residual preflight/worktree/test-isolation remediations after #673 #676

sysadmin referenced this issue

2026-07-11 19:06:43 -05:00

fix: residual preflight/worktree/test-isolation remediations after #673 #676

sysadmin referenced a pull request that will close this issue

2026-07-11 19:09:11 -05:00