Scaled-Tech-Consulting/Gitea-Tools
2
0
Fork 0
Code Issues 73 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

fix(test): remediate repository-wide regressions (Closes #673) #674

Merged
sysadmin merged 1 commits from fix/issue-673-remediate-regressions into master 2026-07-11 18:16:05 -05:00
Conversation 4 Commits 1 Files Changed 12
+75 -21
jcwalker3 commented 2026-07-11 18:13:47 -05:00
Owner
Copy Link
Copy Source

Closes #673

Closes #673
jcwalker3 added 1 commit 2026-07-11 18:13:47 -05:00
fix(test): remediate repository-wide regressions (Closes #673) a7aac0df1d
sysadmin commented 2026-07-11 18:14:36 -05:00
Owner
Copy Link
Copy Source

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #674
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 12689-522eada16855
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions
phase: claimed
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-11T23:14:32Z
expires_at: 2026-07-12T01:14:32Z
blocker: none

<!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #674 issue: none reviewer_identity: sysadmin profile: prgs-reviewer session_id: 12689-522eada16855 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions phase: claimed candidate_head: none target_branch: master target_branch_sha: none last_activity: 2026-07-11T23:14:32Z expires_at: 2026-07-12T01:14:32Z blocker: none
sysadmin approved these changes 2026-07-11 18:15:21 -05:00
sysadmin left a comment
Owner
Copy Link
Copy Source

Review of PR #674

I have reviewed the changes in PR #674 (fix/issue-673-remediate-regressions) targeting the master branch. The PR addresses the repository-wide regressions (72 failing tests) caused by path alignment mismatches and environment cleanup during testing.

Verification

  • A full test suite execution was run on the exact current head (a7aac0df1d608317486c6958ec68b601e8d15bf8) inside the isolated worktree /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions.
  • All 2551 tests pass successfully (2545 passed, 6 skipped).

Canonical PR State

STATE: ready-for-merger
WHO_IS_NEXT: merger
NEXT_ACTION: Merge PR #674 into master.
NEXT_PROMPT:

Run gitea_merge_pr on remote 'prgs' for PR #674 to merge the remediation changes into master.

WHAT_HAPPENED: Reviewed PR #674 and verified 100% green test run on repair branch.
WHY: Fixes repository-wide regressions.
ISSUE: #673
HEAD_SHA: a7aac0df1d
REVIEW_STATUS: APPROVED
MERGE_READY: YES
BLOCKERS: none
VALIDATION: passed
LAST_UPDATED_BY: sysadmin / prgs-reviewer

Controller Handoff

  • Task: remediate repository-wide regressions
  • Repo: Scaled-Tech-Consulting/Gitea-Tools
  • Role: reviewer
  • Identity: sysadmin / prgs-reviewer
  • Active profile: prgs-reviewer
  • Runtime context: prgs
  • Selected PR: fix(test): remediate repository-wide regressions (Closes #673) (#674)
  • Linked issue: incident: repository-wide regression in master test suite (#673)
  • Eligibility class: PR_REVIEW_ELIGIBLE
  • Queue ordering policy: FIFO
  • Inventory pagination proof: inventory_complete=true
  • Earlier PRs skipped: none
  • Candidate head SHA: a7aac0df1d
  • Reviewed head SHA: a7aac0df1d
  • Target branch: master
  • Target branch SHA: ec903b0
  • Already-landed gate: not already landed
  • Author-safety result: passed
  • Prior request-changes state: none
  • Review worktree used: true
  • Review worktree path: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions
  • Review worktree inside branches: true
  • Review worktree HEAD state: clean
  • Review worktree dirty before validation: false
  • Review worktree dirty after validation: false
  • Baseline worktree used: false
  • Baseline worktree path: none
  • Files reviewed: mcp_daemon_guard.py, mcp_server.py, tests/test_author_mutation_worktree.py, tests/test_create_issue_workspace_guard.py, tests/test_issue_540_comment_role_poison.py, tests/test_issue_comment_workspace_guard.py, tests/test_mcp_daemon_guard.py, tests/test_mcp_server.py, tests/test_reconciler_close_workspace_guard.py, tests/test_root_checkout_guard.py, tests/test_workspace_guard_alignment.py, webui/worktree_scanner.py
  • Validation: /Users/jasonwalker/Development/Gitea-Tools/venv/bin/python3 -m pytest tests/ -> 2545 passed, 6 skipped, 0 failed
  • Official validation integrity status: passed
  • Terminal review mutation: approve
  • Review decision: APPROVED
  • Merge preflight: not run
  • Merge result: none
  • Linked issue status: status:pr-open
  • Main checkout branch: master
  • Main checkout dirty state: clean
  • Main checkout updated: false
  • File edits by reviewer: none
  • Worktree/index mutations: none
  • Git ref mutations: none
  • MCP/Gitea mutations: gitea_create_pr, gitea_lock_issue
  • Review mutations: gitea_submit_pr_review (completed)
  • Merge mutations: none
  • Cleanup mutations: none
  • External-state mutations: none
  • Read-only diagnostics: none
  • Blockers: none
  • Current status: review-completed
  • Safe next action: Switch to merger profile to merge PR #674.
  • Safety statement: I verify that the changes were tested inside an isolated worktree and that all 2551 tests pass successfully.
  • Workflow-load helper result: workflow_hash="da045d1e1f1f", final_report_schema_hash="a7634e7b8689", boundary_status="clean"
### Review of PR #674 I have reviewed the changes in PR #674 (`fix/issue-673-remediate-regressions`) targeting the `master` branch. The PR addresses the repository-wide regressions (72 failing tests) caused by path alignment mismatches and environment cleanup during testing. #### Verification * A full test suite execution was run on the exact current head (`a7aac0df1d608317486c6958ec68b601e8d15bf8`) inside the isolated worktree `/Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions`. * All 2551 tests pass successfully (2545 passed, 6 skipped). ## Canonical PR State STATE: ready-for-merger WHO_IS_NEXT: merger NEXT_ACTION: Merge PR #674 into master. NEXT_PROMPT: ```text Run gitea_merge_pr on remote 'prgs' for PR #674 to merge the remediation changes into master. ``` WHAT_HAPPENED: Reviewed PR #674 and verified 100% green test run on repair branch. WHY: Fixes repository-wide regressions. ISSUE: #673 HEAD_SHA: a7aac0df1d608317486c6958ec68b601e8d15bf8 REVIEW_STATUS: APPROVED MERGE_READY: YES BLOCKERS: none VALIDATION: passed LAST_UPDATED_BY: sysadmin / prgs-reviewer ## Controller Handoff - Task: remediate repository-wide regressions - Repo: Scaled-Tech-Consulting/Gitea-Tools - Role: reviewer - Identity: sysadmin / prgs-reviewer - Active profile: prgs-reviewer - Runtime context: prgs - Selected PR: #674 - Linked issue: #673 - Eligibility class: PR_REVIEW_ELIGIBLE - Queue ordering policy: FIFO - Inventory pagination proof: inventory_complete=true - Earlier PRs skipped: none - Candidate head SHA: a7aac0df1d608317486c6958ec68b601e8d15bf8 - Reviewed head SHA: a7aac0df1d608317486c6958ec68b601e8d15bf8 - Target branch: master - Target branch SHA: ec903b0 - Already-landed gate: not already landed - Author-safety result: passed - Prior request-changes state: none - Review worktree used: true - Review worktree path: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions - Review worktree inside branches: true - Review worktree HEAD state: clean - Review worktree dirty before validation: false - Review worktree dirty after validation: false - Baseline worktree used: false - Baseline worktree path: none - Files reviewed: mcp_daemon_guard.py, mcp_server.py, tests/test_author_mutation_worktree.py, tests/test_create_issue_workspace_guard.py, tests/test_issue_540_comment_role_poison.py, tests/test_issue_comment_workspace_guard.py, tests/test_mcp_daemon_guard.py, tests/test_mcp_server.py, tests/test_reconciler_close_workspace_guard.py, tests/test_root_checkout_guard.py, tests/test_workspace_guard_alignment.py, webui/worktree_scanner.py - Validation: /Users/jasonwalker/Development/Gitea-Tools/venv/bin/python3 -m pytest tests/ -> 2545 passed, 6 skipped, 0 failed - Official validation integrity status: passed - Terminal review mutation: approve - Review decision: APPROVED - Merge preflight: not run - Merge result: none - Linked issue status: status:pr-open - Main checkout branch: master - Main checkout dirty state: clean - Main checkout updated: false - File edits by reviewer: none - Worktree/index mutations: none - Git ref mutations: none - MCP/Gitea mutations: gitea_create_pr, gitea_lock_issue - Review mutations: gitea_submit_pr_review (completed) - Merge mutations: none - Cleanup mutations: none - External-state mutations: none - Read-only diagnostics: none - Blockers: none - Current status: review-completed - Safe next action: Switch to merger profile to merge PR #674. - Safety statement: I verify that the changes were tested inside an isolated worktree and that all 2551 tests pass successfully. - Workflow-load helper result: workflow_hash="da045d1e1f1f", final_report_schema_hash="a7634e7b8689", boundary_status="clean"
sysadmin commented 2026-07-11 18:15:55 -05:00
Owner
Copy Link
Copy Source

adopted_at: 2026-07-11T23:15:51Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 12689-522eada16855
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 10335
adoption_reason: merger-handoff-approved-head

repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #674
issue: none
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 12689-7d29c1445453
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions
phase: adopted
candidate_head: a7aac0df1d
target_branch: master
target_branch_sha: none
last_activity: 2026-07-11T23:15:51Z
expires_at: 2026-07-12T01:15:51Z
blocker: none

<!-- mcp-review-lease-adoption:v1 --> adopted_at: 2026-07-11T23:15:51Z adopted_by_identity: sysadmin adopted_by_profile: prgs-merger adopted_from_session_id: 12689-522eada16855 adopted_from_profile: prgs-reviewer adopted_from_reviewer_identity: sysadmin adopted_from_comment_id: 10335 adoption_reason: merger-handoff-approved-head <!-- mcp-review-lease:v1 --> repo: Scaled-Tech-Consulting/Gitea-Tools pr: #674 issue: none reviewer_identity: sysadmin profile: prgs-merger session_id: 12689-7d29c1445453 worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-673-remediate-regressions phase: adopted candidate_head: a7aac0df1d608317486c6958ec68b601e8d15bf8 target_branch: master target_branch_sha: none last_activity: 2026-07-11T23:15:51Z expires_at: 2026-07-12T01:15:51Z blocker: none
sysadmin merged commit bee24e2b10 into master 2026-07-11 18:16:05 -05:00
sysadmin commented 2026-07-11 19:04:27 -05:00
Owner
Copy Link
Copy Source

Stale #332 review-decision lock cleanup (#594)

Status: APPLIED

Manual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.

## Stale #332 review-decision lock cleanup (#594) Status: **APPLIED** - actor: `sysadmin` - profile: `prgs-reviewer` - timestamp: `2026-07-12T00:04:27.304170+00:00` - last terminal: `approve` on PR #674 - PR state: `closed` (merged=True) - merge_commit_sha: `bee24e2b102dbdc201932d2e5397a7d9e3be5fc5` - prior live_mutations_count: `1` - prior profile_identity: `prgs-reviewer` Manual deletion of session-state files is **not** the workflow. This path only clears a lock when the referenced PR is merged/closed.
Sign in to join this conversation.
Reviewers
No Reviewers
sysadmin
Labels
Clear labels
allocator
Controller-owned work allocator
 anti-stomp
Prevent concurrent LLM session stomping
 architecture
Architecture / structural design
 bug
chore
codex
OpenAI Codex client / workflow session surface
 concurrency
Concurrent session safety
 contamination
Workflow or session contamination incident
 control-plane
MCP control-plane coordination and allocation authority
 dashboard
MCP operational dashboard/queue view
 database
Internal coordination storage (SQLite/Postgres)
 design
Design / investigation, no implementation
 documentation
Docs / runbooks
 enhancement
New feature or improvement
 gitea
Gitea MCP workflow
 glitchtip
GlitchTip integration
 important
incident
Operational or process incident requiring durable audit trail
 incident-bridge
Sentry-to-Gitea incident bridging
 integration
Integration testing
 jenkins
Jenkins integration
 labels
Label taxonomy management
 leases
Lease adopt/release/expire lifecycle
 mcp
MCP server / tooling
 mcp-health
MCP namespace and runtime health
 mcp-menu
MCP menu surface
 multi-project
Work spanning multiple monitoring projects or Gitea repos
 mutating
Mutating action; requires gating
 nice-to-have
observability
Observability, metrics, traces, error reporting
 portability
Cross-platform / portability
 preflight
Shared preflight gates before mutation
 protected-branch
Protected branch / stable-branch policy concern
 queue
Work queue visibility and allocation
 read-only
Read-only, no mutation
 reconnect
MCP client reconnect/reload recovery path
 recovery
Recovery paths for stale/foreign leases
 refactor
Code refactor / restructure
 release
Release / versioning
 reliability
Reliability / failure handling
 resumable-review
Persist and resume prepared review verdicts across sessions
 reviewer
Reviewer workflow tooling
 roadmap
Roadmap / umbrella issue
 safety
Safety rails and fail-closed mutation guards
 security
Security / trust boundary
 self-hosted
Self-hosted infrastructure integration
 sentry
Sentry error monitoring integration
 stale-runtime
Stale backend daemon / runtime-vs-master parity failures
 status:blocked
Issue is blocked
 status:in-progress
Issue is being worked on
 status:pr-open
Issue has an open pull request
 status:ready
Issue is ready for work
 terminal-lock
Terminal review lock (#332) path
 testing
Tests / test coverage
 tracker
Issue tracker hygiene / meta
 type:bug
Bug or defect
 type:feature
Feature or enhancement
 type:feature
Feature or enhancement
 type:guardrail
Safety gate or guardrail
 visibility
Workflow state visibility for LLMs/operators
 workflow
Cross-tool workflow
 workflow-hardening
LLM workflow coordination hardening
 workflow-hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcwalker3 sysadmin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#674