feat: prove inventory pagination and worktree state in reviewer reports (Closes #293) #369

2026-07-07T04:40:11-05:00

jcwalker3 commented

2026-07-07 04:40:11 -05:00

Summary

Implements issue #293: reviewer final reports must prove PR inventory pagination completeness and report worktree state consistently.

Changes

Add reviewer_inventory_worktree.py with assess_inventory_worktree_report()
Reject partial first-page inventory claims and exactly-full pages without finality proof
Reject Scratch worktree used: false when a branches/ review worktree was used
Require consistent Review worktree used/path/HEAD state and Main checkout branch fields
Reject contradictory checkout wording (e.g. Detached HEAD / Branch master)
Wire verifier into build_final_report and export from review_proofs
Tests in tests/test_reviewer_inventory_worktree.py

Verification

pytest tests/test_reviewer_inventory_worktree.py tests/test_llm_workflow_split.py::test_inventory_worktree_verifier_exported -q

10 passed

## Summary Implements issue #293: reviewer final reports must prove PR inventory pagination completeness and report worktree state consistently. ## Changes - Add `reviewer_inventory_worktree.py` with `assess_inventory_worktree_report()` - Reject partial first-page inventory claims and exactly-full pages without finality proof - Reject `Scratch worktree used: false` when a `branches/` review worktree was used - Require consistent `Review worktree used/path/HEAD state` and `Main checkout branch` fields - Reject contradictory checkout wording (e.g. `Detached HEAD / Branch master`) - Wire verifier into `build_final_report` and export from `review_proofs` - Tests in `tests/test_reviewer_inventory_worktree.py` ## Verification ``` pytest tests/test_reviewer_inventory_worktree.py tests/test_llm_workflow_split.py::test_inventory_worktree_verifier_exported -q ``` 10 passed

jcwalker3 added 1 commit 2026-07-07 04:40:12 -05:00

feat: prove inventory pagination and worktree state in reviewer reports (#293 ) 1d3ee72274

Add assess_inventory_worktree_report verifier to reject partial PR inventory
claims, exactly-full first pages without finality proof, legacy scratch-worktree
flags that contradict branches/ review worktrees, and contradictory checkout
wording. Wire into build_final_report and export from review_proofs.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 referenced this pull request

2026-07-07 04:40:23 -05:00

Reviewer final reports must prove inventory completeness and worktree state consistently #293

jcwalker3 commented

2026-07-07 04:40:23 -05:00

Ready for review. Closes #293.

Verifier: reviewer_inventory_worktree.assess_inventory_worktree_report()
Tests: pytest tests/test_reviewer_inventory_worktree.py -q (10 passed)

Ready for review. Closes #293. Verifier: `reviewer_inventory_worktree.assess_inventory_worktree_report()` Tests: `pytest tests/test_reviewer_inventory_worktree.py -q` (10 passed)

jcwalker3 added 1 commit 2026-07-07 08:17:31 -05:00

fix: resolve conflicts for PR #366 against current master a5fb7d2472

jcwalker3 referenced this issue from a commit

2026-07-07 08:31:45 -05:00

fix: resolve conflicts for PR #369 against latest master

jcwalker3 added 1 commit 2026-07-07 08:31:45 -05:00

fix: resolve conflicts for PR #369 against latest master 51d0c14009

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 referenced this issue from a commit

2026-07-07 08:37:17 -05:00

fix: resolve conflicts for PR #369 against latest master

jcwalker3 added 1 commit 2026-07-07 08:37:17 -05:00

fix: resolve conflicts for PR #369 against latest master faf4484657

jcwalker3 referenced this issue from a commit

2026-07-07 08:44:16 -05:00

fix: resolve conflicts for PR #369 against current master

jcwalker3 added 1 commit 2026-07-07 08:44:16 -05:00

fix: resolve conflicts for PR #369 against current master 56f8f9eeb4

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

sysadmin approved these changes 2026-07-07 08:46:54 -05:00

sysadmin left a comment

All tests pass successfully after merging master (1369 passed, 1 failed [pre-existing]). Reviewed the implementation of assess_inventory_worktree_report in reviewer_inventory_worktree.py and the test coverage in tests/test_reviewer_inventory_worktree.py. It correctly validates PR inventory pagination completeness and checks that worktree fields (used/path/HEAD state) are reported consistently. Verified that the remaining failure is pre-existing on master.

All tests pass successfully after merging master (1369 passed, 1 failed [pre-existing]). Reviewed the implementation of `assess_inventory_worktree_report` in `reviewer_inventory_worktree.py` and the test coverage in `tests/test_reviewer_inventory_worktree.py`. It correctly validates PR inventory pagination completeness and checks that worktree fields (used/path/HEAD state) are reported consistently. Verified that the remaining failure is pre-existing on master.

sysadmin merged commit e7a1e183a0 into master

2026-07-07 08:47:06 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#369