feat: require infra_stop repair handoff for blocked reviewers (Closes #289) #366

2026-07-07T04:36:00-05:00

jcwalker3 commented

2026-07-07 04:36:00 -05:00

Summary

Closes #289

Adds assess_infra_stop_handoff_report to stop PR queue work when infra_stop blocks reviewer capability and require a repair handoff instead of stale PR review output.

Changes

New reviewer_infra_stop_handoff.py verifier
Re-export from review_proofs.py
Unit tests in tests/test_reviewer_infra_stop_handoff.py
Export test in tests/test_llm_workflow_split.py

Behavior

Blocks PR selection, queue advancement, and review mutations while infra_stop is active
Requires repair handoff or capability-stop terminal heading
Requires CONTROL-CHECKOUT REPAIR MODE for main-checkout diagnostics
Blocks schedule / manage_task workaround tools
Requires infra diagnostic fields (MCP root, git root, conflict path, safe next action)
Delegates to assess_capability_stop_report (#197) for additional purity checks

Testing

pytest tests/test_reviewer_infra_stop_handoff.py tests/test_llm_workflow_split.py::test_infra_stop_handoff_verifier_exported -q

8 passed

## Summary Closes #289 Adds `assess_infra_stop_handoff_report` to stop PR queue work when `infra_stop` blocks reviewer capability and require a repair handoff instead of stale PR review output. ## Changes - New `reviewer_infra_stop_handoff.py` verifier - Re-export from `review_proofs.py` - Unit tests in `tests/test_reviewer_infra_stop_handoff.py` - Export test in `tests/test_llm_workflow_split.py` ## Behavior - Blocks PR selection, queue advancement, and review mutations while `infra_stop` is active - Requires repair handoff or capability-stop terminal heading - Requires `CONTROL-CHECKOUT REPAIR MODE` for main-checkout diagnostics - Blocks `schedule` / `manage_task` workaround tools - Requires infra diagnostic fields (MCP root, git root, conflict path, safe next action) - Delegates to `assess_capability_stop_report` (#197) for additional purity checks ## Testing ``` pytest tests/test_reviewer_infra_stop_handoff.py tests/test_llm_workflow_split.py::test_infra_stop_handoff_verifier_exported -q ``` 8 passed

jcwalker3 added 1 commit 2026-07-07 04:36:01 -05:00

Add infra-stop repair handoff verifier for blocked reviewers (#289 ) 6be8f16351

Stop PR queue advancement when infra_stop blocks capability and require
CONTROL-CHECKOUT REPAIR MODE handoffs with infra diagnostics.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 commented

2026-07-07 04:36:05 -05:00

Ready for review — implements #289 with 8 passing tests in the targeted slice.

jcwalker3 referenced this issue from a commit

2026-07-07 08:17:30 -05:00

fix: resolve conflicts for PR #366 against current master

jcwalker3 added 1 commit 2026-07-07 08:17:30 -05:00

fix: resolve conflicts for PR #366 against current master c5ab43ed5a

jcwalker3 referenced this issue from a commit

2026-07-07 08:17:31 -05:00

fix: resolve conflicts for PR #366 against current master

jcwalker3 referenced this issue from a commit

2026-07-07 08:31:24 -05:00

fix: resolve conflicts for PR #366 against latest master

jcwalker3 added 1 commit 2026-07-07 08:31:24 -05:00

fix: resolve conflicts for PR #366 against latest master 8a6cb6ac2c

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 referenced this issue from a commit

2026-07-07 08:37:13 -05:00

fix: resolve conflicts for PR #366 against latest master

jcwalker3 added 1 commit 2026-07-07 08:37:14 -05:00

fix: resolve conflicts for PR #366 against latest master 93230457d8

sysadmin approved these changes 2026-07-07 08:39:22 -05:00

sysadmin left a comment

All tests pass successfully after merging master (1346 passed, 1 failed [pre-existing]). Reviewed the implementation of assess_infra_stop_handoff_report in reviewer_infra_stop_handoff.py and the test coverage in tests/test_reviewer_infra_stop_handoff.py. It correctly validates repair handoff purity when infra_stop blocks reviewer capabilities. Verified that the remaining failure is pre-existing on master.

All tests pass successfully after merging master (1346 passed, 1 failed [pre-existing]). Reviewed the implementation of `assess_infra_stop_handoff_report` in `reviewer_infra_stop_handoff.py` and the test coverage in `tests/test_reviewer_infra_stop_handoff.py`. It correctly validates repair handoff purity when infra_stop blocks reviewer capabilities. Verified that the remaining failure is pre-existing on master.

sysadmin merged commit a17e8561d0 into master

2026-07-07 08:39:36 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#366