feat: enforce precise mutation categories in controller handoffs (Closes #319) #365

2026-07-07T04:31:35-05:00

jcwalker3 commented

2026-07-07 04:31:35 -05:00

Summary

Closes #319

Adds assess_mutation_categories_report to require explicit mutation category fields in reviewer controller handoffs and reject legacy Workspace mutations wording.

Changes

New reviewer_mutation_categories.py verifier
Re-export from review_proofs.py
Unit tests in tests/test_reviewer_mutation_categories.py
Export test in tests/test_llm_workflow_split.py

Behavior

Blocks legacy Workspace mutations: fields in controller handoffs
Requires File edits by reviewer, Worktree/index mutations, and Git ref mutations
Delegates contradiction checks to assess_workspace_mutation_consistency (#313)
Distinguishes no file edits from worktree/index mutations

Testing

pytest tests/test_reviewer_mutation_categories.py tests/test_llm_workflow_split.py::test_mutation_categories_verifier_exported -q

8 passed

## Summary Closes #319 Adds `assess_mutation_categories_report` to require explicit mutation category fields in reviewer controller handoffs and reject legacy `Workspace mutations` wording. ## Changes - New `reviewer_mutation_categories.py` verifier - Re-export from `review_proofs.py` - Unit tests in `tests/test_reviewer_mutation_categories.py` - Export test in `tests/test_llm_workflow_split.py` ## Behavior - Blocks legacy `Workspace mutations:` fields in controller handoffs - Requires `File edits by reviewer`, `Worktree/index mutations`, and `Git ref mutations` - Delegates contradiction checks to `assess_workspace_mutation_consistency` (#313) - Distinguishes no file edits from worktree/index mutations ## Testing ``` pytest tests/test_reviewer_mutation_categories.py tests/test_llm_workflow_split.py::test_mutation_categories_verifier_exported -q ``` 8 passed

jcwalker3 added 1 commit 2026-07-07 04:31:35 -05:00

Add precise mutation category verifier for controller handoffs (#319 ) b71d3aeab3

Reject legacy Workspace mutations wording and require explicit file,
worktree/index, and git ref mutation fields in reviewer controller handoffs.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 commented

2026-07-07 04:31:39 -05:00

Ready for review — implements #319 with 8 passing tests in the targeted slice.

jcwalker3 referenced this issue from a commit

2026-07-07 08:17:30 -05:00

fix: resolve conflicts for PR #365 against current master

jcwalker3 added 1 commit 2026-07-07 08:17:30 -05:00

fix: resolve conflicts for PR #365 against current master a237b15559

jcwalker3 referenced this issue from a commit

2026-07-07 08:28:26 -05:00

fix: resolve conflicts for PR #365 against latest master

jcwalker3 added 1 commit 2026-07-07 08:28:26 -05:00

fix: resolve conflicts for PR #365 against latest master e823000301

sysadmin approved these changes 2026-07-07 08:33:41 -05:00

sysadmin left a comment

All tests pass successfully after merging master (1331 passed, 1 failed [pre-existing]). Reviewed the implementation of assess_mutation_categories_report in reviewer_mutation_categories.py and the test coverage in tests/test_reviewer_mutation_categories.py. It correctly requires precise mutation categories (file edits by reviewer, worktree/index mutations, git ref mutations) in reviewer controller handoffs, and blocks legacy vague fields. Verified that the remaining failure is pre-existing on master.

All tests pass successfully after merging master (1331 passed, 1 failed [pre-existing]). Reviewed the implementation of `assess_mutation_categories_report` in `reviewer_mutation_categories.py` and the test coverage in `tests/test_reviewer_mutation_categories.py`. It correctly requires precise mutation categories (file edits by reviewer, worktree/index mutations, git ref mutations) in reviewer controller handoffs, and blocks legacy vague fields. Verified that the remaining failure is pre-existing on master.

sysadmin merged commit 8b9a0705b6 into master

2026-07-07 08:33:57 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#365