feat: block edits in PR validation worktrees (Closes #315) #363

2026-07-07T04:28:36-05:00

jcwalker3 commented

2026-07-07 04:28:36 -05:00

Summary

Closes #315

Adds assess_validation_worktree_edit_report to keep PR validation worktrees read-only and require separate diagnostic scratch worktrees for local-fix experiments.

Changes

New reviewer_validation_worktree_edits.py verifier
Re-export from review_proofs.py
Unit tests in tests/test_reviewer_validation_worktree_edits.py
Export test in tests/test_llm_workflow_split.py

Behavior

Blocks file edits inside PR validation worktrees (branches/review-pr*)
Diagnostic experiments require separate scratch worktree path and diagnostic labeling
Rejects File edits by reviewer: none when edits occurred
Blocks reporting post-edit results as official PR-head validation

Testing

pytest tests/test_reviewer_validation_worktree_edits.py tests/test_llm_workflow_split.py::test_validation_worktree_edit_verifier_exported -q

8 passed

## Summary Closes #315 Adds `assess_validation_worktree_edit_report` to keep PR validation worktrees read-only and require separate diagnostic scratch worktrees for local-fix experiments. ## Changes - New `reviewer_validation_worktree_edits.py` verifier - Re-export from `review_proofs.py` - Unit tests in `tests/test_reviewer_validation_worktree_edits.py` - Export test in `tests/test_llm_workflow_split.py` ## Behavior - Blocks file edits inside PR validation worktrees (`branches/review-pr*`) - Diagnostic experiments require separate scratch worktree path and diagnostic labeling - Rejects `File edits by reviewer: none` when edits occurred - Blocks reporting post-edit results as official PR-head validation ## Testing ``` pytest tests/test_reviewer_validation_worktree_edits.py tests/test_llm_workflow_split.py::test_validation_worktree_edit_verifier_exported -q ``` 8 passed

jcwalker3 added 1 commit 2026-07-07 04:28:36 -05:00

Add validation worktree no-edit verifier for reviewer reports (#315 ) b842a7f923

Block file edits in PR validation worktrees, require separate diagnostic
scratch worktrees with explicit labeling, and reject contradictory
File edits by reviewer: none claims.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

jcwalker3 commented

2026-07-07 04:28:41 -05:00

Ready for review — implements #315 with 8 passing tests in the targeted slice.

jcwalker3 referenced this issue from a commit

2026-07-07 04:33:17 -05:00

fix: resolve conflicts for PR #363

jcwalker3 added 1 commit 2026-07-07 04:33:17 -05:00

fix: resolve conflicts for PR #363 7c7aa1ac2d

jcwalker3 referenced this issue from a commit

2026-07-07 08:17:13 -05:00

fix: resolve conflicts for PR #363 against current master

jcwalker3 added 1 commit 2026-07-07 08:17:13 -05:00

fix: resolve conflicts for PR #363 against current master 07b23950ab

sysadmin approved these changes 2026-07-07 08:22:43 -05:00

sysadmin left a comment

All tests pass successfully after merging master (1272 passed, 1 failed [pre-existing]). Reviewed the implementation of assess_validation_worktree_edit_report in reviewer_validation_worktree_edits.py and the test coverage in tests/test_reviewer_validation_worktree_edits.py. It correctly blocks edits inside PR validation worktrees and requires separate scratch worktrees for diagnostic experiments. Verified that the remaining failure is pre-existing on master.

All tests pass successfully after merging master (1272 passed, 1 failed [pre-existing]). Reviewed the implementation of `assess_validation_worktree_edit_report` in `reviewer_validation_worktree_edits.py` and the test coverage in `tests/test_reviewer_validation_worktree_edits.py`. It correctly blocks edits inside PR validation worktrees and requires separate scratch worktrees for diagnostic experiments. Verified that the remaining failure is pre-existing on master.

sysadmin merged commit e26398b7a9 into master

2026-07-07 08:22:58 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#363