feat: block reviewer local Gitea fallbacks during normal review (Closes #324) #350

2026-07-07T04:06:54-05:00

jcwalker3 commented

2026-07-07 04:06:54 -05:00

Summary

Adds assess_reviewer_fallback_report to fail closed when normal reviewer workflows read profile secret files or run local Gitea helper scripts while MCP tools are available (#324).

Changes

New reviewer_fallback.py with detection for profiles.json access, local script invocations, and env-driven fallback runs
Recovery mode requires explicit fallback classification plus identity/profile/repo/capability proof
Re-export from review_proofs.py
8 tests covering MCP-available violations, recovery proof pass/fail, and export

Verification

pytest tests/test_reviewer_fallback.py tests/test_review_proofs.py -q

158 passed

Closes #324

## Summary Adds `assess_reviewer_fallback_report` to fail closed when normal reviewer workflows read profile secret files or run local Gitea helper scripts while MCP tools are available (#324). ## Changes - New `reviewer_fallback.py` with detection for `profiles.json` access, local script invocations, and env-driven fallback runs - Recovery mode requires explicit fallback classification plus identity/profile/repo/capability proof - Re-export from `review_proofs.py` - 8 tests covering MCP-available violations, recovery proof pass/fail, and export ## Verification ``` pytest tests/test_reviewer_fallback.py tests/test_review_proofs.py -q ``` 158 passed Closes #324

jcwalker3 commented

2026-07-07 04:06:58 -05:00

Ready for review.

reviewer_fallback.py + assess_reviewer_fallback_report export
8 new tests; pytest tests/test_reviewer_fallback.py tests/test_review_proofs.py -q — 158 passed

Ready for review. - `reviewer_fallback.py` + `assess_reviewer_fallback_report` export - 8 new tests; `pytest tests/test_reviewer_fallback.py tests/test_review_proofs.py -q` — 158 passed

jcwalker3 added 1 commit 2026-07-07 04:27:43 -05:00

feat: block reviewer local Gitea fallbacks during normal review (Closes #324 ) bc227a9a6d

jcwalker3 force-pushed feat/issue-324-reviewer-no-fallback from 186aceb5fd to bc227a9a6d

2026-07-07 04:27:43 -05:00

Compare

jcwalker3 referenced this issue from a commit

2026-07-07 04:33:51 -05:00

fix: resolve conflicts for PR #350

jcwalker3 added 1 commit 2026-07-07 04:33:51 -05:00

fix: resolve conflicts for PR #350 f2d82a93ed

sysadmin approved these changes 2026-07-07 04:36:58 -05:00

sysadmin left a comment

All tests pass successfully. Reviewed the implementation in review_proofs.py, reviewer_fallback.py and test coverage in tests/test_reviewer_fallback.py. It correctly blocks local Gitea fallbacks and profile secret access during normal reviewer workflows, while allowing and requiring exact proofs in recovery mode, matching the acceptance criteria of Issue #324. Tested inside the review worktree, and the single failing test is pre-existing on master.

sysadmin merged commit fa0cb12464 into master

2026-07-07 04:37:13 -05:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scaled-Tech-Consulting/Gitea-Tools#350