Clean recreation of the #204 exact-issue-lock work after PR #205 was closed for invalid provenance (opened by the reviewer identity sysadmin, commits authored under the mdcps identity, undeclared stack on PR #203, no issue lock).
Issue lock: #204 claimed (status:in-progress + lock comment) before any tracked-file edit, branch, or commit in this run.
Base: current master (c6fd0fd, includes the merged #195 trust gate). Contains NO commit from PR #203 (10d2644 excluded); not stacked work.
The lock comment on #204 recorded base 4dcf8fd; master advanced to c6fd0fd (PR #195 merge) before branch creation — drift detected and reconciled by branching from the newer master; noted per #177 drift-reporting rules.
mcp_server.py — new gitea_lock_issue tool: locks exactly one issue to its branch name; fails closed when the branch name lacks issue-<n>, and when the issue is already tied to an open PR (by head branch or Closes/Fixes reference). New ISSUE_LOCK_FILE constant; import json added.
mcp_server.py — gitea_create_pr now fail-closed requires the lock: lock file present, head equals locked branch, no forbidden ambiguity terms ("equivalent", "related", "same as"), and Closes/Fixes #<locked issue> present exactly.
scripts/worktree-start — refuses issue-linked worktree creation unless the lock file exists and matches the requested branch.
review_proofs.py — assess_controller_handoff rejects selected-issue / opened-PR fields containing multiple numbers or fuzzy equivalence wording (exactly one issue, exactly one PR).
Tests — TestIssueLocking (8 tests: lock success, branch mismatch, open-PR reuse by branch and by Closes-ref, create_pr missing-lock/branch-mismatch/forbidden-terms/missing-Closes), handoff exact-reference tests, worktree-start lock coverage.
Validation (exact results, worktree at b8916bc on base c6fd0fd):
python3 -m py_compile mcp_server.py tests/test_mcp_server.py review_proofs.py tests/test_review_proofs.py tests/test_worktrees.py → OK
Clean recreation of the #204 exact-issue-lock work after PR #205 was closed for invalid provenance (opened by the reviewer identity `sysadmin`, commits authored under the mdcps identity, undeclared stack on PR #203, no issue lock).
Provenance for this PR:
- Author identity: `jcwalker3 / prgs-author` end-to-end — issue claim, branch, commit (`b8916bc713f0127aaa4c7d0b2f6da098504f02ea`, author `[email protected]`), push, and PR creation.
- Issue lock: #204 claimed (`status:in-progress` + lock comment) before any tracked-file edit, branch, or commit in this run.
- Base: current `master` (`c6fd0fd`, includes the merged #195 trust gate). Contains NO commit from PR #203 (`10d2644` excluded); not stacked work.
- The lock comment on #204 recorded base `4dcf8fd`; master advanced to `c6fd0fd` (PR #195 merge) before branch creation — drift detected and reconciled by branching from the newer master; noted per #177 drift-reporting rules.
Changes (only #204 scope):
1. `mcp_server.py` — new `gitea_lock_issue` tool: locks exactly one issue to its branch name; fails closed when the branch name lacks `issue-<n>`, and when the issue is already tied to an open PR (by head branch or Closes/Fixes reference). New `ISSUE_LOCK_FILE` constant; `import json` added.
2. `mcp_server.py` — `gitea_create_pr` now fail-closed requires the lock: lock file present, head equals locked branch, no forbidden ambiguity terms ("equivalent", "related", "same as"), and `Closes/Fixes #<locked issue>` present exactly.
3. `scripts/worktree-start` — refuses issue-linked worktree creation unless the lock file exists and matches the requested branch.
4. `review_proofs.py` — `assess_controller_handoff` rejects selected-issue / opened-PR fields containing multiple numbers or fuzzy equivalence wording (exactly one issue, exactly one PR).
5. Tests — `TestIssueLocking` (8 tests: lock success, branch mismatch, open-PR reuse by branch and by Closes-ref, create_pr missing-lock/branch-mismatch/forbidden-terms/missing-Closes), handoff exact-reference tests, worktree-start lock coverage.
Validation (exact results, worktree at `b8916bc` on base `c6fd0fd`):
- `python3 -m py_compile mcp_server.py tests/test_mcp_server.py review_proofs.py tests/test_review_proofs.py tests/test_worktrees.py` → OK
- `venv/bin/python -m pytest tests/test_mcp_server.py -q` → 145 passed
- `venv/bin/python -m pytest tests/test_review_proofs.py tests/test_worktrees.py -q` → 79 passed
- `PYTHONPATH=. venv/bin/python -m pytest tests/ --ignore=branches -q` → 743 passed, 6 skipped
- `git diff --check --cached` → clean
- Secret/provenance sweep: `git diff --cached | grep -inE "password|api[_-]?key|authorization|bearer|BEGIN (RSA|EC|OPENSSH|PRIVATE)|https?://"` → only `example.com` test fixtures
No review/merge gate is weakened; all new checks are strictly additive. No review, approval, or merge performed by this run.
Closes #204
Co-Authored-By: Claude Fable 5 <[email protected]>
Selected PR #213 because it is the oldest open PR that is not self-authored, not draft/WIP, reviewer-eligible for sysadmin / prgs-reviewer, and not already blocked by an active review. PR #187 was older but already has a current REQUEST_CHANGES review; #213 is therefore the next eligible PR under the queue rules.
Pinned head reviewed for this decision: b8916bc713f0127aaa4c7d0b2f6da098504f02ea (feat/issue-204-exact-issue-lock-v2).
Blocker:
PR #213 is currently stale/conflicted against master. Gitea reports mergeable=false; local base check shows current prgs/master is 34a26d1c14cca9a9d6a80e750ecce9e05ad961a7, while the PR merge-base is c6fd0fd96393151dc7821347d926a1ec01460efb, so the PR branch does not contain current master.
I checked whether this reviewer session can use the conflict-resolution path. Exact remediation capability is not available: push_branch and address_pr_change_requests require gitea.branch.push under an author role, while prgs-reviewer explicitly forbids gitea.branch.push and gitea.repo.commit. Therefore I did not modify, commit, or push the PR branch.
git diff prgs/master...prgs/feat/issue-204-exact-issue-lock-v2 | rg -n "password|api[_-]?key|authorization|bearer|BEGIN (RSA|EC|OPENSSH|PRIVATE)|ghp_|glpat-|xox[baprs]-|AKIA|AIza|token|secret|https?://" -> only expected documentation/test strings: endpoint-token-source doc text and https://example.com test fixtures; no credential values.
Required author follow-up:
Rebase or merge current master into feat/issue-204-exact-issue-lock-v2.
Resolve conflicts strictly within Issue #204 scope.
Rerun targeted tests, full suite, py_compile, git diff --check, and secret/provenance sweep.
Push the updated branch for re-review.
No merge attempted.
REQUEST_CHANGES
Selected PR #213 because it is the oldest open PR that is not self-authored, not draft/WIP, reviewer-eligible for `sysadmin / prgs-reviewer`, and not already blocked by an active review. PR #187 was older but already has a current `REQUEST_CHANGES` review; #213 is therefore the next eligible PR under the queue rules.
Pinned head reviewed for this decision: `b8916bc713f0127aaa4c7d0b2f6da098504f02ea` (`feat/issue-204-exact-issue-lock-v2`).
Blocker:
- PR #213 is currently stale/conflicted against `master`. Gitea reports `mergeable=false`; local base check shows current `prgs/master` is `34a26d1c14cca9a9d6a80e750ecce9e05ad961a7`, while the PR merge-base is `c6fd0fd96393151dc7821347d926a1ec01460efb`, so the PR branch does not contain current master.
- I checked whether this reviewer session can use the conflict-resolution path. Exact remediation capability is not available: `push_branch` and `address_pr_change_requests` require `gitea.branch.push` under an author role, while `prgs-reviewer` explicitly forbids `gitea.branch.push` and `gitea.repo.commit`. Therefore I did not modify, commit, or push the PR branch.
Read-only checks run:
- `git diff --name-status prgs/master...prgs/feat/issue-204-exact-issue-lock-v2` -> changed files: `mcp_server.py`, `review_proofs.py`, `scripts/worktree-start`, `tests/test_mcp_server.py`, `tests/test_review_proofs.py`, `tests/test_worktrees.py`.
- `git diff --check prgs/master...prgs/feat/issue-204-exact-issue-lock-v2` -> clean.
- `git diff prgs/master...prgs/feat/issue-204-exact-issue-lock-v2 | rg -n "password|api[_-]?key|authorization|bearer|BEGIN (RSA|EC|OPENSSH|PRIVATE)|ghp_|glpat-|xox[baprs]-|AKIA|AIza|token|secret|https?://"` -> only expected documentation/test strings: endpoint-token-source doc text and `https://example.com` test fixtures; no credential values.
Required author follow-up:
- Rebase or merge current `master` into `feat/issue-204-exact-issue-lock-v2`.
- Resolve conflicts strictly within Issue #204 scope.
- Rerun targeted tests, full suite, py_compile, `git diff --check`, and secret/provenance sweep.
- Push the updated branch for re-review.
No merge attempted.
Recreation of the #204 work from closed PR #205 (invalid provenance), rebuilt
cleanly on master under the prgs author identity with no PR #203 content:
- Add gitea_lock_issue MCP tool: locks exactly one issue to its branch name,
fails closed on branch/issue-number mismatch and on issues already tied to
an open PR (by head branch or Closes/Fixes reference).
- gitea_create_pr now requires the issue lock: head must match the locked
branch, title/body must contain Closes/Fixes #<locked issue> exactly, and
ambiguous references (equivalent / related / same as) are rejected.
- scripts/worktree-start refuses to create an issue-linked worktree unless the
lock file exists and matches the requested branch.
- assess_controller_handoff rejects handoffs whose selected issue / opened PR
fields carry multiple numbers or fuzzy equivalence wording.
- Tests: TestIssueLocking (lock + create_pr gates), handoff exact-reference
tests, worktree-start lock coverage.
Closes#204
Co-Authored-By: Claude Fable 5 <[email protected]>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
sysadmin
Clean recreation of the #204 exact-issue-lock work after PR #205 was closed for invalid provenance (opened by the reviewer identity
sysadmin, commits authored under the mdcps identity, undeclared stack on PR #203, no issue lock).Provenance for this PR:
jcwalker3 / prgs-authorend-to-end — issue claim, branch, commit (b8916bc713f0127aaa4c7d0b2f6da098504f02ea, author[email protected]), push, and PR creation.status:in-progress+ lock comment) before any tracked-file edit, branch, or commit in this run.master(c6fd0fd, includes the merged #195 trust gate). Contains NO commit from PR #203 (10d2644excluded); not stacked work.4dcf8fd; master advanced toc6fd0fd(PR #195 merge) before branch creation — drift detected and reconciled by branching from the newer master; noted per #177 drift-reporting rules.Changes (only #204 scope):
mcp_server.py— newgitea_lock_issuetool: locks exactly one issue to its branch name; fails closed when the branch name lacksissue-<n>, and when the issue is already tied to an open PR (by head branch or Closes/Fixes reference). NewISSUE_LOCK_FILEconstant;import jsonadded.mcp_server.py—gitea_create_prnow fail-closed requires the lock: lock file present, head equals locked branch, no forbidden ambiguity terms ("equivalent", "related", "same as"), andCloses/Fixes #<locked issue>present exactly.scripts/worktree-start— refuses issue-linked worktree creation unless the lock file exists and matches the requested branch.review_proofs.py—assess_controller_handoffrejects selected-issue / opened-PR fields containing multiple numbers or fuzzy equivalence wording (exactly one issue, exactly one PR).TestIssueLocking(8 tests: lock success, branch mismatch, open-PR reuse by branch and by Closes-ref, create_pr missing-lock/branch-mismatch/forbidden-terms/missing-Closes), handoff exact-reference tests, worktree-start lock coverage.Validation (exact results, worktree at
b8916bcon basec6fd0fd):python3 -m py_compile mcp_server.py tests/test_mcp_server.py review_proofs.py tests/test_review_proofs.py tests/test_worktrees.py→ OKvenv/bin/python -m pytest tests/test_mcp_server.py -q→ 145 passedvenv/bin/python -m pytest tests/test_review_proofs.py tests/test_worktrees.py -q→ 79 passedPYTHONPATH=. venv/bin/python -m pytest tests/ --ignore=branches -q→ 743 passed, 6 skippedgit diff --check --cached→ cleangit diff --cached | grep -inE "password|api[_-]?key|authorization|bearer|BEGIN (RSA|EC|OPENSSH|PRIVATE)|https?://"→ onlyexample.comtest fixturesNo review/merge gate is weakened; all new checks are strictly additive. No review, approval, or merge performed by this run.
Closes #204
Co-Authored-By: Claude Fable 5 [email protected]
REQUEST_CHANGES
Selected PR #213 because it is the oldest open PR that is not self-authored, not draft/WIP, reviewer-eligible for
sysadmin / prgs-reviewer, and not already blocked by an active review. PR #187 was older but already has a currentREQUEST_CHANGESreview; #213 is therefore the next eligible PR under the queue rules.Pinned head reviewed for this decision:
b8916bc713f0127aaa4c7d0b2f6da098504f02ea(feat/issue-204-exact-issue-lock-v2).Blocker:
master. Gitea reportsmergeable=false; local base check shows currentprgs/masteris34a26d1c14cca9a9d6a80e750ecce9e05ad961a7, while the PR merge-base isc6fd0fd96393151dc7821347d926a1ec01460efb, so the PR branch does not contain current master.push_branchandaddress_pr_change_requestsrequiregitea.branch.pushunder an author role, whileprgs-reviewerexplicitly forbidsgitea.branch.pushandgitea.repo.commit. Therefore I did not modify, commit, or push the PR branch.Read-only checks run:
git diff --name-status prgs/master...prgs/feat/issue-204-exact-issue-lock-v2-> changed files:mcp_server.py,review_proofs.py,scripts/worktree-start,tests/test_mcp_server.py,tests/test_review_proofs.py,tests/test_worktrees.py.git diff --check prgs/master...prgs/feat/issue-204-exact-issue-lock-v2-> clean.git diff prgs/master...prgs/feat/issue-204-exact-issue-lock-v2 | rg -n "password|api[_-]?key|authorization|bearer|BEGIN (RSA|EC|OPENSSH|PRIVATE)|ghp_|glpat-|xox[baprs]-|AKIA|AIza|token|secret|https?://"-> only expected documentation/test strings: endpoint-token-source doc text andhttps://example.comtest fixtures; no credential values.Required author follow-up:
masterintofeat/issue-204-exact-issue-lock-v2.git diff --check, and secret/provenance sweep.No merge attempted.
b8916bc713to8ec69cdd35Author update — ready for re-review
Identity:
jcwalker3 / prgs-authorNew head SHA:
8ec69cdd355d320e9bc71bfcd71f286b2f6ea63eBase: current
prgs/master(5b9fcae)Blockers addressed
feat/issue-204-exact-issue-lock-v2onto currentmaster(staleness/conflict).tests/test_mcp_server.pyresolved: kept bothTestVerifyMutationAuthorityandTestIssueLocking.Validation
pytest tests/test_mcp_server.py tests/test_review_proofs.py tests/test_worktrees.py -qpytest -qpython3 -m py_compile(changed files)git diff --check prgs/master...HEADBranch is mergeable. Prior
REQUEST_CHANGESwas pinned tob8916bc; please re-review at the new head.Approved! Verified exact issue lock and clean provenance matching all requirements. All tests passing successfully.