sysadmin
e9c67e7292
Make the nine-line compact Controller Handoff the default end-of-task format; reserve the long Controller Handoff Summary for high-risk/complex tasks (merge/tag/release, failed validation, blocked gates, secrets/prod, complicated owner decisions, cross-repo state, or explicit owner request). Compact form is for controller-LLM readability, safety confirmations are never omitted, and PR bodies still carry full review detail. Updates SKILL.md §K, llm-workflow-runbooks.md, and the start-issue / review-pr templates. Documentation only. Refs #101. Closes #108. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
39 lines
1.7 KiB
Markdown
39 lines
1.7 KiB
Markdown
# Template: review a PR
|
|
|
|
Copy, fill the `<...>` fields, and paste as the task prompt.
|
|
|
|
```text
|
|
Task: review PR #<pr> for issue #<n>.
|
|
|
|
Rules (llm-project-workflow):
|
|
- Review in a SEPARATE detached review worktree, never the author's folder.
|
|
- You must NOT be the PR author. If the authenticated user == PR author, stop.
|
|
A different LLM-Agent-SHA does NOT make you a different actor — only a
|
|
different authenticated Gitea user does (docs/llm-agent-sha.md).
|
|
- Do not merge if any check fails.
|
|
|
|
Steps:
|
|
1. Verify your authenticated identity (whoami) and the active profile.
|
|
2. Fetch the PR facts: PR author, head SHA, state (must be open), base branch.
|
|
3. If authenticated user == PR author → STOP (no self-review).
|
|
4. scripts/worktree-review <pr-head-branch> # detached, branches/review-*
|
|
cd branches/review-<pr-head-branch-slug>
|
|
5. Confirm the worktree is clean. Inspect the FULL diff; confirm scope matches
|
|
issue #<n>; flag any unrelated files, secrets, or formatting churn.
|
|
6. Run the test suite; note results.
|
|
7. Post the review verdict: approve only if scope is clean and checks pass;
|
|
otherwise request changes with specifics. Never merge from this review step.
|
|
Include a "Review Metadata" block (attribution only — docs/llm-agent-sha.md):
|
|
|
|
Review Metadata:
|
|
- LLM-Agent-SHA: llm-<12 lowercase hex, e.g. llm-41d0e7aa9f2c>
|
|
- LLM-Role: reviewer
|
|
- Authenticated-Gitea-User: <whoami result>
|
|
- MCP-Profile: <profile name>
|
|
- Eligibility: passed/failed
|
|
|
|
Handoff: reviewer identity, PR author, scope verdict, checks + results, decision —
|
|
formatted per SKILL.md §K (compact by default; long form if a merge happened
|
|
or a gate blocked you); if you could not merge, name the exact gate.
|
|
```
|