fix(gate): preserve exact-owner renewal evidence across duplicate rechecks (Closes #945)

Conversation 4 Commits 1 Files Changed 3

+593 -7

1 Commits

Author SHA1 Message Date

Author	SHA1	Message	Date
jcwalker3andClaude Opus 4.8	79334d4840	fix(gate): preserve exact-owner renewal evidence across duplicate rechecks (Closes #945 ) An exact-owner lease renewal (#760) is granted the owning-PR duplicate-work waiver inside gitea_lock_issue, but every later enforcement path rebuilt that proof from the durable lock through issue_lock_recovery.recovered_owning_pr_from_lock, which reads only the dead_session_recovery block. A plain renewal persists its proof under lease_renewal instead, so the waiver expired with the lock call and the next author mutation was refused duplicate_commit_prevented with owning_pr_recovery_exempted: false on the very PR the renewal had just proved. Add issue_lock_renewal.owning_pr_renewal_from_lock as the renewal mirror of the recovery rebuild, and resolve both halves through one helper, _owning_pr_continuation_from_lock, in the same precedence gitea_lock_issue applies. The three enforcement paths that previously saw only recovery evidence now share that resolver: the commit/create-PR duplicate recheck, the read-only duplicate assessor, and the push-ownership prover. The rebuild re-applies the equality the renewal assessor required (PR head == local head == remote head) and additionally binds the record to the claimant the lock names, so a renewal block cannot be reused under another identity, profile, or workflow session. Validation of the resulting token against live PR state is unchanged and still owned solely by issue_work_duplicate_gate._assess_owning_pr_exemption, so repository, issue, PR, branch and head binding continue to be enforced in exactly one place. No public signature, MCP tool schema, refusal shape, or reason code changes. Dead-session recovery behaviour is untouched. Tests: tests/test_issue_945_owning_pr_renewal_continuation.py - 49 tests, 8 subtests, all in-memory (no durable branch, worktree, lock, lease or PR). Against unmodified `aab54d48` the suite is 47 failed / 2 passed; the 2 that pass are the defect-pinning reproductions. Full suite 28F/5574P/6S/1002 subtests at head vs 28F/5525P/6S/994 at base, with identical failing test id sets. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>	2026-07-26 10:42:44 -05:00

jcwalker3andClaude Opus 4.8

79334d4840

fix(gate): preserve exact-owner renewal evidence across duplicate rechecks (Closes #945 )

An exact-owner lease renewal (#760) is granted the owning-PR duplicate-work
waiver inside gitea_lock_issue, but every later enforcement path rebuilt that
proof from the durable lock through
issue_lock_recovery.recovered_owning_pr_from_lock, which reads only the
dead_session_recovery block. A plain renewal persists its proof under
lease_renewal instead, so the waiver expired with the lock call and the next
author mutation was refused duplicate_commit_prevented with
owning_pr_recovery_exempted: false on the very PR the renewal had just proved.

Add issue_lock_renewal.owning_pr_renewal_from_lock as the renewal mirror of the
recovery rebuild, and resolve both halves through one helper,
_owning_pr_continuation_from_lock, in the same precedence gitea_lock_issue
applies. The three enforcement paths that previously saw only recovery evidence
now share that resolver: the commit/create-PR duplicate recheck, the read-only
duplicate assessor, and the push-ownership prover.

The rebuild re-applies the equality the renewal assessor required (PR head ==
local head == remote head) and additionally binds the record to the claimant the
lock names, so a renewal block cannot be reused under another identity, profile,
or workflow session. Validation of the resulting token against live PR state is
unchanged and still owned solely by
issue_work_duplicate_gate._assess_owning_pr_exemption, so repository, issue, PR,
branch and head binding continue to be enforced in exactly one place.

No public signature, MCP tool schema, refusal shape, or reason code changes.
Dead-session recovery behaviour is untouched.

Tests: tests/test_issue_945_owning_pr_renewal_continuation.py - 49 tests,
8 subtests, all in-memory (no durable branch, worktree, lock, lease or PR).
Against unmodified aab54d48 the suite is 47 failed / 2 passed; the 2 that pass
are the defect-pinning reproductions. Full suite 28F/5574P/6S/1002 subtests at
head vs 28F/5525P/6S/994 at base, with identical failing test id sets.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

2026-07-26 10:42:44 -05:00

fix(gate): preserve exact-owner renewal evidence across duplicate rechecks (Closes #945) #946