fix(guardrail): detect and reject manually launched duplicate MCP role servers (#686) #925
Merged
sysadmin
merged 2 commits from 2026-07-25 18:32:24 -05:00
fix/issue-686-detect-reject-manual-mcp into master
Labels
Clear labels
allocator
anti-stomp
architecture
bug
chore
codex
concurrency
contamination
control-plane
dashboard
database
design
documentation
enhancement
gitea
glitchtip
important
incident
incident-bridge
integration
jenkins
labels
leases
mcp
mcp-health
mcp-menu
multi-project
mutating
nice-to-have
observability
portability
preflight
protected-branch
queue
read-only
reconnect
recovery
refactor
release
reliability
resumable-review
reviewer
roadmap
safety
security
self-hosted
sentry
stale-runtime
status:blocked
status:in-progress
status:pr-open
status:ready
terminal-lock
testing
tracker
type:bug
type:feature
type:feature
type:guardrail
visibility
workflow
workflow-hardening
workflow-hardening
Controller-owned work allocator
Prevent concurrent LLM session stomping
Architecture / structural design
OpenAI Codex client / workflow session surface
Concurrent session safety
Workflow or session contamination incident
MCP control-plane coordination and allocation authority
MCP operational dashboard/queue view
Internal coordination storage (SQLite/Postgres)
Design / investigation, no implementation
Docs / runbooks
New feature or improvement
Gitea MCP workflow
GlitchTip integration
Operational or process incident requiring durable audit trail
Sentry-to-Gitea incident bridging
Integration testing
Jenkins integration
Label taxonomy management
Lease adopt/release/expire lifecycle
MCP server / tooling
MCP namespace and runtime health
MCP menu surface
Work spanning multiple monitoring projects or Gitea repos
Mutating action; requires gating
Observability, metrics, traces, error reporting
Cross-platform / portability
Shared preflight gates before mutation
Protected branch / stable-branch policy concern
Work queue visibility and allocation
Read-only, no mutation
MCP client reconnect/reload recovery path
Recovery paths for stale/foreign leases
Code refactor / restructure
Release / versioning
Reliability / failure handling
Persist and resume prepared review verdicts across sessions
Reviewer workflow tooling
Roadmap / umbrella issue
Safety rails and fail-closed mutation guards
Security / trust boundary
Self-hosted infrastructure integration
Sentry error monitoring integration
Stale backend daemon / runtime-vs-master parity failures
Issue is blocked
Issue is being worked on
Issue has an open pull request
Issue is ready for work
Terminal review lock (#332) path
Tests / test coverage
Issue tracker hygiene / meta
Bug or defect
Feature or enhancement
Feature or enhancement
Safety gate or guardrail
Workflow state visibility for LLMs/operators
Cross-tool workflow
LLM workflow coordination hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Scaled-Tech-Consulting/Gitea-Tools#925
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #686.
Summary of Changes
gitea_config.py:"GITEA_CLIENT_MANAGED": "1"inlauncher_entry().RECOGNIZED_GITEA_ENV_KEYS,RECOGNIZED_GITEA_ENV_PREFIXES, andget_unconsumed_gitea_env_overrides()helper to detect unsupportedGITEA_*env overrides.gitea_mcp_server.py:_is_client_managed_process()and_provenance_mutation_block()._profile_permission_blockand_namespace_mutation_blockreturningblocker_kind="unsupported_manual_launch"._check_mcp_runtimes_diagnosticsto ignore non-client-managed processes when determining runtime freshness and inventory process duplicates.gitea_get_runtime_contextto surface provenance,is_client_managed, and unconsumed env overrides.mcp_namespace_health.py:docs/mcp-namespace-eof-recovery.md, cross-linking #630, #657, and #686.tests/test_issue_686_manual_mcp_provenance.pycovering all acceptance criteria.repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #925
issue: none
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 41012-679ca3c5f3fb
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-686-detect-reject-manual-mcp
phase: claimed
candidate_head: none
target_branch: master
target_branch_sha: none
last_activity: 2026-07-25T23:30:07Z
expires_at: 2026-07-25T23:40:07Z
blocker: none
Canonical PR State
STATE: IN_REVIEW
WHO_IS_NEXT: reviewer
NEXT_ACTION: Complete native review submission for PR #925
NEXT_PROMPT:
WHAT_HAPPENED: Submitting native review approval for PR #925 (Issue #686).
WHY: Implementation meets all acceptance criteria for manual launch provenance detection and fail-closed rejection with comprehensive test coverage.
ISSUE: #686
HEAD_SHA:
dc0bff764dREVIEW_STATUS: IN_REVIEW
MERGE_READY: False
BLOCKERS: None
VALIDATION: All unit and integration test suites passed (pytest tests/test_issue_686_manual_mcp_provenance.py tests/test_commit_files_gate.py tests/test_mcp_stale_runtime.py tests/test_config_menu.py tests/test_runtime_clarity.py).
LAST_UPDATED_BY: prgs-reviewer
adopted_at: 2026-07-25T23:32:00Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 41012-679ca3c5f3fb
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 17146
adoption_reason: merger-handoff-approved-head
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #925
issue: #686
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 41016-b765bb0ee860
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/fix-issue-686-detect-reject-manual-mcp
phase: adopted
candidate_head:
dc0bff764dtarget_branch: master
target_branch_sha: none
last_activity: 2026-07-25T23:32:00Z
expires_at: 2026-07-25T23:42:00Z
blocker: none