fix(mcp): accept strict-descendant dead-session recovery (Closes #768) #769
Labels
Clear labels
allocator
anti-stomp
architecture
bug
chore
codex
concurrency
contamination
control-plane
dashboard
database
design
documentation
enhancement
gitea
glitchtip
important
incident
incident-bridge
integration
jenkins
labels
leases
mcp
mcp-health
mcp-menu
multi-project
mutating
nice-to-have
observability
portability
preflight
protected-branch
queue
read-only
reconnect
recovery
refactor
release
reliability
resumable-review
reviewer
roadmap
safety
security
self-hosted
sentry
stale-runtime
status:blocked
status:in-progress
status:pr-open
status:ready
terminal-lock
testing
tracker
type:bug
type:feature
type:feature
type:guardrail
visibility
workflow
workflow-hardening
workflow-hardening
Controller-owned work allocator
Prevent concurrent LLM session stomping
Architecture / structural design
OpenAI Codex client / workflow session surface
Concurrent session safety
Workflow or session contamination incident
MCP control-plane coordination and allocation authority
MCP operational dashboard/queue view
Internal coordination storage (SQLite/Postgres)
Design / investigation, no implementation
Docs / runbooks
New feature or improvement
Gitea MCP workflow
GlitchTip integration
Operational or process incident requiring durable audit trail
Sentry-to-Gitea incident bridging
Integration testing
Jenkins integration
Label taxonomy management
Lease adopt/release/expire lifecycle
MCP server / tooling
MCP namespace and runtime health
MCP menu surface
Work spanning multiple monitoring projects or Gitea repos
Mutating action; requires gating
Observability, metrics, traces, error reporting
Cross-platform / portability
Shared preflight gates before mutation
Protected branch / stable-branch policy concern
Work queue visibility and allocation
Read-only, no mutation
MCP client reconnect/reload recovery path
Recovery paths for stale/foreign leases
Code refactor / restructure
Release / versioning
Reliability / failure handling
Persist and resume prepared review verdicts across sessions
Reviewer workflow tooling
Roadmap / umbrella issue
Safety rails and fail-closed mutation guards
Security / trust boundary
Self-hosted infrastructure integration
Sentry error monitoring integration
Stale backend daemon / runtime-vs-master parity failures
Issue is blocked
Issue is being worked on
Issue has an open pull request
Issue is ready for work
Terminal review lock (#332) path
Tests / test coverage
Issue tracker hygiene / meta
Bug or defect
Feature or enhancement
Feature or enhancement
Safety gate or guardrail
Workflow state visibility for LLMs/operators
Cross-tool workflow
LLM workflow coordination hardening
LLM workflow coordination hardening
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Scaled-Tech-Consulting/Gitea-Tools#769
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #768
Summary
Dead-session author lock recovery previously required exact head equality between the clean local worktree and the head recorded at lock time. That made post-review remediation unpublishable after a session death: recovery requires a clean worktree, committing is the only sanctioned way to clean without discarding work, and committing advances HEAD past the recorded value.
This change accepts a strict descendant of the recorded/remote head when every other ownership proof still matches (same issue, branch, worktree, claimant, profile, dead prior PID, no competing live lock). Ancestry is observed server-side via
git merge-base --is-ancestor— never caller-asserted.Recovery evidence (recorded head, accepted head, relation, ancestry proof) is written into the durable lock and re-read for commit / create-PR / duplicate-work gates so an open owning PR is not re-blocked as competing work.
Acceptance criteria
read_head_ancestry+ lock record onlybuild_recovery_recordFiles changed
issue_lock_recovery.py— descendant disposition, owning-PR evidence, lock rebuild helperissue_lock_worktree.py—read_head_ancestryissue_work_duplicate_gate.py— accept recorded or accepted head for owning-PR exemptiongitea_mcp_server.py— wire ancestry probe + lock-derived recovery evidence into lock/commit/create-PR pathstests/test_issue_768_strict_descendant_recovery.py— new focused suitetests/test_issue_755_owning_pr_recovery.py— evidence shape update for equal-head tokensValidation
Runner:
/opt/homebrew/bin/python3, worktreebranches/issue-768-descendant-recovery.pytest tests/test_issue_768_strict_descendant_recovery.py tests/test_issue_753_dead_pid_lock_recovery.py tests/test_issue_755_owning_pr_recovery.py -q→ 90 passed, 2 subtests passed.pytest -q→ 3737 passed, 6 skipped, 2 failed (pre-existing #737 master drift:test_issue_702_review_findings_f1_f6andtest_reconciler_supersession_close; outside this diff).Evidence only — not modified
Issue #607, PR #767, review #479, branch
feat/issue-607-sentry-incident-bridge, worktreebranches/issue-607-sentry-incident-bridge, and local commita487f9fdc94388252b9a234976ca0c9c9ea7f706were not modified or published. They remain reproduction evidence for the #768 deadlock only.Head
fix/issue-768-descendant-recovery554739903795bca34e0bbbdf56542d3e74deb606masteratd12adabeb1cf7810b1286ca8871a9b680646021cAuthor role only. Stop for an independent reviewer; do not merge from this session.
Canonical Issue State
STATE:
pr_open_awaiting_independent_review
WHO_IS_NEXT:
reviewer
NEXT_ACTION:
Independent prgs-reviewer acquires a reviewer PR lease on PR #769 and reviews at pinned head
5547399037.NEXT_PROMPT:
WHAT_HAPPENED:
Author opened PR #769 at head
5547399037implementing #768.WHY:
Handoff to independent reviewer after author-only implementation and validation.
RELATED_PRS:
#769 closes #768
BLOCKERS:
none
VALIDATION:
Focused 90 passed; broader 171 passed; full suite 3737 passed / 6 skipped / 2 failed (#737 pre-existing). #607/#767/a487f9fd preserved untouched.
LAST_UPDATED_BY:
jcwalker3 / prgs-author
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #769
issue: #768
reviewer_identity: sysadmin
profile: prgs-reviewer
session_id: 23716-f4eb79cb2196
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/review-fix-issue-768-descendant-recovery
phase: claimed
candidate_head:
5547399037target_branch: master
target_branch_sha:
d12adabeb1last_activity: 2026-07-20T07:57:37Z
expires_at: 2026-07-20T08:07:37Z
blocker: none
Canonical PR State
STATE:
approved_awaiting_merge
WHO_IS_NEXT:
merger
NEXT_ACTION:
Merger (separate role/session) may merge PR #769 only after re-pinning head
5547399037and passing all merge gates. Do not merge from this reviewer session.NEXT_PROMPT:
WHAT_HAPPENED:
Independent prgs-reviewer sysadmin acquired reviewer lease 13141, reviewed full diff at exact head
5547399037, validated AC1–AC8, and APPROVED via native gitea_submit_pr_review.WHY:
Strict-descendant dead-session recovery is correctly fail-closed, server-derived, and in scope for #768; no blocking findings.
ISSUE:
#768
HEAD_SHA:
5547399037REVIEW_STATUS:
APPROVED
MERGE_READY:
false (approval is not merge authorization; merger role required)
BLOCKERS:
none for review; merge requires separate merger session and gates
VALIDATION:
Focused: 90 passed (+2 subtests). Broader lock/workspace: 171 passed (+2 subtests). Pre-merge baseline-proven failures only: test_issue_702_review_findings_f1_f6::test_removed_worktree_recovers_before_probe and test_reconciler_supersession_close::test_tool_posts_comment_and_closes_superseded_pr_issue (same signatures on base
d12adaband PR head; outside this diff).NATIVE_REVIEW_PROOF: transport=native_mcp; entrypoint=mcp_server; token_fingerprint=7efadb39b285ede3; pid=23716; mode=production
LAST_UPDATED_BY:
sysadmin / prgs-reviewer
Independent formal review — APPROVE
Repo: prgs / Scaled-Tech-Consulting / Gitea-Tools
PR: #769 · Issue: #768
Reviewed head:
554739903795bca34e0bbbdf56542d3e74deb606Base:
master@d12adabeb1cf7810b1286ca8871a9b680646021cAuthor: jcwalker3 · Reviewer: sysadmin (prgs-reviewer)
Review Metadata
/Users/jasonwalker/Development/Gitea-Tools/branches/review-fix-issue-768-descendant-recovery(detached, clean, HEAD == pinned)Provenance
d12adab(parent exactlyd12adabeb1cf…).issue_lock_recovery.pyissue_lock_worktree.pyissue_work_duplicate_gate.pygitea_mcp_server.pytests/test_issue_768_strict_descendant_recovery.py(new)tests/test_issue_755_owning_pr_recovery.py(token shape)a487f9fd(AC8).AC1–AC8
Diagnostics distinguish
equal,strict_descendant, and rejected (no accepted relation).Tests (review worktree)
Pre-merge baseline proof (#533)
d12adabeb1cf7810b1286ca8871a9b680646021c554739903795bca34e0bbbdf56542d3e74deb606branches/baseline-master-pr769-reviewpytest tests/test_issue_702_review_findings_f1_f6.py tests/test_reconciler_supersession_close.py -qFormal verdict
APPROVE at exact head
554739903795bca34e0bbbdf56542d3e74deb606.Blocking findings: none.
Review approval is not merge authorization.
adopted_at: 2026-07-20T08:05:10Z
adopted_by_identity: sysadmin
adopted_by_profile: prgs-merger
adopted_from_session_id: 23716-f4eb79cb2196
adopted_from_profile: prgs-reviewer
adopted_from_reviewer_identity: sysadmin
adopted_from_comment_id: 13141
adoption_reason: merger-handoff-approved-head
repo: Scaled-Tech-Consulting/Gitea-Tools
pr: #769
issue: #768
reviewer_identity: sysadmin
profile: prgs-merger
session_id: 26866-19bf1dbaab46
worktree: /Users/jasonwalker/Development/Gitea-Tools/branches/merge-pr-769
phase: adopted
candidate_head:
5547399037target_branch: master
target_branch_sha:
d12adabeb1last_activity: 2026-07-20T08:05:10Z
expires_at: 2026-07-20T08:15:10Z
blocker: none
Stale #332 review-decision lock cleanup (#594)
Status: APPLIED
sysadminprgs-merger2026-07-20T08:05:47.031393+00:00approveon PR fix(mcp): accept strict-descendant dead-session recovery (Closes #768) (#769)closed(merged=True)edaeede250f46f361784061f025ab0e867172d2c2prgs-reviewerManual deletion of session-state files is not the workflow.
This path only clears a lock when the referenced PR is merged/closed.
CTH: Merger Handoff
Canonical Issue State
STATE:
merged
WHO_IS_NEXT:
reconciler
NEXT_ACTION:
Post-merge cleanup only: release moot merger lease, delete merged branch if eligible, prune worktrees/labels for #768/#769. Do not remediate #767 in this lane.
NEXT_PROMPT:
WHAT_HAPPENED:
PR #769 merged via gitea_merge_pr method=merge under prgs-merger/sysadmin with confirmation MERGE PR 769. Pinned head
5547399037matched live. Review #480 APPROVED at exact head. Lease adopted comment 13148 from reviewer session 23716-f4eb79cb2196. Decision lock cleared (audit 13153). Issue #768 closed via Closes linkage.WHY:
All merger gates passed: identity sysadmin, profile prgs-merger, workflow boundary clean, namespace IDE-proven, parity current, eligibility true, sync recommended_next_action=merge_now, approval_at_current_head=true, baseline-proven suite failures accepted per review evidence.
RELATED_PRS:
#769 (merged); Issue #768 (closed); #767 evidence-only (do not remediate here)
BLOCKERS:
none
VALIDATION:
Read-after-write: PR state=closed, merged_at set, merge_commit_sha=edaeede250f46f361784061f025ab0e867172d2c; prgs/master advanced d12adab→edaeede;
5547399is ancestor of master; Issue #768 state=closed. Unrelated PRs not mutated in this session.LAST_UPDATED_BY:
sysadmin / prgs-merger